From: Zhaoyang Huang <huangzhaoyang@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: "zhaoyang.huang" <zhaoyang.huang@unisoc.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Vlastimil Babka <vbabka@suse.cz>,
Nathan Chancellor <nathan@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
ke.wang@unisoc.com,
Mirsad Todorovac <mirsad.todorovac@alu.unizg.hr>
Subject: Re: [PATCHv2] mm: use stack_depot_early_init for kmemleak
Date: Wed, 18 Jan 2023 09:40:03 +0800 [thread overview]
Message-ID: <CAGWkznEusXRmi=ZEOvfK8qRfe+aKWa3X-bLG28=XoeGZ5umeuQ@mail.gmail.com> (raw)
In-Reply-To: <20230117173145.867a06c1585728da1e9b6a54@linux-foundation.org>
On Wed, Jan 18, 2023 at 9:31 AM Andrew Morton <akpm@linux-foundation.org> wrote:
>
> On Wed, 18 Jan 2023 09:25:48 +0800 Zhaoyang Huang <huangzhaoyang@gmail.com> wrote:
>
> > On Wed, Jan 18, 2023 at 8:17 AM Andrew Morton <akpm@linux-foundation.org> wrote:
> > >
> > > On Tue, 17 Jan 2023 16:11:52 +0800 "zhaoyang.huang" <zhaoyang.huang@unisoc.com> wrote:
> > >
> > > > Mirsad report bellow error which caused by stack_depot_init failed in kvcalloc.
> > > > Solve this by having stackdepot use stack_depot_early_init. Extra Kconfig also
> > > > done by moving kmemleak stuff to mm/Kconfig.debug.
> > >
> > > I don't understand - what was the reason for the Kconfig change?
> > The items related to kmemleak are moved from lib/Kconfig.debug to
> > mm/Kconfig.debug
>
> Well yes, but why?
It was suggested by Vlastimil in a previous comment. It makes more
sense to have kmemleak's source code and Kconfig items under the same
directory.
>
> Is that related to this bug fix? If not then please let's have that
> change in a separate patch.
The moved items are updated for this bug fix.
>
next prev parent reply other threads:[~2023-01-18 1:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-17 8:11 zhaoyang.huang
2023-01-18 0:17 ` Andrew Morton
2023-01-18 1:25 ` Zhaoyang Huang
2023-01-18 1:31 ` Andrew Morton
2023-01-18 1:40 ` Zhaoyang Huang [this message]
2023-01-18 1:49 ` Zhaoyang Huang
2023-01-18 0:18 ` Andrew Morton
2023-01-18 1:30 ` Zhaoyang Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGWkznEusXRmi=ZEOvfK8qRfe+aKWa3X-bLG28=XoeGZ5umeuQ@mail.gmail.com' \
--to=huangzhaoyang@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=catalin.marinas@arm.com \
--cc=ke.wang@unisoc.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mirsad.todorovac@alu.unizg.hr \
--cc=nathan@kernel.org \
--cc=peterz@infradead.org \
--cc=vbabka@suse.cz \
--cc=zhaoyang.huang@unisoc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox