From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44AD1ECAAD2 for ; Tue, 30 Aug 2022 02:42:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A106A940007; Mon, 29 Aug 2022 22:42:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9BF3C6B0074; Mon, 29 Aug 2022 22:42:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 85FF4940007; Mon, 29 Aug 2022 22:42:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 761786B0073 for ; Mon, 29 Aug 2022 22:42:13 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 4F982160EE0 for ; Tue, 30 Aug 2022 02:42:13 +0000 (UTC) X-FDA: 79854709746.02.2B31098 Received: from mail-lf1-f53.google.com (mail-lf1-f53.google.com [209.85.167.53]) by imf23.hostedemail.com (Postfix) with ESMTP id 0221A14001A for ; Tue, 30 Aug 2022 02:42:12 +0000 (UTC) Received: by mail-lf1-f53.google.com with SMTP id bt10so13702752lfb.1 for ; Mon, 29 Aug 2022 19:42:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=p1rCUVVOx3EtRRRfoxbwmNUBHiId3GOW3+wZvEDaYcY=; b=TYlpK7Cdl6vprclxB7keOnBZeV1p1z/gL/XVk9MveYIetBsLqBLhQStTg7EblQLiik k1Ml9TiGc0fd3etLqxNriyETRIg5IVd+bS+zXwVnj2aRpIekJX96LwX34HT3RcA4BTuw JHdOvwPRA1qnqGoxL1pH7pyqNT3bgG88I5C0zT87Cn86oJKhzdd7XQEsVS4mpZ2vRTRC umOYmytqjl91gpEABkiabJkC9Luz8jltpl9ulang/vonNqfxT6kgadCNoj83yTXVj3Tf 1S3/sUvi2uSKMod9Jw20vtL5I/sj6+Z8LZRf2fpJNFUJwGQqbooK+6bcZscs0IwLXl0s 5+Jw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=p1rCUVVOx3EtRRRfoxbwmNUBHiId3GOW3+wZvEDaYcY=; b=zJIMzRhYjceDbfKBmBuxd50YgQzHC3Xf7zwoak9dDxln2wghUaCe7pNpxfE0aqfK+i KnNHNTOdPpm9tn+ctMoH+X9p3brr/G6uGSM0CaUZWHdBwvHX0C4zQpwDwYJqGtmgm7hp LSbKyO8Y948NEbl+t7RPmZdHrfhm3ewjRWCmHi/FQi7kjxYGzJlKueABd2hKekpYMAfc p5NAARMzueBNmhrXFRNhT6WJlOF8+KYQeNxcadgx0wVxDeZ5cf3EFkxYcgiLRynEtQQz SLr+3+cW2yzNZZIZ2wtqi0Tfu3id7By81LLtQeVdyfF/sd7u0XJXbvh41TRfeb9rE314 2ZTg== X-Gm-Message-State: ACgBeo2qF+2sBwZXq1Xx64YUi4/bDF2jGjvGWwjo6ZWou6UHiBhJShIn JOub5Ow8kjglFErq/72ZKNEkPMweYoblf+bB4XE= X-Google-Smtp-Source: AA6agR5+jUF2Ty12b+dONg9eCjxYohU7sTVXvt6uHwYeuTt72x4xwGfvu921skeEOOlWO+r8mFb3OmZbYgJamb4j2HI= X-Received: by 2002:a05:6512:e99:b0:492:db20:efd7 with SMTP id bi25-20020a0565120e9900b00492db20efd7mr6675342lfb.468.1661827331338; Mon, 29 Aug 2022 19:42:11 -0700 (PDT) MIME-Version: 1.0 References: <1661483530-11308-1-git-send-email-zhaoyang.huang@unisoc.com> <12759ac7-4a6c-89fa-5fd0-914728f6415e@redhat.com> In-Reply-To: <12759ac7-4a6c-89fa-5fd0-914728f6415e@redhat.com> From: Zhaoyang Huang Date: Tue, 30 Aug 2022 10:41:43 +0800 Message-ID: Subject: Re: [PATCH] mm: skip reserved page for kmem leak scanning To: David Hildenbrand Cc: "zhaoyang.huang" , Andrew Morton , Catalin Marinas , "open list:MEMORY MANAGEMENT" , LKML , Ke Wang Content-Type: text/plain; charset="UTF-8" ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=TYlpK7Cd; spf=pass (imf23.hostedemail.com: domain of huangzhaoyang@gmail.com designates 209.85.167.53 as permitted sender) smtp.mailfrom=huangzhaoyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1661827333; a=rsa-sha256; cv=none; b=E9IaXVLA0F+Uem1y9/k5g41RIfMSALYzDVYmvmCdR9v7PqKv+ASMvyUhhR/kB3K2SRakzJ vbZlDAuYWTOwoD3DErl4qc3Wq9EQb8PYJ3OcFCI2iERb+ZVfMa9G/pWBnHlmKIb/z6HjeN OaZyGbxG8kRTN1GSMlRHqP+tyNNFyjw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1661827333; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=p1rCUVVOx3EtRRRfoxbwmNUBHiId3GOW3+wZvEDaYcY=; b=4Vq1PTWkHKjNp+Dzj7NCLGLwvGXckiGsMsS/qc6ZNqamgccCAMcKA34oyclFvGDdI2EQhz fxkyQvQDtHpT+d5xWS61lOUqwzzReotNV0PjNGmaOD4B1zIyLdfJKihoF9dURr7fic0jRP BnbMdDf9+VFFUeKtTh7G61aph6yRf5Q= Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=TYlpK7Cd; spf=pass (imf23.hostedemail.com: domain of huangzhaoyang@gmail.com designates 209.85.167.53 as permitted sender) smtp.mailfrom=huangzhaoyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspamd-Server: rspam06 X-Rspam-User: X-Stat-Signature: d64od5ijyzbqiaq89ykjyngwh58ksbfb X-Rspamd-Queue-Id: 0221A14001A X-HE-Tag: 1661827332-944113 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Aug 29, 2022 at 8:19 PM David Hildenbrand wrote: > > On 26.08.22 05:23, Zhaoyang Huang wrote: > > On Fri, Aug 26, 2022 at 11:13 AM zhaoyang.huang > > wrote: > >> > >> From: Zhaoyang Huang > >> > >> It is no need to scan reserved page, skip it. > >> > >> Signed-off-by: Zhaoyang Huang > >> --- > >> mm/kmemleak.c | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff --git a/mm/kmemleak.c b/mm/kmemleak.c > >> index a182f5d..c546250 100644 > >> --- a/mm/kmemleak.c > >> +++ b/mm/kmemleak.c > >> @@ -1471,7 +1471,7 @@ static void kmemleak_scan(void) > >> if (page_zone(page) != zone) > >> continue; > >> /* only scan if page is in use */ > >> - if (page_count(page) == 0) > >> + if (page_count(page) == 0 || PageReserved(page)) > > Sorry for previous stupid code by my faint, correct it here > > Did you even test the initial patch? > > I wonder why we should consider this change > > (a) I doubt it's a performance issue. If it is, please provide numbers > before/after. For Android-like SOC systems where AP(cpu runs linux) are one of the memory consumers which are composed of other processors such as modem, isp,wcn etc. The reserved memory occupies a certain number of memory(could be 30% of MemTotal) which makes scan reserved pages pointless. > (b) We'll stop scanning early allocations. As the memmap is usually > allocated early during boot ... we'll stop scanning essentially the > whole mmap and that whole loop would be dead code? What am i > missing? memmap refers to pages here? If we can surpass these as it exist permanently during life period. Besides, I wonder if PageLRU should also be skipped? - if (page_count(page) == 0) + if (page_count(page) == 0 || PageReserved(page) || PageLRU(page)) > > -- > Thanks, > > David / dhildenb >