From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D632C77B73 for ; Mon, 22 May 2023 02:07:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 86A72900002; Sun, 21 May 2023 22:07:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 81A336B0075; Sun, 21 May 2023 22:07:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6E1D8900002; Sun, 21 May 2023 22:07:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 5DC4A6B0074 for ; Sun, 21 May 2023 22:07:04 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 143331C714E for ; Mon, 22 May 2023 02:07:04 +0000 (UTC) X-FDA: 80816253168.03.9F271EC Received: from mail-lf1-f41.google.com (mail-lf1-f41.google.com [209.85.167.41]) by imf28.hostedemail.com (Postfix) with ESMTP id 32AD6C0007 for ; Mon, 22 May 2023 02:07:01 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=kVzRmtd6; spf=pass (imf28.hostedemail.com: domain of huangzhaoyang@gmail.com designates 209.85.167.41 as permitted sender) smtp.mailfrom=huangzhaoyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684721222; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+o1JrsfH1Q1L+OLEEIhjvDhMdiV4AbRg16ZMJOJ+nHY=; b=7bPFMNljXD33N+8IQMFafTztgtVQNNPGGm7jli2J1JleOFxNTjHG+GqiScaNNcj/v7FA/s qesYEbNzq2qTBfG6jiHwrxyDRO94+jm6aO2wIT/438he9qt6HEEG0CS5EBbinRxjB8oWBc jbKuttDKorCAx+KzwjYGYsumzqJDrik= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684721222; a=rsa-sha256; cv=none; b=Q/5QQOML3QrKKiuLkvX2TjmoZH6pWp+Vmqvp11oVfGjLuWwDRLwceEbh6eq6XWkuUGLICT tBFzpwnSF/cbyTi9/8yhFuKeayE3EiMu036fhQw84n4AyEXaYkskAwhMlIdfV0kdMc3zgH PLgp3blzlVOVtGD1Wz+N7TOAg/iaL5k= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=kVzRmtd6; spf=pass (imf28.hostedemail.com: domain of huangzhaoyang@gmail.com designates 209.85.167.41 as permitted sender) smtp.mailfrom=huangzhaoyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-lf1-f41.google.com with SMTP id 2adb3069b0e04-4f3b9c88af8so1547286e87.2 for ; Sun, 21 May 2023 19:07:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1684721220; x=1687313220; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=+o1JrsfH1Q1L+OLEEIhjvDhMdiV4AbRg16ZMJOJ+nHY=; b=kVzRmtd6i2buheixqrgAOax4f4kpjb76V9Ixbx26N5o/+a+1FjWyyPtM/pUfPgBcoc K+/3ZH4NiFk7uXkM8pULDTHnCfSRShYBnHKdJbnokgrGLu/moytD1ZXQ3bkPoO12Rrv4 01Xn5pvUacT8lj9A+kNWNxHKqlbTX6dB2IXFF1iawEO9OLxEWs7TQzoHJ0YCrsK1vqti a5J54G8mhMdyCRFjWJjbhxLjL9ENsOtiQBJEWTqzBtzderjmSHNvsXkh2SfNeHAQ08Dx M8fCS59GFwRB4qd/zi3Z/AcY+QvUGu41eO1S9wiShcm0RtJ3kJobNyjKTTJTDWjxiyOa gROQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684721220; x=1687313220; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+o1JrsfH1Q1L+OLEEIhjvDhMdiV4AbRg16ZMJOJ+nHY=; b=ImZoM1V4P7wpuQ5eSuLt9rX8L5Db5OCm8ff8kmXmFE7cfaIL1ZJcu7ZP+8ch17oImx No1C4q2uWCzvMSP4Ois+zrVWtzNK9Hc6H+gE/On12T/Rd8m66Qjy5Jzk9Nlq2wEv1xtC ghTqSLp8gaLhHs9Zns20JbI4FT1D8/VVepC++vtAk/HDHUUijNw0Xzo9YiCH4Uu2qPsU PHX+C6OpJK+D5NZcfkqMQ/MKqr2pV9UmbzmOp1nCcWxFtA3bFUOhS95R08fx81u0tbkX PnSPyUkTQRvAJVj0uEBVPVQRmnB+y0xNUt/Tq5t1qgQtWAiR2GcpUMBE2Nvv7SvdSqq7 2p4Q== X-Gm-Message-State: AC+VfDwjs8IYNiQnv6LZio+wGvI5zQo+IO9KSpAZ7DJsyU1RtI9tdLyN 9oXncpRoTbgpgGsDreKrKSwm6CQ9k5UuAbE/xLg= X-Google-Smtp-Source: ACHHUZ7tkAXmXic6xNcvkj2mJE66oK6OWHVz0mbiH/WtLvmfg3UzSWjX3vTz+xrFii60C0yRQiohFDYY30H+caH/dwI= X-Received: by 2002:a19:c218:0:b0:4f4:b05c:dbca with SMTP id l24-20020a19c218000000b004f4b05cdbcamr368005lfc.66.1684721220062; Sun, 21 May 2023 19:07:00 -0700 (PDT) MIME-Version: 1.0 References: <1684143495-12872-1-git-send-email-zhaoyang.huang@unisoc.com> <20230519145839.3b5193e6accf3b13fd619a07@linux-foundation.org> In-Reply-To: <20230519145839.3b5193e6accf3b13fd619a07@linux-foundation.org> From: Zhaoyang Huang Date: Mon, 22 May 2023 10:06:36 +0800 Message-ID: Subject: Re: [Resend PATCHv2] mm: skip CMA pages when they are not available To: Andrew Morton Cc: "zhaoyang.huang" , Matthew Wilcox , Minchan Kim , Joonsoo Kim , linux-mm@kvack.org, linux-kernel@vger.kernel.org, ke.wang@unisoc.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: a4mgppujp53horh15yzdq3mmiiyp6wkr X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 32AD6C0007 X-Rspam-User: X-HE-Tag: 1684721221-734710 X-HE-Meta: U2FsdGVkX18J7qdKhKkrxQ67ODtPx+NmsXPggTAHPyqSrdezQpTtmBoaEChBFLmUux6YhoVhYJM+NC852/5P9dcu2UGlgTNdeRqxW/+Pl6arkvmuHXb5Ki9qXZL2zvsDpcxocD3yxxX3HBeX6Q2OG0Aersef8wBFfxSgugSYma3ygBwjfP9cb1NCvN+CZJOsC0Ujlq/WoCwL5HA706bVCWjwXkxTdN3aKje6glpiHtRjT4CEiQRvmPcHpSQNU1hs8eWA5YgQ+weY7xCwvfAiiWrDKmIiPRZletqVxjdHnxu/3OtXRmMgJvsFpp5lwtvC4a/FQp4D1kD3qHFW6vdEWeNRIT8iM02HXpoJSgsHtW5hCyBrWU1MSOOQSH/fvunBSPPdXgOLFBgmeN92q+PqyuWRFIMojbCuBXc0+p5JHGLRES1lNYweE6XT9LEaUk4Bz8X4VKtQQIc2jND52Rmq+Z6UxsmE5XpgnoTMdgEnz6ocQNksSdSQeLG73iGbrG2CzlN6VMOsqICe5Uf/Y+87aFUEiesAtVY+YGRsaT9lIUXPUQoGTHudES1Gh3We/OFdpMMTNtkSaloFuwrLARoGCdqKNsbES+ErEbpsUkeLv7+7cBsvkCksFoM0itiKV/5L28J8Tj+UR1ViC9kh+qyew1XQxdT1Ll6RXTdkLSsvwzplag6gHDFqNEE3jSHgIwjvkYWqs+LzTf7eDm5hQm2PD6NlDTwebbdNbBWrCil4plAsiX35zwxHpUp/7w9/dUWkXp8NRVeBm+576jvG5qncOm+1fviGCSdBuN2IsJiMHiC+zWeU2ddNvE6R+z2whlId1N5sYgOkKfgsRorltxiGx1bHPKwuKjcouYvswUuIp7RiFOd4cLOCAmxopfUQaUJXZ330la/5bDa8fVJIaKYc7qC873tmsWbVV+Qzleq6TIBnfRAIAZDwQzG1pOz7exDGmn9EAinmZbR0cbmZv/5 z80DMJAB +m1hwTjcKMRaWDARrZSBKwQaD7u8XwSapcqSlg0gnhTcC9C0+xwBOQrvMIIBBwxZVXgEWgbnBJx4J7BfSk0QGvfHcSlHQYbFkLIMXCLi6OAtFL5bwJB/sjBNHx51Mm5LDmsB/C7cz81oNvLKENqA4mBwrr2osiZEx0qGl/UY9yknS+2boUervoPGoYqZh4suosv6Z+u7tgUKgTYF4MSBZ9StJqVHJ3ZPjwGk2E647rJj4r8+Zi1Vfn5ul8iWHlLVXaKiyaDXs+QFRcMdhrsJ1ryudadomTsV9Q7gSFiTJNTRXrFT5H7J9B4FCFC8uGvpjanBhkuR774hBbbUNz0dttYtmiGLjEXzELUuWwvtlLqsaiay+w74eMA5sYUvOFydiMUVgXXu8BxVhXvxi2XsMVJuWPSd779UdW5V2R/YzrAHqurgXSg5YzWSYzA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, May 20, 2023 at 5:58=E2=80=AFAM Andrew Morton wrote: > > On Fri, 19 May 2023 16:41:41 +0800 Zhaoyang Huang wrote: > > > any comments? > > Have any of the regular CMA developers commented on a version of this? None comments until now. IMO, it is mainly affect reclaiming process. > > > I have a couple of little complaints: > > > diff --git a/mm/vmscan.c b/mm/vmscan.c > > index bd6637f..19fb445 100644 > > --- a/mm/vmscan.c > > +++ b/mm/vmscan.c > > @@ -2225,10 +2225,16 @@ static unsigned long isolate_lru_folios(unsigne= d long nr_to_scan, > > unsigned long nr_skipped[MAX_NR_ZONES] =3D { 0, }; > > unsigned long skipped =3D 0; > > unsigned long scan, total_scan, nr_pages; > > + bool cma_cap =3D true; > > + struct page *page; > > LIST_HEAD(folios_skipped); > > > > total_scan =3D 0; > > scan =3D 0; > > + if ((IS_ENABLED(CONFIG_CMA)) && !current_is_kswapd() > > + && (gfp_migratetype(sc->gfp_mask) !=3D MIGRATE_MOVABLE)= ) > > + cma_cap =3D false; > > + > > A code comment above this alteration would be good. Tell the reader > why we're doing this. ok, will update > > > > while (scan < nr_to_scan && !list_empty(src)) { > > struct list_head *move_to =3D src; > > struct folio *folio; > > @@ -2239,12 +2245,17 @@ static unsigned long isolate_lru_folios(unsigne= d long nr_to_scan, > > nr_pages =3D folio_nr_pages(folio); > > total_scan +=3D nr_pages; > > > > - if (folio_zonenum(folio) > sc->reclaim_idx) { > > + page =3D &folio->page; > > + > > + if ((folio_zonenum(folio) > sc->reclaim_idx) > > +#ifdef CONFIG_CMA > > + || (get_pageblock_migratetype(page) =3D=3D MIGR= ATE_CMA && !cma_cap) > > +#endif > > + ) { > > nr_skipped[folio_zonenum(folio)] +=3D nr_pages; > > move_to =3D &folios_skipped; > > goto move; > > } > > That's pretty ugly. Can we use IS_ENABLED(CONFIG_CMA) here to avoid > the ifdef? ok >