From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B20FC77B7F for ; Thu, 11 May 2023 06:00:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A3BF16B0072; Thu, 11 May 2023 02:00:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9EAA66B0074; Thu, 11 May 2023 02:00:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8DAF46B0075; Thu, 11 May 2023 02:00:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 7E28F6B0072 for ; Thu, 11 May 2023 02:00:02 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 050F5120CEF for ; Thu, 11 May 2023 06:00:01 +0000 (UTC) X-FDA: 80776923444.21.F0C0945 Received: from mail-lf1-f51.google.com (mail-lf1-f51.google.com [209.85.167.51]) by imf25.hostedemail.com (Postfix) with ESMTP id 7D056A0016 for ; Thu, 11 May 2023 05:59:58 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=MbC0YPcN; spf=pass (imf25.hostedemail.com: domain of huangzhaoyang@gmail.com designates 209.85.167.51 as permitted sender) smtp.mailfrom=huangzhaoyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1683784798; a=rsa-sha256; cv=none; b=G7kyuHFGkff6Nwt+nwonglGWkbEU15MNkdSR85WIEApWqr1/H1AfdAMIBeusKkcixYBx9V mcKAlz8N9AWFpsacCe0cOSwyY7xSjE7Ip63lT13Zi3RtiYsUBvKbzDzwdhVm3Pb3Ppo4FN 8NgpaT26X29mwxl4U5KdcNtO1dSZXIU= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=MbC0YPcN; spf=pass (imf25.hostedemail.com: domain of huangzhaoyang@gmail.com designates 209.85.167.51 as permitted sender) smtp.mailfrom=huangzhaoyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1683784798; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Ob7GWlTRgvWZ3pXLoalNHIlZFx5sCzWHAfObxgHzBLQ=; b=Q2hCMN+MVv7ZT87fPm5xtnasacgvjYo6Vtba6snOQitgWwfsA9QgmKDldQjPWIzvdTw2x/ ImDaaFfjMPiqPvpPgT6Gxr2xerDLPGDoA/uRMtldoCNaPBzraRIVXZvm4EcGmhkF6TVftU gSVXaFegQ8OkVdS7uV3OTgTXhOcHMD8= Received: by mail-lf1-f51.google.com with SMTP id 2adb3069b0e04-4f22908a082so6127450e87.1 for ; Wed, 10 May 2023 22:59:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683784796; x=1686376796; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Ob7GWlTRgvWZ3pXLoalNHIlZFx5sCzWHAfObxgHzBLQ=; b=MbC0YPcN712jWen4x7kIlMBrUhrF/5Bld1BpEG7CIHbc3v9862gjnS2MCI88PXb4CF +050yeVT4cYIzsHmHTxcAuvfX6vwc9PEKFSgelcA4PIOSM/mbnAsiToFRR59w6Jm5msQ O/G9qRptHQJxOU1m/2FaF7PsVZGCSNViLl7qxgtyDBOcnqX+PT0GUqFzzMpNmksRvEIj E2LqH2IbIdFyYrAhIK5DzAEJFairEY9LtWc497htip4V//8D9GuxWogiZL2utN5jE/+S uJFvvA6vHAPScdNkOxbT9QOx02FX1WyvoyYdCJ6KGHBcfDo9NxA1nJ+o7s9FWWz21s0X AzqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683784796; x=1686376796; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Ob7GWlTRgvWZ3pXLoalNHIlZFx5sCzWHAfObxgHzBLQ=; b=g3w5GbkBprnwsVttB3Adyhr8RpxA0ugtiveJeF8UZlN9Jtfwah4YxmzLsRBHnOlfAF TMQmvKdFP8KKnfx3Z5/Nxxy5sTw9gFPkR9HjkTXesM0l6MloyVKYPDYyakOogJXlTUj1 OoPixIrssi1b09Kn00exzdmwgiBu+tcyGdXBl7pxLo/bDcYf1vOUWQ2guuUJu7EfVECf ZPjb9H1snufaqqm8Ur8AeCuVS51TTZpLZGbHscDVoY/synIFV4oKgBeOpzOr7Jg09zZI uMlgWPI20EAMFegDnnQks798/ZSpDgIq8cy1lf7XZiu+1aQRIHt9bKCFFYWg8h1i1/mz JHAQ== X-Gm-Message-State: AC+VfDwqv72N9VtZvSrkNoZEhjzQrcrz8tU1EEYvVJDhbTDLHcN7Z2Nc bytHiE9CT3caD6ct89BonAMwGnna0R8e/keOZwk= X-Google-Smtp-Source: ACHHUZ6xNLZsaDCyh/KMjbZbeY+ZkovihJ5HXWgKfX+Sd+1H5LyClJymrRQw81Rs8x4JTtW0xmfkrnOX0fVC+GbYHYE= X-Received: by 2002:ac2:42d1:0:b0:4e8:c5d:42a5 with SMTP id n17-20020ac242d1000000b004e80c5d42a5mr2358825lfl.24.1683784796346; Wed, 10 May 2023 22:59:56 -0700 (PDT) MIME-Version: 1.0 References: <1683538383-19685-1-git-send-email-zhaoyang.huang@unisoc.com> <1683538383-19685-3-git-send-email-zhaoyang.huang@unisoc.com> In-Reply-To: <1683538383-19685-3-git-send-email-zhaoyang.huang@unisoc.com> From: Zhaoyang Huang Date: Thu, 11 May 2023 13:59:33 +0800 Message-ID: Subject: Re: [PATCH 2/2] mm: skip CMA pages when they are not available To: "zhaoyang.huang" , Matthew Wilcox Cc: Andrew Morton , Roman Gushchin , Minchan Kim , Roman Gushchin , Joonsoo Kim , linux-mm@kvack.org, linux-kernel@vger.kernel.org, ke.wang@unisoc.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 7D056A0016 X-Stat-Signature: k5maerf3nmuk8skm6kzttpesbn5xj4xf X-HE-Tag: 1683784798-774577 X-HE-Meta: U2FsdGVkX19aRBUi/u1os2a2B1PzGhoqcO+7a44nkywCpq1y3WDc0l5YLy8te1/m7xOWzqFksIhTekN3PFWXw/9y7fkfSedpZu1LpnQYAArozyN46MIDXqTU9ZFpDzDVJHVtiVzWiXskiuVTit7evfGvq+24LO5WElkwhahDEj1hD2g2EqVewXsHQcRMJL7KaYcG0Xp0cOd3oOu84okQzew8cdfappc3Qt0wbqrHW8NukOayUdmgeQVp7T0ZV+Oz3+eKHKvTHjEc5f35VyOvNsWA307TcFz1H1+K9hYFJ3vNOpggU7g257Xo2AtslzxF1mrQAeVMXhtIUpddBTRg1z9d/h/V1CaxPwEfA4wPguWwfrHtJbs/PL5tMm+cZiZB66V0hgE6fhIB+B3hD68+CRnGMQlBUmZ0RAsC7g34oo2Pj3kHBJNEqp+LMJK/d+xSB42wZr/N9vDgOtDzLFxGc2J7h7ymzlimb6K1AtZXF0PrU42i1N9R6Q89C03huwger9+jiWQDOq+avzgD/ccg6hQZ1lFqfkdPfgfvdUt99w3QPa8upXDHRTBjfPMnZrJEcTAOHE227YSQTMvrxmErv+SioBJV2mulXSEilqlnoN4p9Iqm47/4P+qhwncbsPoaZ7xPnV4pd/aAZLDSR7WE+bB3TjgayFaSZjX7QbHMvbTYOtgBb2kapVDq4D1aQpQIbthdE1FitLS4p07t/g7qrf1bUruKXwBwofKIYoV+zdNARviLXUEHoRGfVjkit8o/CZ1TDiQljQJUClF5Ges1rKeHBnoG50jjdOAIx3ql3xYeIxCCcbf6KKQJMPn9EW8eOwumsrwGHDmdAlrd+OAqF88DFzCElP0JIurcG1QQGWCgOIYI4AjTA7qydADhVez+JWFdMMtOn9zAO7n9Be25Eg8nG6lBogbQ/L0wGqMgH07rp5jwIwsu9hSjpotZzrEJq0ctoLIJUI8e/blUlM7 o5eO1nCX 5pBg417FO2Ue9A7rWtfZhM8MjwwqxXirs1MJ1vl9bgKezhjdZcd/+bltuO+Te45iG295aKSRyDQ5GAFZ/tl93FuwYZ/sHLothhxyXUJT0vNwjBbdsZz3r78Bb3nA7K+etsrc2zuQNbd4r8JXbKIwUYjkHH/SxlCFvfm48m44J/USTbBS9W3cFNbn/7G6n2f5136/nOwEfb7Xb0jUZo9bL3RkHwfnYJMObRKLlOkLngQaSJI3nemTuQr1Ds2COVAN867sm+d2EKpglbqvGIJlxVFjRMEg3X0SXI8Snei72jsMlpWfqZU8LAFLjYR3br5ukqCS7H/vgfJiHS38/nM9DyMOLdgvATqSd9dM/VVHYyzklFZxRiLmhj6twEBo6Xq2wXLwVJ0ERYXeMzJSGCdfBSZI+A9X00qS5kftUNlXsY/2MOGIXV43vBUWSXSzo+FRorxsd X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: +Matthew Wilcox On Mon, May 8, 2023 at 5:35=E2=80=AFPM zhaoyang.huang wrote: > > From: Zhaoyang Huang > > This patch fixes unproductive reclaiming of CMA pages by skipping them wh= en they > are not available for current context. It is arise from bellowing OOM iss= ue, which > caused by large proportion of MIGRATE_CMA pages among free pages. There h= as been > commit(168676649) to fix it by trying CMA pages first instead of fallback= in > rmqueue. > > 04166 < 4> [ 36.172486] [03-19 10:05:52.172] ActivityManager: page allo= cation failure: order:0, mode:0xc00(GFP_NOIO), nodemask=3D(null),cpuset=3Df= oreground,mems_allowed=3D0 > 0419C < 4> [ 36.189447] [03-19 10:05:52.189] DMA32: 0*4kB 447*8kB (C) 2= 17*16kB (C) 124*32kB (C) 136*64kB (C) 70*128kB (C) 22*256kB (C) 3*512kB (C)= 0*1024kB 0*2048kB 0*4096kB =3D 35848kB > 0419D < 4> [ 36.193125] [03-19 10:05:52.193] Normal: 231*4kB (UMEH) 49*= 8kB (MEH) 14*16kB (H) 13*32kB (H) 8*64kB (H) 2*128kB (H) 0*256kB 1*512kB (H= ) 0*1024kB 0*2048kB 0*4096kB =3D 3236kB > ...... > 041EA < 4> [ 36.234447] [03-19 10:05:52.234] SLUB: Unable to allocate m= emory on node -1, gfp=3D0xa20(GFP_ATOMIC) > 041EB < 4> [ 36.234455] [03-19 10:05:52.234] cache: ext4_io_end, object= size: 64, buffer size: 64, default order: 0, min order: 0 > 041EC < 4> [ 36.234459] [03-19 10:05:52.234] node 0: slabs: 53,objs: 33= 92, free: 0 > > Signed-off-by: Zhaoyang Huang > --- > mm/vmscan.c | 15 +++++++++++++-- > 1 file changed, 13 insertions(+), 2 deletions(-) > > diff --git a/mm/vmscan.c b/mm/vmscan.c > index bd6637f..19fb445 100644 > --- a/mm/vmscan.c > +++ b/mm/vmscan.c > @@ -2225,10 +2225,16 @@ static unsigned long isolate_lru_folios(unsigned = long nr_to_scan, > unsigned long nr_skipped[MAX_NR_ZONES] =3D { 0, }; > unsigned long skipped =3D 0; > unsigned long scan, total_scan, nr_pages; > + bool cma_cap =3D true; > + struct page *page; > LIST_HEAD(folios_skipped); > > total_scan =3D 0; > scan =3D 0; > + if ((IS_ENABLED(CONFIG_CMA)) && !current_is_kswapd() > + && (gfp_migratetype(sc->gfp_mask) !=3D MIGRATE_MOVABLE)) > + cma_cap =3D false; > + > while (scan < nr_to_scan && !list_empty(src)) { > struct list_head *move_to =3D src; > struct folio *folio; > @@ -2239,12 +2245,17 @@ static unsigned long isolate_lru_folios(unsigned = long nr_to_scan, > nr_pages =3D folio_nr_pages(folio); > total_scan +=3D nr_pages; > > - if (folio_zonenum(folio) > sc->reclaim_idx) { > + page =3D &folio->page; > + > + if ((folio_zonenum(folio) > sc->reclaim_idx) > +#ifdef CONFIG_CMA > + || (get_pageblock_migratetype(page) =3D=3D MIGRAT= E_CMA && !cma_cap) > +#endif > + ) { > nr_skipped[folio_zonenum(folio)] +=3D nr_pages; > move_to =3D &folios_skipped; > goto move; > } > - > /* > * Do not count skipped folios because that makes the fun= ction > * return with no isolated folios if the LRU mostly conta= ins > -- > 1.9.1 >