From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D6CDC6FD1D for ; Thu, 30 Mar 2023 09:42:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8652B6B0074; Thu, 30 Mar 2023 05:42:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8158B6B0075; Thu, 30 Mar 2023 05:42:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6B7BD900002; Thu, 30 Mar 2023 05:42:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 5DC096B0074 for ; Thu, 30 Mar 2023 05:42:21 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 0769E1A0419 for ; Thu, 30 Mar 2023 09:42:21 +0000 (UTC) X-FDA: 80625074082.18.F8A833F Received: from mail-lf1-f50.google.com (mail-lf1-f50.google.com [209.85.167.50]) by imf08.hostedemail.com (Postfix) with ESMTP id 1B20E160024 for ; Thu, 30 Mar 2023 09:42:18 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=ImBZjcN6; spf=pass (imf08.hostedemail.com: domain of huangzhaoyang@gmail.com designates 209.85.167.50 as permitted sender) smtp.mailfrom=huangzhaoyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680169339; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8k+ftPu1pOQhWJUqmpZoNXnka9ZSxidu9TmOjrsgsRc=; b=ULMPYJX5H6lqmiFu/jFCxC8Ebmq4cqqJGLp9rKYQD32slrNBHTH4WlUEeTUyGiFD0Szu3s HHhFvg1nkj8+YAfZQExh5rCK2CL5Lh1pUjFmtthjQ3Y5VbgrI5yY7ZYQoOPRO6fr0dAZh2 tSdK+PkASrOpKfJGWYAqd+qNWAIgg2w= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=ImBZjcN6; spf=pass (imf08.hostedemail.com: domain of huangzhaoyang@gmail.com designates 209.85.167.50 as permitted sender) smtp.mailfrom=huangzhaoyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680169339; a=rsa-sha256; cv=none; b=dMTr/FbwOEVkKOt1EaV01L6rrUE7KUrzyNgsJExXwlfi98BVNxLLhvhsDS1n6sS3OrFMs6 TNGJZJlZ/GG+Gc8mxPF3Om+/wYdW6/uLDorKEkvKMt10iixpTbIyHpZ3Zp+Po9M93gWsFW 2GKdNT1t33EyAZVRuVFFzxF67v2LXhE= Received: by mail-lf1-f50.google.com with SMTP id q16so23722549lfe.10 for ; Thu, 30 Mar 2023 02:42:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680169337; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=8k+ftPu1pOQhWJUqmpZoNXnka9ZSxidu9TmOjrsgsRc=; b=ImBZjcN6EHm/FQr3czBlAuWIJeVX+PlaicLsHzO61GZjBUXjieonAJsgRnFybWa2Sb tTxYFWfb2gllA7JO2j26JzZo4eJcepeWT2a8ab7uDhn5JGCXJo/ki/AASSeS6ho9KJ4Q y3HjCd9cS4iUpgnD1yIzv0QfV2lpRS2nrRQN5C/6hfScWU4BCfjIC+ge3hQ9GkPujLJq wyW7CxoUZrEYpSqpnRvJkLD8Ac7r7j4Wqz/2FHdvO88T1WJDZAwMdGa7ZFJHzViybs5b l4WNMWfM2uW9QCMIZRCV6JnZQ4Srk04esGEO8lKebnNlM07bhZNSakF0TPWP7BcZTSkh ehVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680169337; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8k+ftPu1pOQhWJUqmpZoNXnka9ZSxidu9TmOjrsgsRc=; b=qxAyGvh3HCVdjUMP4Tz0/XID41c64KnMsVIGaHsQMLbno3xX+iJ4IWT8JOd3sSJSAO p8JdflnGkx5IgdleziOSAry3NXoj4mccraZKrkY9Gr+G/9tPCNqohBvaUMR+8L4jXGAE bhSmRae3k86Oi4ucKv6Ywxl0xxzrZ7oGkoy4VawpOy//v6tOE3yY2IAymeu9dyJB/blX 4T/1eYsHpPPbKWjFuDmYZyL1kjqmehRFGNGZ70RXAn9SdObiyahgCPQKutTy4wN+OBU+ Svsjxv3dgzDvVdc6TcrM7PM3oTQYwygL5yW4W2ps7sUK+ic+aeDLQ8uPji69PUGnfXLd x8aA== X-Gm-Message-State: AAQBX9ffuap0Z5rDxsb1muN8nno8lV9BdrgVUoSAamgoZM08SXHZPc46 E/6kw3xxSVB8KbbI8hgfqDxI7KxL0UT45S512do= X-Google-Smtp-Source: AKy350aA2hRcKGMpD5L8ZSuM0W1ha9Ld0y2KHoHT5geFAS/zx0W87IbxWa+TjhaBL3smiced1VzNWBc44g/MloUnGIs= X-Received: by 2002:ac2:44d9:0:b0:4d5:ca42:e43b with SMTP id d25-20020ac244d9000000b004d5ca42e43bmr6463457lfm.4.1680169337074; Thu, 30 Mar 2023 02:42:17 -0700 (PDT) MIME-Version: 1.0 References: <1680086855-7989-1-git-send-email-zhaoyang.huang@unisoc.com> In-Reply-To: From: Zhaoyang Huang Date: Thu, 30 Mar 2023 17:41:55 +0800 Message-ID: Subject: Re: [PATCH] mm: mark folio as workingset in lru_deactivate_fn To: Johannes Weiner Cc: "zhaoyang.huang" , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, ke.wang@unisoc.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: grb85qa3zfbfyoz6885sy1brwbtjmog9 X-Rspamd-Queue-Id: 1B20E160024 X-HE-Tag: 1680169338-125644 X-HE-Meta: U2FsdGVkX19ASzHHm3+NIobJh7wvaV4R1qQMYRbV6mpMGswQv3ZIWXtV+x+1KdwGfPiIvIU7QBpnWlp9UAWuNd6JGt8wPpmhN9F0DJwwAZaK5Bp/dBGz+wZec2K33Mmr12rF+fi2TMI3MpTVyI3CocD5ZGyr+kzcLEW04vvu+Uj51bZpAxdo61GEm6LBpX4hIc30Z4IFNo/2H7B992x6KE9H2Lazf6cKC+4GdJHvZ43BbxJy90k0GZd7CYFCRpsN6hVMqI6F2GrcCfqRMjX2uVfAqUDcRhmwJhMBWP1Ig9mI3cOQRtzmAAwKyuUj5mm6NOvHSMwCD0o0aHa0PajcQ9TZQQ38Q7bE/5zYUl85O5LsjLg63XyOWLQApWBwr6fqBZn6JhwjeWKKHh7DCn3907HNAIFAaIz/0V/1OqE/1Su9TXpNgY6Qp+n7C0LFIz6oFtSXGv6UWYggRecBhAYLh2pLggGpMNwYpHsFu7m/Mc5ZaVAG9eeHQ8K1yUFeMYmvvCZvNiQL+tY97CoN6F3Vh1oIdEYd4Zf/+TrzR69Ck88JAq9Y4ALS4EcsLEjs92NBiF4rHx8bdeSwzfTyFQ4ZqdqQrny/ZPmrz1noPqBtQxqwu5NqjMOngkuh9suy97Pz3/lugC5mNjgykTDwPk2KdaJvJ2/zP1eS0bpm0YX+ls6n5Y+uQJrt55C/dxkhdIS5dWa19Q5KgwQ6+W4pBm8ZL3PwwPyLB6ViYoQ0g+zoBbbTZn8cnthLdhVoi/8yZ20y3nOsADzXHU6wVOXsWstdZnfvuUJSNDFFG3pKRXpYIaC0Nfi98sdgyJce9giK2MAoFQkpd7/UW6Kh3t/dInU1/nDlEK9KoVndjtsHljBDMLbx7+xRPsLB4pKroHMi/mNEh25TThFKqWWWpgJmtEAEFarR3zqtW4DSEZRKMg26tM640Ujl6lSHI1IdLUNd6AsYlhvQr9jwQK+2Hoa/H52 KIouVHjN yWUKB/wy217JVZKFjwRWg/WASGCweraVCVBVHYaTfmM7IzIBZIwBYiUfQJgZ0EexN+2bYq8hFy9pJx8pxcNe/jwosKjjCbr4GSvE5bufuHlFWXPymbsQy3tSN9HfFaov2kSIg807rtkWphgouHgfm4aYLewDG5KU1LANRtYSc+pSPSNO9DO5rYoqvTYZwtk0DxTlc223q2OFc+ZKL+7PHpJTaNSQ2IQlHEiW+ytplnDhosY1i+xzvJIt51Uje1R7Yi79aK2c1RtFp2/+jBaqeeSJc9t+r5iOrMN4G+H3vMCjr7fFq3b/0yNSRXp9fYFK1Pub7yO/GwHSwZgoLEXRCOcyX69mgJzlCKwsXEymG0UaRmDGIY5yNP7pYWJjuNbIoCmXakx1nAeJhT/we6yYG/A4Zf94b2IAfQcJB79/hyy4lDvFmptjn3jRLiiQZ0ZxB/I4omtO7t5Q7J3XjFr0gHi/QijmlwgK9IQH2zLy1iqfTntawgVOJ1g5BGqWMTJYqIRdE99VVhaZrbWGypHy736nx8A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Mar 30, 2023 at 5:32=E2=80=AFPM Johannes Weiner wrote: > > On Thu, Mar 30, 2023 at 09:38:48AM +0800, Zhaoyang Huang wrote: > > On Wed, Mar 29, 2023 at 10:55=E2=80=AFPM Johannes Weiner wrote: > > > > > > On Wed, Mar 29, 2023 at 06:47:35PM +0800, zhaoyang.huang wrote: > > > > From: Zhaoyang Huang > > > > > > > > folio will skip of being set as workingset in lru_deactivate_fn. > > > > > > Can you please elaborate why that's undesirable? What's the problem > > > you're fixing? > > If I am correct, folio will skip being set as workingset when moving > > from active lru to inactive lru, which is performed on every folio in > > shrink_active_list during normal reclaim. > > shrink_active_list directly calls folio_set_workingset(). The function > you're editing is used for things like MADV_COLD and truncate(). Yes. > > It sounds like there is just a misunderstanding of the code, not an > actual problem. Isn't that a problem? As my understanding, MADV_COLD could be deemed as a stimulation of normal reclaiming which turbo the folio towards eviction, while the page moving by it should be also delt in the same way(PG_active has been cleaned)