From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C407C48BDF for ; Mon, 21 Jun 2021 02:35:40 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id DCC9E611AC for ; Mon, 21 Jun 2021 02:35:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DCC9E611AC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 41B6C6B006E; Sun, 20 Jun 2021 22:35:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3CA896B0070; Sun, 20 Jun 2021 22:35:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 21D6B6B0072; Sun, 20 Jun 2021 22:35:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0127.hostedemail.com [216.40.44.127]) by kanga.kvack.org (Postfix) with ESMTP id E3E5F6B006E for ; Sun, 20 Jun 2021 22:35:38 -0400 (EDT) Received: from smtpin09.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 789938249980 for ; Mon, 21 Jun 2021 02:35:38 +0000 (UTC) X-FDA: 78276165156.09.D6B0DBF Received: from mail-qt1-f180.google.com (mail-qt1-f180.google.com [209.85.160.180]) by imf12.hostedemail.com (Postfix) with ESMTP id 6F5731400 for ; Mon, 21 Jun 2021 02:35:34 +0000 (UTC) Received: by mail-qt1-f180.google.com with SMTP id g12so12365474qtb.2 for ; Sun, 20 Jun 2021 19:35:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=9KVuKt6/Acd5sh2MXrhLbdYillpVA4Z1LuBqycxXY+g=; b=BZH21ZVppIAge/3bfEeZWpYeOi3wbY7BofQ1+E/+OtmY2keBKUz2kCWc0ImPOHTrci 9NEdJ+y02KQNqcGk/7s/OAyXkMChYDLN8UNFZwhUmQRZ4neMS1yPTbejt9YN0cJDvbka DdzPxn8B0/+vOmvIsHN1CRknUzPYVEt3V1fZY391dIOcwO4C3PPLyOwc0Lsx3WGhxV7z GGMj1cYLHkKRBg1+kGIsOjJ32/0VjMzZTLMatv1a+8tc8SP37knn0/tsYfB0eTzsEZBr 0OVByAcm6pCmBNUfaaAvXzR9qikQ/xZAHvHpy9iLeF7B4JGtSKjfsGaUnmnViEK1Afyo 215g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=9KVuKt6/Acd5sh2MXrhLbdYillpVA4Z1LuBqycxXY+g=; b=IH5AYF2tS84hO2ZHr7aEiQTB34ko6QXEi5Rmf+OZk85LYQwSW6Gy5gIPFuhoeXfasu umwb7DyIhSqt5cskOupB34ZjTnZDCHPGQ0afOKOLOK3mOIIJHYlwLJdCLD3naqYrboV+ C2GHT0YlfoU5fxDfQhtD1NjzVTaL0MAlU92ziAcyF2mSmQlvPzQOE+MrgIzkk2NZGKwT e6Rk+vUENW20aQoAGNT6WRp6pjQhew49Pn61o2Zgf1ruXj+N15cNe5HVLLYLMGuRFfrQ XZ1UgkS4JlGcHP7egbwCrW/7+vE8jcgWP+yH82n0rTepbapXZR7OoPW3/lfQi1MRd9m5 vI8Q== X-Gm-Message-State: AOAM533Ua2EBYn7EEdb4fwp/EoRwXwk0HAa6Q5Ov5wieNl+ziplGYjNH cfEiVEK7Fmq9BMpoSeZRcdOgOJTeUcoA38AJJF8= X-Google-Smtp-Source: ABdhPJzAFv+FO3dzmLwaH3YLTggpMfuJuQMJ6Reoo5QP04ulG83hLRPwxTEaUdzfefytoOHwuIGl5ulcs8XE4i3eLJk= X-Received: by 2002:a05:622a:11c3:: with SMTP id n3mr21506013qtk.63.1624242937598; Sun, 20 Jun 2021 19:35:37 -0700 (PDT) MIME-Version: 1.0 References: <1623137297-29685-1-git-send-email-huangzhaoyang@gmail.com> In-Reply-To: From: Zhaoyang Huang Date: Mon, 21 Jun 2021 10:35:26 +0800 Message-ID: Subject: Re: [PATCH] mm: zram: amend SLAB_RECLAIM_ACCOUNT on zspage_cachep To: Minchan Kim Cc: Andrew Morton , Zhaoyang Huang , "open list:MEMORY MANAGEMENT" , LKML , Nitin Gupta , Sergey Senozhatsky Content-Type: text/plain; charset="UTF-8" Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=BZH21ZVp; spf=pass (imf12.hostedemail.com: domain of huangzhaoyang@gmail.com designates 209.85.160.180 as permitted sender) smtp.mailfrom=huangzhaoyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Stat-Signature: nmcw1uqsmeo5oyu31p8n3fcug7pd1dmc X-Rspamd-Queue-Id: 6F5731400 X-Rspamd-Server: rspam06 X-HE-Tag: 1624242934-180082 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Jun 19, 2021 at 6:02 AM Minchan Kim wrote: > > On Tue, Jun 08, 2021 at 03:28:17PM +0800, Huangzhaoyang wrote: > > From: Zhaoyang Huang > > > > Zspage_cachep is found be merged with other kmem cache during test, which > > is not good for debug things(zs_pool->zspage_cachep present to be another > > kmem cache in memory dumpfile). It is also neccessary to do so as shrinker has > > It's not a only problem of zsmalloc because slab want to minimize > fragmentation so try to merge several objects if it's allowed. > So I don't think it's particular problem of zsmalloc. > I guess slub has some option maybe "nomerge" if you want it. > > > been registered for zspage. Amending this flag can help kernel to calculate > > SLAB_RECLAIMBLE correctly. > > > > Signed-off-by: Zhaoyang Huang > > --- > > mm/zsmalloc.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c > > index 19b563b..0b0addd 100644 > > --- a/mm/zsmalloc.c > > +++ b/mm/zsmalloc.c > > @@ -328,7 +328,7 @@ static int create_cache(struct zs_pool *pool) > > return 1; > > > > pool->zspage_cachep = kmem_cache_create("zspage", sizeof(struct zspage), > > - 0, 0, NULL); > > + 0, SLAB_RECLAIM_ACCOUNT, NULL); > > How does zspage become SLAB_RECLAIM_ACCOUNT? > > I took the flag as "cacheable" object. IOW, when the shrinker > ask to reclaim the object, it should reclaim(e.g., discarding) > those objects for reclaming. However, that's not the case > in zsmalloc. alloc_slab will take the allocated object into account as SLAB_RECLAIMABLE when this flag set on the kmem_cache