From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10D99C7EE22 for ; Thu, 11 May 2023 02:44:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 506B26B0072; Wed, 10 May 2023 22:44:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4B5C76B0074; Wed, 10 May 2023 22:44:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 37D7F6B0075; Wed, 10 May 2023 22:44:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 251CA6B0072 for ; Wed, 10 May 2023 22:44:16 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id D6B34ADFE9 for ; Thu, 11 May 2023 02:44:15 +0000 (UTC) X-FDA: 80776430070.06.9569738 Received: from mail-lf1-f50.google.com (mail-lf1-f50.google.com [209.85.167.50]) by imf21.hostedemail.com (Postfix) with ESMTP id EDA771C0008 for ; Thu, 11 May 2023 02:44:13 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=kso8xE9n; spf=pass (imf21.hostedemail.com: domain of huangzhaoyang@gmail.com designates 209.85.167.50 as permitted sender) smtp.mailfrom=huangzhaoyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1683773054; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=G7rMa9jvL/jm69EPCEihwi6Elw876z+kbt0ES9Rgu6g=; b=qgmE2oGSoOcO6hwvTZQJb20Cuiej3yyCLYIXG9oByztJer/9viDjSYYvuxcAKtQ+IAG9tu 13kktX92DckVtNY3x6xoVIyXiHfv9v3gHADj2yH5c2B4bLAmPHdxfbcQvB2/DEb4Jv583o gqFupPTWNe0QfKv+9HQy9L/IpsPAzh0= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=kso8xE9n; spf=pass (imf21.hostedemail.com: domain of huangzhaoyang@gmail.com designates 209.85.167.50 as permitted sender) smtp.mailfrom=huangzhaoyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1683773054; a=rsa-sha256; cv=none; b=3aKVuWly9CQcO886u0zRkQAu90bvS5Ozpg4KdH/YNNGnmPaHuz7ghxRASfC9Ous/TwTnrP UtYEKjoD6WMD1sAoNjlVac6W17PLxGFlQy0FE4KzdG7DmCMm8iTBTE/rM2dd/+BmR+eFze eikbi0PTSJJCA7sw8AwVEuPkzh2DBtI= Received: by mail-lf1-f50.google.com with SMTP id 2adb3069b0e04-4f14ec8d72aso6974921e87.1 for ; Wed, 10 May 2023 19:44:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683773052; x=1686365052; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=G7rMa9jvL/jm69EPCEihwi6Elw876z+kbt0ES9Rgu6g=; b=kso8xE9nDAZhqYv7SjjhFjTmw6sr6VZ2trUU3zhe74uOQAPtXuhcMnM9kUfCh5Xl6K cRvYTiMeHqxiu6gBWHaJSXxe0/QutYfXSzsGg7UikjMaDZQjPf+8Sja2FfrLMZSEXsaJ 1aIUCWXirsSq1tKGR5+3x/H1nDbqLBFQ3Ub+xv/iHTjomsQuFTH0aBW1mloZDi2yxyC7 jEntgyCcDT9N7QN2nPoIyLnrSYOAxPpHTLK0vTYyIRhXwbRfxjkS39qyQ1BIB71iALu+ vl2KlgTAyHMBinGckrHZDCl1EORlU+ji5MxJWg1VPxWAydD60eE6CBYZv6Mk+pKqzyxj bnJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683773052; x=1686365052; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=G7rMa9jvL/jm69EPCEihwi6Elw876z+kbt0ES9Rgu6g=; b=QegRmYWrCJKozaA9EiWF+DhFZc992VrtHZWtgJh8Cf7FfiKhl0Wx4AyZ/0Rc6BY8ct 1B58StJSeWF69IUlbMjyRjygmAxzdwCgFp4WQ8SBU1N0htg7vHJz52kmVD4Tyc6UZcqz CHIQkK6Cz5DuyjlcYAFnuA0Uldfew3BBC3MmJ1l2DI+wJFPqwzVAhU/wbjomr9em0I6C VSowhzsDdoMYicQ8LekKDt7fO79qt7Z7Y6jvapX5tGvsSjh6Em0ThWFio06rwHdBCMF8 eFoVi1adzLZCqSGSC3WhhmH1eCo8rllqlA0uHWWXwpDMSnGjyqg7Tl71AtxKaEfAPjUE 02DQ== X-Gm-Message-State: AC+VfDxqqtUC8dD1BTJ9o3Y8eeCvIddoiGDfmqkQGiPqhK8t3lSd+NZM VjlybT2NLhbGF7oDjrAv00O+5Jc4amkQtUYcA/E= X-Google-Smtp-Source: ACHHUZ6pDenYmvTlbJdon/tXIRnRgvejfHLwAJ/zZA3nKt83sqaQgzu2laNIN3VD/OBxjY3xWEzXFbTqwbD0Q8aBhGE= X-Received: by 2002:ac2:5fd2:0:b0:4ed:c61d:c8e8 with SMTP id q18-20020ac25fd2000000b004edc61dc8e8mr2366686lfg.29.1683773051996; Wed, 10 May 2023 19:44:11 -0700 (PDT) MIME-Version: 1.0 References: <1683685251-2059-1-git-send-email-zhaoyang.huang@unisoc.com> In-Reply-To: From: Zhaoyang Huang Date: Thu, 11 May 2023 10:43:48 +0800 Message-ID: Subject: Re: [PATCHv4] mm: optimization on page allocation when CMA enabled To: Roman Gushchin Cc: "zhaoyang.huang" , Andrew Morton , Roman Gushchin , Minchan Kim , Joonsoo Kim , linux-mm@kvack.org, linux-kernel@vger.kernel.org, ke.wang@unisoc.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: 4kbcgz75qssee1b3kwoxaj1brp9gauf9 X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: EDA771C0008 X-Rspam-User: X-HE-Tag: 1683773053-185475 X-HE-Meta: U2FsdGVkX1/nJ4d83IxNi4vHvvReGXVb+o574ocjK+5ETNdunMSTfxveGqw8VD+jsMg/wX7l/L75C7mZsceCJxw0y+aq6ugPS2sWLf7yfd6Vd8z09Ljmu1f4DCoosxsQapILP9uFdZ6rYOO7/17pRZwzMK/YKN5a3d1Q9IqR1Ran97we9HugveZSOezDvXi/y3W7QS+tgjxqTNjCB5cxFMralKPDu+iPCRz86eVQA0sX7NPCyajad1QK1Z6kn1PMC3YTcAzMwTCj+AXa3T4IMwfHDSucaafh4GMT5gzl1X/JoIb9RlLAmN7LDX9fWrsOyDYzhppna7DC2A4QAwqQd/d0LLl5LlsIs6dPFvZ1aNVba04BhK9Sn9dGnCFFWQ+OANDh4u4fjzU8MJTAPwxwZq/frAXbkz6D/efG201ZaLou1LannGeiSvxAbDBdOizz0a7TvpZ11/5uxxp3SJhU63DiYCZFGGsLdSo/hRkJyVgWt05BQ0wr6VN3+W6AtO58kKJKqkD6KB2Kn/erdn8FaQ5QwFNeENG56BAd1EMNxrogAgeU+CgmlPzbzmEZ+/wWlFK8wABFwe8RucRgTq/0EzQJJd8w5++sprhBbKvJhQlwGWgExH9bdu5eXbkNo/rsjwHLQKkU+mjsZ+r4Udj9bmAxXLK58X93eecUCcuMVLj1HelgsG6HUZfJIZerHj8/m5O8RjiB6JSuDC0pawUakvs2aD4N/RJgx+13ZmoFw0mkxOlnCmtxjOhbtrjaG99OxoWIVHkTRrGOktsgb28grRXIAmStEBQgbIIlzFF4tQ5Nmn0vVKhyeAGDmZ2GCPLGOQPmgcFN/M/sXwVkK2sDFjdSE316Jjba4PPORGnlKZyahxIpb2ECJXEvXBe78zfd55gKkMXelUmPquMTfSC2XU6wxttEeMgJGk2b/dBZHrMr0XLqiU8Na9pu4JAcW2wVbsMQ3UXX9+r1VMGl0td kyRifNqJ 8u2yVljMwwF9G5C5DTDsY6iYDjfrmqZOyVqjsnm3bFWkBeEKG9C4TM+vuYREIarCvyR1UoVs1yamgDRazGnIoce6r3GBxTP7xD1KDkpJPe33d2oveXs2Tsa/w19jObSKn1KDu5VuB7GUWCMRJVjNdLb9j8Dk7I6mdVTom9a03hqmwEnchRPMOrfQFh2ldyrTwxn0nh/ZblakGYNQVf82vf3WO+qguGIua8lQVrK/FJukQC/wAAJYZhPVN8inTVITUJrrqeo1R4w8fMbWC+7dL7LJa0jyit+nFur/sO27uVXhbU7Gp+WAxna+z+72ZWNFObPAFpmA/Vq13yySDvidBERpi0Xn4crq84e8JWIop1FUwaxryyzZC12xFYEtOW/FvPOHSimP6ClrFHqEtQP5dzP0dTjAGfSTJIzmnfW/N2f52f3OGaJPbzmXDEezuZFr/dVrw X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, May 11, 2023 at 6:08=E2=80=AFAM Roman Gushchin wrote: > > On Wed, May 10, 2023 at 10:20:51AM +0800, zhaoyang.huang wrote: > > From: Zhaoyang Huang > > > > Let us look at the series of scenarios below with WMARK_LOW=3D25MB,WMAR= K_MIN=3D5MB > > (managed pages 1.9GB). We can know that current 'fixed 1/2 ratio' start= to use > > CMA since C which actually has caused U&R lower than WMARK_LOW (this sh= ould be > > deemed as against current memory policy, that is, UNMOVABLE & RECLAIMAB= LE should > > either stay around WATERMARK_LOW when no allocation or do reclaim via e= ntering > > slowpath) > > > > -- Free_pages > > | > > | > > -- WMARK_LOW > > | > > -- Free_CMA > > | > > | > > -- > > > > Free_CMA/Free_pages(MB) A(12/30) B(12/25) C(12/20) > > fixed 1/2 ratio N N Y > > this commit Y Y Y > > > > Signed-off-by: Zhaoyang Huang > > I'm mostly fine with the code. The commit message is still very confusing= to me, > not sure I understand what exactly this table means. And you still use "U= &R". I would like to highlight the scenario "A&B" where the previous fixed 1/2 ratio introduces over use of UNMOVABLE & RECLAIMABLE. I will try to make it more clear by v5 > > Also I'm a bit concerned about potential performance implications. Would = be > great to provide some benchmarks or some data. > Probably it's ok because of we have pcp caches on top, but I'm not 100% s= ure. This patch helps solve my OOM issue in v5.15. Actually, It inherit the logic of 1/2 ratio and just behave differently when free pages is around corresponding watermark > > Thanks!