From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9F14C76196 for ; Mon, 3 Apr 2023 08:19:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 37EBB6B0072; Mon, 3 Apr 2023 04:19:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 32ED96B0074; Mon, 3 Apr 2023 04:19:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1F75E6B0075; Mon, 3 Apr 2023 04:19:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 113F56B0072 for ; Mon, 3 Apr 2023 04:19:21 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id BFF25140A58 for ; Mon, 3 Apr 2023 08:19:20 +0000 (UTC) X-FDA: 80639380080.07.76E2078 Received: from mail-lf1-f54.google.com (mail-lf1-f54.google.com [209.85.167.54]) by imf01.hostedemail.com (Postfix) with ESMTP id 6293B40003 for ; Mon, 3 Apr 2023 08:19:17 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b="cBjC/HIt"; spf=pass (imf01.hostedemail.com: domain of huangzhaoyang@gmail.com designates 209.85.167.54 as permitted sender) smtp.mailfrom=huangzhaoyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680509957; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=cB2n2J2tug6yoYqxC8LOxF9o11fo7ad2BJBVTYzPiEw=; b=LQ1MBmY3WTs/4XqFreQERhMsNeP+sicdheELcgtPFyhzkFls4UGfBLTlSE/Tozb3/289sD 5BE50mz+nSfHM7KDGb95zSTpHSosOVHdWlpnZ06xe/VTQrAApgqOztk4h2EgjOlwVf2zLn T0irITt2zeGIxKA8laYfDDHuGth6B+4= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b="cBjC/HIt"; spf=pass (imf01.hostedemail.com: domain of huangzhaoyang@gmail.com designates 209.85.167.54 as permitted sender) smtp.mailfrom=huangzhaoyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680509957; a=rsa-sha256; cv=none; b=dw4yL5ZNjw4yHbYawek4z371BnHt0aRF9P2R5KZ+RKGFvYhEOz/eKSfXSRQ4KHInscNDkA O9ewRcH1HZ8jMe+an+PpQaDJoTE5oBk6tTxYwEkYkdq2BUO7bVwkNz6K7mHK2ugoduX55n h0OVFUUNBG9nYL3/TqZYP+eDMim62+s= Received: by mail-lf1-f54.google.com with SMTP id y20so36992471lfj.2 for ; Mon, 03 Apr 2023 01:19:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680509955; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=cB2n2J2tug6yoYqxC8LOxF9o11fo7ad2BJBVTYzPiEw=; b=cBjC/HItYTQ2dYJMZ8zMF/E4NtJ3q7Gb3aJoGTDnWOgKKID1YF9jcE/soHk5ziDKZ2 pjPhkSKis4xbGotsrhoXlSQN5dFD4ARNSOGJQPjFpmI0ngHjCUNPW9DJ5AfgW1C+2NR8 tjsIEtX4t0grcBEaqqtpaHLETPl4u/bMF9sDxRP6C06yGduis65e5Gm67LDUnfyRdKNT TXBNxCKaCzKcz0QqgLzBk+OkuKvRzuuP8nRUz1HP4PrkQVj+cvOgSv1e/K684ZlWrwB9 012+3uXoMs37TcDOwG/Gp4ixGOC/3S2P8IGhMeXJ3Cfowo0keC19uyPsjK3j4ew0EmVE E88g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680509955; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=cB2n2J2tug6yoYqxC8LOxF9o11fo7ad2BJBVTYzPiEw=; b=UaQAqaQx3tWF5Ed6JoMHwg5nUsnW0wnDb27I9kRRy6TZvfv5UKld9rZPuAoG9l1ba5 lJRW2D7QtQV+EJNrdWETYEn+5gP4bO8kKtdsCn9ZSysD0/ho4t5UMg4mchsPSJLahbSo j6Q+uiWT+yxfjfwVH8RXMyfc6VzEZBejEFKWCWNdU5/PqB/UanM6/WnIq5ZDjP5WhcB/ MxmLW0u5Xrth/0VWH28RAC0k8SYpmWq18z99XiVm8GkBEmU6nG72J+YRBOWaSTi38c/V CeksHhjAJKy7VZIRhoykkD7DqKaSJNqKBwtFhkC+amfe181jGhHd383SmvdKF8vJpT7w vu2w== X-Gm-Message-State: AAQBX9ci7h0toMPg/RrCNPBnQMYbuZ6g8DV10STcByOe5kJE8OrHB0f+ FX2eCHv/6XyYhoKriXvJxblnnGm5n93cPiLcrYc= X-Google-Smtp-Source: AKy350Z6ENSxQVWkg33xULYCcgxfw0HhTePD49i0PT+jqNPBW1VJzNuV9txIC7vuzLQW/NLx10d3FGUtE12pGCf9t8Y= X-Received: by 2002:ac2:5322:0:b0:4eb:93a:41f0 with SMTP id f2-20020ac25322000000b004eb093a41f0mr9101959lfh.4.1680509955390; Mon, 03 Apr 2023 01:19:15 -0700 (PDT) MIME-Version: 1.0 References: <1680086855-7989-1-git-send-email-zhaoyang.huang@unisoc.com> In-Reply-To: From: Zhaoyang Huang Date: Mon, 3 Apr 2023 16:18:53 +0800 Message-ID: Subject: Re: [PATCH] mm: mark folio as workingset in lru_deactivate_fn To: Johannes Weiner Cc: "zhaoyang.huang" , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, ke.wang@unisoc.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 6293B40003 X-Rspam-User: X-Stat-Signature: da7g11sq9oua1kaiouxshmau44n91dzd X-HE-Tag: 1680509957-629511 X-HE-Meta: U2FsdGVkX1/nT/jTpQbynhDhMJNZBCB3KRt0H1u5qb0ocdEMRz4iCxwVRZ0ZjoCari7wxJiOD+TwWl46qu0RxTNYtE1iTyr33XbjkNNeO4vY/uDmctZkHougdFaYjSchIAxWfqAH2YxXlJlMc+c+myHUovr2DFYkwi4WIqAR0ORdc2DM+T3DKNAhNu7lGDo17kCil2pAsWaexQChFlr4xDOZ2Fpn80543/MIBVAQHnhqmLLgTlDLTtQdpGDt+4U5DCmN5N0HfblM1ybyCZVfxuCSeq2KrbnaCz39tbT/CX8tlx/9i+KE+EVCRL50+vUPgSqri5GyTolugKPQXXxtkYaWkvOUbCP4fAtKYSK5/GnwX6QpxOYNZc7AtzqAtE8mhDYLFtsdJgc9fLcPz/jm7l8bOBIcRvHAFEWVZ2LGs4vWs3pCHjDnv5lZdls/ba9dQG/xzlYrBK4kHS/OHi2C9xOqZSj/CS/3n2WCuPDDqWBLlh0GHgUE9vLTE5T+6Iss8t4KmRtuZJsUqeKW+56tmcooKqphp0m7VHkM6XHV5trxZXNzSHfRf0QWGqgZ/GxgkAdCyvMsgtUAkC4MQLkXBijsi+QBvI0B/iNS7nNhBxKg+p3ubVe1CeOwGXy3lxhmmRe45tKKdc2n+Aslg4H1LNXCbROqRq/F8Ote+eZ42BddrocQbl4ROj0jugoTDXhWPdb2k145eO83TU98/W03DFsavu+kx1pKiaIR/RlxhT3Qzn1QqxXZBWgZimTI6zPuqiPk2MbUqqL9rUStRCISXxsslonCOTmjwnXzBK4u/zxlTD68zixs+zJo85C7c0U/b2+baG88K49HAQHOiv2eu8eu2t2zJ2KYciqp8B2qj3VJXXSbOomRBdEBfhjrAf7bqzaou66tAfAu5k1s44PPoffXB/pTXZFfpmSsYglqRYHdNky88k1LiEtfr4NnO5zGJYPnSXtEPvxG7Kif3fT D/dMCPnv XJ3q7kZuAPQvdeNbTBsHdEXYy9+Dzw1x4GuAti79bXIiuFBCBkZHQUX5cAiNJZY1Kf8kFGbNuBDqvQZOLRyalatTu+NOLPjtLPCiwtZ/CAZzsDvVVf/L2GF4ieGWQ0Fao065ogYHjkF7Wbdbhs+aVlYm+I8Oo0WK6w4SH2605gmY8t+vyPdBjVt9iE8cNLKB+8VMCOWYd39LM3MW99FbWdsbITjeUNvZTKOHLSVfF0NuyXBdzNKPLqYkK/gtuAiJY/XK2SQC1KnFpTMqTrxP0bOEmGBcFZ9a7xy8OezRjw0Eodj6kiyKMQgYrz0yXL8WKUALnpEuw0NV+W79ag051Z/3KtFy/L99mXr8QvkrLy2LKVtyYXkfhuA3WRNDyw+drshOcX3TMe0xzJU70rWoXjvwpANQtJ5LshmoxiImcY32pFQAgTkwOIB3jASXSygId38ktNq9LWTkm0wg/wQCKfmyJrrKoRRWWo4ERP3CHGY+GyJrAi7ZvM8FDlKB4GSpr6+KN3+dmPvysYF8HhUE4eEBsbV0bg0j/CFZtd24yFiwAcyM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Mar 30, 2023 at 5:41=E2=80=AFPM Zhaoyang Huang wrote: > > On Thu, Mar 30, 2023 at 5:32=E2=80=AFPM Johannes Weiner wrote: > > > > On Thu, Mar 30, 2023 at 09:38:48AM +0800, Zhaoyang Huang wrote: > > > On Wed, Mar 29, 2023 at 10:55=E2=80=AFPM Johannes Weiner wrote: > > > > > > > > On Wed, Mar 29, 2023 at 06:47:35PM +0800, zhaoyang.huang wrote: > > > > > From: Zhaoyang Huang > > > > > > > > > > folio will skip of being set as workingset in lru_deactivate_fn. > > > > > > > > Can you please elaborate why that's undesirable? What's the problem > > > > you're fixing? > > > If I am correct, folio will skip being set as workingset when moving > > > from active lru to inactive lru, which is performed on every folio in > > > shrink_active_list during normal reclaim. > > > > shrink_active_list directly calls folio_set_workingset(). The function > > you're editing is used for things like MADV_COLD and truncate(). > Yes. > > > > It sounds like there is just a misunderstanding of the code, not an > > actual problem. > Isn't that a problem? As my understanding, MADV_COLD could be deemed > as a stimulation of normal reclaiming which turbo the folio towards > eviction, while the page moving by it should be also delt in the same > way(PG_active has been cleaned) Sorry, I am still confused. Does it mean the pages deactivated via MADV_COLD like methods should NOT be deemed as workingset pages?