From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53D07C27C75 for ; Thu, 13 Jun 2024 09:23:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DE7486B00B2; Thu, 13 Jun 2024 05:23:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D70986B00B4; Thu, 13 Jun 2024 05:23:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BC3C16B00B6; Thu, 13 Jun 2024 05:23:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 99D636B00B2 for ; Thu, 13 Jun 2024 05:23:42 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 069241C274B for ; Thu, 13 Jun 2024 09:23:41 +0000 (UTC) X-FDA: 82225327884.03.3B4C6EA Received: from mail-lf1-f44.google.com (mail-lf1-f44.google.com [209.85.167.44]) by imf27.hostedemail.com (Postfix) with ESMTP id 1EA8B40024 for ; Thu, 13 Jun 2024 09:23:39 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=mzB5yUJi; spf=pass (imf27.hostedemail.com: domain of huangzhaoyang@gmail.com designates 209.85.167.44 as permitted sender) smtp.mailfrom=huangzhaoyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718270619; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Gg+23UUXLD0QiiaYlgluUVs+RMApwPP3zSxNMn9RCpk=; b=R1ps8mGTmONWipNUpv0gYr8L87o/UraZMTo4480eJBamBJdL8mC7gb2cZoang1LLcNz7/n tNchkYWiPZKkrmNGWhZWbd19xkXu8rLzyE0qC9XhdI92j21/GPGK+XyBvm5hFEEG42A1Ns 1+kPMMWWXbYh8DYxumqx0A5FxoYzBcQ= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=mzB5yUJi; spf=pass (imf27.hostedemail.com: domain of huangzhaoyang@gmail.com designates 209.85.167.44 as permitted sender) smtp.mailfrom=huangzhaoyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718270619; a=rsa-sha256; cv=none; b=EqT2YnFea4f1XtBiImYGqW+zxuOwks44VN4Ahy8MDKv7UJf3iTm0mV6Y1t51nElg4tyAww RVYwv1ptEAey+3thkxAuwoJgSe2DQ0NjYFbiIwrbYkCUb5ElCMMpC08Rgn0/7/C4fGR+uq b0JOpccy3HuL3UXLm9ipYc7cBQg9X30= Received: by mail-lf1-f44.google.com with SMTP id 2adb3069b0e04-52c815e8e9eso925733e87.0 for ; Thu, 13 Jun 2024 02:23:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718270618; x=1718875418; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Gg+23UUXLD0QiiaYlgluUVs+RMApwPP3zSxNMn9RCpk=; b=mzB5yUJiCXR6teuJfDQihb831dl8u0Nyi+TSA89QWgGV1d3OMUBoa4v9lS3RmHLJvx UER3fuPGBbNEqq7p+iOEXdkOyRl/oFCR4v83vanz4FA9Mk5z573fDMAA0Q27EL9Jlbs8 6LbUpllwEr0mhqm7XHJXySq3rp52HNI4cinwWW+nBuWuEObO12ddIGeTUcCE23n8qmiH hdYHVNRxzaRYFLd6L9q11edxRhK0pBY5hiRg/8+UoxepffzTr+aI0A2nFpP3PHxqRqij Ton7vaSC/psTNfS6TDIr5kUx9UQ4ur0hVHNHjJz3UUF48FhvzYpODJlAow7jkBDafBxv X3/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718270618; x=1718875418; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Gg+23UUXLD0QiiaYlgluUVs+RMApwPP3zSxNMn9RCpk=; b=pwVGG1IFbKckkOJljN5ZfMOUMhu0ri3/SRM7PN6Pq3ehjANDTW4fPisAIzMLDVKIPa QCmcoSqAMM71+aaL4Xjyqlk3VXembDxaQk/lQfJ6qGq3AlIlVzMvBGJ8ql2GM2+q30IZ F0zNgc6bEt0TyS0B36GrHMhbXYk3tR9vQUX8OGXiJr4fqvOLDK68N5l2PjHVSO0XxGKa R24PbPvXfSOgp4GJs5PK9ZsR2UCRNQGl8Kohnp3uTq+Qz5OJTYJdCqUXeh1ZYnH6FCE5 w5fZ8gtXZteTf6TMQziA+1xSe3WUS7Lz/G7cTXtpVs4xS1/lx75Lnp58aQ3n7E3rhMVf Sfsw== X-Forwarded-Encrypted: i=1; AJvYcCXcvoIkVBv8b/oaLafmTbL/0hgU1CG9OjKvKTQD/IQzW0oqk9ZP3GXpZz/Tza2jWzggMmifmB1nnv6e1STy4lA8Q3A= X-Gm-Message-State: AOJu0YwHgTViy28Jv4hd+uxl7q2KKTVv/RMPkkFxFPCwzqr6uRsBljSO 4ksR6o8X4OSF4tshR0zzH6Hld6wKyFWw/s7ijzUF8VVbpV9uLvmk7WVjObbMO9XXAIGAVOTCAcr aZrQyVEPCsjfO5ETPeOyVMUnJirY= X-Google-Smtp-Source: AGHT+IHNHTBRcHOOmC217Up4Ka0WkhyYvVN+oWQ2WndOVDn1z0YjAqT/Ba384DNdoh/dvoO13r92M/g7kfJ30eTfu7U= X-Received: by 2002:a19:ad09:0:b0:529:b79f:ab1d with SMTP id 2adb3069b0e04-52c9a3c6cefmr2451182e87.22.1718270618150; Thu, 13 Jun 2024 02:23:38 -0700 (PDT) MIME-Version: 1.0 References: <20240607023116.1720640-1-zhaoyang.huang@unisoc.com> <20240613091106.sfgtmoto6u4tslq6@oppo.com> In-Reply-To: <20240613091106.sfgtmoto6u4tslq6@oppo.com> From: Zhaoyang Huang Date: Thu, 13 Jun 2024 17:23:26 +0800 Message-ID: Subject: Re: [Resend PATCHv4 1/1] mm: fix incorrect vbq reference in purge_fragmented_block To: hailong liu Cc: Baoquan He , Uladzislau Rezki , "zhaoyang.huang" , Andrew Morton , Christoph Hellwig , Lorenzo Stoakes , Thomas Gleixner , linux-mm@kvack.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, steve.kang@unisoc.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: h7wwi1theopejhhdebefuchyc878zmz1 X-Rspam-User: X-Rspamd-Queue-Id: 1EA8B40024 X-Rspamd-Server: rspam02 X-HE-Tag: 1718270619-343934 X-HE-Meta: U2FsdGVkX18KZH5Kmi0ZNE/dlwrYYoaWfUFRttF65vSQY5GNWjyDpCXBD/IUPBYDr4baWd2FNxuEp0sIu55psed8ZOXImGVJRE2EOW3la6p13VU/F+jsHMnK8MKzUxN4ygaHeLPr+r+8IV97cP95r656b84ZXuW/UHS30MtujQ+YkLxO8ytXkc9/dUCKWoRLiQvzrL613IHGWHQ2ofi9i2bcJSk90YOl/BPAAbX6eYvitAN5l369P3L5Fm1t84H093pocEA2VcckazRrydZYu4psENcofpLadVdAc70ks0UrlmDPF2vTl0IXzFFa0sgTeiUX7o2sjIg9WJHeefcVzboHmuH+cK6dqHnn5wNs33cS9UJCZLpskyL2YWLawmXLSANTCChArzZ7nNr6kLWpguyoCOXsZ12gCnLvuzDNlhuKIgdBD4TGMH5HWh7orbqUiEhcrnn0itS5RqD++uCQeRP77kq0mBovsYFZs2xW0ElTQc5pZkzctxN9abbMhSo08zxG0528jV/CgiFAPCqVD0tfcSyAfGhliIEt4akFsBIYu7yepCeRgq5FOT97/YUs7wd6PKTAxgr+cX1NpEfLMEE1ljLHT9aX+kqNv3VTY3FSi/qF9+S047pbStybCdFsY9XcfivrQe5xIdb9cDn4L3Y8dMgNiQs6ITpCMGvCLjfnWGs4js0Tx1JXj3VggQYCwXQBomPB4K7A4O8E+ylmjovaBA8g4dDwsIWkQhDAhDmvNUxRkZ7US1BdMG9Fc+tcl7g03iarnnP7qWy1YOyd7B2aOyPTBHN6ZdrjwOdjnIsB+ucJVE7xXt+W237lkaIBgd7XOzPYP4JBYO/0QWj0St0re7w+2Z3E0hE8vt+C9ACpqS2s/YqdLCCXldrkpk8/78xBcz969siTGaXdl9oRvb/qNgX6gjCDh65SGImPBEmyL1uW7l6mBIfehLwbbbnIm7lVpdV+jAX1PFy0UzM co7K2Tcu NizxqoC5aWEopzUpVMH7bTPuQkVPM7dKxdc+2R2PMS56sehh+tt3xlez70DAA6Nu3GReeK3DdkbynuAMHehSXsUZ6A5yAcMt8Zzw+xYIGD2Ff/QyKWraTvEIeJ+Q+zT/g5dnoaMlOFbmNM0Aix6q4i99ep5RBYnOUE9yx+BpmjUQgn1Z27KnfBhG3LzB8fTnqtaVMKvaDGS8M2dHdl9lzxB7LYt7pBOzik3BHs5bumFmdwDiGPT1nnNPJHq94Gv2Yrfl3z1w2P8Mz/EEeS+S/47wYHJHQFYtkX+G7gND+VhMlvKG32AoGdGyGvaqbTl0x8inPcdVtg07ZnMrL/Usrea+irqBLY5/peBx4sB7K9ZLT7Cc/H2Mbp9XZObeoauvj3LwqwMRFUaxPpvSuj8nrUQFC7FZFzRizmCcxWM3i0yHgUaw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000861, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jun 13, 2024 at 5:11=E2=80=AFPM hailong liu = wrote: > > On Thu, 13. Jun 16:41, Baoquan He wrote: > > On 06/12/24 at 01:27pm, Uladzislau Rezki wrote: > > > On Wed, Jun 12, 2024 at 10:00:14AM +0800, Zhaoyang Huang wrote: > > > > On Wed, Jun 12, 2024 at 2:16=E2=80=AFAM Uladzislau Rezki wrote: > > > > > > > > > > > > > > > > > Sorry to bother you again. Are there any other comments or new = patch > > > > > > on this which block some test cases of ANDROID that only accept= ACKed > > > > > > one on its tree. > > > > > > > > > > > I have just returned from vacation. Give me some time to review y= our > > > > > patch. Meanwhile, do you have a reproducer? So i would like to se= e how > > > > > i can trigger an issue that is in question. > > > > This bug arises from an system wide android test which has been > > > > reported by many vendors. Keep mount/unmount an erofs partition is > > > > supposed to be a simple reproducer. IMO, the logic defect is obviou= s > > > > enough to be found by code review. > > > > > > > Baoquan, any objection about this v4? > > > > > > Your proposal about inserting a new vmap-block based on it belongs > > > to, i.e. not per-this-cpu, should fix an issue. The problem is that > > > such way does __not__ pre-load a current CPU what is not good. > > > > With my understand, when we start handling to insert vb to vbq->xa and > > vbq->free, the vmap_area allocation has been done, it doesn't impact th= e > > CPU preloading when adding it into which CPU's vbq->free, does it? > > > > Not sure if I miss anything about the CPU preloading. > > > > > > IIUC, if vb put by hashing funcation. and the following scenario may occu= r: > > A kthread limit on CPU_x and continuously calls vm_map_ram() > The 1 call vm_map_ram(): no vb in cpu_x->free, so > CPU_0->vb > CPU_1 > ... > CPU_x > > The 2 call vm_map_ram(): no vb in cpu_x->free, so > CPU_0->vb > CPU_1->vb > ... > CPU_x Yes, this could make the per_cpu vbq meaningless and the VMALLOC area be abnormally consumed(like 8KB in 4MB for each allocation) > > -- > help you, help me, > Hailong.