From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7034FA373D for ; Sun, 30 Oct 2022 03:46:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1055D8E0001; Sat, 29 Oct 2022 23:46:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 08EEE6B0073; Sat, 29 Oct 2022 23:46:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E71068E0001; Sat, 29 Oct 2022 23:46:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id D0DE56B0071 for ; Sat, 29 Oct 2022 23:46:19 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id A41D2C03E1 for ; Sun, 30 Oct 2022 03:46:19 +0000 (UTC) X-FDA: 80076228078.22.713C5CF Received: from mail-lj1-f173.google.com (mail-lj1-f173.google.com [209.85.208.173]) by imf26.hostedemail.com (Postfix) with ESMTP id 2B87F140007 for ; Sun, 30 Oct 2022 03:46:18 +0000 (UTC) Received: by mail-lj1-f173.google.com with SMTP id x21so11617416ljg.10 for ; Sat, 29 Oct 2022 20:46:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=Sp8bHwLrWZSds5lmdel+BN8d5LhT4/IKfgXdbYjTqiw=; b=p4ETo3RUzobyXcJAcDaDMlL+/p3HOtKhTQczWzLPW+blfMMmGT9JQkcUY/xRPucg6/ 8NjxSPaLazDNHMxN2oUTiM7R1LXJ2X+HjXvAgC7ZQWFv5zusfl/1//bGyrPQUDoDNI98 GH3V6oGNxWOGajeS8bIUIB79UsSyQBZdDVd+M7YCsS0m/k1n0K9w53CAbgsCRHNeK387 VXm+GJfq0JxHDyu2OjTuwQzxmwxdmae8D8/wq60VoBLfAJ5A20KbWH+UVhoIRYqlg1D/ MF7Dz46eSNCceqAUAJk9Z5HM18cl2s9u615WLeoPRv1cwwdtiLwvbBYMKSQEQbMHXqb3 fkPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Sp8bHwLrWZSds5lmdel+BN8d5LhT4/IKfgXdbYjTqiw=; b=PHcZZ+Z/lYpQrZDZQNQ34OzxaB/M2GrmiK6J6N+FcgQdkJv7kodyr4ch8b8dCnSk94 sg8I5/4+iY2wpcDprjxFfvUlhLSw+46JtvUc98iYSkAX8UMjQKRzCjlTio8WuQvjBP1v 9ZLxFFSmojFOrT2DQi2WnQN561cjIxbOFMv4QlQGH6hyaxwSxIOiywhIisitlQ0BApnc bxpotClpaHcsOkUuV6mAL1XlPNbd54aT8+DJnv7+UR602DOysvijveyX9dOV3DiDHI5S 1ytmN+NzGCkAgJBUwhPAOZWjzOI1Mp6l8Bg1v0A4mxkSzkE7EId3rL13k9tCf9EhLrpE h2jA== X-Gm-Message-State: ACrzQf1PW6BROC49twsDppo1nUdWaN/YqaY45ejaN7BVAcw1mYmgdnsN EjTZ0k9xf3xAERffAbo8P28F4XYfFLNAJp9gguM= X-Google-Smtp-Source: AMsMyM4wCkIgCP6CqWFIBmoZE0sUvRhnWNcEQYez7TIHd1Lo4Ue9fdRALgDvAY3ng+vt+hdGraCeX84wx2Qoz6P7aTI= X-Received: by 2002:a2e:b16b:0:b0:277:3946:7611 with SMTP id a11-20020a2eb16b000000b0027739467611mr2877585ljm.392.1667101577318; Sat, 29 Oct 2022 20:46:17 -0700 (PDT) MIME-Version: 1.0 References: <1667101354-4669-1-git-send-email-zhaoyang.huang@unisoc.com> In-Reply-To: <1667101354-4669-1-git-send-email-zhaoyang.huang@unisoc.com> From: Zhaoyang Huang Date: Sun, 30 Oct 2022 11:45:48 +0800 Message-ID: Subject: Re: [PATCHv3] mm: use stack_depot for recording kmemleak's backtrace To: "zhaoyang.huang" Cc: Andrew Morton , Catalin Marinas , Matthew Wilcox , Vlastimil Babka , linux-mm@kvack.org, linux-kernel@vger.kernel.org, ke.wang@unisoc.com, steve.kang@unisoc.com Content-Type: text/plain; charset="UTF-8" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1667101579; a=rsa-sha256; cv=none; b=awqE6fcTx3fr+7IagKyCPFXjUJqHmaptenU/iqwBLviBZSE7f5srLUjJWLiRETXMLHLxHv NH6xBp8WHTyqc9K/QcxBlzLsyUqvNIdT4UQPy5FjutuxYtY7sN3Xuj8kaGymp268GswJiX UqOeHVwKDS7GDsQuSAarfaSZySQ44aA= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=p4ETo3RU; spf=pass (imf26.hostedemail.com: domain of huangzhaoyang@gmail.com designates 209.85.208.173 as permitted sender) smtp.mailfrom=huangzhaoyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1667101579; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Sp8bHwLrWZSds5lmdel+BN8d5LhT4/IKfgXdbYjTqiw=; b=IyiQLiipXsCMtv95KnSKuH9OQM6gFZHauUXlEnkk3vEgs84RzHoXWyZ7FpUDXt1p2AbghZ tVLK4vQEwN1WK7rBFx6ncCrbmmQel563LTnk62DZApismkLt2raA3ERJu2t+RwwtBtO2rl a62bCkjFtUzCVkcUro7LlGnRUMnW8aw= Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=p4ETo3RU; spf=pass (imf26.hostedemail.com: domain of huangzhaoyang@gmail.com designates 209.85.208.173 as permitted sender) smtp.mailfrom=huangzhaoyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 2B87F140007 X-Stat-Signature: ixfe8jtx4545ua4krfiozse7we43pzuj X-Rspam-User: X-HE-Tag: 1667101578-451617 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: This patchset fixes bellowing lkp report by having CONFIG_DEBUG_KMEMLEAK select CONFIG_STACK_DEPOT by default and remove unused function. tree: https://github.com/ammarfaizi2/linux-block akpm/mm/mm-unstable head: eecc1f68b7ae1e677dd01b728e58de61a2f8ae71 commit: a3ed421a1d5f0bea0bcd91a0d001428b2c42ecbe [216/244] mm: use stack_depot for recording kmemleak's backtrace config: s390-randconfig-r021-20221030 compiler: clang version 16.0.0 (https://github.com/llvm/llvm-project 791a7ae1ba3efd6bca96338e10ffde557ba83920) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install s390 cross compiling tool for clang build # apt-get install binutils-s390x-linux-gnu # https://github.com/ammarfaizi2/linux-block/commit/a3ed421a1d5f0bea0bcd91a0d001428b2c42ecbe git remote add ammarfaizi2-block https://github.com/ammarfaizi2/linux-block git fetch --no-tags ammarfaizi2-block akpm/mm/mm-unstable git checkout a3ed421a1d5f0bea0bcd91a0d001428b2c42ecbe # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=s390 SHELL=/bin/bash If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot All errors (new ones prefixed by >>): s390x-linux-ld: DWARF error: could not find abbrev number 13221 mm/kmemleak.o: in function `__create_object': >> kmemleak.c:(.text+0x40a): undefined reference to `stack_depot_print' s390x-linux-ld: mm/kmemleak.o: in function `paint_ptr': kmemleak.c:(.text+0xaf8): undefined reference to `stack_depot_print' s390x-linux-ld: mm/kmemleak.o: in function `kmemleak_scan': >> kmemleak.c:(.text+0x19ee): undefined reference to `stack_depot_fetch' s390x-linux-ld: mm/kmemleak.o: in function `dump_str_object_info': kmemleak.c:(.text+0x1bac): undefined reference to `stack_depot_print' >> s390x-linux-ld: kmemleak.c:(.text+0x1c40): undefined reference to `stack_depot_print' s390x-linux-ld: mm/kmemleak.o: in function `scan_block': kmemleak.c:(.text+0x249a): undefined reference to `stack_depot_print' s390x-linux-ld: mm/kmemleak.o: in function `kmemleak_seq_show': kmemleak.c:(.text+0x2f28): undefined reference to `stack_depot_fetch' s390x-linux-ld: mm/kmemleak.o: in function `kmemleak_vmalloc': >> kmemleak.c:(.ref.text+0x290): undefined reference to `stack_depot_print' s390x-linux-ld: mm/kmemleak.o: in function `kmemleak_free': kmemleak.c:(.ref.text+0x66c): undefined reference to `stack_depot_print' s390x-linux-ld: mm/kmemleak.o: in function `kmemleak_free_percpu': kmemleak.c:(.ref.text+0xb44): undefined reference to `stack_depot_print' s390x-linux-ld: mm/kmemleak.o: in function `kmemleak_scan_area': kmemleak.c:(.ref.text+0x1248): undefined reference to `stack_depot_print' s390x-linux-ld: mm/kmemleak.o: in function `kmemleak_no_scan': kmemleak.c:(.ref.text+0x1622): undefined reference to `stack_depot_print' On Sun, Oct 30, 2022 at 11:43 AM zhaoyang.huang wrote: > > From: Zhaoyang Huang > > Using stack_depot to record kmemleak's backtrace which has been implemented > on slub for reducing redundant information. > > Signed-off-by: Zhaoyang Huang > Acked-by: Catalin Marinas > Cc: ke.wang > Cc: Matthew Wilcox (Oracle) > Cc: Vlastimil Babka > Cc: Zhaoyang Huang > Signed-off-by: Andrew Morton > --- > changes of v2: fix bugs of stack_depot_init related issue > changes of v3: have DEBUG_KMEMLEAK select STACK_DEPOT by default > remove unuse functions > --- > --- > lib/Kconfig.debug | 1 + > mm/kmemleak.c | 48 +++++++++++++++++++++++++++++------------------- > 2 files changed, 30 insertions(+), 19 deletions(-) > > diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug > index bcbe60d..0def8e0 100644 > --- a/lib/Kconfig.debug > +++ b/lib/Kconfig.debug > @@ -717,6 +717,7 @@ config DEBUG_KMEMLEAK > select STACKTRACE if STACKTRACE_SUPPORT > select KALLSYMS > select CRC32 > + select STACKDEPOT > help > Say Y here if you want to enable the memory leak > detector. The memory allocation/freeing is traced in a way > diff --git a/mm/kmemleak.c b/mm/kmemleak.c > index 1eddc01..cedc6f3 100644 > --- a/mm/kmemleak.c > +++ b/mm/kmemleak.c > @@ -79,6 +79,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -159,8 +160,7 @@ struct kmemleak_object { > u32 checksum; > /* memory ranges to be scanned inside an object (empty for all) */ > struct hlist_head area_list; > - unsigned long trace[MAX_TRACE]; > - unsigned int trace_len; > + depot_stack_handle_t trace_handle; > unsigned long jiffies; /* creation timestamp */ > pid_t pid; /* pid of the current task */ > char comm[TASK_COMM_LEN]; /* executable name */ > @@ -343,21 +343,24 @@ static bool unreferenced_object(struct kmemleak_object *object) > * print_unreferenced function must be called with the object->lock held. > */ > static void print_unreferenced(struct seq_file *seq, > - struct kmemleak_object *object) > + struct kmemleak_object *object) > { > int i; > + unsigned long *entries; > + unsigned int nr_entries; > unsigned int msecs_age = jiffies_to_msecs(jiffies - object->jiffies); > > + nr_entries = stack_depot_fetch(object->trace_handle, &entries); > warn_or_seq_printf(seq, "unreferenced object 0x%08lx (size %zu):\n", > - object->pointer, object->size); > + object->pointer, object->size); > warn_or_seq_printf(seq, " comm \"%s\", pid %d, jiffies %lu (age %d.%03ds)\n", > - object->comm, object->pid, object->jiffies, > - msecs_age / 1000, msecs_age % 1000); > + object->comm, object->pid, object->jiffies, > + msecs_age / 1000, msecs_age % 1000); > hex_dump_object(seq, object); > warn_or_seq_printf(seq, " backtrace:\n"); > > - for (i = 0; i < object->trace_len; i++) { > - void *ptr = (void *)object->trace[i]; > + for (i = 0; i < nr_entries; i++) { > + void *ptr = (void *)entries[i]; > warn_or_seq_printf(seq, " [<%p>] %pS\n", ptr, ptr); > } > } > @@ -370,15 +373,16 @@ static void print_unreferenced(struct seq_file *seq, > static void dump_object_info(struct kmemleak_object *object) > { > pr_notice("Object 0x%08lx (size %zu):\n", > - object->pointer, object->size); > + object->pointer, object->size); > pr_notice(" comm \"%s\", pid %d, jiffies %lu\n", > - object->comm, object->pid, object->jiffies); > + object->comm, object->pid, object->jiffies); > pr_notice(" min_count = %d\n", object->min_count); > pr_notice(" count = %d\n", object->count); > pr_notice(" flags = 0x%x\n", object->flags); > pr_notice(" checksum = %u\n", object->checksum); > pr_notice(" backtrace:\n"); > - stack_trace_print(object->trace, object->trace_len, 4); > + if (object->trace_handle) > + stack_depot_print(object->trace_handle); > } > > /* > @@ -591,12 +595,18 @@ static struct kmemleak_object *find_and_remove_object(unsigned long ptr, int ali > return object; > } > > -/* > - * Save stack trace to the given array of MAX_TRACE size. > - */ > -static int __save_stack_trace(unsigned long *trace) > +static noinline depot_stack_handle_t set_track_prepare(void) > { > - return stack_trace_save(trace, MAX_TRACE, 2); > + depot_stack_handle_t trace_handle; > + unsigned long entries[MAX_TRACE]; > + unsigned int nr_entries; > + > + if (!kmemleak_initialized) > + return 0; > + nr_entries = stack_trace_save(entries, ARRAY_SIZE(entries), 3); > + trace_handle = stack_depot_save(entries, nr_entries, GFP_NOWAIT); > + > + return trace_handle; > } > > /* > @@ -654,7 +664,7 @@ static struct kmemleak_object *__create_object(unsigned long ptr, size_t size, > } > > /* kernel backtrace */ > - object->trace_len = __save_stack_trace(object->trace); > + object->trace_handle = set_track_prepare(); > > raw_spin_lock_irqsave(&kmemleak_lock, flags); > > @@ -694,7 +704,6 @@ static struct kmemleak_object *__create_object(unsigned long ptr, size_t size, > rb_link_node(&object->rb_node, rb_parent, link); > rb_insert_color(&object->rb_node, is_phys ? &object_phys_tree_root : > &object_tree_root); > - > list_add_tail_rcu(&object->object_list, &object_list); > out: > raw_spin_unlock_irqrestore(&kmemleak_lock, flags); > @@ -1094,7 +1103,7 @@ void __ref kmemleak_update_trace(const void *ptr) > } > > raw_spin_lock_irqsave(&object->lock, flags); > - object->trace_len = __save_stack_trace(object->trace); > + object->trace_handle = set_track_prepare(); > raw_spin_unlock_irqrestore(&object->lock, flags); > > put_object(object); > @@ -2064,6 +2073,7 @@ void __init kmemleak_init(void) > if (kmemleak_error) > return; > > + stack_depot_init(); > jiffies_min_age = msecs_to_jiffies(MSECS_MIN_AGE); > jiffies_scan_wait = msecs_to_jiffies(SECS_SCAN_WAIT * 1000); > > -- > 1.9.1 >