From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E23A0C5321D for ; Tue, 27 Aug 2024 02:53:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4B6EF6B007B; Mon, 26 Aug 2024 22:53:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 466DA6B0082; Mon, 26 Aug 2024 22:53:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3569A6B0083; Mon, 26 Aug 2024 22:53:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 1858B6B007B for ; Mon, 26 Aug 2024 22:53:20 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id AB8B412156C for ; Tue, 27 Aug 2024 02:53:19 +0000 (UTC) X-FDA: 82496504118.28.C8AA885 Received: from mail-lf1-f42.google.com (mail-lf1-f42.google.com [209.85.167.42]) by imf17.hostedemail.com (Postfix) with ESMTP id D130840003 for ; Tue, 27 Aug 2024 02:53:17 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=gAdvnlhk; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf17.hostedemail.com: domain of huangzhaoyang@gmail.com designates 209.85.167.42 as permitted sender) smtp.mailfrom=huangzhaoyang@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724727101; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ZPrMdRJgCEqshIHBhb83joFSbupL5mDWXNnSTcIfedE=; b=YCmRo1cP0dAUkzci2dSAiOmoK3wyRoGtSb0B06voRq1IQ52S0cHp6ZDrv+237fAgtNZUQU FIic+pAwjDqt3hmoNKuMGmUisCBZaMgKlYqrDQgSV2idve8QNkEMbrSUWt4NTarStEz+Ta IHHIKwNhnEl18P3vpwnPzLi0ZjCsVoM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724727101; a=rsa-sha256; cv=none; b=d6lVMA23pQj8hQcEpGLRiXH1Aj/N9Sx2CkI0oRgXAmHluV02mTzu7pVLSsLGQq3CwFF0vl V7HUUIpY/VfSpMRxhmRy3AbGZJ7+EPFUKkFQ/phZreUsCZ8H13P7ObJVJELhI7TFE9Y7QI TKG2q3tFGScUo8CZ/lSm4XR23nX9JBk= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=gAdvnlhk; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf17.hostedemail.com: domain of huangzhaoyang@gmail.com designates 209.85.167.42 as permitted sender) smtp.mailfrom=huangzhaoyang@gmail.com Received: by mail-lf1-f42.google.com with SMTP id 2adb3069b0e04-5334b61b6beso816110e87.3 for ; Mon, 26 Aug 2024 19:53:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1724727196; x=1725331996; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=ZPrMdRJgCEqshIHBhb83joFSbupL5mDWXNnSTcIfedE=; b=gAdvnlhk4lxr0ZjO6eiHnVPACxfaELps5SIdKasCz8eLUm+wj6lQpvYlzso34M/0H7 jhiW1uSUjbyOBNgiPiRwvrQepHWSlB5bw8+ZkSoM2zjArR1HGj0Rql1TtD1z/t59dJpO AbjBL2Ykxe+v3FKPAmtCAqZ/fo69r/2pASMepSdlCGTSTVxCpdVfqobdme9v2zDYf9nG 2jNwb+2ZIADzlWmDg7OZYYCVgDM3S+TlaSQeJNogozAEn4yHDqj380nc6CmYVM5QJARP 54PEhEfri83xriouaIb2EJsv+nB/aZQ5j3Bh5c+KCKfsbtPMpCmkGf9if5F3i6H/DrT9 PWzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724727196; x=1725331996; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ZPrMdRJgCEqshIHBhb83joFSbupL5mDWXNnSTcIfedE=; b=jjgiWrmwsgvJ90DGMV6SMd0Qe9Y3FZshZpc68qIA9cLooOlzoN5fPPVDRJfbN+3PsN 3NiHaGQ/R/FMpJ5bDHcDSIe4lTkqL2TM2Lr39UfFxXM8VaocJVo2HOB4RS6JfqCCJO1U EeO2dS2b2rGXKW6j0mXTmSjYcl2zCT5xlkT+QJ62zl0N3DP6m90x/DzZsBGtnx2ADMGk s67jpeBbnXZmisSSLLkeygBQf6Jf01pkfitNVDMW1rUQVW70rouGl5+uZGmzuvsZ03Fe kjQ0SZeDEXTp/bsP+Ka8yoFLW88pu1iRoXnwaShWVmWTSDVErEkIYbXu4m2kZx7KZHSD Luww== X-Forwarded-Encrypted: i=1; AJvYcCXQ/nuS5Q8I3ciIyTSqP4HoN+QjutwtoPHXW0FjqJS/bGZTUWXIJhnqAtog9A7km98SX4NS147gKw==@kvack.org X-Gm-Message-State: AOJu0Yy71ilM9XQQnoPPzqbAFbkIwIyj2khJzND+yjs0gemM/KQT0bIE AH3Ru+VKggIyywWlXec/PIA1eVshdoilvURcBp7YW7Ddaj3rs4E55T5msIQ0x7sw2r/xjlCHepx egZqfo4tlYb1/f5mxsj0rax5Df1Q= X-Google-Smtp-Source: AGHT+IGUTRcJ2INikU/5qtg10zQdq50CoQs+thFiTCXFivJC6mxCbbSpWdeyskER/pxAOZ/D2NxVF2U/l990cYmTjhU= X-Received: by 2002:a05:651c:b07:b0:2f3:a896:1877 with SMTP id 38308e7fff4ca-2f4f4748b7emr52277381fa.0.1724727195256; Mon, 26 Aug 2024 19:53:15 -0700 (PDT) MIME-Version: 1.0 References: <20240826085056.895865-1-zhaoyang.huang@unisoc.com> <38881e37-767c-456a-8301-2a7d0371d12e@redhat.com> <8ffc4e3f-bae9-4567-8eb7-f1b163309d7e@redhat.com> In-Reply-To: From: Zhaoyang Huang Date: Tue, 27 Aug 2024 10:53:03 +0800 Message-ID: Subject: Re: [RFC PATCH 1/1] mm: Skip folio with private data during isolation To: Matthew Wilcox Cc: David Hildenbrand , "zhaoyang.huang" , Andrew Morton , Yu Zhao , Baolin Wang , linux-mm@kvack.org, steve.kang@unisoc.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: D130840003 X-Stat-Signature: 5jcm9m11bnqpbjnzai8nkt6h14pqm18c X-Rspam-User: X-HE-Tag: 1724727197-62601 X-HE-Meta: U2FsdGVkX1/uFZniuDQp4syHNKczAsY/2zSqi0Qbd9Bo2zag4i4q47Vl+6+NBG98+XzMALhIfkbrn1pOGAtcFn68P96Ph3KX/gT/pzzfJUgqiAYCFJTp0cJJx8Tyt0QnOafat5+eop9FUl6jZxXq2T/aPUkIHEQQEDFNs9SqvEDp/BdLNOCeBUQQNvr+Zj6bhIpemHG9n+9MrTCZQ+FWS03nDJ9U350V/d5pAgL990kOzVn9y9hZ45ls196xIMropo4ayrvj967krKDnv/UgymcsE8xPkaze9q4QzDTKFfOSXnQNFZPYQTmLJddfJ/P8l0A4dceX9qVTtonbiZOg1OYojmA7Rwebq2c4ZVx0aqhxhDA3MnEAsnEBnC5jos5723J44u14ByuiUVQlyi0bsu2A7C2SdWQu5UIhMpVQGDlcyKGhUPxM/2fWZsKsIRwQc+MREr4sCSC/jbrjnaXzHkzGuOYMbOqyT4zO1Zy6FQYDdV9jNPNM7K4wMCC/gMjrU2zkYui2XSauvSEovs/9Rpz22cDEK/6Ch5ybSARaMgna6m1NZcnroZWiuo/a7a+fxRaWPJk7HlsxLNjZVofOI/rzsdxyu4PlNZzfQE4RNv4lEvj6l2TyPwazLQLNxG0dzev+YD8GULOa/24geE7co6dFJU5hV6By7kmpn32n92GX3zHibB40SFXWMlsjURrYonukDZmlRjfFN73SAZlKm7EMpkFVCYyVqOydC6DRUAFcYPKK2kv1c6eWsV5AdGpSEYq77iymOmOs9NQ6P2Vehu44ZKtCHJv4RmQFX1HWR0WgGpOmi9wFvSEUg+6qvWbXRwWWvBvdcMOYMgJzK4qgd45OFefKAd97ONDtlmStofwXZzkaGVKzidANnectRYlHYcjDFpMOTov9Ht15mfdpKNYIEI8/6SJNemwmqUY90ZpeZ8OcyivEn7woOsDTnn+mKqUJi6llpk8sjE6cjjT VYms8G6+ XhWp3wzUKqBb2NfFmIlX7M8FXZeMh+bh6dX+zDvQ7vFvsECG5tEHCy7HsHVWFqZZFebIYQuPa+UiZ0+OJzOI59awg28WbjppVwPEqKxtV9MuVOqghJoNxa6AfGvGHjgQzAPnbpjvXya0MnphgfME07+tgiOyIxcRvkMRLKWcrZlTjrQMymBY0TxaE08qtgdHSw9Tt7TOtT8JKO79pkxzi40pu8LlrdgAVHzQyvX1k8QIcWXRMT/djBWRMGcAJSTeppMb42RN0dJGrD+IEi5Mogdsx9cM8i0ZGnGfB82MCUx9U6vHr++HoSngBtkcmJ+cejaiTftPSNYuryqwUYANyA2e2bk+YRLuLsUwOWcgzY+P4ezdk5RsvXk8+RQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Aug 27, 2024 at 10:49=E2=80=AFAM Matthew Wilcox wrote: > > On Tue, Aug 27, 2024 at 10:45:11AM +0800, Zhaoyang Huang wrote: > > On Mon, Aug 26, 2024 at 9:01=E2=80=AFPM David Hildenbrand wrote: > > > On 26.08.24 13:10, Zhaoyang Huang wrote: > > > > On Mon, Aug 26, 2024 at 6:36=E2=80=AFPM David Hildenbrand wrote: > > > >> An earlier filemap_release_folio() would have failed if the privat= e data > > > >> (buffers) cannot get freed, and we went into the activate_locked p= ath. > > > >> > > > >> if (folio_needs_release(folio)) { > > > >> if (!filemap_release_folio(folio, sc->gfp_mask) > > > >> goto activate_locked; > > > >> ... > > > No, this is actually a migration failure issue[1] related to cma_alloc > > where the bh keeps busy as the journal's transaction can't be > > launched[2][3][4][5][6]. I am just inspired by this issue to check if > > there is anything to do in reclaiming. By counting from a ramdump, > > there are 300MB "lru, private" pages found in a 6GB RAM system which > > could lower the reclaiming efficiency if the same scenario as above > > happens. > > As David said, if we encounter a filesystem folio with private data, > we ask the filesystem to strip the private data off. Usually this > succeeds, because most folios aren't part of the journal for very long. Got it, thanks for clarifying.