From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F2BAC25B74 for ; Thu, 30 May 2024 07:36:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7DE176B0098; Thu, 30 May 2024 03:36:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 78DEB6B0099; Thu, 30 May 2024 03:36:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 67BE46B009C; Thu, 30 May 2024 03:36:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 4AC166B0098 for ; Thu, 30 May 2024 03:36:08 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id E4AACC0EA9 for ; Thu, 30 May 2024 07:36:07 +0000 (UTC) X-FDA: 82174253574.26.B0F2A98 Received: from mail-lj1-f171.google.com (mail-lj1-f171.google.com [209.85.208.171]) by imf14.hostedemail.com (Postfix) with ESMTP id 05A90100013 for ; Thu, 30 May 2024 07:36:05 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Tiw2agz4; spf=pass (imf14.hostedemail.com: domain of huangzhaoyang@gmail.com designates 209.85.208.171 as permitted sender) smtp.mailfrom=huangzhaoyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717054566; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=FSdMX9nVn63UzsnfKzlfMyErtMmAkmSMyXsDizDSnrU=; b=1MNk88tkhU0tzaTGAu7vJnfmd2lUjPJwIMiR1NI2toPYbINHcxH0NnSH2YE739/Ta4jaHO xs1rg8dQKix1nsPCRqe5D0hrvTmaYcb5SeUXfxO/yydp/iY6+SH705zjKCgPrudGC3HqFS kqJr4vWRkZEcEl16ORXes/vij0EjR/Q= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Tiw2agz4; spf=pass (imf14.hostedemail.com: domain of huangzhaoyang@gmail.com designates 209.85.208.171 as permitted sender) smtp.mailfrom=huangzhaoyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717054566; a=rsa-sha256; cv=none; b=nqPobDgF4Zio29qoM7wGyAM8Zlf7WFf5eAb5hZs6zufTw9dJO7Mfz6/x5eJrdCtj6Jxywz t0IqQ5JGQvxMhlpoq/ZdplkYzm1i+2Tl9QpR8EGByy6axGu2y5YuHKRMMfL0NVyH8m86Nb EEYfrt9lz28vaOcG9a0McRluChTRqFY= Received: by mail-lj1-f171.google.com with SMTP id 38308e7fff4ca-2e6f2534e41so5586171fa.0 for ; Thu, 30 May 2024 00:36:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1717054564; x=1717659364; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=FSdMX9nVn63UzsnfKzlfMyErtMmAkmSMyXsDizDSnrU=; b=Tiw2agz4f4gweeVVRtjW3S5PKQYkdM04kFI089i4EKNi+oCZjrqzsEfk7q542kqWr0 U1QFT1tht33GQrFoO8B1PYSo3IBWea12jLcxwICkMDOCRd1mBxy5V8e/NtVmGHU75G2J 6pGoyjDMtqU3HysLHCpWvFaFu+davXdNxHJqOAyRROhL6WZ/D0rXIox3MoJfSroUvWiH lE1sWDUTaiOh4D5mxEfLzOokSN/ZxRUEFmypbXwkbsSd0vbkMQ3Bi+kEwta4+yee/CA8 S67jpAr9b+cR/ahyUbaBluIAgGsWc4dgOOTqSTBWesX0HFDVOXlKjG1KE5+YCwub+KrE ntnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717054564; x=1717659364; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=FSdMX9nVn63UzsnfKzlfMyErtMmAkmSMyXsDizDSnrU=; b=vVlSoFWYohcu66NGu15zo4jifuU5yP/v8xe8uHd0yjdhR1uDdW8sZ0jW0rNttyDJ49 luYwNE0WbrZPYsV+4ovg1KUpB+rR7gUx4rSz7idN2Mh33+hqt69QBuw36i/hZdgt9xJq nfynNmUUg7POb0qXY6wuyrzp0HqiYzbex/YGYevmJQb38kP33IXjex+vOfTjlMGLnrFz Dwgd1g5ekFWwCE0SAgQBT1Lal2jFWo/Xgcn9sC0h3OqZVtyjSy8ydvNC/+N0LfrqaYU/ 1ZvIS3Z24DnQPJObJ67UAP8cZHdg3+OqEJIQ2+cPKcchGP8QvyY2RLriSo81i8bKgApn pWFQ== X-Forwarded-Encrypted: i=1; AJvYcCXpzXxzTFoV1Bl6q1qBx6xIrEWtFn7YRM8KHVixYGlrooBM4EpMx5887EM3OtCgUIuWiYnqWedLyT2ouWvhFIlkaIk= X-Gm-Message-State: AOJu0Yw5jUYFzKaZE1c1xUln6zq9oJe+v6s0xD/CiihBd0m2ss+XKw6z oNgrIL+CzQwX+MARDlZxx12Ewv43YGY4Zy4TLmt12HWpAWSa5TMTGbx2WBW/WTa39CBzJNlZ2BJ RRUtIU2lhUxkZIsj0fITsf8c7GyU= X-Google-Smtp-Source: AGHT+IGt4yUZwhuTvVGgWsfFTUOCI4IUIKuGOQdQBQ4ueIr+TvLrPg/MUYEVlyPEvn9z6PHZ4g/KIWcq6W87wJ8RT14= X-Received: by 2002:a2e:90d2:0:b0:2e1:fae0:8ba3 with SMTP id 38308e7fff4ca-2ea846e416emr7310961fa.0.1717054563994; Thu, 30 May 2024 00:36:03 -0700 (PDT) MIME-Version: 1.0 References: <20240530025144.1570865-1-zhaoyang.huang@unisoc.com> In-Reply-To: From: Zhaoyang Huang Date: Thu, 30 May 2024 15:35:52 +0800 Message-ID: Subject: Re: [PATCH] mm: fix incorrect vbq reference in purge_fragmented_block To: Baoquan He Cc: "zhaoyang.huang" , Andrew Morton , Uladzislau Rezki , Christoph Hellwig , Lorenzo Stoakes , linux-mm@kvack.org, linux-kernel@vger.kernel.org, steve.kang@unisoc.com, Thomas Gleixner Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 05A90100013 X-Stat-Signature: x9qd5rm9ab8r6u5wkgx1wpmytrc7zuz7 X-HE-Tag: 1717054565-186191 X-HE-Meta: U2FsdGVkX18URmLVVav7o2iAgQS7LtiuSb09hwLICZQwRUs0BMmBUgYL/ui59D+6hOlkKtoD50gVZqv6trtlfMo0kZFOf4jZ/NYy5sft2hoTuEIFZ8HaA3w8fmh0KfiMG6uSCTnynhxmxwOyndcCIsB/Kxz8fhF+3YG97HKYpDyRSTeSrfR9UVjsBKbn9ElqJGz/RZO3ZBGoTQ4BNPlr7m877euUCAx4Qb7lZi3FJtIPfPZg6yri6lORA1vzNSPdi/iwyX6NxkxsL4leyLZNjMNrVayFEhkplcUCLdKWwnEVrOG3Oe2mllX58A5TzzzKC5Iq3pfnrAqyyGvS0FKu3Owfa1XuHT4N2ZkMxu2yO6TNh75gef3NY4RQ2aPbpPVH6mKt542D0eJK6BJGGLOvNn+ZGEWl9EarSl6ke86VwRdRFCPm4HUGOgd2uuMdgZtm69FuSeQlf1GgCmW0pP/CANirAdSj7KzE0E56vbxERU06PLH24oD7OVkZXPSWHJoijDFxecqgp78seZJokIrhPDsdsoEQ25TioNvEGrOV8IoBbxqeWlT4bWX/LwmEZllu4RdX10Id7lvpWk1JlvLsY6XypoKIrL4P8Zr1qpfXaA0HH9b1WR5q0p3hYBHWdanA1EugwNRSevAvIxKD9P3t87wL6faNHTdMKMLtXEOcln/Yi1RuVumNPITLBmAWC1FxJyc2uOtAMhMMD+qawNXatPv7HtUTuaohbZqyOWb5w/MuGJiGvqDxblM2iZKz+8cZgYwun1JubSV/rORFIJhHKoz3EsUORwkHARLeLPLI0hu0kUuPrCECuEsQpe1hpoARnTcG7CQGRTqbF8XjYMBC1+X/yFQyeYKxdkwCI09sE9UXppxrmYxPVUGj1LqrHToJjWYzFqFZKnSUgSq1xOGJeuUGjctQKSn/PhBhAq6RX4zDsxntyi7fE9CRasqDP3LUTtlogKBushAb5N3SK7m yeEKxzmw sy32vXtWH0EX79PwRPrqRjSZYNebItC4zZhS1W6d6FleSO8BIp5l9EPDMkXyc9l7BZWwDG7ZHCV9IMZcsthLTZaC4ywR/y3A5yKZmGh+L4Vrd7Lv4b1lGzCHkv/8YfPmybKmGP5mIsMnSUePvoh+QMgEwfHyHaQf/mXO9VfVzvnwccGIYzclPNSqrESwSdnJB7E+HgqJ2B5vypLPrD22tO8JqQxE4UILfxBo8yy/w4lLghhS7u2toVIHfejT0UhLX5BzlTfYQ7MaNdJcL5wLi5/NN6Aa19x3ZXI6+3eTtqvo8wmZyeE73RSiLKaxbWi8f579oXTz2eFGX3ZgnbfbrYgojLx/HreL1qjZG1rnaiuuKXwp4XF8pW8H071bQgd2sUd9v2rl9p1QexWHhuii2eAZ/kc9QKDXNIZv/SDodbD+AIF3QPNyt6Xl8nKiUgcOtF+oBmt/elrQwpFMfI35/63DGPYo2WC+F6hug X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, May 30, 2024 at 3:19=E2=80=AFPM Baoquan He wrote: > > On 05/30/24 at 10:51am, zhaoyang.huang wrote: > > From: Zhaoyang Huang > > > > Broken vbq->free reported on a v6.6 based system which is caused > > by invalid vbq->lock protect over vbq->free in purge_fragmented_block. > > This should be introduced by the Fixes below which ignored vbq->lock > > matter. > > It will be helpful to provide more details, what's the symptom of the > brekage, and in which case vbq->free is broken. Vmalloc area runs out in our ARM64 system during an erofs test as vm_map_ram failed[1]. We find that one vbq->free->next point to vbq->free which makes list_for_each_entry_rcu can not iterate the list and find the BUG. [1] PID: 1 TASK: ffffff80802b4e00 CPU: 6 COMMAND: "init" #0 [ffffffc08006afe0] __switch_to at ffffffc08111d5cc #1 [ffffffc08006b040] __schedule at ffffffc08111dde0 #2 [ffffffc08006b0a0] schedule at ffffffc08111e294 #3 [ffffffc08006b0d0] schedule_preempt_disabled at ffffffc08111e3f0 #4 [ffffffc08006b140] __mutex_lock at ffffffc08112068c #5 [ffffffc08006b180] __mutex_lock_slowpath at ffffffc08111f8f8 #6 [ffffffc08006b1a0] mutex_lock at ffffffc08111f834 #7 [ffffffc08006b1d0] reclaim_and_purge_vmap_areas at ffffffc0803ebc3c #8 [ffffffc08006b290] alloc_vmap_area at ffffffc0803e83fc #9 [ffffffc08006b300] vm_map_ram at ffffffc0803e78c0 #10 [ffffffc08006b420] z_erofs_lz4_decompress at ffffffc0806a49b0 #11 [ffffffc08006b670] z_erofs_decompress_queue at ffffffc0806a8fd0 #12 [ffffffc08006b860] z_erofs_runqueue at ffffffc0806a8744 #13 [ffffffc08006b970] z_erofs_readahead at ffffffc0806a6cfc #14 [ffffffc08006ba00] read_pages at ffffffc08037ed78 #15 [ffffffc08006ba70] page_cache_ra_unbounded at ffffffc08037eb58 #16 [ffffffc08006bb00] page_cache_ra_order at ffffffc08037f42c #17 [ffffffc08006bbb0] do_sync_mmap_readahead at ffffffc080371d3c #18 [ffffffc08006bc40] filemap_fault at ffffffc080371774 #19 [ffffffc08006bd60] handle_mm_fault at ffffffc0803cc118 #20 [ffffffc08006bdc0] do_page_fault at ffffffc08112a618 #21 [ffffffc08006be20] do_translation_fault at ffffffc08112a36c #22 [ffffffc08006be30] do_mem_abort at ffffffc0800bfbf0 #23 [ffffffc08006be70] el0_ia at ffffffc08111583c #24 [ffffffc08006bea0] el0t_64_sync_handler at ffffffc0811156a4 #25 [ffffffc08006bfe0] el0t_64_sync at ffffffc080091584 > > > > > Fixes: fc1e0d980037 ("mm/vmalloc: prevent stale TLBs in fully utilized = blocks") > > > > Signed-off-by: Zhaoyang Huang > > --- > > mm/vmalloc.c | 11 +++++++---- > > 1 file changed, 7 insertions(+), 4 deletions(-) > > > > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > > index 22aa63f4ef63..112b50431725 100644 > > --- a/mm/vmalloc.c > > +++ b/mm/vmalloc.c > > @@ -2614,9 +2614,10 @@ static void free_vmap_block(struct vmap_block *v= b) > > } > > > > static bool purge_fragmented_block(struct vmap_block *vb, > > - struct vmap_block_queue *vbq, struct list_head *purge_lis= t, > > - bool force_purge) > > + struct list_head *purge_list, bool force_purge) > > { > > + struct vmap_block_queue *vbq; > > + > > if (vb->free + vb->dirty !=3D VMAP_BBMAP_BITS || > > vb->dirty =3D=3D VMAP_BBMAP_BITS) > > return false; > > @@ -2625,6 +2626,8 @@ static bool purge_fragmented_block(struct vmap_bl= ock *vb, > > if (!(force_purge || vb->free < VMAP_PURGE_THRESHOLD)) > > return false; > > > > + vbq =3D container_of(addr_to_vb_xa(vb->va->va_start), > > + struct vmap_block_queue, vmap_blocks); > > /* prevent further allocs after releasing lock */ > > WRITE_ONCE(vb->free, 0); > > /* prevent purging it again */ > > @@ -2664,7 +2667,7 @@ static void purge_fragmented_blocks(int cpu) > > continue; > > > > spin_lock(&vb->lock); > > - purge_fragmented_block(vb, vbq, &purge, true); > > + purge_fragmented_block(vb, &purge, true); > > spin_unlock(&vb->lock); > > } > > rcu_read_unlock(); > > @@ -2801,7 +2804,7 @@ static void _vm_unmap_aliases(unsigned long start= , unsigned long end, int flush) > > * not purgeable, check whether there is dirty > > * space to be flushed. > > */ > > - if (!purge_fragmented_block(vb, vbq, &purge_list,= false) && > > + if (!purge_fragmented_block(vb, &purge_list, fals= e) && > > vb->dirty_max && vb->dirty !=3D VMAP_BBMAP_BI= TS) { > > unsigned long va_start =3D vb->va->va_sta= rt; > > unsigned long s, e; > > -- > > 2.25.1 > > > > >