From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2BDCDC433EF for ; Mon, 20 Jun 2022 11:24:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A4DC46B0071; Mon, 20 Jun 2022 07:24:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9FE1E6B0073; Mon, 20 Jun 2022 07:24:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8EC118E0001; Mon, 20 Jun 2022 07:24:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 7F97B6B0071 for ; Mon, 20 Jun 2022 07:24:06 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 45F2133CDD for ; Mon, 20 Jun 2022 11:24:06 +0000 (UTC) X-FDA: 79598380092.10.01913F4 Received: from mail-lj1-f175.google.com (mail-lj1-f175.google.com [209.85.208.175]) by imf26.hostedemail.com (Postfix) with ESMTP id DEF7814000B for ; Mon, 20 Jun 2022 11:24:05 +0000 (UTC) Received: by mail-lj1-f175.google.com with SMTP id j22so4915252ljg.0 for ; Mon, 20 Jun 2022 04:24:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=6Yt7N7lIt6rrL+t7Ro4DPilPiH3bCntuNreRubvS7Kc=; b=P86niLyEltitD6qcrewvCIeD/Op6qsjJFYmoGU6u+gtc6fVIqmPbQhGFZEkDLgI6OI BXArQyWCEe/Cyz8l5OJ3nYOh+qih2Kxxycb2IrB1x91kOt1hBtAcm8Ms7plCV9r3Sw02 BDdJBwuF5+ZhxP8OIygE9OSGlfvj1YA8GBERqjBNiHmTHtPc002LYYI/WdFffSmVbFp7 ss5zm6nJOmHMP5dnB8lYHWM97VavfT7DzMnxXQ6bP5emyjiGDGqPvQkfKWXHTzLppgpl vmz0e+IzsOKiUPE8lJjv/rRI2sxRvUDpLWNXXZ00Tvx0CTMU593HWGFbs/WjimSaAeo7 98BA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=6Yt7N7lIt6rrL+t7Ro4DPilPiH3bCntuNreRubvS7Kc=; b=LV+CGmgHQTwfKLAEdvnjDuOzreEH7H16qgCh3TNwo7SGPHPP5EPJkBj3D41T4Nb8Hy qkUlv3QQYCumtUeG0slBCbbuP5xH26Rob02Vy37ClY7xkkPP3EcbW2EYn+DP1b2qon9r rUdDndnJdb0d+UpMQXecz4fQFOoSvCbvZ257H9nYFv94iaGrgrOcySY2kQAeDBTm0VgB oDEXZX2aesfVvAw+UrWZ8AMTVie2nSK2TK+TfT4HYbLHr0FDPMSPBL0Lnto03efHgvYv 4svpzoDVo4bg6RYGilH/GA7We9zIm7S8u2H/2tBqfY2J6XpZcJYStMi0366YIbKjLoS3 xckw== X-Gm-Message-State: AJIora97qekq7vEpmPPrpPYz94gTRdYq2MMcgy8XR1TBKIlC9m/1HVDT XEuN2643ZMUZG7cFopr9xsX8ZIxTkAT8xW58Ed0= X-Google-Smtp-Source: AGRyM1tkovQ3GhgpyWicWNL/SBpHcmpj4RpsJcHMRz54/hlnlFAbPCTQ0AcppAB5v0FJLJ4PjVP8MQEzCRBA39J1FiI= X-Received: by 2002:a2e:7d17:0:b0:25a:6ccd:ab6 with SMTP id y23-20020a2e7d17000000b0025a6ccd0ab6mr3048176ljc.114.1655724244209; Mon, 20 Jun 2022 04:24:04 -0700 (PDT) MIME-Version: 1.0 References: <1653447164-15017-1-git-send-email-zhaoyang.huang@unisoc.com> In-Reply-To: From: Zhaoyang Huang Date: Mon, 20 Jun 2022 19:23:34 +0800 Message-ID: Subject: Re: [PATCH] mm: fix racing of vb->va when kasan enabled To: Uladzislau Rezki Cc: "zhaoyang.huang" , Andrew Morton , "open list:MEMORY MANAGEMENT" , LKML , Ke Wang , Christoph Hellwig Content-Type: text/plain; charset="UTF-8" ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=P86niLyE; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf26.hostedemail.com: domain of huangzhaoyang@gmail.com designates 209.85.208.175 as permitted sender) smtp.mailfrom=huangzhaoyang@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1655724245; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6Yt7N7lIt6rrL+t7Ro4DPilPiH3bCntuNreRubvS7Kc=; b=wHAKaAQ/bqo9iufUC7QVgr5z2dluN2Tj3ZbVHaKDhUTdIOp8aBFY0O/EilUpSpyttpl6cq QgCpKafsSg+g9ABUT8IXJeK73laBqFkyOXjhFUoU5hyTLuL4eb7SA8f//6cUpOYu82SamI vz/VxoQIEJImFwLyrsb2Kz16rjjbnRk= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1655724245; a=rsa-sha256; cv=none; b=G1j9vtXQfvKMG/Gr0OSluAjbWbwj4ceQueY1gC1+rBIkmk/H2qjkzWy2jFXoASNDqY2Tlr wq/i0t3f661JQs1oyO/Fo+dX7UsV8oIMIeTAwqt+BfEUyL9ZuaXkypITl4rso30nk68JhZ EUhfoefU8noedxzOY5ZKQGeyP2U1Kcs= X-Stat-Signature: r9f5a1thzg1epm55ygnshyouywodzp9g X-Rspamd-Queue-Id: DEF7814000B X-Rspam-User: Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=P86niLyE; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf26.hostedemail.com: domain of huangzhaoyang@gmail.com designates 209.85.208.175 as permitted sender) smtp.mailfrom=huangzhaoyang@gmail.com X-Rspamd-Server: rspam10 X-HE-Tag: 1655724245-55015 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000011, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jun 20, 2022 at 6:44 PM Uladzislau Rezki wrote: > > > > > > > > Is it easy to reproduce? If so could you please describe the steps? As i see > > > the freeing of the "vb" is RCU safe whereas vb->va is not. But from the first > > > glance i do not see how it can accessed twice. Hm.. > > It was raised from a monkey test on A13_k515 system and got 1/20 pcs > > failed. IMO, vb->va which out of vmap_purge_lock protection could race > > with a concurrent ra freeing within __purge_vmap_area_lazy. > > > Do you have exact steps how you run "monkey" test? There are about 30+ kos inserted during startup which could be a specific criteria for reproduction. Do you have doubts about the test result or the solution? > > -- > Uladzislau Rezki