From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86F9FECAAD8 for ; Wed, 14 Sep 2022 08:15:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 08ACB6B0074; Wed, 14 Sep 2022 04:15:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 013266B0075; Wed, 14 Sep 2022 04:14:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DF6BA8D0001; Wed, 14 Sep 2022 04:14:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id CB8716B0074 for ; Wed, 14 Sep 2022 04:14:59 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id A00EFC0958 for ; Wed, 14 Sep 2022 08:14:59 +0000 (UTC) X-FDA: 79909980318.02.49D290E Received: from mail-lf1-f53.google.com (mail-lf1-f53.google.com [209.85.167.53]) by imf23.hostedemail.com (Postfix) with ESMTP id 4AEAF1400BB for ; Wed, 14 Sep 2022 08:14:59 +0000 (UTC) Received: by mail-lf1-f53.google.com with SMTP id o2so21770343lfc.10 for ; Wed, 14 Sep 2022 01:14:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=I0k8tZU5EA1om2p0HrvWZQVrfuJRA9iwaMceluI49gg=; b=AU3CnAwBQXv3Uq2aLCAH3Cu2NRTkciuThvL6P2EotywNNuz5Hcosue5+HWnXbjiy/k 0ajrsxJiDskN9nEu4KRYyAJz99BCAyzOXEg5CoCbWu2hMZOYFXa4a66jdOIo8wnordNA YnqEFYJKrAOsymBCWRmg+WaklkGFOseC7Z8qsWmNIRJeHu+Zuhxw84QPloRqhmqX8O5m NNmNJRCXWufMtwYlrGSNGYrIz2fkCUzgUK+D+mykCFbZ/Azkv8wj1OWD4qld4xi7jFjx 9eb9mkdLJN5CKzLY6z3uJ+ptJ27jL0Nliz5BSNwiRKgjqO+m6l2vleak/y6RGQAYw/wm z7Sw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=I0k8tZU5EA1om2p0HrvWZQVrfuJRA9iwaMceluI49gg=; b=6J/FTX40JhR0mk2KIopEpAoWRQ7j+pbf+vBVucFC8OpHqREHjl47hzI+yvc4Kbq9rV qid5IfwMWWXNSFXMJTDzS5QObtm4aPrN0CeOdDzwNDZ1IbUo/3TiVEdn84mVwukeRLFT RvE2ZR0GvfyKhgIuI6jAqen5kL2HLYaGJtGgRxuICAigO+uF6KQi0/fKqM0XdViy0chS 5rQ8PIyoyyKjyyloBdjU4CWcZlhOSdF97/BLCwwF4RoCkPQ8akdqp6DF0CcyrXNTN1AA fC1tfCFmBPQsjwi2NawBImeZtFqVcvRRZ1Hl+rkzWD+EgkYni06oT9FjxwO5t9u3UrZd di4w== X-Gm-Message-State: ACgBeo3KDEbkER8bESUfTwnSXIX4rgz0PN12h57uuw2lSlc2nYN5YquI Sw60uUUU/Hc4WwvHX1mdKBL3eTMxmGN/6Ytnf2s= X-Google-Smtp-Source: AA6agR4ZGW+PVIYAdlIi72oYGw0MFVTgwkNPpggNR6PJmEis6+XHJWhjPA+2jz/oKwfLXaOoPhPqGJEB0tyRq4+Zb0Q= X-Received: by 2002:a05:6512:1527:b0:48b:99:f3ff with SMTP id bq39-20020a056512152700b0048b0099f3ffmr11568941lfb.81.1663143297635; Wed, 14 Sep 2022 01:14:57 -0700 (PDT) MIME-Version: 1.0 References: <1663126621-26926-1-git-send-email-zhaoyang.huang@unisoc.com> In-Reply-To: From: Zhaoyang Huang Date: Wed, 14 Sep 2022 16:14:29 +0800 Message-ID: Subject: Re: [PATCH 1/2] mm: fix logic error of page_expected_state To: Matthew Wilcox Cc: "zhaoyang.huang" , Andrew Morton , Catalin Marinas , "open list:MEMORY MANAGEMENT" , LKML , Ke Wang Content-Type: text/plain; charset="UTF-8" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1663143299; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=I0k8tZU5EA1om2p0HrvWZQVrfuJRA9iwaMceluI49gg=; b=bRpKX/4uy5eLwtp8lZ+YoNzVGLhDnyF9n1e4EdsqHc0b0pBCQr9Gq99XnEgrzxUa3Z50C1 cEswX8Z9HRpGV/o3ceKIc+5k8j4iNE3SxC9guON+RYNFFl7D2GYmTSH0BuLnUqGktpb9Ys E2oNvQg+muGylNI4xKArQivJlmnBh4Q= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=AU3CnAwB; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf23.hostedemail.com: domain of huangzhaoyang@gmail.com designates 209.85.167.53 as permitted sender) smtp.mailfrom=huangzhaoyang@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1663143299; a=rsa-sha256; cv=none; b=t9B1bP70guCeq0Dwgnh5t9CYP4stpkukSwHCXDowGWBp7010L1EE9bIHJgcDzxV5jyDt0p BkbqqFss7aapY4EC0iYPjeALh69s090J6q1IHCs5FLf1/2WRqZJJOAPHsX2fxtWSK+r1S4 tzhQt2g+u7GlChL/6kbV7Z9nTQ7kWKw= Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=AU3CnAwB; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf23.hostedemail.com: domain of huangzhaoyang@gmail.com designates 209.85.167.53 as permitted sender) smtp.mailfrom=huangzhaoyang@gmail.com X-Stat-Signature: ohktaa3ckgbc3ud3e6cwk9nkqwo9mo3i X-Rspamd-Queue-Id: 4AEAF1400BB X-Rspam-User: X-Rspamd-Server: rspam09 X-HE-Tag: 1663143299-955021 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Sep 14, 2022 at 3:35 PM Matthew Wilcox wrote: > > On Wed, Sep 14, 2022 at 11:37:00AM +0800, zhaoyang.huang wrote: > > From: Zhaoyang Huang > > > > The page with special page type will be deemed as bad page wrongly since > > type share the same address with mapcount. > > That's not wrongly. You didn't clear the bit. I told you you would > need to do that in the first version of the patch you sent. Yes, I have cleared the PG_trackleak since v2 as you suggested. However, IMHO, the page which has page type should be skipped for mapcount check. The present problem is there is no invoking of free_pages_prepare within the chain of drain_pages_zone->free_pcppages_bulk, special pages with page->type(PG_guard and PG_trackleak etc) will be leaked as bulkfree_pcp_prepare will deem it as bad by checking the mapcount.