From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60748C433EF for ; Wed, 9 Mar 2022 13:54:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AA66E8D0003; Wed, 9 Mar 2022 08:54:06 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A566E8D0001; Wed, 9 Mar 2022 08:54:06 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 944348D0003; Wed, 9 Mar 2022 08:54:06 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0166.hostedemail.com [216.40.44.166]) by kanga.kvack.org (Postfix) with ESMTP id 8622A8D0001 for ; Wed, 9 Mar 2022 08:54:06 -0500 (EST) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 3B50E8249980 for ; Wed, 9 Mar 2022 13:54:06 +0000 (UTC) X-FDA: 79224991692.19.212B7BD Received: from mail-ed1-f45.google.com (mail-ed1-f45.google.com [209.85.208.45]) by imf27.hostedemail.com (Postfix) with ESMTP id B8D3C4000E for ; Wed, 9 Mar 2022 13:54:05 +0000 (UTC) Received: by mail-ed1-f45.google.com with SMTP id x5so2911414edd.11 for ; Wed, 09 Mar 2022 05:54:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=58ItMAXsny1L+anxiMU9T6c9Palwcv7/9rI4u4RF93Y=; b=LYmpyqEhPpVCocyivY6GecOg7VdFQVfvuY/trXXPIDCWFXVealEM2nKhk5VMPe0EMK m6qP02dLPOJq6r4nOvTFvnwOUclUvGGqDzMsMJhrsPyxHmvD4GjCd1i+QSV/mnNeT8j6 O+23IpoeL1BMxMPL6/6Ym/d7C6qeAoVTAG0ncKVyVYpczZbzqVdLcin2+mEWIbDNWNBQ AaXb6/JF0JgdXpI/qhxbqBsA6BdIb24KNnS+/lMuNYvjJlwSKY2krkdmsj848HxCHIe1 D0LyHRSHEr5iAGL/SdaVKi3XAvGcTWayQRWV6UwePmTyYn3wOk0Q99oO4aHes4yL5X0U qjrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=58ItMAXsny1L+anxiMU9T6c9Palwcv7/9rI4u4RF93Y=; b=DvLNXoLbJLbdZHrz3UEq26SE2oG0Xd0UEe/HTDXGRCcEcN9/4RSfoucUqh1yhtG+De SS3oFnoDl2zVxGvaxEEduUNTIhyMdx/bh6nrTgGWRjq3jM3bcJS74mske96dtUzwKzvS ZuLxrAW8V36X1kUpyx+okJG34qGE/JmNox22EXBin+V/l0NpLh8QXB7R/IMUcjDnduw0 QeudF+hmQdSHu5LlferBvxdNHgnqDh0xWHfQBuIBqqr3O0Kxme2XPzci8vEndZ1WmiN+ QCdWXOaNTW/Vn1Sa0O5LNAV3dDA5+qQ6pG0G+/xpe16e27VzzZvVGNgq7GzMccgpAhuj ajqw== X-Gm-Message-State: AOAM5338cJ2tg1AoRX35MTW8x9/xudvPHsTrkXfK4GganaKze6bQVVCj aomTkiVl4+6xN4t6wrNtSf6kZlpxCV+l2Uis0wa5vg== X-Google-Smtp-Source: ABdhPJyIqqjIhDdsKFYeGKRq2VBngVbOH/FmX+MjBEvKAOVvgdA9H+3Kga13rb0K5Vbd78rsqsqnasGn7vBfUfzwWng= X-Received: by 2002:a05:6402:1747:b0:415:ee04:47e1 with SMTP id v7-20020a056402174700b00415ee0447e1mr21018226edx.229.1646834044075; Wed, 09 Mar 2022 05:54:04 -0800 (PST) MIME-Version: 1.0 References: <20220309083753.1561921-1-liupeng256@huawei.com> <20220309083753.1561921-3-liupeng256@huawei.com> In-Reply-To: <20220309083753.1561921-3-liupeng256@huawei.com> From: Daniel Latypov Date: Wed, 9 Mar 2022 07:53:52 -0600 Message-ID: Subject: Re: [PATCH v2 2/3] kunit: make kunit_test_timeout compatible with comment To: Peng Liu Cc: brendanhiggins@google.com, glider@google.com, elver@google.com, dvyukov@google.com, akpm@linux-foundation.org, linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com, linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com, linux-mm@kvack.org, wangkefeng.wang@huawei.com Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: B8D3C4000E X-Stat-Signature: whc8r44dq53cnhqbansh7mh5edxy5ndx Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=LYmpyqEh; spf=pass (imf27.hostedemail.com: domain of dlatypov@google.com designates 209.85.208.45 as permitted sender) smtp.mailfrom=dlatypov@google.com; dmarc=pass (policy=reject) header.from=google.com X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1646834045-53005 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Mar 9, 2022 at 2:19 AM 'Peng Liu' via KUnit Development wrote: > > In function kunit_test_timeout, it is declared "300 * MSEC_PER_SEC" > represent 5min. However, it is wrong when dealing with arm64 whose > default HZ = 250, or some other situations. Use msecs_to_jiffies to > fix this, and kunit_test_timeout will work as desired. > > Fixes: 5f3e06208920 ("kunit: test: add support for test abort") > Signed-off-by: Peng Liu Reviewed-by: Daniel Latypov Thanks for catching this! > --- > lib/kunit/try-catch.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/kunit/try-catch.c b/lib/kunit/try-catch.c > index 6b3d4db94077..f7825991d576 100644 > --- a/lib/kunit/try-catch.c > +++ b/lib/kunit/try-catch.c > @@ -52,7 +52,7 @@ static unsigned long kunit_test_timeout(void) > * If tests timeout due to exceeding sysctl_hung_task_timeout_secs, > * the task will be killed and an oops generated. > */ > - return 300 * MSEC_PER_SEC; /* 5 min */ > + return 300 * msecs_to_jiffies(MSEC_PER_SEC); /* 5 min */ > } > > void kunit_try_catch_run(struct kunit_try_catch *try_catch, void *context) > -- > 2.18.0.huawei.25 > > -- > You received this message because you are subscribed to the Google Groups "KUnit Development" group. > To unsubscribe from this group and stop receiving emails from it, send an email to kunit-dev+unsubscribe@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/kunit-dev/20220309083753.1561921-3-liupeng256%40huawei.com.