From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A32BBC4332F for ; Fri, 2 Dec 2022 01:19:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0C2CE6B0072; Thu, 1 Dec 2022 20:19:47 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 04BB46B0073; Thu, 1 Dec 2022 20:19:46 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E078A6B0074; Thu, 1 Dec 2022 20:19:46 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id CE9DF6B0072 for ; Thu, 1 Dec 2022 20:19:46 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 9FDEEA0287 for ; Fri, 2 Dec 2022 01:19:46 +0000 (UTC) X-FDA: 80195609172.11.758FC0B Received: from mail-yb1-f182.google.com (mail-yb1-f182.google.com [209.85.219.182]) by imf23.hostedemail.com (Postfix) with ESMTP id 41133140004 for ; Fri, 2 Dec 2022 01:19:45 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=AT27u0tg; spf=pass (imf23.hostedemail.com: domain of dlatypov@google.com designates 209.85.219.182 as permitted sender) smtp.mailfrom=dlatypov@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1669943985; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=b7S/Lk010656nN0nZxqgfS6l85QGHGwdF8mVU2ojAvw=; b=eQkKtBwxX7x2NZEI6KjFkc7pyg3IXIuIvCKtiwPUkACsY+G8m+jUtG/QKAl+FcU2SydafX 0iR2J0dI+RWHdzH9zl+QrDxpfCgUQ/TtD0cnVASnKSsZc0fTZf2FfJJJKDBWt8wnQwFbGD gTNi/2eODrak+l9SDhOKKM6IkPw+v9k= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=AT27u0tg; spf=pass (imf23.hostedemail.com: domain of dlatypov@google.com designates 209.85.219.182 as permitted sender) smtp.mailfrom=dlatypov@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1669943985; a=rsa-sha256; cv=none; b=bgXL0W1x9UC+mbWeQPKhrJfGp10wlxwvqQJrO56eYGhUveDWM+yo17elw4ALN3VnMe9XIT D7tyFjm5nDGzBXTjRN2bo90xQROX3fSqdO9GOi3Wc0D0VzKeMoUx3UjMyk/n9wA94y7liF Ysb55Q3wUQhIBTbxfLzCvn7qxzyDwiA= Received: by mail-yb1-f182.google.com with SMTP id v206so4306118ybv.7 for ; Thu, 01 Dec 2022 17:19:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=b7S/Lk010656nN0nZxqgfS6l85QGHGwdF8mVU2ojAvw=; b=AT27u0tgCh7uOLyY8Ql580WvVeAiLYjcI4f7NZQk46/CLU3/+7buoJ9V9c45rcuscx vO3aJrqhgyS83lteGHszZNkkP6VWo3MZjH2Qjet5VpEKr0WGC7ohz8eweYOlk/r4/M3N 2re1dOKiEt2z8CUlhFFmVe1BO2uIxZ+/7iLECz027ISRWR5OSHZtMIrQ3EJwwv+7BrA8 HuFq/TFGiHrpGVs5rpDfrSJezKlFjz8vkxbLERmHxYGvM66JGx9bqyz+9LTQMpygTbAX obXKGb1YCfLqFUB3LT2WKVMxMV0uKAc214ok+1DRf56odpooPaRsD/tiliqpYyz/Ar2b LRvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=b7S/Lk010656nN0nZxqgfS6l85QGHGwdF8mVU2ojAvw=; b=kyd778Y/ZCW5KZor0Kn5S6hPWJBylx5vboEdlYQOWPcpneQ6yL7Rtuz0yi1QsCQuzJ PySNl0PUr18xnCZWx5w93+y6f1wluNGPXAAdUHqTMEZIyaYg4d5rtydgqo02exfsieuV xaLDHvFrDa/sIFW99+bZWzidcG90RjsUwKkmkUdOAzLh+gK7Jz+9QrB7oADwmgatxLXK W6VNZkDRGfX4StmS4DA3IfPoj0mlbwLc9jQKzCGimaLjUSlaKdpkc+3OIRW2q8GSC1Sh dPzXLSGAHczjmhCb7Pu+2i3AsmR3zkhuWhVIkyh5qdnKlZtiCyVlUSGM3saH5wwu7ZAo muGQ== X-Gm-Message-State: ANoB5plEmz4zM6larOecNHBdlmHjOpvrITff6M5aofwVO0T7mE5uIfw9 39YyLyIPT9FJl2IRNmAPSVASG4eqfw6JUbJh2CaNRg== X-Google-Smtp-Source: AA0mqf5T9Ra5V6yzXWV8vxb2tO65VZIyhze90LfjaKJK9kFL4fvKtrfCro9CM2DGiAIYQHU0Nn4aBh3Rm5cSdQPsKak= X-Received: by 2002:a25:ef09:0:b0:6fc:63f6:eb89 with SMTP id g9-20020a25ef09000000b006fc63f6eb89mr3768398ybd.587.1669943984310; Thu, 01 Dec 2022 17:19:44 -0800 (PST) MIME-Version: 1.0 References: <20221125084306.1063074-1-davidgow@google.com> <202212011652.4E8CB40@keescook> In-Reply-To: <202212011652.4E8CB40@keescook> From: Daniel Latypov Date: Thu, 1 Dec 2022 17:19:33 -0800 Message-ID: Subject: Re: [PATCH v4 1/3] kunit: Provide a static key to check if KUnit is actively running tests To: Kees Cook Cc: David Gow , Brendan Higgins , Shuah Khan , kunit-dev@googlegroups.com, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" X-Spamd-Result: default: False [2.50 / 9.00]; SORBS_IRL_BL(3.00)[209.85.219.182:from]; BAYES_HAM(-0.60)[81.77%]; BAD_REP_POLICIES(0.10)[]; RCVD_NO_TLS_LAST(0.10)[]; MIME_GOOD(-0.10)[text/plain]; MIME_TRACE(0.00)[0:+]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; DMARC_POLICY_ALLOW(0.00)[google.com,reject]; RCPT_COUNT_SEVEN(0.00)[9]; DKIM_TRACE(0.00)[google.com:+]; TO_MATCH_ENVRCPT_SOME(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[linux-mm@kvack.org]; R_DKIM_ALLOW(0.00)[google.com:s=20210112]; ARC_SIGNED(0.00)[hostedemail.com:s=arc-20220608:i=1]; FROM_HAS_DN(0.00)[]; R_SPF_ALLOW(0.00)[+ip4:209.85.128.0/17]; TO_DN_SOME(0.00)[]; ARC_NA(0.00)[] X-Rspamd-Queue-Id: 41133140004 X-Rspam-User: X-Rspamd-Server: rspam07 X-Stat-Signature: gbx8rwzj73hr9yexaa5ffmfku7yr9sqb X-HE-Tag: 1669943985-610861 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Dec 1, 2022 at 4:53 PM Kees Cook wrote: > > + static_branch_inc(&kunit_running); > > Is it expected there will be multiple tests running? (I was expecting > "static_branch_enable"). It shouldn't normally happen, no. One possible use case: KUnit's unit tests for itself create fake test objects and operate on them. They don't currently exercise this particular code though, afaict (maybe they should). > > > + > > for (i = 0; i < num_suites; i++) { > > kunit_init_suite(suites[i]); > > kunit_run_tests(suites[i]); > > } > > + > > + static_branch_dec(&kunit_running); > > return 0; > > } > > EXPORT_SYMBOL_GPL(__kunit_test_suites_init); > > -- > > 2.38.1.584.g0f3c55d4c2-goog > > > > Regardless: > > Reviewed-by: Kees Cook > > -- > Kees Cook Daniel