From: Pavel Tatashin <pasha.tatashin@oracle.com>
To: mhocko@kernel.org
Cc: osalvador@techadventures.net,
Andrew Morton <akpm@linux-foundation.org>,
Vlastimil Babka <vbabka@suse.cz>,
mgorman@techsingularity.net, aaron.lu@intel.com,
iamjoonsoo.kim@lge.com,
Linux Memory Management List <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>,
dan.j.williams@intel.com, osalvador@suse.de
Subject: Re: [PATCH v3 4/5] mm/page_alloc: Move initialization of node and zones to an own function
Date: Thu, 26 Jul 2018 11:35:35 -0400 [thread overview]
Message-ID: <CAGM2rebcp=S+WN3owDWVSa3_6QqLzs=qbOFs76rhsxuepQ1ALw@mail.gmail.com> (raw)
In-Reply-To: <20180726081200.GY28386@dhcp22.suse.cz>
> OK, this looks definitely better. I will have to check that all the
> required state is initialized properly. Considering the above
> explanation I would simply fold the follow up patch into this one. It is
> not so large it would get hard to review and you would make it clear why
> the work is done.
I will review this work, once Oscar combines patches 4 & 5 as Michal suggested.
>
> > +/*
> > + * Set up the zone data structures:
> > + * - mark all pages reserved
> > + * - mark all memory queues empty
> > + * - clear the memory bitmaps
> > + *
> > + * NOTE: pgdat should get zeroed by caller.
> > + * NOTE: this function is only called during early init.
> > + */
> > +static void __paginginit free_area_init_core(struct pglist_data *pgdat)
>
> now that this function is called only from the early init code we can
> make it s@__paginginit@__init@ AFAICS.
True, in patch 5. Also, zone_init_internals() should be marked as __paginginit.
Thank you,
Pavel
next prev parent reply other threads:[~2018-07-26 15:36 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-25 22:01 [PATCH v3 0/5] Refactor free_area_init_core and add free_area_init_core_hotplug osalvador
2018-07-25 22:01 ` [PATCH v3 1/5] mm/page_alloc: Move ifdefery out of free_area_init_core osalvador
2018-07-25 22:01 ` [PATCH v3 2/5] mm: access zone->node via zone_to_nid() and zone_set_nid() osalvador
2018-07-26 8:05 ` Michal Hocko
2018-07-26 8:12 ` Oscar Salvador
2018-07-26 15:14 ` Pavel Tatashin
2018-07-26 16:43 ` Michal Hocko
2018-07-26 17:18 ` Pavel Tatashin
2018-07-26 17:52 ` Michal Hocko
2018-07-26 17:55 ` Pavel Tatashin
2018-07-26 19:15 ` Oscar Salvador
2018-07-25 22:01 ` [PATCH v3 3/5] mm/page_alloc: Inline function to handle CONFIG_DEFERRED_STRUCT_PAGE_INIT osalvador
2018-07-26 15:17 ` Pavel Tatashin
2018-07-25 22:01 ` [PATCH v3 4/5] mm/page_alloc: Move initialization of node and zones to an own function osalvador
2018-07-26 8:12 ` Michal Hocko
2018-07-26 15:35 ` Pavel Tatashin [this message]
2018-07-26 19:15 ` Oscar Salvador
2018-07-25 22:01 ` [PATCH v3 5/5] mm/page_alloc: Introduce memhotplug version of free_area_init_core osalvador
2018-07-26 7:38 ` Oscar Salvador
2018-07-26 12:02 ` Oscar Salvador
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGM2rebcp=S+WN3owDWVSa3_6QqLzs=qbOFs76rhsxuepQ1ALw@mail.gmail.com' \
--to=pasha.tatashin@oracle.com \
--cc=aaron.lu@intel.com \
--cc=akpm@linux-foundation.org \
--cc=dan.j.williams@intel.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=mhocko@kernel.org \
--cc=osalvador@suse.de \
--cc=osalvador@techadventures.net \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox