From: Pavel Tatashin <pasha.tatashin@oracle.com>
To: bhe@redhat.com
Cc: LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
dave.hansen@intel.com, pagupta@redhat.com,
Linux Memory Management List <linux-mm@kvack.org>,
kirill.shutemov@linux.intel.com
Subject: Re: [PATCH v5 4/4] mm/sparse: Optimize memmap allocation during sparse_init()
Date: Wed, 27 Jun 2018 23:19:22 -0400 [thread overview]
Message-ID: <CAGM2reaWkmCF_DWY1jETsC=NOPC7TGFq3VX06YrTDLAp+X2+AQ@mail.gmail.com> (raw)
In-Reply-To: <20180627013116.12411-5-bhe@redhat.com>
> Signed-off-by: Baoquan He <bhe@redhat.com>
>
> Signed-off-by: Baoquan He <bhe@redhat.com>
Please remove duplicated signed-off
> if (!usemap) {
> ms->section_mem_map = 0;
> + nr_consumed_maps++;
Currently, we do not set ms->section_mem_map to 0 when fail to
allocate usemap, only when fail to allocate mmap we set
section_mem_map to 0. I think this is an existing bug.
Reviewed-by: Pavel Tatashin <pasha.tatashin@oracle.com>
next prev parent reply other threads:[~2018-06-28 3:20 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-27 1:31 [PATCH v5 0/4] " Baoquan He
2018-06-27 1:31 ` [PATCH v5 1/4] mm/sparse: Add a static variable nr_present_sections Baoquan He
2018-06-28 3:10 ` Pavel Tatashin
2018-06-27 1:31 ` [PATCH v5 2/4] mm/sparsemem: Defer the ms->section_mem_map clearing Baoquan He
2018-06-27 9:54 ` Oscar Salvador
2018-06-27 22:59 ` Baoquan He
2018-06-28 3:11 ` Pavel Tatashin
2018-06-27 1:31 ` [PATCH v5 3/4] mm/sparse: Add a new parameter 'data_unit_size' for alloc_usemap_and_memmap Baoquan He
2018-06-28 3:14 ` Pavel Tatashin
2018-06-28 6:57 ` Baoquan He
2018-06-27 1:31 ` [PATCH v5 4/4] mm/sparse: Optimize memmap allocation during sparse_init() Baoquan He
2018-06-28 3:19 ` Pavel Tatashin [this message]
2018-06-28 6:39 ` Baoquan He
2018-06-29 17:16 ` Dave Hansen
2018-06-29 17:48 ` Pavel Tatashin
2018-06-29 17:52 ` Dave Hansen
2018-06-29 18:01 ` Pavel Tatashin
2018-06-29 18:56 ` Dave Hansen
2018-06-29 18:59 ` Pavel Tatashin
2018-06-27 1:47 ` [PATCH v5 0/4] " Baoquan He
2018-06-27 17:47 ` Pavel Tatashin
2018-06-27 23:39 ` Baoquan He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGM2reaWkmCF_DWY1jETsC=NOPC7TGFq3VX06YrTDLAp+X2+AQ@mail.gmail.com' \
--to=pasha.tatashin@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=bhe@redhat.com \
--cc=dave.hansen@intel.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=pagupta@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox