From: Pavel Tatashin <pasha.tatashin@oracle.com>
To: mhocko@kernel.org
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
tglx@linutronix.de, willy@infradead.org, mingo@redhat.com,
axboe@kernel.dk, gregkh@linuxfoundation.org, davem@davemloft.net,
viro@zeniv.linux.org.uk, Dave Airlie <airlied@gmail.com>,
Tejun Heo <tj@kernel.org>, Theodore Tso <tytso@google.com>,
snitzer@redhat.com,
Linux Memory Management List <linux-mm@kvack.org>,
neelx@redhat.com, mgorman@techsingularity.net
Subject: Re: Instability in current -git tree
Date: Mon, 16 Jul 2018 09:26:41 -0400 [thread overview]
Message-ID: <CAGM2reaM1sCCj8QjkfSrKhTXrj=__DXAFgQkBV2ZN5chKgjzTQ@mail.gmail.com> (raw)
In-Reply-To: <20180716122918.GO17280@dhcp22.suse.cz>
> Maybe a stupid question, but I do not see it from the code (this init
> code is just to complex to keep it cached in head so I always have to
> study the code again and again, sigh). So what exactly prevents
> memmap_init_zone to stumble over reserved regions? We do play some ugly
> games to find a first !reserved pfn in the node but I do not really see
> anything in the init path to properly skip over reserved holes inside
> the node.
Hi Michal,
This is not a stupid question. I figured out how this whole thing
became broken: Revert "mm: page_alloc: skip over regions of invalid
pfns where possible" caused that.
Because, before that was reverted, memmap_init_zone() would use
memblock.memory to check that only pages that have physical backing
are initialized. But, now after that was reverted zer_resv_unavail()
scheme became totally broken.
The concept is quite easy: zero all the allocated memmap memory that
has not been initialized by memmap_init_zone(). So, I think I will
modify memmap_init_zone() to zero the skipped pfns that have memmap
backing. But, that requires more thinking.
Thank you,
Pavel
next prev parent reply other threads:[~2018-07-16 13:27 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CA+55aFyARQV302+mXNYznrOOjzW+yxbcv+=OkD43dG6G1ktoMQ@mail.gmail.com>
[not found] ` <alpine.DEB.2.21.1807140031440.2644@nanos.tec.linutronix.de>
[not found] ` <CA+55aFzBx1haeM2QSFvhaW2t_HVK78Y=bKvsiJmOZztwkZ-y7Q@mail.gmail.com>
[not found] ` <CA+55aFzVGa57apuzDMBLgWQQRcm3BNBs1UEg-G_2o7YW1i=o2Q@mail.gmail.com>
[not found] ` <CA+55aFy9NJZeqT7h_rAgbKUZLjzfxvDPwneFQracBjVhY53aQQ@mail.gmail.com>
2018-07-13 23:48 ` Andrew Morton
2018-07-13 23:51 ` Linus Torvalds
2018-07-13 23:58 ` Andrew Morton
2018-07-14 0:19 ` Pavel Tatashin
2018-07-14 0:28 ` Linus Torvalds
2018-07-14 0:46 ` Pavel Tatashin
2018-07-14 2:40 ` Linus Torvalds
2018-07-14 3:03 ` Pavel Tatashin
2018-07-14 3:25 ` Linus Torvalds
2018-07-14 3:28 ` Pavel Tatashin
2018-07-14 13:39 ` Pavel Tatashin
2018-07-14 17:11 ` Linus Torvalds
2018-07-14 17:29 ` Linus Torvalds
2018-07-16 12:06 ` Michal Hocko
2018-07-16 12:09 ` Pavel Tatashin
2018-07-16 12:29 ` Michal Hocko
2018-07-16 13:26 ` Pavel Tatashin [this message]
2018-07-16 14:12 ` Michal Hocko
2018-07-16 13:39 ` Oscar Salvador
2018-07-14 3:04 ` Linus Torvalds
2018-07-14 0:20 ` Linus Torvalds
2018-07-14 9:28 ` Ard Biesheuvel
2018-07-17 2:59 ` Ard Biesheuvel
2018-07-17 3:14 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGM2reaM1sCCj8QjkfSrKhTXrj=__DXAFgQkBV2ZN5chKgjzTQ@mail.gmail.com' \
--to=pasha.tatashin@oracle.com \
--cc=airlied@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=davem@davemloft.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=mhocko@kernel.org \
--cc=mingo@redhat.com \
--cc=neelx@redhat.com \
--cc=snitzer@redhat.com \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=tytso@google.com \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox