From: Pavel Tatashin <pasha.tatashin@oracle.com>
To: dave.hansen@intel.com
Cc: Steven Sistare <steven.sistare@oracle.com>,
Daniel Jordan <daniel.m.jordan@oracle.com>,
LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
kirill.shutemov@linux.intel.com, Michal Hocko <mhocko@suse.com>,
Linux Memory Management List <linux-mm@kvack.org>,
dan.j.williams@intel.com, jack@suse.cz, jglisse@redhat.com,
Souptick Joarder <jrdr.linux@gmail.com>,
bhe@redhat.com, gregkh@linuxfoundation.org,
Vlastimil Babka <vbabka@suse.cz>,
Wei Yang <richard.weiyang@gmail.com>,
rientjes@google.com, mingo@kernel.org,
osalvador@techadventures.net
Subject: Re: [PATCH v3 0/2] sparse_init rewrite
Date: Mon, 2 Jul 2018 13:46:25 -0400 [thread overview]
Message-ID: <CAGM2reYVkvVPgj+_upEdpjUL5noS=0ObGxnxXH3gAz+cJosEjA@mail.gmail.com> (raw)
In-Reply-To: <de99ae79-8d68-e8d6-5243-085fd106e1e5@intel.com>
On Mon, Jul 2, 2018 at 12:20 PM Dave Hansen <dave.hansen@intel.com> wrote:
>
> On 07/01/2018 07:04 PM, Pavel Tatashin wrote:
> > include/linux/mm.h | 9 +-
> > mm/sparse-vmemmap.c | 44 ++++---
> > mm/sparse.c | 279 +++++++++++++++-----------------------------
> > 3 files changed, 125 insertions(+), 207 deletions(-)
>
> FWIW, I'm not a fan of rewrites, but this is an awful lot of code to remove.
>
> I assume from all the back-and-forth, you have another version
> forthcoming. I'll take a close look through that one.
The removed code is a benefit, but once you review it, you will see
that it was necessary to re-write in order to get rid of the temporary
buffers. Please review the current version. The only change that is
going to be in the next version is added "nid" to pr_err() in
sparse_init_nid() for more detailed error.
Thank you,
Pavel
prev parent reply other threads:[~2018-07-02 17:47 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-02 2:04 Pavel Tatashin
2018-07-02 2:04 ` [PATCH v3 1/2] mm/sparse: add sparse_init_nid() Pavel Tatashin
2018-07-02 2:11 ` Baoquan He
2018-07-02 2:18 ` Pavel Tatashin
2018-07-02 2:31 ` Baoquan He
2018-07-02 2:43 ` Pavel Tatashin
2018-07-02 2:53 ` Baoquan He
2018-07-02 3:03 ` Pavel Tatashin
2018-07-02 3:14 ` Baoquan He
2018-07-02 3:17 ` Baoquan He
2018-07-02 3:28 ` Pavel Tatashin
2018-07-02 3:42 ` Baoquan He
2018-07-02 2:56 ` Baoquan He
2018-07-02 3:05 ` Pavel Tatashin
2018-07-02 19:59 ` Dave Hansen
2018-07-02 20:29 ` Pavel Tatashin
2018-07-05 13:39 ` Dave Hansen
2018-07-09 14:31 ` Pavel Tatashin
2018-07-02 2:04 ` [PATCH v3 2/2] mm/sparse: start using sparse_init_nid(), and remove old code Pavel Tatashin
2018-07-02 14:04 ` Oscar Salvador
2018-07-02 19:47 ` Dave Hansen
2018-07-02 19:54 ` Pavel Tatashin
2018-07-02 20:00 ` Dave Hansen
2018-07-02 20:12 ` Pavel Tatashin
2018-07-02 16:20 ` [PATCH v3 0/2] sparse_init rewrite Dave Hansen
2018-07-02 17:46 ` Pavel Tatashin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGM2reYVkvVPgj+_upEdpjUL5noS=0ObGxnxXH3gAz+cJosEjA@mail.gmail.com' \
--to=pasha.tatashin@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=bhe@redhat.com \
--cc=dan.j.williams@intel.com \
--cc=daniel.m.jordan@oracle.com \
--cc=dave.hansen@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=jack@suse.cz \
--cc=jglisse@redhat.com \
--cc=jrdr.linux@gmail.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=mingo@kernel.org \
--cc=osalvador@techadventures.net \
--cc=richard.weiyang@gmail.com \
--cc=rientjes@google.com \
--cc=steven.sistare@oracle.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox