From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5882C433FE for ; Wed, 9 Nov 2022 21:49:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2D1998E0002; Wed, 9 Nov 2022 16:49:05 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 282026B0074; Wed, 9 Nov 2022 16:49:05 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 122FD8E0002; Wed, 9 Nov 2022 16:49:05 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id F39246B0073 for ; Wed, 9 Nov 2022 16:49:04 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id C5DA41C6C14 for ; Wed, 9 Nov 2022 21:49:04 +0000 (UTC) X-FDA: 80115244608.22.A4BE2E6 Received: from mail-ej1-f51.google.com (mail-ej1-f51.google.com [209.85.218.51]) by imf24.hostedemail.com (Postfix) with ESMTP id 5E53A180004 for ; Wed, 9 Nov 2022 21:49:03 +0000 (UTC) Received: by mail-ej1-f51.google.com with SMTP id m22so229410eji.10 for ; Wed, 09 Nov 2022 13:49:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=cnCKimjPnszuIv7P7tspkRhy5Ca1GNkxCTByBpzQ+sI=; b=DO9FR6ZD8ZIFh+aT5h4gwblO1n9ghAWy3MsuSo3TmN7NhzBNojKqBDaAOyjojPXBpb 2apvdXr1918BW/PGEEnPwlYhi00OUDvvaN6HBtkWxJvxACQMtWImcvQB9v/0iOJ8C+xl tJHnnlH4FWdcXpQT3kBvkMyMvMnwsS9vhSGxa8N8daChnXdybjvYQCSwDiawdsC1TMkj CHU04xFNEn7j8Q9B/F07yQKjkM1nCiGvBEAoBVYVWIrikEcdXLsyMzcCEMnYcKWCtYkO yV4FZUnABZSnS2NkNwyo2QEUHICiCYQmL+WUQAs8EHwZRUxSg4ZHHPOeyb/Ehtc/klrr JI+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=cnCKimjPnszuIv7P7tspkRhy5Ca1GNkxCTByBpzQ+sI=; b=C/lGiDXb45WzjYPeqrZ3KvrftmnH65wxZUkQVvFK5KLMX6wczugcAokEzSC3yrJoBU RXwAYqaA9i79kfk5KKJCOFZZoDtQ9Xlei+6OFOkBDH1Q8BzhsgpqIBvDhBI39BikvpTI AVpj6VAKB6Ft1e/efw2fwZnsM89ze299mcbBpEqA/IZR2fJI5g6kvmjqNJ6YvSkj/X4N xo/3s+rV/IPBHDpMK7gL0MYqC6h8sj0XDH6/bYt7DeTepV0xhoXFVf8pcYk0fFn7kI+9 QTlGxunZii0e9DKTJMD9s5jojwkwHRlqDZaylGN+EQg/jtFjdL27UDfjiw+qBMuORhCY IZEQ== X-Gm-Message-State: ACrzQf2Bl/wEIQdZJzu8y0kN5prygUXjFEfdO/6E816zaKg+QUtgTJua SX4+lK9rMgJ2qprAjTC8xKixTUiWw7JP7zQGmpBA X-Google-Smtp-Source: AMsMyM4GI/CT8J2vgpNPmtw7prru+BKDWcCBKJuFSaTiFl13pqM1mmfcmz/5X1/dsZC/odHmQ3nDLRca52uPdbt1N30= X-Received: by 2002:a17:906:c839:b0:78a:d0a4:176 with SMTP id dd25-20020a170906c83900b0078ad0a40176mr1831678ejb.720.1668030541823; Wed, 09 Nov 2022 13:49:01 -0800 (PST) MIME-Version: 1.0 References: <20221109194404.gonna.558-kees@kernel.org> <20221109200050.3400857-1-keescook@chromium.org> In-Reply-To: <20221109200050.3400857-1-keescook@chromium.org> From: Bill Wendling Date: Wed, 9 Nov 2022 13:48:45 -0800 Message-ID: Subject: Re: [PATCH v2 1/6] panic: Separate sysctl logic from CONFIG_SMP To: Kees Cook Cc: Jann Horn , Petr Mladek , Andrew Morton , tangmeng , "Guilherme G. Piccoli" , Tiezhu Yang , Sebastian Andrzej Siewior , Greg KH , Linus Torvalds , Seth Jenkins , Andy Lutomirski , "Eric W. Biederman" , Arnd Bergmann , Marco Elver , Dmitry Vyukov , Peter Zijlstra , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Daniel Bristot de Oliveira , Valentin Schneider , Andrey Ryabinin , Alexander Potapenko , Andrey Konovalov , Vincenzo Frascino , Luis Chamberlain , David Gow , "Paul E. McKenney" , Jonathan Corbet , Baolin Wang , "Jason A. Donenfeld" , Eric Biggers , Huang Ying , Anton Vorontsov , Mauro Carvalho Chehab , Laurent Dufour , Rob Herring , linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com, linux-mm@kvack.org, linux-doc@vger.kernel.org, linux-hardening@vger.kernel.org Content-Type: text/plain; charset="UTF-8" ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=DO9FR6ZD; spf=pass (imf24.hostedemail.com: domain of morbo@google.com designates 209.85.218.51 as permitted sender) smtp.mailfrom=morbo@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1668030543; a=rsa-sha256; cv=none; b=DZrUcYbdZMbaPHQP+2RiNeFodPRLt4XcQjJ5DBDxXgZScyYcRmi4VG57+9uyCatIGWr5P1 gvIyhGoHg52ax2y5QGWi5iwwaIeqsw7hsHcrUhMtbzkHI1u4dKJg3xPXByWpdTK+VdQCkf 8ebcWXnSVDpjbN0ueh/E3z1xPzVCAas= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1668030543; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=cnCKimjPnszuIv7P7tspkRhy5Ca1GNkxCTByBpzQ+sI=; b=AcbkKkYavegR+WA8QKrm3RC5eRzLwQv+syfb8nFmwvz3P+7LSrYGgB5NrNul9w0k7pYsfG mB1GzuJTKhkp2j4YiVJ3h39Hs4bdDLaSV5f4imOua1mbJnICLAXxPKs0SX+dLTEUkoiyUM IuXURvZ9m3+xskjy5U/GYjYcZtbAmPQ= X-Stat-Signature: 59f75aymnw1tufegiskzg8dzdnmos9nu X-Rspamd-Queue-Id: 5E53A180004 Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=DO9FR6ZD; spf=pass (imf24.hostedemail.com: domain of morbo@google.com designates 209.85.218.51 as permitted sender) smtp.mailfrom=morbo@google.com; dmarc=pass (policy=reject) header.from=google.com X-Rspam-User: X-Rspamd-Server: rspam06 X-HE-Tag: 1668030543-134161 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Nov 9, 2022 at 12:01 PM Kees Cook wrote: > > In preparation for adding more sysctls directly in kernel/panic.c, split > CONFIG_SMP from the logic that adds sysctls. > > Cc: Petr Mladek > Cc: Andrew Morton > Cc: tangmeng > Cc: "Guilherme G. Piccoli" > Cc: Tiezhu Yang > Cc: Sebastian Andrzej Siewior > Signed-off-by: Kees Cook > --- > kernel/panic.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/kernel/panic.c b/kernel/panic.c > index da323209f583..129936511380 100644 > --- a/kernel/panic.c > +++ b/kernel/panic.c > @@ -75,8 +75,9 @@ ATOMIC_NOTIFIER_HEAD(panic_notifier_list); > > EXPORT_SYMBOL(panic_notifier_list); > > -#if defined(CONFIG_SMP) && defined(CONFIG_SYSCTL) > +#if CONFIG_SYSCTL Should this be "#ifdef CONFIG_SYSCTL"? > static struct ctl_table kern_panic_table[] = { > +#if defined(CONFIG_SMP) nit: This could be "#ifdef CONFIG_SMP" > { > .procname = "oops_all_cpu_backtrace", > .data = &sysctl_oops_all_cpu_backtrace, > @@ -86,6 +87,7 @@ static struct ctl_table kern_panic_table[] = { > .extra1 = SYSCTL_ZERO, > .extra2 = SYSCTL_ONE, > }, > +#endif > { } > }; > > -- > 2.34.1 >