From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D45BBC433EF for ; Thu, 9 Jun 2022 23:18:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 628258D0062; Thu, 9 Jun 2022 19:18:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5AFC46B00BC; Thu, 9 Jun 2022 19:18:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 450978D0062; Thu, 9 Jun 2022 19:18:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 31D786B00BB for ; Thu, 9 Jun 2022 19:18:48 -0400 (EDT) Received: from smtpin31.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay12.hostedemail.com (Postfix) with ESMTP id 03695120141 for ; Thu, 9 Jun 2022 23:18:47 +0000 (UTC) X-FDA: 79560264336.31.80C079C Received: from mail-lj1-f177.google.com (mail-lj1-f177.google.com [209.85.208.177]) by imf09.hostedemail.com (Postfix) with ESMTP id 96EFE140065 for ; Thu, 9 Jun 2022 23:18:45 +0000 (UTC) Received: by mail-lj1-f177.google.com with SMTP id e4so11867153ljl.1 for ; Thu, 09 Jun 2022 16:18:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=af6354Q+PYtjAeTE1fHxbOWk4spb0xe2rddSt4jQNw0=; b=qsw/gp8RDQr7TxcFAw67QADvplw4M8CuLpbXwYePEvTc9gyloRoNkLA0/65LPS2PHG lwvUx0Vk5tnQau+/eN+yj4vNNvEwrbFYrLKwsm69bjXQ0R4nOllOmIVjbhrvEDyLI/wP oUAGxwYePVYRcuzvMPpwS/H20SN6RBqtDq3M/sIFmsPVSQfFBqjqsQ4YrUJFt60H+vrG /vbIkayBKj2NafmzkfPK5WFIV3Pwo6mzHcJ+8+5Fy+N2x3QXFf68sSVrj/uvcZRdIojW qhr4netPBQEp3dEnvthXme6ipHwfVm1f0OwUWXWzeGYvw+rVPOiGjeTn1JUKCz0o06hy xlcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=af6354Q+PYtjAeTE1fHxbOWk4spb0xe2rddSt4jQNw0=; b=XWYb4TfQ2UhdqsAbpLgpDlGGpGosCAV8CjaG7nERP9URry3+Zru9RBN9n0kpYhSA3S TolN3ANymyne92BSoOLdQSTTwTQHWjoLUJmbuHbEJBp5TjXnr2F/LEfp2Bo+VXvTa8MV yqat/PpTMa9KwqkDVJBxo0ZqKjTWEkPj6C7K4uJP9gIbWMI0Du2FWKm5C37pbLG2dZfo IucfX2uBr/iddPd3FDSShi6AvjbBI4ZG2OjlqYlTKcYWldUY7qMZqCVNSiWJUSQgOEmG c6Qagp0Lm/0/lH+bGJcPya0N8z416xYVbNPFmHhZaPhtYjchii/FP3jLKrMGeDHLwsk2 6pjA== X-Gm-Message-State: AOAM532Eo3+39mj2BDq0VJVW+3BgRRVAcMDMw3aSG6UcdvN8NWc3/3GG x0uUZohzHM24LKamZxa6Ewj2/Cu5i5aTdfLSZzXA X-Google-Smtp-Source: ABdhPJzslpbBTkBZ3coZd7t5JavMPBitkHrctHqYQ1MeTY4oO+M4rEae62HvWxHeD6/VvLbJ6ql3Pgg1eI26i3ys1SY= X-Received: by 2002:a2e:bc0e:0:b0:255:9fa0:ed4 with SMTP id b14-20020a2ebc0e000000b002559fa00ed4mr10953078ljf.390.1654816723853; Thu, 09 Jun 2022 16:18:43 -0700 (PDT) MIME-Version: 1.0 References: <20220609221702.347522-1-morbo@google.com> <20220609221702.347522-2-morbo@google.com> <3a773edf-f850-e83d-828d-19f91a373384@infradead.org> In-Reply-To: <3a773edf-f850-e83d-828d-19f91a373384@infradead.org> From: Bill Wendling Date: Thu, 9 Jun 2022 16:18:31 -0700 Message-ID: Subject: Re: [PATCH 01/12] x86/mce: use correct format characters To: Randy Dunlap Cc: Bill Wendling , Tony Luck , Borislav Petkov , Thomas Gleixner , Ingo Molnar , Dave Hansen , "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" , "H. Peter Anvin" , Phillip Potter , Arnd Bergmann , Greg Kroah-Hartman , "Rafael J. Wysocki" , Jan Kara , Andrew Morton , Pablo Neira Ayuso , Jozsef Kadlecsik , Florian Westphal , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jaroslav Kysela , Takashi Iwai , Nathan Chancellor , Nick Desaulniers , Tom Rix , Daniel Kiper , Ross Philipson , linux-edac@vger.kernel.org, LKML , ACPI Devel Maling List , linux-mm@kvack.org, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, Networking , alsa-devel@alsa-project.org, clang-built-linux Content-Type: text/plain; charset="UTF-8" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1654816725; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=af6354Q+PYtjAeTE1fHxbOWk4spb0xe2rddSt4jQNw0=; b=UsfU1oh9vqX7hamWt96GM08pG4h/1Ox7BcRPD9t5eHloDdo76WgO+Xrb/u7lOwzHZX+8fO 0OwKH0j7NERKj0SdOlG8IeRfEaZJRq36xz6iGzBJadBvuxgDldRpuIY6/INybT7hQjhNBu NwlxMCdLMOVI8mkb8KdVBcSwqPJYo7M= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1654816725; a=rsa-sha256; cv=none; b=TL3FBr99r2XJhduMePknvDplWU5xznVQcUyEfAgH98Y7KT6l9Ie5IoybbVYvxqRyNIC2/H jgQ9dUWHwV1RDh7PW6GT3spsY5OY16DoX9Edl90soZlakXWk5Gy3zApkRB5lVCo4fBwktD 8c8tP9VlJwu1BViahVyMIxkv/rYSzW8= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b="qsw/gp8R"; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf09.hostedemail.com: domain of morbo@google.com designates 209.85.208.177 as permitted sender) smtp.mailfrom=morbo@google.com Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b="qsw/gp8R"; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf09.hostedemail.com: domain of morbo@google.com designates 209.85.208.177 as permitted sender) smtp.mailfrom=morbo@google.com X-Rspamd-Server: rspam08 X-Rspam-User: X-Stat-Signature: krxz7kk4bzcn9x7i4j598kp7ooi4b49s X-Rspamd-Queue-Id: 96EFE140065 X-HE-Tag: 1654816725-100489 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jun 9, 2022 at 4:15 PM Randy Dunlap wrote: > On 6/9/22 15:16, Bill Wendling wrote: > > From: Bill Wendling > > > > When compiling with -Wformat, clang emits the following warnings: > > > > arch/x86/kernel/cpu/mce/core.c:295:9: error: format string is not a string literal (potentially insecure) [-Werror,-Wformat-security] > > panic(msg); > > ^~~ > > > > Use a string literal for the format string. > > > > Link: https://github.com/ClangBuiltLinux/linux/issues/378 > > Signed-off-by: Bill Wendling > > --- > > arch/x86/kernel/cpu/mce/core.c | 2 +- > > scripts/Makefile.extrawarn | 4 ++-- > > Where is the scripts/ change? > I'm sorry about this. The change in that file was a mistake that I reverted, but I forgot to change this part. -bw > > 2 files changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/arch/x86/kernel/cpu/mce/core.c b/arch/x86/kernel/cpu/mce/core.c > > index 2c8ec5c71712..3d411b7c85ad 100644 > > --- a/arch/x86/kernel/cpu/mce/core.c > > +++ b/arch/x86/kernel/cpu/mce/core.c > > @@ -292,7 +292,7 @@ static noinstr void mce_panic(const char *msg, struct mce *final, char *exp) > > if (!fake_panic) { > > if (panic_timeout == 0) > > panic_timeout = mca_cfg.panic_timeout; > > - panic(msg); > > + panic("%s", msg); > > } else > > pr_emerg(HW_ERR "Fake kernel panic: %s\n", msg); > > > > -- > ~Randy