From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0118C43334 for ; Mon, 13 Jun 2022 18:47:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6B7A06B0257; Mon, 13 Jun 2022 14:47:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 63F8E8D01A1; Mon, 13 Jun 2022 14:47:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 491526B0259; Mon, 13 Jun 2022 14:47:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 336056B0257 for ; Mon, 13 Jun 2022 14:47:32 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id E956C2084F for ; Mon, 13 Jun 2022 18:47:31 +0000 (UTC) X-FDA: 79574095902.18.40BC0E9 Received: from mail-lj1-f179.google.com (mail-lj1-f179.google.com [209.85.208.179]) by imf21.hostedemail.com (Postfix) with ESMTP id 8C6151C009C for ; Mon, 13 Jun 2022 18:47:31 +0000 (UTC) Received: by mail-lj1-f179.google.com with SMTP id c30so7157973ljr.9 for ; Mon, 13 Jun 2022 11:47:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=gnUSbe8CiTQ19HP1QRaMovzHPwVV5AH7oRueQxzbr2w=; b=psqvyg4bPOOObXvl93Zxro9XA/ODLoG6iBN8VzURq2kWrUR7F3BHDeeHNMu0CFKyIh Niks5hKvSuVELNC275GXW5lNVLONvG604XONrgXtzQCBbODYI+FiNC4UHOy01ziKEw6P PnJJ8X8mCYdNE116ke64zsX9sSqEcXHCfXLltO9UXIpqgB60u1m1gOJgKSvqZ2Vu7Rt3 Fab5Mj4u35jsb3FBf1q2tLM98qhaB60LVo3lH+ODCh+pfDogtGE59OZmPCThjZAo5F3C uARnmPJ0E0/9jMWP5IEUMjK7PRjAVPO04tktB/Od36POLALwftkbezadySNHJrj1LtR7 bRTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=gnUSbe8CiTQ19HP1QRaMovzHPwVV5AH7oRueQxzbr2w=; b=5QRSXoN7jSM4MEmHEHFoaSRb5uOluFvFPjM1Y5aFFEkyOX9FGVdSKIozaynKbfGI2n nni9Haj6zzIOFI8SJ+F3dq4z6ryHDpKCnGZ/RmuT7vjzlmL7ng1f3LsNa4IeGnBJHKeF Ye2WfGhh5WOF9LuDcLT2u6xka02sLdGDwv4f60wQzDMt4MD+GTG1/DkhbrQQ2OWCNg8E q+ipiXqSxCfj14P98M9kzx/TBfI/XnFQRVJpJUZZQMTgYRtuGikWpmiU+lAmEibHWapB Llx8TBsEveXcHsFQgi0wKwKTGqbTuKHQJhTXwutiUMgSFb2uAXe7vqxbkoLt9qFq9OFX utdA== X-Gm-Message-State: AJIora9vEKaHUAUblilyWHU7mUqcwPHVC++DcUNTMBIAUMZU44lASViO 7I4FCTegZi5pyRpUAkzV2mNQYbRy+Tl9epE5dVnB X-Google-Smtp-Source: AGRyM1uMA1RswQj/kRbYWxpa2gpbkIqW/H3Lhp9QgKWhkKjVKtC7uz71CWdrVgWOGoL64GzPA+QRw4qUugKbzHueGjo= X-Received: by 2002:a05:651c:1581:b0:255:48d1:fdae with SMTP id h1-20020a05651c158100b0025548d1fdaemr472476ljq.286.1655146049852; Mon, 13 Jun 2022 11:47:29 -0700 (PDT) MIME-Version: 1.0 References: <20220609221702.347522-1-morbo@google.com> <20220609221702.347522-9-morbo@google.com> In-Reply-To: From: Bill Wendling Date: Mon, 13 Jun 2022 11:47:18 -0700 Message-ID: Subject: Re: [PATCH 08/12] cdrom: use correct format characters To: Phillip Potter Cc: Bill Wendling , Tony Luck , Borislav Petkov , Thomas Gleixner , Ingo Molnar , Dave Hansen , "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" , "H. Peter Anvin" , Arnd Bergmann , Greg Kroah-Hartman , "Rafael J. Wysocki" , Jan Kara , Andrew Morton , Pablo Neira Ayuso , Jozsef Kadlecsik , Florian Westphal , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jaroslav Kysela , Takashi Iwai , Nathan Chancellor , Nick Desaulniers , Tom Rix , Ross Philipson , Daniel Kiper , linux-edac@vger.kernel.org, LKML , ACPI Devel Maling List , linux-mm@kvack.org, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, Networking , alsa-devel@alsa-project.org, clang-built-linux Content-Type: text/plain; charset="UTF-8" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1655146051; a=rsa-sha256; cv=none; b=HbXs0I7GwFP0/EYBDWeUjsxPI0gvvzNPpo5q/VkFa4kNFQf2RHGQSSBZnPvbn/NpqYzGBb Baqwyijaz22vin72eJDYvqmEu1/p/0kTORjMJ4PZ35sQci9v5zpRpsXu4L6OR+6O/9cg45 f+ZDpGteENxjMQkJoA10BbjJQhQC+gk= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=psqvyg4b; spf=pass (imf21.hostedemail.com: domain of morbo@google.com designates 209.85.208.179 as permitted sender) smtp.mailfrom=morbo@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1655146051; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=gnUSbe8CiTQ19HP1QRaMovzHPwVV5AH7oRueQxzbr2w=; b=Q5ImBV1PfeGIHf2H0LeD25KQ2z3arMrMkECB0ehYZyKwqqu98cspdMew32WqyNuembD/DU T6TUia2yJqKLKLFEr0PraJ/U23YAE0obAkwKMRAoBmxl/W1jZknWqHBEeGB6y2hNUvn2n3 wnEVPSxEQVqd7HQw/U0XJ21BhKNBT6M= X-Stat-Signature: wqeukrdht5kycangzqfohkjttcuk697u X-Rspamd-Queue-Id: 8C6151C009C Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=psqvyg4b; spf=pass (imf21.hostedemail.com: domain of morbo@google.com designates 209.85.208.179 as permitted sender) smtp.mailfrom=morbo@google.com; dmarc=pass (policy=reject) header.from=google.com X-Rspamd-Server: rspam07 X-Rspam-User: X-HE-Tag: 1655146051-307665 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Jun 12, 2022 at 9:23 AM Phillip Potter wrote: > > On Thu, Jun 09, 2022 at 10:16:27PM +0000, Bill Wendling wrote: > > From: Bill Wendling > > > > When compiling with -Wformat, clang emits the following warnings: > > > > drivers/cdrom/cdrom.c:3454:48: error: format string is not a string literal (potentially insecure) [-Werror,-Wformat-security] > > ret = scnprintf(info + *pos, max_size - *pos, header); > > ^~~~~~ > > > > Use a string literal for the format string. > > > > Link: https://github.com/ClangBuiltLinux/linux/issues/378 > > Signed-off-by: Bill Wendling > > --- > > drivers/cdrom/cdrom.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/cdrom/cdrom.c b/drivers/cdrom/cdrom.c > > index 416f723a2dbb..52b40120c76e 100644 > > --- a/drivers/cdrom/cdrom.c > > +++ b/drivers/cdrom/cdrom.c > > @@ -3451,7 +3451,7 @@ static int cdrom_print_info(const char *header, int val, char *info, > > struct cdrom_device_info *cdi; > > int ret; > > > > - ret = scnprintf(info + *pos, max_size - *pos, header); > > + ret = scnprintf(info + *pos, max_size - *pos, "%s", header); > > if (!ret) > > return 1; > > > > -- > > 2.36.1.255.ge46751e96f-goog > > > > Hi Bill, > > Thank you for the patch, much appreciated. > > Looking at this though, all callers of cdrom_print_info() provide 'header' > as a string literal defined within the driver, when making the call. > Therefore, I'm not convinced this change is necessary for cdrom.c - > that said, in this particular use case I don't think it would hurt > either. > > I've followed the other responses on parts of this series, so I > understand that a different solution is potentially in the works. > Thought I'd respond anyway though out of courtesy. > Thanks, Phillip. I pointed out in a separate response that this specific warning is disabled by default, but when I ran into while hacking stuff there weren't a lot of places where the warning popped up (at least for x86 builds) and thought it would be a nice cleanup. I understand if you don't think this patch is necessary for your code. There are some places where visual inspection of the code is "good enough" to ensure that nothing untoward will happen (Greg pointed out a similar thing in an mm/ file). Cheers! -bw