From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A359C43334 for ; Thu, 9 Jun 2022 23:16:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0CF926B00B9; Thu, 9 Jun 2022 19:16:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 058638D0063; Thu, 9 Jun 2022 19:16:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DC5698D0062; Thu, 9 Jun 2022 19:16:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id C7C216B00B9 for ; Thu, 9 Jun 2022 19:16:29 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 9DE3C2037F for ; Thu, 9 Jun 2022 23:16:29 +0000 (UTC) X-FDA: 79560258498.28.90E47C2 Received: from mail-lf1-f50.google.com (mail-lf1-f50.google.com [209.85.167.50]) by imf21.hostedemail.com (Postfix) with ESMTP id 433D31C0079 for ; Thu, 9 Jun 2022 23:16:29 +0000 (UTC) Received: by mail-lf1-f50.google.com with SMTP id a2so34139835lfg.5 for ; Thu, 09 Jun 2022 16:16:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=+qQsabkwxRvA8bdaAfDmJWrhJnuevA/KFdg/I1GgKtI=; b=Ild0j7K/fhaVoC0PM7iI7pWdMAhRoR7/W2DRfNt0y6B95s4E9BAdtVXpgi3bEW9uNf AG1lgqOnQ2uv5vAvry2j8xPExVeLJ3BYnAE/tN+xXqHuPln6DSb5D7skU1STvZI/NDhW jtR8Pxq27ZSax7URoP+iTQwlBmGjk0LFf4D0uom1Imt1fNNlM84d4KYNh2dTlJaTBsbT JVm5nxYhNIVv0OxKdscaj9QMvA2PvsOaMEbHHEGSiRoofkVzd7gclfaU8PJEykQKLQma 53nit31M3stTWvFisr1YokQQjCrMXni13o6jwb6NDhQT5srtIccNwD3iLK4QBnuEEitd 6fKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=+qQsabkwxRvA8bdaAfDmJWrhJnuevA/KFdg/I1GgKtI=; b=nULi/qSxve6FObhP4h4z2+wMM10SB6/jGEbQLlttqAwaEOeXJS3+DYLTEtv/KFM9lA Z2ionqlafRQqfAAWDJh8WQcBKTRwWTxNiExx2KhfSWoTysxgIWwCIukjdfOj0HRByyy9 wkYg5irsUP0o08gY8LRBmbtjS/Jn3cYayvHAk1DKaI8GfYVk4LfrK/Enm7E4aIEWnqgW WPLxVW7JSeSh+Cw3oldFvxW1mEqxo6+hX3HdNc+5NV92U1mVsBVO3AqwEwO/KdDUrHSk QmDoTJLrMHlIThqGhr9DXW6Jvf1v4DsAV6xI1e2Df26ARtN1cCqhDT4gOfs00FnQxKn2 mHRw== X-Gm-Message-State: AOAM533tP5PP3IAZkewFYQuZxpxvJgT9t3KbMw2IV/J186hZnbEONv9v vbPaecAesVKrcQjKuxIp0GeIsoOmfL5HV0XbmPU3 X-Google-Smtp-Source: ABdhPJxylpDJBi9Oyjp7yXKp6FA+T0ynmXHzLKYVD27usilZLqbUqbJzR3v4r67aMe0WXL7WusF4sc80jjd/QAokEMo= X-Received: by 2002:a05:6512:280a:b0:47a:e70d:63e9 with SMTP id cf10-20020a056512280a00b0047ae70d63e9mr5068916lfb.288.1654816587358; Thu, 09 Jun 2022 16:16:27 -0700 (PDT) MIME-Version: 1.0 References: <20220609221702.347522-1-morbo@google.com> <20220609152527.4ad7862d4126e276e6f76315@linux-foundation.org> In-Reply-To: From: Bill Wendling Date: Thu, 9 Jun 2022 16:16:16 -0700 Message-ID: Subject: Re: [PATCH 00/12] Clang -Wformat warning fixes To: Jan Engelhardt Cc: Andrew Morton , Bill Wendling , Tony Luck , Borislav Petkov , Thomas Gleixner , Ingo Molnar , Dave Hansen , "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" , "H. Peter Anvin" , Phillip Potter , Arnd Bergmann , Greg Kroah-Hartman , "Rafael J. Wysocki" , Jan Kara , Pablo Neira Ayuso , Jozsef Kadlecsik , Florian Westphal , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jaroslav Kysela , Takashi Iwai , Nathan Chancellor , Nick Desaulniers , Tom Rix , Ross Philipson , Daniel Kiper , linux-edac@vger.kernel.org, LKML , ACPI Devel Maling List , linux-mm@kvack.org, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, Networking , alsa-devel@alsa-project.org, clang-built-linux Content-Type: text/plain; charset="UTF-8" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1654816589; a=rsa-sha256; cv=none; b=vxrl3yqsYjZaDRPnhNP+ncFj5p58DfSrCNBV+bQkefV3HQSv27kjWFf3RQKHJOkfdBvS6x cX1LAvatt6Is3WjB/ttT5Cjw/UGBRO/aQ1QzmgQTXeykYaEo5raZdI2//kP25RKgHuid4H W8pUi7WHlHDag99cwaZvzSsxh4uWIu8= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b="Ild0j7K/"; spf=pass (imf21.hostedemail.com: domain of morbo@google.com designates 209.85.167.50 as permitted sender) smtp.mailfrom=morbo@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1654816589; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+qQsabkwxRvA8bdaAfDmJWrhJnuevA/KFdg/I1GgKtI=; b=6GYy6V8lXJBUeXI9zwZZ4MtomOWDRr5AjLHJ5cW18nSCKqlbnroXEcnUv1GB/hKg4s3yc7 lq3YqyDb75jkUci8+hm2hOz3jhtrzXRGCyfRX9Tu0lZHhb7QcqCRjImJoS/viaCq15JKoa +2uhmiYboqkW0dXKGJMI6zcpwDmxd6g= X-Rspamd-Queue-Id: 433D31C0079 Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b="Ild0j7K/"; spf=pass (imf21.hostedemail.com: domain of morbo@google.com designates 209.85.167.50 as permitted sender) smtp.mailfrom=morbo@google.com; dmarc=pass (policy=reject) header.from=google.com X-Rspam-User: X-Rspamd-Server: rspam06 X-Stat-Signature: i5jwjzty38pf36fb1ker7mr9p6mennnr X-HE-Tag: 1654816589-146734 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jun 9, 2022 at 4:03 PM Jan Engelhardt wrote: > On Friday 2022-06-10 00:49, Bill Wendling wrote: > >On Thu, Jun 9, 2022 at 3:25 PM Andrew Morton wrote: > >> On Thu, 9 Jun 2022 22:16:19 +0000 Bill Wendling wrote: > >> > >> > This patch set fixes some clang warnings when -Wformat is enabled. > >> > >> tldr: > >> > >> - printk(msg); > >> + printk("%s", msg); > >> > >> Otherwise these changes are a > >> useless consumer of runtime resources. > > > >Calling a "printf" style function is already insanely expensive. > >[...] > >The "printk" and similar functions all have the "__printf" attribute. > >I don't know of a modification to that attribute which can turn off > >this type of check. > > Perhaps you can split vprintk_store in the middle (after the call to > vsnprintf), and offer the second half as a function of its own (e.g. > "puts"). Then the tldr could be > > - printk(msg); > + puts(msg); That might be a nice compromise. Andrew, what do you think? -bw