From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx115.postini.com [74.125.245.115]) by kanga.kvack.org (Postfix) with SMTP id 677106B13F3 for ; Fri, 3 Feb 2012 10:36:37 -0500 (EST) Received: by vcbf13 with SMTP id f13so3393260vcb.14 for ; Fri, 03 Feb 2012 07:36:36 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <20120203145304.GA18335@tiehlicka.suse.cz> References: <1328258627-2241-1-git-send-email-geunsik.lim@gmail.com> <20120203133950.GA1690@cmpxchg.org> <20120203145304.GA18335@tiehlicka.suse.cz> Date: Sat, 4 Feb 2012 00:36:36 +0900 Message-ID: Subject: Re: [PATCH] Handling of unused variable 'do-numainfo on compilation time From: Geunsik Lim Content-Type: multipart/alternative; boundary=20cf3071c6aeff47c704b81113e0 Sender: owner-linux-mm@kvack.org List-ID: To: Michal Hocko Cc: Johannes Weiner , KAMEZAWA Hiroyuki , Andrew Morton , linux-kernel , Daisuke Nishimura , linux-mm --20cf3071c6aeff47c704b81113e0 Content-Type: text/plain; charset=UTF-8 On Fri, Feb 3, 2012 at 11:53 PM, Michal Hocko wrote: > On Fri 03-02-12 14:39:50, Johannes Weiner wrote: > > Michal, this keeps coming up, please decide between the proposed > > solutions ;-) > > Hmm, I thought we already sorted this out > https://lkml.org/lkml/2012/1/26/25 ? > > I don't know previous history about this variable. Is it same? Please, adjust this patch or fix the unsuitable variable 'do_numainfo' as I mentioned. > > > > On Fri, Feb 03, 2012 at 05:43:47PM +0900, Geunsik Lim wrote: > > > Actually, Usage of the variable 'do_numainfo'is not suitable for gcc > compiler. > > > Declare the variable 'do_numainfo' if the number of NUMA nodes > 1. > > > > > > Signed-off-by: Geunsik Lim > > > --- > > > mm/memcontrol.c | 5 ++++- > > > 1 files changed, 4 insertions(+), 1 deletions(-) > > > > > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > > > index 556859f..4e17ac5 100644 > > > --- a/mm/memcontrol.c > > > +++ b/mm/memcontrol.c > > > @@ -776,7 +776,10 @@ static void memcg_check_events(struct mem_cgroup > *memcg, struct page *page) > > > /* threshold event is triggered in finer grain than soft limit */ > > > if (unlikely(mem_cgroup_event_ratelimit(memcg, > > > > MEM_CGROUP_TARGET_THRESH))) { > > > - bool do_softlimit, do_numainfo; > > > + bool do_softlimit; > > > +#if MAX_NUMNODES > 1 > > > + bool do_numainfo; > > > +#endif > > > > > > do_softlimit = mem_cgroup_event_ratelimit(memcg, > > > > MEM_CGROUP_TARGET_SOFTLIMIT); > > > -- > > > 1.7.8.1 > > > > > -- > Michal Hocko > SUSE Labs > SUSE LINUX s.r.o. > Lihovarska 1060/12 > 190 00 Praha 9 > Czech Republic > -- ---- Best regards, Geunsik Lim, Samsung Electronics http://leemgs.fedorapeople.org ---- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ --20cf3071c6aeff47c704b81113e0 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable

On Fri, Feb 3, 2012 at 11:53 PM, Michal = Hocko <mhocko@suse.c= z> wrote:
On Fri 03-02-12 14:39:50, Johannes Weiner wrote:
> Michal, this keeps coming up, please decide between the proposed
> solutions ;-)

Hmm, I thought we already sorted this out https://lkml.org/lkml/2012/1/26/25 ?

variable 'do_numainfo' as I mentioned.=C2=A0
>
> On Fri, Feb 03, 2012 at 05:43:47PM +0900, Geunsik Lim wrote:
> > Actually, Usage of the variable 'do_numainfo'is not suita= ble for gcc compiler.
> > Declare the variable 'do_numainfo' if the number of NUMA = nodes > 1.
> >
> > Signed-off-by: Geunsik Lim <geunsik.lim@samsung.com>
> > ---
> > =C2=A0mm/memcontrol.c | =C2=A0 =C2=A05 ++++-
> > =C2=A01 files changed, 4 insertions(+), 1 deletions(-)
> >
> > diff --git a/mm/memcontrol.c b/mm/memcontrol.c
> > index 556859f..4e17ac5 100644
> > --- a/mm/memcontrol.c
> > +++ b/mm/memcontrol.c
> > @@ -776,7 +776,10 @@ static void memcg_check_events(struct mem_cg= roup *memcg, struct page *page)
> > =C2=A0 =C2=A0 /* threshold event is triggered in finer grain than= soft limit */
> > =C2=A0 =C2=A0 if (unlikely(mem_cgroup_event_ratelimit(memcg,
> > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 MEM_CGROUP_TARGET_THRESH))) {
> > - =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 bool do_softlimit, do_numain= fo;
> > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 bool do_softlimit;
> > +#if MAX_NUMNODES > 1
> > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0bool do_= numainfo;
> > +#endif
> >
> > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 do_softlimit =3D mem_cg= roup_event_ratelimit(memcg,
> > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 MEM_CGROUP_TARGET_SOFTLIMIT);
> > --
> > 1.7.8.1
> >

--
Michal Hocko
SUSE Labs
SUSE LINUX s.r.o.
Lihovarska 1060/12
190 00 Praha 9
Czech Republic



--
----
Best regards,
Geunsik Lim, Samsung Electron= ics
----
To unsubscribe from this list: send the line "unsu= bscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.= org

--20cf3071c6aeff47c704b81113e0-- -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org