From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1CEAC04FFE for ; Thu, 9 May 2024 00:29:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4FFDC6B0083; Wed, 8 May 2024 20:29:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4B00E6B0085; Wed, 8 May 2024 20:29:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 377906B0089; Wed, 8 May 2024 20:29:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 1BC046B0083 for ; Wed, 8 May 2024 20:29:39 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 9EFB8C0F0E for ; Thu, 9 May 2024 00:29:38 +0000 (UTC) X-FDA: 82096974036.01.250E638 Received: from mail-ed1-f45.google.com (mail-ed1-f45.google.com [209.85.208.45]) by imf22.hostedemail.com (Postfix) with ESMTP id BA892C0007 for ; Thu, 9 May 2024 00:29:36 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b="JZNhBX+/"; spf=pass (imf22.hostedemail.com: domain of edliaw@google.com designates 209.85.208.45 as permitted sender) smtp.mailfrom=edliaw@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715214576; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/ze6we/9zl1hwpr5TTVXS+9EQi+iUJaNZFz5eMfIu64=; b=LUeZofaJJKcIeFkpKiqE7Z6TZ/GDwnhZ9kPvgHB3OjR07GLKAF/G617rJ6MwI9N7blISZ9 76sYpT0+7bpxozCXKZBiG+d9e28iwL3UCd791sjXuIiUq55qa1zn8y7jAwjPI8276aIDVa TeeOOxaizVveIlGkX8e3nUZR89DJNcs= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715214576; a=rsa-sha256; cv=none; b=m4O4bmLEYnyUSHKlEO5yuAIP04g15kYI6jgoTJOcoSSbU+N6J87Y/ytbeB+81gnVEwRA9C E4DibF8tZ0unmyUD61222SJXWKfUYgwNNZs2LaB00ECa1bJ2igmyCpNPG5/YYlpMzY2UZH WXoxtXMr4WKpP+5oCMGXpSEzY64Q0/c= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b="JZNhBX+/"; spf=pass (imf22.hostedemail.com: domain of edliaw@google.com designates 209.85.208.45 as permitted sender) smtp.mailfrom=edliaw@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-ed1-f45.google.com with SMTP id 4fb4d7f45d1cf-572aad902baso6293a12.0 for ; Wed, 08 May 2024 17:29:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1715214575; x=1715819375; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=/ze6we/9zl1hwpr5TTVXS+9EQi+iUJaNZFz5eMfIu64=; b=JZNhBX+/D9YL+3GUoNx4PgC1RNwSSE6g3/P/QAXMwDuQ0wbKa7GbS6/yma7F4tByqR mou3YTyS5McEpcdZzLkwrDxyFb8nMGtl6moafJWN7/8XUfbramZdQIOhpBIH0/8YrmHU fWGVGtaRn/Tx6h7qTJ0bXpbzj5ypayg2ggkV9nY73oiNMBhKfcFcUBKgLusjaN1LPYIv uWn9CMUWpqhApp9pFewYVJbIJzzyYDStLQzeozLLxG4Mppr4LCwnWhNOe1iY80ZSoByE OqyYfdBwnV/oSIhvNAbZX5SuUdQ8+t5Oi+gVO8HSwE3xGxGgvqkS3YOUnHNAWHdubwpZ Ox/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715214575; x=1715819375; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/ze6we/9zl1hwpr5TTVXS+9EQi+iUJaNZFz5eMfIu64=; b=MtpgxGAb6riqElttER6DJaChqBO8fXyuGw/D3MMKJzKAmEGY2++uu1wFJ7MpJEZew1 SGglrU/ug7fEMJWdhabcBzcQ14a9jylqgwVX6wPLNqMeCw5rVeTydn14pndObKgCOWgS cRL4dDjYOjWcL7MT+lgKeR9qF38c3jcWtIupG5tdNs2kk3pIxdJwclFTGc5BRkQImLNl GXTyEQtOUoPcrFiJQ+elKqkyAwmGZ/uBi1mIhM+471LuKZ7Pp8+NuIxqdQax4DEk+7+T wV+45e3HXutT1nplt/fS3dLsC58MxH8iJak6jzuw1vvok8zykUWq+yj0ft0T8L+fCCzn QpqQ== X-Forwarded-Encrypted: i=1; AJvYcCU6Roh5mUVlBIgefJvrNiGSjF86poQ1tZklf6y6foQbWjbsQP+qIp2UvTQFidHh5IQtIGeLUMxDu+7F7N/8MMfz43c= X-Gm-Message-State: AOJu0YzKypQXWJRnQDXC/AzjAdsr/1FDJFZy5cOpg7016WfT7yV96EMx mWkiPn6aSftd1sizgpjBPUbxh0hZJftXU4AsjR+c+XAgVQZrbveQZR2UmBOEMkkTVD2GKAnfO5M 7ML18Ic3mjTIkfm93TQkG4hN/ZnLdLV5/cHox X-Google-Smtp-Source: AGHT+IEpRBxjqO7YXZEC9B8FKVtXSFN03eOTZMizwoUq2jNrJCvIwReN+ats511GKy8ts5rRqhmgn49fpwdVOB7Y6R8= X-Received: by 2002:a05:6402:742:b0:572:a154:7081 with SMTP id 4fb4d7f45d1cf-5733434b416mr85834a12.4.1715214574664; Wed, 08 May 2024 17:29:34 -0700 (PDT) MIME-Version: 1.0 References: <20240507214254.2787305-1-edliaw@google.com> <20240507214254.2787305-4-edliaw@google.com> In-Reply-To: From: Edward Liaw Date: Wed, 8 May 2024 17:29:07 -0700 Message-ID: Subject: Re: [PATCH v2 3/5] selftests: Include KHDR_INCLUDES in Makefile To: John Hubbard Cc: shuah@kernel.org, Mark Brown , Jaroslav Kysela , Takashi Iwai , Catalin Marinas , Will Deacon , Nhat Pham , Johannes Weiner , Christian Brauner , Eric Biederman , Kees Cook , OGAWA Hirofumi , Thomas Gleixner , Ingo Molnar , Peter Zijlstra , Darren Hart , Davidlohr Bueso , =?UTF-8?Q?Andr=C3=A9_Almeida?= , Jiri Kosina , Benjamin Tissoires , Jason Gunthorpe , Kevin Tian , Andy Lutomirski , Will Drewry , Marc Zyngier , Oliver Upton , James Morse , Suzuki K Poulose , Zenghui Yu , Paolo Bonzini , Sean Christopherson , Anup Patel , Atish Patra , Paul Walmsley , Palmer Dabbelt , Albert Ou , Christian Borntraeger , Janosch Frank , Claudio Imbrenda , David Hildenbrand , =?UTF-8?B?TWlja2HDq2wgU2FsYcO8bg==?= , Paul Moore , James Morris , "Serge E. Hallyn" , Andrew Morton , Seth Forshee , Bongsu Jeon , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Steffen Klassert , Herbert Xu , =?UTF-8?Q?Andreas_F=C3=A4rber?= , Manivannan Sadhasivam , Matthieu Baerts , Mat Martineau , Geliang Tang , Willem de Bruijn , Fenghua Yu , Reinette Chatre , Mathieu Desnoyers , "Paul E. McKenney" , Boqun Feng , Alexandre Belloni , Jarkko Sakkinen , Dave Hansen , Muhammad Usama Anjum , linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, kernel-team@android.com, linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org, linux-input@vger.kernel.org, iommu@lists.linux.dev, kvmarm@lists.linux.dev, kvm@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-security-module@vger.kernel.org, linux-fsdevel@vger.kernel.org, netdev@vger.kernel.org, linux-actions@lists.infradead.org, mptcp@lists.linux.dev, linux-rtc@vger.kernel.org, linux-sgx@vger.kernel.org, bpf@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Stat-Signature: e43aojjbtwdibjze8o1j5o11hchh8kzi X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: BA892C0007 X-HE-Tag: 1715214576-680838 X-HE-Meta: U2FsdGVkX1/4pxZPBxz9jC3Cih2OMbH+OJP0YQ2zlYFLUAt0yj83PaFSJ2HUch5V4DnLy4LwJyvCsu3Z0wRgvi3CeKbjpIt/SZ2Xs0GzsLnvo9W1mwMWZjIxlW6vSE334Y8CXPHO6a6M24/D8OFOk3P3aPOIccgl0gB7N02w6uCTR09FwZ3nbIwAbIShLRDvyhaivvgXg4EBYRWOT9i/FnTi9IHAgwx5PQRuUB1DUwUOsNeUFLqkubHmfn3HfSxUozu53TcKxiixlo2OjExZYNwrfCbV7UArewtAgBsr2csrCw7xV0ZfqGKxPtohyjLZat4vhu9HrehumTCoAVLthcNdnUfmhBgNSGmfGixf49Fa/o14fiw9NQzBFD/cppkskDNdH2ppsYqFDa/wlfSQD1a9Cx1S+QJDybWBcTcxSoGxwkL5O644WgERTuy0gO7CDnfn5lkrHkyyG/oUEjKHeAtWmgm0ydDFkM/fMHF0LFJ+uZKfSYza6MCTGnSUBSXeIoAM0uUz1Qz493pItV3vneEBIgNhaISXLv7OWEEfuRqkYW42g5Ir3zbFxShx1U0wL98Jn6Xl+8p27gFDxIKEEsK5sGHkv+Gm+Ejq0CfrfAsKhrReJdcmUxqu/0VtxaowwViMtzH244E6k+CL7v4hU5shdIsPB001gKysykWwJPVAIIuk4dusNJPKTwu1WdbmliWkUK5i/tuohfzyHkcOfRI7CwFXX6UivCiPKjQzZqMkjwszs1i5u4oJfIbe2wb7+uxEkphsj5R4rqktj8HJe5LgWRJZh9RP/SG9rBBJ1+I5ur1KPe9uxn9XKxcnOGccHq56uNnkLsXeGmMqj+j0i2v5cbjk4sMRnoCs0c+UI6DtLJAOWIhYhHg7Zx1AziOrUfU0t0gy8mK1HLIU3daV3c1a+Vm+BtROKcXBateFm0zZTGXFuHACw5rPm2e/luGZvoFPRvv3e1OklJgdqrs foHXSIRJ 1dOWH09ET2k8OjjytBHYV8L9Q5gNu4u3UHqgrXwvmnFFhLU5szZc4uCmeLCnu6yliEypZts+SLNxXaQ3DN+n5wdJRb87OUddUusvy5EpZEtvhWgwdqe0YNgfj/nRakg3F+rdyVRrG/4hjbo8s7aKKsiFVW9VOhBase0fT0myJqzR+DyH1Sn1GP2WtlYFVuMQM8rsxCLuFeR/HGmdbcQXxGm5vjIj9cC45ve+UssOgRKHCMg11TWrJ7oJDeoipAed8TEdGijthugFJdgqcHGuArUoFIsoWZePNvgOwxZ0NgeKE5c5cUOshor67fZwc6JCWPpnPNk8ogWFKPOBbHMvngcfYXX0iu6daxi9f2Qcf7dEkfq9qfe46YxfW49kszlFrchHqY1hteBdMXjc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, May 8, 2024 at 2:41=E2=80=AFPM John Hubbard w= rote: > > On 5/7/24 2:38 PM, Edward Liaw wrote: > > Add KHDR_INCLUDES to CFLAGS to pull in the kselftest harness > > dependencies (-D_GNU_SOURCE). > > > > Fixes: 809216233555 ("selftests/harness: remove use of LINE_MAX") > > Signed-off-by: Edward Liaw > > --- > > tools/testing/selftests/alsa/Makefile | 2 +- > > tools/testing/selftests/arm64/signal/Makefile | 2 +- > > tools/testing/selftests/exec/Makefile | 2 +- > > tools/testing/selftests/filesystems/overlayfs/Makefile | 2 +- > > tools/testing/selftests/hid/Makefile | 2 +- > > tools/testing/selftests/nci/Makefile | 2 +- > > tools/testing/selftests/prctl/Makefile | 2 ++ > > tools/testing/selftests/proc/Makefile | 2 +- > > tools/testing/selftests/riscv/mm/Makefile | 2 +- > > tools/testing/selftests/rtc/Makefile | 2 +- > > tools/testing/selftests/tmpfs/Makefile | 2 +- > > 11 files changed, 12 insertions(+), 10 deletions(-) > > Hi Edward, > > Seeing as how these all include lib.mk, and all use CFLAGS, is there > any reason not to simply fix this in lib.mk instead? Like this: > > diff --git a/tools/testing/selftests/lib.mk b/tools/testing/selftests/lib= .mk > index 7fa4a96e26ed..df72610e0d2b 100644 > --- a/tools/testing/selftests/lib.mk > +++ b/tools/testing/selftests/lib.mk > @@ -170,6 +170,8 @@ clean: $(if $(TEST_GEN_MODS_DIR),clean_mods_dir) > CFLAGS +=3D $(USERCFLAGS) > LDFLAGS +=3D $(USERLDFLAGS) > > +CFLAGS +=3D $(KHDR_INCLUDES) > + > # When make O=3D with kselftest target from main level > # the following aren't defined. > # > Or how about just adding -D_GNU_SOURCE to CFLAGS then? > > thanks, > -- > John Hubbard > NVIDIA > > > > > diff --git a/tools/testing/selftests/alsa/Makefile b/tools/testing/self= tests/alsa/Makefile > > index 5af9ba8a4645..9a0ef194522c 100644 > > --- a/tools/testing/selftests/alsa/Makefile > > +++ b/tools/testing/selftests/alsa/Makefile > > @@ -6,7 +6,7 @@ LDLIBS +=3D $(shell pkg-config --libs alsa) > > ifeq ($(LDLIBS),) > > LDLIBS +=3D -lasound > > endif > > -CFLAGS +=3D -L$(OUTPUT) -Wl,-rpath=3D./ > > +CFLAGS +=3D $(KHDR_INCLUDES) -L$(OUTPUT) -Wl,-rpath=3D./ > > > > LDLIBS+=3D-lpthread > > > > diff --git a/tools/testing/selftests/arm64/signal/Makefile b/tools/test= ing/selftests/arm64/signal/Makefile > > index 8f5febaf1a9a..ae682ade615d 100644 > > --- a/tools/testing/selftests/arm64/signal/Makefile > > +++ b/tools/testing/selftests/arm64/signal/Makefile > > @@ -2,7 +2,7 @@ > > # Copyright (C) 2019 ARM Limited > > > > # Additional include paths needed by kselftest.h and local headers > > -CFLAGS +=3D -D_GNU_SOURCE -std=3Dgnu99 -I. > > +CFLAGS +=3D $(KHDR_INCLUDES) -std=3Dgnu99 -I. > > > > SRCS :=3D $(filter-out testcases/testcases.c,$(wildcard testcases/*.c= )) > > PROGS :=3D $(patsubst %.c,%,$(SRCS)) > > diff --git a/tools/testing/selftests/exec/Makefile b/tools/testing/self= tests/exec/Makefile > > index fb4472ddffd8..15e78ec7c55e 100644 > > --- a/tools/testing/selftests/exec/Makefile > > +++ b/tools/testing/selftests/exec/Makefile > > @@ -1,7 +1,7 @@ > > # SPDX-License-Identifier: GPL-2.0 > > CFLAGS =3D -Wall > > CFLAGS +=3D -Wno-nonnull > > -CFLAGS +=3D -D_GNU_SOURCE > > +CFLAGS +=3D $(KHDR_INCLUDES) > > > > TEST_PROGS :=3D binfmt_script.py > > TEST_GEN_PROGS :=3D execveat load_address_4096 load_address_2097152 l= oad_address_16777216 non-regular > > diff --git a/tools/testing/selftests/filesystems/overlayfs/Makefile b/t= ools/testing/selftests/filesystems/overlayfs/Makefile > > index 56b2b48a765b..6c29c963c7a8 100644 > > --- a/tools/testing/selftests/filesystems/overlayfs/Makefile > > +++ b/tools/testing/selftests/filesystems/overlayfs/Makefile > > @@ -2,6 +2,6 @@ > > > > TEST_GEN_PROGS :=3D dev_in_maps > > > > -CFLAGS :=3D -Wall -Werror > > +CFLAGS :=3D -Wall -Werror $(KHDR_INCLUDES) > > > > include ../../lib.mk > > diff --git a/tools/testing/selftests/hid/Makefile b/tools/testing/selft= ests/hid/Makefile > > index 2b5ea18bde38..0661b34488ef 100644 > > --- a/tools/testing/selftests/hid/Makefile > > +++ b/tools/testing/selftests/hid/Makefile > > @@ -21,7 +21,7 @@ CXX ?=3D $(CROSS_COMPILE)g++ > > > > HOSTPKG_CONFIG :=3D pkg-config > > > > -CFLAGS +=3D -g -O0 -rdynamic -Wall -Werror -I$(OUTPUT) > > +CFLAGS +=3D -g -O0 -rdynamic -Wall -Werror $(KHDR_INCLUDES) -I$(OUTPUT= ) > > CFLAGS +=3D -I$(OUTPUT)/tools/include > > > > LDLIBS +=3D -lelf -lz -lrt -lpthread > > diff --git a/tools/testing/selftests/nci/Makefile b/tools/testing/selft= ests/nci/Makefile > > index 47669a1d6a59..bbc5b8ec3b17 100644 > > --- a/tools/testing/selftests/nci/Makefile > > +++ b/tools/testing/selftests/nci/Makefile > > @@ -1,5 +1,5 @@ > > # SPDX-License-Identifier: GPL-2.0 > > -CFLAGS +=3D -Wl,-no-as-needed -Wall > > +CFLAGS +=3D -Wl,-no-as-needed -Wall $(KHDR_INCLUDES) > > LDFLAGS +=3D -lpthread > > > > TEST_GEN_PROGS :=3D nci_dev > > diff --git a/tools/testing/selftests/prctl/Makefile b/tools/testing/sel= ftests/prctl/Makefile > > index 01dc90fbb509..1a0aefec9d6f 100644 > > --- a/tools/testing/selftests/prctl/Makefile > > +++ b/tools/testing/selftests/prctl/Makefile > > @@ -6,6 +6,8 @@ ARCH ?=3D $(shell echo $(uname_M) | sed -e s/i.86/x86/ = -e s/x86_64/x86/) > > ifeq ($(ARCH),x86) > > TEST_PROGS :=3D disable-tsc-ctxt-sw-stress-test disable-tsc-on-off-st= ress-test \ > > disable-tsc-test set-anon-vma-name-test set-process-name > > + > > +CFLAGS +=3D $(KHDR_INCLUDES) > > all: $(TEST_PROGS) > > > > include ../lib.mk > > diff --git a/tools/testing/selftests/proc/Makefile b/tools/testing/self= tests/proc/Makefile > > index cd95369254c0..9596014c10a0 100644 > > --- a/tools/testing/selftests/proc/Makefile > > +++ b/tools/testing/selftests/proc/Makefile > > @@ -1,6 +1,6 @@ > > # SPDX-License-Identifier: GPL-2.0-only > > CFLAGS +=3D -Wall -O2 -Wno-unused-function > > -CFLAGS +=3D -D_GNU_SOURCE > > +CFLAGS +=3D $(KHDR_INCLUDES) > > LDFLAGS +=3D -pthread > > > > TEST_GEN_PROGS :=3D > > diff --git a/tools/testing/selftests/riscv/mm/Makefile b/tools/testing/= selftests/riscv/mm/Makefile > > index c333263f2b27..715a21241113 100644 > > --- a/tools/testing/selftests/riscv/mm/Makefile > > +++ b/tools/testing/selftests/riscv/mm/Makefile > > @@ -3,7 +3,7 @@ > > # Originally tools/testing/arm64/abi/Makefile > > > > # Additional include paths needed by kselftest.h and local headers > > -CFLAGS +=3D -D_GNU_SOURCE -std=3Dgnu99 -I. > > +CFLAGS +=3D $(KHDR_INCLUDES) -std=3Dgnu99 -I. > > > > TEST_GEN_FILES :=3D mmap_default mmap_bottomup > > > > diff --git a/tools/testing/selftests/rtc/Makefile b/tools/testing/selft= ests/rtc/Makefile > > index 55198ecc04db..654f9d58da3c 100644 > > --- a/tools/testing/selftests/rtc/Makefile > > +++ b/tools/testing/selftests/rtc/Makefile > > @@ -1,5 +1,5 @@ > > # SPDX-License-Identifier: GPL-2.0 > > -CFLAGS +=3D -O3 -Wl,-no-as-needed -Wall > > +CFLAGS +=3D -O3 -Wl,-no-as-needed -Wall $(KHDR_INCLUDES) > > LDLIBS +=3D -lrt -lpthread -lm > > > > TEST_GEN_PROGS =3D rtctest > > diff --git a/tools/testing/selftests/tmpfs/Makefile b/tools/testing/sel= ftests/tmpfs/Makefile > > index aa11ccc92e5b..bcdc1bb6d2e6 100644 > > --- a/tools/testing/selftests/tmpfs/Makefile > > +++ b/tools/testing/selftests/tmpfs/Makefile > > @@ -1,6 +1,6 @@ > > # SPDX-License-Identifier: GPL-2.0-only > > CFLAGS +=3D -Wall -O2 > > -CFLAGS +=3D -D_GNU_SOURCE > > +CFLAGS +=3D $(KHDR_INCLUDES) > > > > TEST_GEN_PROGS :=3D > > TEST_GEN_PROGS +=3D bug-link-o-tmpfile > >