From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0AB06C10F1A for ; Thu, 9 May 2024 06:14:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8F1856B0088; Thu, 9 May 2024 02:14:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 87A5F6B0089; Thu, 9 May 2024 02:14:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6CCB56B008A; Thu, 9 May 2024 02:14:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 4E1416B0088 for ; Thu, 9 May 2024 02:14:23 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id CC59B4143C for ; Thu, 9 May 2024 06:14:22 +0000 (UTC) X-FDA: 82097842764.23.B01A286 Received: from mail-ed1-f42.google.com (mail-ed1-f42.google.com [209.85.208.42]) by imf23.hostedemail.com (Postfix) with ESMTP id 01497140002 for ; Thu, 9 May 2024 06:14:20 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=a0qYb5I2; spf=pass (imf23.hostedemail.com: domain of edliaw@google.com designates 209.85.208.42 as permitted sender) smtp.mailfrom=edliaw@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715235261; a=rsa-sha256; cv=none; b=4PCxEsVTP4+m/tmjpZy0awDh2LzgLRXJH3edgARo0I6+AD0JfhigrwbxNn+mLxh6RRFRXL 7/+YzlJ1wgiWHaGr2O3HGsXOYJfT498U76eDq8UkjBqYBZohb7We3yq0cLSEvuIHyDvYXb CiTnoFZE4m0r1th+g+uAXWI5mPIvETA= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=a0qYb5I2; spf=pass (imf23.hostedemail.com: domain of edliaw@google.com designates 209.85.208.42 as permitted sender) smtp.mailfrom=edliaw@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715235261; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=72bWBwjQodIuSi8MsUtQvKNvKwdUWjXGREUei480Xwo=; b=FGRUKEew/BPNM+CdTfMon0eYftjmDzv6iIaepww4qhln5oLyyW6TG+izYdrBOcpQfJWMkt rpysQ0VeWNlcHy4hQ8YM1rhI7ltNiJStKiXaFwLOJL4j2Jm+XaVUqKexxWV9djGUNrpl8I l8YrlcL46c4JwwaiWeKNjhNhZdiLnnw= Received: by mail-ed1-f42.google.com with SMTP id 4fb4d7f45d1cf-5724736770cso4851a12.1 for ; Wed, 08 May 2024 23:14:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1715235259; x=1715840059; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=72bWBwjQodIuSi8MsUtQvKNvKwdUWjXGREUei480Xwo=; b=a0qYb5I2IXLQmcl7S0ONoqbAMNdbT+aXaIiLcTyAt6juedH1R2Mtzh4fYaD9ZufIpG HIWWWCrygZs5eP/NTIzfvVKPkv08rer9iLjEUwFtIQy/G8OAOvbIw+bQV9N8WAqiiCqH +3iodATNyBsQHyEj6v9gYlzcdX6VfjUQUGDLnC2xXZm/iakbmDacqaBWhsPM4Qvh4Q6w yKhjgElyU8pRtpKQmSD+crZ1Y0idI/ViRbIaM2kjJ+Q1ak+N8t0pFzWwlHGPYtLgrIAc 8Yh2moo5Y8R1WgI0RJ/ngD0Qe4NQjezYgnx61qZGTNLxESFrc7ORYweHlrSQgpv2WXGz Bf2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715235259; x=1715840059; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=72bWBwjQodIuSi8MsUtQvKNvKwdUWjXGREUei480Xwo=; b=jc8v1OexsTEX2H3m4FuV7pHAdyt8w/FliAUdhLWIZ7lva3Qc18A/1x53+SNjO8GP/m Yr9UoRHLBn/h9nyXGJGZjgpslNPBm5GycFstFkb9/JVcJ/nBg4HdhojXw2SSIpuqhDnY ytrm5FDwlYp4T5HilpTlfxbWzU6Sznlqi+2RtRqJrOCbJKwMRzduaPUWPQJNrY5sjRm2 V5J5zxA2hlx9CyfTCKKTkcfI7De/tQSadusORHM6PAxJTe94d73Fee94UniGF123JGJ0 pL7+QHExl0GVAkQK3cGO6b1x2W0Y5/sFiOvndtS63aIDDujNt/zYOSHb3nurlsYRmZ+a YhRA== X-Forwarded-Encrypted: i=1; AJvYcCUWqmYn/YOPAmG46N299L3dfZLGTEt8TAPB9e/Qo6OKgP8uO9eyQ+HG+Ah1iFQ0iC6qQ4jY4O79UCvRtoREqkutrAw= X-Gm-Message-State: AOJu0YyOWlSDaiJMyUPQ8NbV3XKhdYi5T6bGkao++Xq66E+NvQf1VxU1 8y9Bve2Eu41oSCjCEEaUdsmQG6ts2lJQLy9O37Eo+MFBReO5QEbFKpM5JK9tS/1IaI6KbuyXpED OuaVYNGgh4d4JfXLHSm1d5cWOLXupCE6V3ugz X-Google-Smtp-Source: AGHT+IHsPAG0LEeM4cJXnAxgH06RrdZlxemOxK5bdPXtb66jyshH3jVsPNC7i5pX8kAB1x6smMgaq3eKTmHMEonCtFw= X-Received: by 2002:a05:6402:5206:b0:572:a23b:1d81 with SMTP id 4fb4d7f45d1cf-5733b9d3b3emr79412a12.5.1715235258767; Wed, 08 May 2024 23:14:18 -0700 (PDT) MIME-Version: 1.0 References: <20240507214254.2787305-1-edliaw@google.com> In-Reply-To: From: Edward Liaw Date: Wed, 8 May 2024 23:13:51 -0700 Message-ID: Subject: Re: [PATCH v2 0/5] Define _GNU_SOURCE for sources using To: Shuah Khan Cc: shuah@kernel.org, Mark Brown , Jaroslav Kysela , Takashi Iwai , Catalin Marinas , Will Deacon , Nhat Pham , Johannes Weiner , Christian Brauner , Eric Biederman , Kees Cook , OGAWA Hirofumi , Thomas Gleixner , Ingo Molnar , Peter Zijlstra , Darren Hart , Davidlohr Bueso , =?UTF-8?Q?Andr=C3=A9_Almeida?= , Jiri Kosina , Benjamin Tissoires , Jason Gunthorpe , Kevin Tian , Andy Lutomirski , Will Drewry , Marc Zyngier , Oliver Upton , James Morse , Suzuki K Poulose , Zenghui Yu , Paolo Bonzini , Sean Christopherson , Anup Patel , Atish Patra , Paul Walmsley , Palmer Dabbelt , Albert Ou , Christian Borntraeger , Janosch Frank , Claudio Imbrenda , David Hildenbrand , =?UTF-8?B?TWlja2HDq2wgU2FsYcO8bg==?= , Paul Moore , James Morris , "Serge E. Hallyn" , Andrew Morton , Seth Forshee , Bongsu Jeon , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Steffen Klassert , Herbert Xu , =?UTF-8?Q?Andreas_F=C3=A4rber?= , Manivannan Sadhasivam , Matthieu Baerts , Mat Martineau , Geliang Tang , Willem de Bruijn , Fenghua Yu , Reinette Chatre , Mathieu Desnoyers , "Paul E. McKenney" , Boqun Feng , Alexandre Belloni , Jarkko Sakkinen , Dave Hansen , Muhammad Usama Anjum , linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, kernel-team@android.com, linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org, linux-input@vger.kernel.org, iommu@lists.linux.dev, kvmarm@lists.linux.dev, kvm@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-security-module@vger.kernel.org, linux-fsdevel@vger.kernel.org, netdev@vger.kernel.org, linux-actions@lists.infradead.org, mptcp@lists.linux.dev, linux-rtc@vger.kernel.org, linux-sgx@vger.kernel.org, bpf@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: znpshpjoduq8trdkqmrc9bmsd1sqs5mf X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 01497140002 X-HE-Tag: 1715235260-283182 X-HE-Meta: U2FsdGVkX181HebCmkXuOjHgQsQ7Pw/mm+i6V29vH8xxwVskhur6oiY1aj+5e0BsB3cx2yqwn2iF3XSVy7BegwD7V3/iiB44lkFTMDI3Q9RT8Z0Xmtmc1Ju847OpQE07u/siVBJkTpWHtH3OZlUSs4/9pRTZjigi5UA4fNFFyo8NSrPUGH1qrBipQWPPc1ShzhOYmejGUk51Jly6Xz3lJluDair81mac/H5tDyEIiodOP3pwUnNSurcuC7+YiTtY5ugHAU/N8HPsfQIvfFsTkfRxez/6HXyvBAjyL3Ws+CH0G8S9Azuu4/f/Hhz2cEiD6SSP0Ese4um4rUseBaAAsCkS0N3j2roSCxFvS57rzlVkMSlPwNnusg64G0E3d76zX6uoYBSQSuGfWYH5Mq3KhZ9IhyEELNRNCDE5Wm5bnvCmo4wRqzFWTDXW4nWoRptA/hani7VQJTd5bYmRzxuxSCP366qmTaDa/Vdo7h1/3jJOekh2z0zQn13JQLAb/KhRs5lmDNwsedKOlINImRl0gKoNoD+Z5J3I4avUINZSvey0KcxhzPbYEDdSSJV2eHEAkQVM7IQZ2BJ+e/xPplbzPhRDBaDWNEKSmhARgq3sF5r/6ySS/2wDQNkRFz5VbGSeCaZau5FjL2kT/gUbECvoN7GqdpbNM93J078wFujDRCGGULR8svHkG2Wex2IE8GsY+RS4nfFXg/bjNBXeSJ1u2foCTabNyqo39oAfl4N5iCPSHShkEjr1YGFctAhHGvkQ47gV4mUhk08MLjqV8EmwY3Q4w3shKWItL/zucDlx1k0aVx+Rul+pGVyuzqlHeDXL4rb/UzvnOGFVMLPRnETW/rNxK8QfIjF6r/wcZUz/aFj1hyRSAV1lO36OYGZS9/rYnJktJPgyz/3cGMQeIJpD3zMVGOgWcu8yo0+OYHQOK6zUP6JosK/7uhqS2dpq1wJzF7HDgXyW64X7r3sGypG 3Giegx8b 2XvlJdEdYN3qyzcXDXfChe2ifM3s4gtxtSwnFleGpPpy/+1W5G1lAO0/TVi5Gwc6B7aqOTADSEdYHU0Kgv7dyP/fOevYMGy2rVpsKOKYHQHPPFyinRVlWVrOxQPc1T4c6ZXkOHSXSSN0b7NJnmVBoLv3w4LgloCrSr0Z9wRrEth20YH/Ty8sR6HOKYkQA85KRipwoYu3ItVbelgjftAtX9DhKTni7XEZxK4rjVAsMmWE1qsrkRUilBcqRTVFe8f7KX/IQWZ0Ht6z3xLcQD2HpVHM82GD7IEsSCZKi/rKsOQn8JQK8pRikE7X5DxnuBD4YqJutNtOn0zOL60OCKmg40Rjtj/fcDRFOOrylPzet2g/lMwFMDXYGO1XjCwuBMLy7FJetLxT8sfYJAXE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, May 8, 2024 at 4:10=E2=80=AFPM Shuah Khan wrote: > > On 5/7/24 15:38, Edward Liaw wrote: > > 809216233555 ("selftests/harness: remove use of LINE_MAX") introduced > > asprintf into kselftest_harness.h, which is a GNU extension and needs > > _GNU_SOURCE to either be defined prior to including headers or with the > > -D_GNU_SOURCE flag passed to the compiler. > > > > v1: https://lore.kernel.org/linux-kselftest/20240430235057.1351993-1-ed= liaw@google.com/ > > v2: add -D_GNU_SOURCE to KHDR_INCLUDES so that it is in a single > > location. Remove #define _GNU_SOURCE from source code to resolve > > redefinition warnings. > > > > Edward Liaw (5): > > selftests: Compile kselftest headers with -D_GNU_SOURCE > > selftests/sgx: Include KHDR_INCLUDES in Makefile > > I appled patches 1/5 and 2.5 - The rest need to be split up. > > > selftests: Include KHDR_INCLUDES in Makefile > > selftests: Drop define _GNU_SOURCE > > selftests: Drop duplicate -D_GNU_SOURCE > > > > Please split these patches pwe test directory. Otherwise it will > cause merge conflicts which can be hard to resolve. Hi Shuah, Sean asked that I rebase the patches on linux-next, and I will need to remove additional _GNU_SOURCE defines. Should I send an unsplit v3 to be reviewed, then split it afterwards? I'm concerned that it will be difficult to review with ~70 patches once split.