From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6500C10F1A for ; Thu, 9 May 2024 21:19:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 305476B0098; Thu, 9 May 2024 17:19:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2B4D06B0099; Thu, 9 May 2024 17:19:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 12F3E6B009A; Thu, 9 May 2024 17:19:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id E7EF26B0098 for ; Thu, 9 May 2024 17:19:52 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 7B2DE1202EB for ; Thu, 9 May 2024 21:19:52 +0000 (UTC) X-FDA: 82100124624.27.257D986 Received: from mail-ed1-f43.google.com (mail-ed1-f43.google.com [209.85.208.43]) by imf19.hostedemail.com (Postfix) with ESMTP id 9492B1A000B for ; Thu, 9 May 2024 21:19:50 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=hbOBfMF5; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf19.hostedemail.com: domain of edliaw@google.com designates 209.85.208.43 as permitted sender) smtp.mailfrom=edliaw@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715289590; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Qgi3h+IjdR+qGYdA2wxHQV5wR5eEl2tpr3YsgoeQfBs=; b=WZEuveVFtZF1yrYGIp2vuEofV2//PhUv03dbJkFI8DiIg/T6nKUaYPD6db7BqD9VWi0PxK Tn4q/MYOmK/NpZVCAuqadyX2PorMIpEijzlzTQhJj24KQEwq/zYMfKZCqHzyuPhLpj+Ns9 PklGdLbe9EY/uAnrfbfSlnli1EvP75I= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=hbOBfMF5; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf19.hostedemail.com: domain of edliaw@google.com designates 209.85.208.43 as permitted sender) smtp.mailfrom=edliaw@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715289590; a=rsa-sha256; cv=none; b=J4VCz5uCFuV990KUnYPeDTz7bjBJ1SHjJKc6VLX836hXWRjHb3ulMyzVhbownxUQYb0sQG Sfe9IQOfG4VpqVNAHFehZ7o0q3tmpWTGwrQBofkrJGdFU/RNv1gXeAJWp4kR/iZAcKDUsW 71m2pM0fRyS5KGnUn1n2bXtBzfB71R0= Received: by mail-ed1-f43.google.com with SMTP id 4fb4d7f45d1cf-572a1b3d6baso1771a12.1 for ; Thu, 09 May 2024 14:19:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1715289589; x=1715894389; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Qgi3h+IjdR+qGYdA2wxHQV5wR5eEl2tpr3YsgoeQfBs=; b=hbOBfMF5pV5qwXOLzHceLXHv/EtABMMHM5f+562BNsuL1OcY3LSiJkCXMDWvCvXf7g KlHSwdh6gw0V4WRkOAbF1OCsXDG/REGZQoodXmHCEUox+UUSy8O3JtPiEAPB9is3iZHp 3LRMDIQJ3R0FcysUndpa2Frgc08edcm16H7DcMWSC1/hlZdSPNA+9xoF3d0RsM0/ojAu VtkDO54wJoJBJB+CWDayQSaHL3mKbjV+5K2QeflZEDcm2L36fPOq4wj6uLm0RkGvPubW 1ZtCG4WqhkUi3PlYapiE1omnDcPQ/7EA7DohvMR+LjaqyaOTZgTSga2n01UICvwykLhh +naw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715289589; x=1715894389; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Qgi3h+IjdR+qGYdA2wxHQV5wR5eEl2tpr3YsgoeQfBs=; b=qFLUbgzvWhYcIqY5jprpXAOKCtDPedobOqFWt1iDcbRZeECdjTdxQaOtI5KN266M5L XbPBxZA6Py+I33Zc6hDRX4yT7YVO/7OQp3laDReopQhsVi6rQiITZB4a8of7tA1yEHuL hMI+aTMYNZ5xfO5HO2X1EY4rCEO6EdtWpddfDAyyLAJCo8J/LoZMGl1jP4vKTMGQjgwR 15c5qGCunpN249Vkhk4fYTpinJYcHHPFytketx3cG4kry873fiX02LF6N3GYqlkSLw3N QXp8uGnubi2j7KN5n3TBdwyu80Tc99tbIouSEM6N9uX2E5uS9oT4j3k/sv67DN/3vVCI FEVA== X-Forwarded-Encrypted: i=1; AJvYcCUumKOhudLM1KL8OKBEoFTXJEPAfPoooNe7RL6gDV2/K0RhcOceoF71Q+JhdKko2kWaUZTGrR1rKqdVMsbcdWNf8Lw= X-Gm-Message-State: AOJu0Yy99tGCmNLLcCv0mCzbdtLg2l+s///TB4GEhq3nLUta7lCqPQux yDW/oEGua2egkm1P3qchkGBSpk4UNb9QkdAneivOeQbD3MTLzUaDWQ8FdedjTE9TrnkYn2O2xvL stlhGKZkTuvV1Fdj5MwJUIO4lpJ5gZNAWz7nZ X-Google-Smtp-Source: AGHT+IESFwBeKEPJHXIvjKnYagQw1HEdTMzk6jry3RDX75zlENIpGV8y1GohMsEmGFBkNbvjuiuL//wMmjE86393x/o= X-Received: by 2002:a50:85cb:0:b0:573:438c:7789 with SMTP id 4fb4d7f45d1cf-57351de5880mr11488a12.1.1715289588869; Thu, 09 May 2024 14:19:48 -0700 (PDT) MIME-Version: 1.0 References: <20240509200022.253089-14-edliaw@google.com> <20240509203113.63537-1-sj@kernel.org> In-Reply-To: <20240509203113.63537-1-sj@kernel.org> From: Edward Liaw Date: Thu, 9 May 2024 14:19:23 -0700 Message-ID: Subject: Re: [PATCH v3 13/68] selftests/damon: Drop define _GNU_SOURCE To: SeongJae Park Cc: shuah@kernel.org, =?UTF-8?B?TWlja2HDq2wgU2FsYcO8bg==?= , =?UTF-8?Q?G=C3=BCnther_Noack?= , Christian Brauner , Richard Cochran , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexei Starovoitov , Daniel Borkmann , "David S. Miller" , Jakub Kicinski , Jesper Dangaard Brouer , John Fastabend , Muhammad Usama Anjum , Andrew Morton , linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, kernel-team@android.com, linux-security-module@vger.kernel.org, netdev@vger.kernel.org, linux-riscv@lists.infradead.org, bpf@vger.kernel.org, damon@lists.linux.dev, linux-mm@kvack.org, mathieu.desnoyers@efficios.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam01 X-Stat-Signature: jrycntz83mswhicf4ju5acxu6gz3ubam X-Rspam-User: X-Rspamd-Queue-Id: 9492B1A000B X-HE-Tag: 1715289590-635326 X-HE-Meta: U2FsdGVkX1+TcnlHfVBYjSKfxtLH5zc//GqsE6TxwHvXEB5pJ+6SfoTV6/z1ThrOWCflsZjDWS/vRrU1Y0tGD0eKTZrj4cLEsvYnchD1L6GEmEtlb/IvVkTCmeGJ5SV428yVw7H667GsUvuBWHlH/xAOXUd3ImIA7SsWRbr6Hfe27BqmFWUxzW1aR1ZRz/se5C0lfcnIP8T9/rOs2sqLBfoU/5XJYr8i6P2DO8TncloWYdI7wBpfUxf/2bLaSZGMKGNuN+kmw/dKR1tfaBZ0GiXcjJ5W27i30LJbJkBA2HLHeVAUJU0qgfyqrJCK1mJEwEX6EH5uBjrVGNTaFdbo6WK7Lf8v/SEWQwyTTXwBuozEnVqjv6k/rOPy1cRi7KWqULRe3cJTRJncKgMCDgdNmsWNXWkbFC6VO9O/oHXC7qWD7pERN1IdKP1C6OgZo7eXq7q6wLVoMPCDg2NJv9ACBb/mkdb795nJv0nSrPyLlrRRkDVm0DZO0JnbpuDpqDrr/AvR++8LTGtPwHv6obDVdsxbj+ejJ1i3BqngoUoYSG/s/gG421ahwoc4G5vm0msmkEkQZNOanqhmrGmSFeZKo/XtuNTcXytV51/mwXxju0wteQNpUVBQ6Hon/iNMYWz6C8M6amzias7iEx1v+/JR9HaFKDD3Ek99BOYt7LrNrp6PTppyDM3Q7bb3OiO4aW9n9VGvkhAXBNzuywnun4fginpsHOmT6rWA2tMcZcc4NKqLmLbEQXIuudmiWITs1zDQ/6+/+KlJCSveMZwUucYyRSTfPkgAkaZXUVVh07ktRUCqlo8gY62pm09oelTqdzX/MGB3/YZbUaEniTZ6ERMmdWH7XQK+8Meh0iLA8VEVskE4qhIqQ5FC7GARj8uDXN+YXcu9d/+vUNfDAYSSi7ZLhhT1NXvxD8Ypnsx8yAdRi7B8Ta6fzgr3TXOGDzIkx7Ia5pOmjKJACiDNnSEd7A3 1+e/uqK3 55hDlYsEsw2xwgYLbR/enEMTOU6p84H1R757zs0S6KPGaxiPB4jFJqTuWhQIzlxsEiYG3LnsQaQzdpXzm+qRzAwNvGGv8jtQqgfQf0m4lDbA34/ic1VIwBhnu5l1MTMd6ESxWdwGIyhXeGuMssYuXW3OmBzEUJwke2WvUvchtdt7Zi8EY+ONP5/t8CnPULFNBFQHY28tKJj75iNFsfJqT1PXcRn+Q/a5U2r4hl7qgbVMhTn8mozycOuwiqLj+5OvEG7F2zQ7EwejoVwp/H+ihSejukh0y5FtZAUqeAgfEkU3XK3uB3heSn0oicUoFaPiJJSz2mcihkD8KoVRF1PdOOl2XZ8ZrOb35lqvr17HukShRv0K21Gd99RXPDlqHSlmvXyasM3v2b8mm6Ol/C1HWZj1eSeKTpX+4OPD3se05Gog2Tvu2pBxWMdqGqifVzDt6pAGJ04mtQayRVRah6CBJgzwrhtMB5D8aCce62xbXx185mb4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000061, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, May 9, 2024 at 1:31=E2=80=AFPM SeongJae Park wrote: > > Hi Edward, > > On Thu, 9 May 2024 19:58:05 +0000 Edward Liaw wrote: > > > _GNU_SOURCE is provided by lib.mk, so it should be dropped to prevent > > redefinition warnings. > > > > Fixes: 809216233555 ("selftests/harness: remove use of LINE_MAX") > > I show Mathieu's comment on this[1]. I have no strong opinion on this, b= ut if > you conclude to remove or change this line, please apply same change to t= his > patch. Will do, thanks for reviewing. > > [1] https://lore.kernel.org/638a7831-493c-4917-9b22-5aa663e9ee84@efficios= .com > > > Signed-off-by: Edward Liaw > > I also added trivial comments that coming from my personal and humble > preferrence below. Other than the above and the below comments, > > Reviewed-by: SeongJae Park > > > --- > > tools/testing/selftests/damon/debugfs_target_ids_pid_leak.c | 3 --- > > .../damon/debugfs_target_ids_read_before_terminate_race.c | 2 -- > > 2 files changed, 5 deletions(-) > > > > diff --git a/tools/testing/selftests/damon/debugfs_target_ids_pid_leak.= c b/tools/testing/selftests/damon/debugfs_target_ids_pid_leak.c > > index 0cc2eef7d142..7a17a03d555c 100644 > > --- a/tools/testing/selftests/damon/debugfs_target_ids_pid_leak.c > > +++ b/tools/testing/selftests/damon/debugfs_target_ids_pid_leak.c > > @@ -2,9 +2,6 @@ > > /* > > * Author: SeongJae Park > > */ > > - > > -#define _GNU_SOURCE > > - > > #include > > I'd prefer having one empty line between the comment and includes. > > > #include > > #include > > diff --git a/tools/testing/selftests/damon/debugfs_target_ids_read_befo= re_terminate_race.c b/tools/testing/selftests/damon/debugfs_target_ids_read= _before_terminate_race.c > > index b06f52a8ce2d..4aeac55ac93e 100644 > > --- a/tools/testing/selftests/damon/debugfs_target_ids_read_before_term= inate_race.c > > +++ b/tools/testing/selftests/damon/debugfs_target_ids_read_before_term= inate_race.c > > @@ -2,8 +2,6 @@ > > /* > > * Author: SeongJae Park > > */ > > -#define _GNU_SOURCE > > - > > #include > > Ditto. > > And I realize I also forgot adding one empty line before the above #defin= e > line. That's why I'm saying this is just a trivial comment :) No problem, I will add it back in. Thanks, Edward > > > #include > > #include > > -- > > 2.45.0.118.g7fe29c98d7-goog > > > Thanks, > SJ