From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70195C2BBCA for ; Wed, 26 Jun 2024 01:22:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AD3526B0089; Tue, 25 Jun 2024 21:22:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A83FC6B0092; Tue, 25 Jun 2024 21:22:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 94A3F6B0093; Tue, 25 Jun 2024 21:22:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 723E66B0089 for ; Tue, 25 Jun 2024 21:22:00 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 27CB2A2380 for ; Wed, 26 Jun 2024 01:22:00 +0000 (UTC) X-FDA: 82271288400.26.440F41B Received: from mail-ed1-f42.google.com (mail-ed1-f42.google.com [209.85.208.42]) by imf18.hostedemail.com (Postfix) with ESMTP id 587D51C0008 for ; Wed, 26 Jun 2024 01:21:58 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=qpdv2GwO; spf=pass (imf18.hostedemail.com: domain of edliaw@google.com designates 209.85.208.42 as permitted sender) smtp.mailfrom=edliaw@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719364910; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MDXzXy/x3VAMGE4telAkJ0AkS3Dvfn3YkfUIsKfqDwQ=; b=20KO/842fPiIPH6CVUu6h1FoZJOQz3X0i9RFkLNhMnvChq8D1rC2UxATcelh4hU1OUPfaW tKGJFfpgpU+BYO9ecWEDEXtAV85DWCEAJ0BMEhyqApYvdQ94vbCVZhGL08PaOxfXNyr+NX xg8OhmHfVjkub0sAtF+8Z+0UCb1/Yyo= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=qpdv2GwO; spf=pass (imf18.hostedemail.com: domain of edliaw@google.com designates 209.85.208.42 as permitted sender) smtp.mailfrom=edliaw@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719364910; a=rsa-sha256; cv=none; b=ACdB6P9X+LVtCizviGREcVS02AiuiJHNOb4XYctQVOvxiNrtl4dMcrPh0Rij93nPOLIW7W V7cUiIaNwLj/McJPzG+EHRp/mYmkyOtNRDDly+xoSPGQMOAI+9WsNU35sQTY79jYA/fb6F tr26orZaYRfLedE03HE03lmidjqOyCM= Received: by mail-ed1-f42.google.com with SMTP id 4fb4d7f45d1cf-57d16251a07so4130a12.1 for ; Tue, 25 Jun 2024 18:21:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1719364917; x=1719969717; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=MDXzXy/x3VAMGE4telAkJ0AkS3Dvfn3YkfUIsKfqDwQ=; b=qpdv2GwOgb2t4nWPbi384vn6JLS93h3V+yHalpq6xQ5vYAOkCFwwKOKMd3HatSnKOU BI/i3zLuhVlDGvAEkFgiUpI2231s9BfOt2SnnumDvKdxJgCIiUl8jUMCQcVlOHX3weUM vjMzlTXNRcieBLIcZiluI7Snl9hNXeqPxG/A45pLoNweqEHQlDevKdOwxrBIdl5R0V1X OOx1dluo4ExziEL4dA7GO3r09NH194r1BZT5dG5LdP4ilLny4Ex57PUZ2syIK4G2xumT qwVUaCeeicwj+TvTrphGGS8NraFcFHqtvjyYShU9aj8XxtK0Kq4WuFRea7Rd3qNkMDwi eSrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719364917; x=1719969717; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=MDXzXy/x3VAMGE4telAkJ0AkS3Dvfn3YkfUIsKfqDwQ=; b=G0DMEtiUbIxiObBFeJey7hu93/SEOq3/VDHiwVNsmkX9qGL4sC0SW0k9JlFTZYThx3 jOXosPY5mEUfxPxM3NP8t4LF1VU7KOIxuPqCIHdOaMEwdtmj9o7GbXjXtbdZLlb9A69L m2A48rToNawROPRkfdYWg4ipxM75NJyzc6H+iVZLiWqqG5POxAIBOkH5ure5hisN0uuq MpkE6sB8vlDIn6qQZHtQRnECx/+Ca2X7i6dd213OaupLTL0McfuYWgxslkMBc38ywiq3 s9Bz2KCae7PpgxC95upI3bYuim4uiQhDergIWA+t9IlDIoxHnaHQZFEXmOfHSJ5ctxM/ Wxzw== X-Forwarded-Encrypted: i=1; AJvYcCX5I80DL7zgS9yUSTzI0nwOW4ngRSI9F4060WDlwkiOn46tAsuLJXT7+NECB6xTTWJ3YITnr8v5ePMRcS1oe4WTcNI= X-Gm-Message-State: AOJu0Yx0QRccrwlxVuhbqRbinLo73IYZDdJiCVEPG5OibqKFznkH4WWx av9Ckx8iQu13tRseW6xEu9ekXhwYo9ytGbdaB8V2QdRPMuntBrjYs2NprgtBgKeXIF622J64+5m brYcjxmAMOvx5AgEp0rXBXVeYQ8XLUoYGCWnt X-Google-Smtp-Source: AGHT+IHX6Dw13lvp9tA5r1Nr3EDVBrqZjzt46+AZrMqkD9VDrFcqyfsc9zQwLVqS3nH7c8fc7LBij/O5GqbVZ/GRwBU= X-Received: by 2002:a05:6402:350c:b0:582:f117:548e with SMTP id 4fb4d7f45d1cf-5832c353bf0mr116598a12.0.1719364915083; Tue, 25 Jun 2024 18:21:55 -0700 (PDT) MIME-Version: 1.0 References: <20240624232718.1154427-1-edliaw@google.com> <20240625135234.d52ef77c0d84cb19d37dc44f@linux-foundation.org> In-Reply-To: From: Edward Liaw Date: Tue, 25 Jun 2024 18:21:27 -0700 Message-ID: Subject: Re: [PATCH v6 00/13] Centralize _GNU_SOURCE definition into lib.mk To: Shuah Khan Cc: Andrew Morton , linux-kselftest@vger.kernel.org, Eric Biederman , Kees Cook , Shuah Khan , Thomas Gleixner , Ingo Molnar , Peter Zijlstra , Darren Hart , Davidlohr Bueso , =?UTF-8?Q?Andr=C3=A9_Almeida?= , Jason Gunthorpe , Kevin Tian , Paolo Bonzini , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Fenghua Yu , Reinette Chatre , Paul Walmsley , Palmer Dabbelt , Albert Ou , Jarkko Sakkinen , Dave Hansen , linux-kernel@vger.kernel.org, usama.anjum@collabora.com, seanjc@google.com, kernel-team@android.com, linux-mm@kvack.org, iommu@lists.linux.dev, kvm@vger.kernel.org, netdev@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-riscv@lists.infradead.org, linux-sgx@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 587D51C0008 X-Stat-Signature: xjeb4znznaqt489pncm7o94cbjbj5tdp X-Rspam-User: X-HE-Tag: 1719364918-893257 X-HE-Meta: U2FsdGVkX19Yea0B49RiTQ3+LJCCYwzYnm5psJZqQBI+wsG0ON7iNNW6TOlb2DjloX6earypRVeUWiSelRuxvPcoLwbA/L88phHYZeZ/I3Z5j/d3BxWMogGVvFC1hFtjLAAPxM6G/Qi4oOXzZAvkkYPJd8brcFWtUmaYo7nkdjKNV6t6QVtrhSkfo5mF/yIAphsq5q6lIX/eaT/+sRjl0OCUIyF8UM3wTTY9MksjiJrOxg+B9LplJFlGXuFBKwOTFFduA4sTsABrMAqZ7IotaKkDifm0NF4c8nFwhi55qJ14vS/u3Xh+2HErifNGROq4JU8sruvUANnrEpN7KP7LmBpWbq2Vhe31cIM9zJAN6b7zGIHemBd1EzxXVTgv+eJgBKMRGj1b52vFXQodb5VRLUQHW88U9PD7qwIEGBmK4L0VZPoF+a/00c0AvL/bI2bZHQmWY0DEnzNgE7s9zz16HPORmLZjYCO8S7PUDa9AdhKyLPb8wXvl6rnsaopx32OdajVGUhbMVmEdbb9+9ZHZLeQG0GgPjfQXQJ9vW1r1Z+wvkKzIeTCzQdB0w2r6Mb5y/z24t1puPX2G0RdjQ06yVY6ylkMOM0+Ll8IF6tUfQE72ONtx7b17FsLuekYGTzb/3pu/liXbTxTiOYKhW/tYuJs0pEEeWc0YQLRbIofKXr4MTIwVGHe4rDjkzFtLEKW54q4aOBCCaZxeao7u/86VddvRv3EVtgC6I/s0X+dlS59fTZdirrE1dlmhy8sQWd+YlOlp9MWAxrstk7JH9vZgXCoZl7Sf3YEMQggOKPB1ae2QI5H7ybDAGxz3EkebOcrlv6h+iTnYGYezEmAJT+sIiZV/WKdGU45UA3y/BGnKAAp5/DeEU4o8HfLy+t0jscMxwJKOVfNh1ZBJXxAfc9EwoTSlw7Omp5WI0WzY0pp3DE+4wmwUkuX/m5TbJgZysxKUXefOrVJp59DRgp6/A+t YstooUe6 0pvTgPiW4a4iIa3lxDKNfG69Qc6r18PGz5RblK//ywns7did+W9JUsWUzUozBbmDJaE5U6Fg1h3eQzDj8PkYjZfAx1BLfkXR8rpx9bKOxJ5pACeSIDojFgyFUy3P/JIddDj9KICIoO5G+ykmlzYR7R4SrlsWKCWOvnWg6JYqgdqc5F5Gu+ElusB66Y5Xxj2gHyrGI7vxyAtjhfgxTEXW42CLjGA6Z+8VhS+WokQXDMeYNUCF5utBCMzK+UrHJ25Xb/LxthXLMitsU0u+G4/UTWIgKFZOpL/ftCccof09fEh/fAfDVIVvrbtHkWlgW3LoKUxcE8iNkZnEFkF0s+MCEvqClLFiF8YCm/p5sKRSNhUTgUGU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jun 25, 2024 at 5:41=E2=80=AFPM Edward Liaw wro= te: > > On Tue, Jun 25, 2024 at 4:34=E2=80=AFPM Shuah Khan wrote: > > > > On 6/25/24 14:52, Andrew Morton wrote: > > > On Mon, 24 Jun 2024 23:26:09 +0000 Edward Liaw wr= ote: > > > > > >> Centralizes the definition of _GNU_SOURCE into lib.mk and addresses = all > > >> resulting macro redefinition warnings. > > >> > > >> These patches will need to be merged in one shot to avoid redefiniti= on > > >> warnings. > > > > > > Yes, please do this as a single patch and resend? > > > > Since the change is limited to makefiles and one source file > > we can manage it with one patch. > > > > Please send single patch and I will apply to next and we can resolve > > conflicts if any before the merge window rolls around. > > Sounds good, I sent: > https://lore.kernel.org/linux-kselftest/20240625223454.1586259-1-edliaw@g= oogle.com I realized that in this v6 patch, I had accidentally sent it in the middle of a rebase, so it's missing the last change to selftests/tmpfs. I've fixed it in v7. > > > > > thanks, > > -- Shuah