From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0725FC4345F for ; Tue, 16 Apr 2024 19:02:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7AAE86B0095; Tue, 16 Apr 2024 15:02:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 732F86B0096; Tue, 16 Apr 2024 15:02:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5AC3A6B0098; Tue, 16 Apr 2024 15:02:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 36CEE6B0095 for ; Tue, 16 Apr 2024 15:02:50 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id CCBB3A0C9C for ; Tue, 16 Apr 2024 19:02:49 +0000 (UTC) X-FDA: 82016316858.24.302038E Received: from mail-ed1-f45.google.com (mail-ed1-f45.google.com [209.85.208.45]) by imf24.hostedemail.com (Postfix) with ESMTP id E2B35180027 for ; Tue, 16 Apr 2024 19:02:47 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=bj6wQFZV; spf=pass (imf24.hostedemail.com: domain of edliaw@google.com designates 209.85.208.45 as permitted sender) smtp.mailfrom=edliaw@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713294168; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8oDUW4EeE2y3eu+7hg+U3G0Qvv1xPh4qHLJznsNFoiQ=; b=4L2PmdqjSP3dTqw3ETZ+tGRvWLBcR0M3ARoCgm3LMv8YUWfvHIoPtCYQaF5OGJd3u5xe5q YnrvuGiiVbl/SGu3tIFNf8LbUZ0CNhc9Ge/1qVIBdR6oahVwz1mmZddtX25sXafDJJKG2S kPlYReOCzOrogeDjtLqMrY6Oo9HeOJU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713294168; a=rsa-sha256; cv=none; b=5o+XYx0bHv09nMMOn7urorwuA5yx2ostO/REglVBeLWb+coDtRr2m3AeF5fdAJPjGX7Tfn SAg/Elp6ufLogZaQn0eAsjHcsSUxVWs87pXVnavgVEQFPXJj6aeDPcGV8eJRRJCetGuwaZ NaDdvcmwA/lAbkOrG728jXd2dAiuv90= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=bj6wQFZV; spf=pass (imf24.hostedemail.com: domain of edliaw@google.com designates 209.85.208.45 as permitted sender) smtp.mailfrom=edliaw@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-ed1-f45.google.com with SMTP id 4fb4d7f45d1cf-56e5174ffc2so2634a12.1 for ; Tue, 16 Apr 2024 12:02:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1713294166; x=1713898966; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=8oDUW4EeE2y3eu+7hg+U3G0Qvv1xPh4qHLJznsNFoiQ=; b=bj6wQFZVHzhaNm2xWlkpjq236rF7Ve9B/XHfm3p3qkkJzcsDuNzTj2k0JyiIHm2mSV Hd2yzrMNQeHNTPQ17V+snGbT19HXxSq3fQfeZCmpzb+fb+KpjnM6Mb1U98BLLHzcON5l d0Ubg3L1lyxZ4yLdWvISw/KkPQ3S8zZ+OvfE9b69b5I3V3wu7Ht+eqmfyB/7Vm3mSJqj sk0IY5Oja/zBEm74DKGCCFRJjeMl1a/J6EvgJD7y1MbraBF/m/el5uYLFCSuEQ/4b66d VuCftnlqi0BNOTt9BTsPdvfnQc0G47n7HQyPy4G0ZQpH37iM2rtYFYzclgaiVrsS7bMf eFEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713294166; x=1713898966; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8oDUW4EeE2y3eu+7hg+U3G0Qvv1xPh4qHLJznsNFoiQ=; b=YQA2oT9qXKTaO9s0dvHMGpakTC60Yql0qjPMQl9WOwPNNmwFqwr3e7aXjvt/wqIkW0 qyAAtOBx8pDfUQ/2XNaAxRWfpsyhcCqih+4hnqS9mxUEAwaiuBqtY1NB4Tj1lm+ltGcO LmiUKPKWwb5mK+QsdSUTQ0MsK7ni1xX8r+zFnukuu5tBH9WbP6Ph01cvgdWEMfB+OnQX 4ZIQd+Yhpbr89nFD52DKx1WnehRKUWzLuXG3TVdPcMV0/zkn3prdO6rNOS4gp5sVGZlx 4pZiGhG5bdNNB7bmTtgFRz5MnQ2nyGSzbSPg5pZX6n2JPWVblzRnEe/vQXD8GrgbJB7m txFw== X-Forwarded-Encrypted: i=1; AJvYcCUDVqEAS7M5eIpUoCV1MkJBh6ecCupU58hd53JrCKU1dBfkxuTi6tK/u06M8garCWpHM7tZr3MKEnm5fWsVCPjVmF4= X-Gm-Message-State: AOJu0YzHzq3kpvfnEq5ki9T63x217NiSXlmKNxGhg2gn18mU2dgL7Tb2 kk1llH8OZTgQq9BdKeZIkVZp6hXEg5FSfcVdKHHsTaayJ+AEl00ekLxVtrO/le+HHjcmpTsnB7Z 59OuymAtdH/wrUGyeUIj1ezpK3d+jUZ8+r/v5 X-Google-Smtp-Source: AGHT+IHYMcrDT1eTfVxvHodCk6Yora72MtXDdoyo6Y6bPBcREeOXinjXeyprZ5qUX8cVpwMb1MCbnFNg/FZgdvirOGY= X-Received: by 2002:a05:6402:352:b0:570:fa4:97d6 with SMTP id r18-20020a056402035200b005700fa497d6mr38389edw.0.1713294166126; Tue, 16 Apr 2024 12:02:46 -0700 (PDT) MIME-Version: 1.0 References: <202404161023.K0EsnDmF-lkp@intel.com> <20240416114439.038054b9c33986a13f4757c7@linux-foundation.org> In-Reply-To: <20240416114439.038054b9c33986a13f4757c7@linux-foundation.org> From: Edward Liaw Date: Tue, 16 Apr 2024 12:02:18 -0700 Message-ID: Subject: Re: [linux-next:master 5507/6266] ../kselftest_harness.h:1167:9: warning: ignoring return value of 'asprintf' declared with attribute 'warn_unused_result' To: Andrew Morton Cc: kernel test robot , oe-kbuild-all@lists.linux.dev, Linux Memory Management List Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: E2B35180027 X-Stat-Signature: gj46zffcbyyn9uf3qakbwxnaqkcirara X-Rspam-User: X-HE-Tag: 1713294167-534976 X-HE-Meta: U2FsdGVkX18HgHOm7fUlIsYTp8UuBh5p8cb0228Badw91NGKIuoV2/ODV3iZTTLFm2rZnvLUntQcfWuCzbrQpJMkmQ+Vg3NaQjfjzkrDcgTLU998zX9A5VhR8abrstLOo//KcpiRNZPQb+HeVUFfqFz/5zXougW7kdpXi5rC+q4xN5w5NbcOBhIQ/Usr0kw/bH9QENk3s+AEulcgH7JWTeYPrhVK8wtz9uIZZInwbsu5PxtKZ6P1TggYa/rmbRVwhrFQXq91nyUvXK48xZe6PBRj/ddf9w0GrVhY87qfw9U9HDj/Zo9khpBrZBQFa/JNH/TFrWXD17Qej3QUWNhFXR5m1Un133h6b5sYvVzug9fJO+cpHZABUK7DSCaQzyQ6mf5z+Rns5Tti4FeIBsCi5RdFW0TB09D/NKktynI1GHiCNK6UXTaKmUXvjxfTLc0IXTfS+ryHuTprio5hgONvHX9DvoBSjImT55KlRSjRQgMGRXnZaxzOSkU7VZLqPT9JOAAdvAEehIDVRsSXxzp/coYkjDbclWYkTQAZWwRkikOv9o3Ga8DoZrBQ7Kc51ZfTZ5Axu8+427kxcA5gIsDHKOH418nZEbm72LorpnKXJb/hpFafCwUC3QFtDg+ZE3TPURMfJULysGvHW85yd6Z+yGCDl4cb3XKVugrmRR98FnDM5OqLbCt1RvsBppFgFHux60dckZ4L2jyjBVF5nk8tQUO9vtwHoBbUArF/bZyaU6/dJwORVuzu//GpA8njHN52Dbwg6eu/q4VcvTK6neauQsmkgeBMm9adJIlyaY06wel7A9MIXGHy/szl4a7W0Fi5MRlD4SFNtJmry/3yxeSOOXmRzsWdKJa/Azb/NG1Wmp8tqI7UpES3woOS3OT4Ybmg6/2iPFIa38yq/R4EgRT6ZkD/aZZQSB4IYiq3u7P3f0xrTiv1X5MV7CUn5eIvMh0bskv1DPx2QpiNQ4XtdqR ShVSa8uO mjTL5sKFmUQ37IBPTwn9tjuODau3JkoteZaztW6OP5KFSKDKqEzfcXx67Qr/00oaAFgWmgCjHGY0qCqvG1RYPPCSpQOG9ngC2IO5E6AQZYr7lopx80uRoNd6tMMukcSDpItV6KZyrF29GOVa8aTyrg90B3PWIM7GsiUxNveHO4ZRJE7P/t6OqPaup6qQRQD1jFtu8YOq9urXGqVQE72eT88QPs86bdkzfSMk/59LGV42QIlAaqbGgv8BFgHZoyCXMX5yXVmpJ6soQeA6FD2DC6hewaLGLxP97rflnoYGFdDYWxTeuQIZSKjSxCoOHaMZYi8544XzfAq4iD2HlPi/UWcFvML1BJDwqXtE7 X-Bogosity: Ham, tests=bogofilter, spamicity=0.001031, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Apr 16, 2024 at 11:44=E2=80=AFAM Andrew Morton wrote: > > Thanks. How does this look? > > --- a/tools/testing/selftests/kselftest_harness.h~selftests-harness-remov= e-use-of-line_max-fix-fix > +++ a/tools/testing/selftests/kselftest_harness.h > @@ -1163,8 +1163,12 @@ void __run_test(struct __fixture_metadat > t->trigger =3D 0; > memset(t->results->reason, 0, sizeof(t->results->reason)); > > - asprintf(&test_name, "%s%s%s.%s", f->name, > - variant->name[0] ? "." : "", variant->name, t->name); > + if (asprintf(&test_name, "%s%s%s.%s", f->name, > + variant->name[0] ? "." : "", variant->name, t->name) =3D= =3D -1) { > + ksft_print_msg("ERROR ALLOCATING MEMORY\n"); > + t->exit_code =3D KSFT_FAIL; > + _exit(t->exit_code); > + } > > ksft_print_msg(" RUN %s ...\n", test_name); > > _ > Thanks for fixing this, that looks good to me. Reviewed-by: Edward Liaw