From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A43CC04FFE for ; Wed, 8 May 2024 20:28:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 955326B00A3; Wed, 8 May 2024 16:28:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 904526B00A5; Wed, 8 May 2024 16:28:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7CAAC6B00A7; Wed, 8 May 2024 16:28:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 5E7FF6B00A3 for ; Wed, 8 May 2024 16:28:15 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id B1A00A1008 for ; Wed, 8 May 2024 20:28:11 +0000 (UTC) X-FDA: 82096365582.10.94CF41D Received: from mail-ed1-f47.google.com (mail-ed1-f47.google.com [209.85.208.47]) by imf04.hostedemail.com (Postfix) with ESMTP id D50464000B for ; Wed, 8 May 2024 20:28:09 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=ZG4vo2A7; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf04.hostedemail.com: domain of edliaw@google.com designates 209.85.208.47 as permitted sender) smtp.mailfrom=edliaw@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715200089; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VxBCT1ZV/EGWLKjxVs7FXcKu7sqjJfkKsVJ1w+mU1+0=; b=a2CBYVsVXZ8RzxUKaGxndGo/aWY1hC7/ckl3rXmMyEg7Uf912Gsd5KQlejDg6kc3bWIqom i1Nzn7OiHRlWZLtESyVVpMbhAQzKwQto8cq/FFs1czLek2P6XL4ag859iU7OUyVWJzok0K QldFyfmwdFv/IrHnEOoas+SW//WWr1U= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=ZG4vo2A7; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf04.hostedemail.com: domain of edliaw@google.com designates 209.85.208.47 as permitted sender) smtp.mailfrom=edliaw@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715200090; a=rsa-sha256; cv=none; b=EYUw3aT4gr1/eNY1rIc8yp/c5WzBGuQJmuae1iU/lATGws3MQyLFCx68vCWqoj6zbpRGKF IWhsm704DrK62a5S8GCqW7Pj8pA07JCgGgFCA75XliNjXQ8HgAzVHggp//UUGrNRGYfj16 v1mzs3oRP6pvGf5Uu8FXPNPjjamorJg= Received: by mail-ed1-f47.google.com with SMTP id 4fb4d7f45d1cf-572a1b3d6baso742a12.1 for ; Wed, 08 May 2024 13:28:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1715200088; x=1715804888; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=VxBCT1ZV/EGWLKjxVs7FXcKu7sqjJfkKsVJ1w+mU1+0=; b=ZG4vo2A78Sy7L78mykSLeJh7oqb3Rs3pNeZmPblum2LU/jdP70TqF8CIaOh/5J0v0X 0r2FelfMdQwFq3BdabNLEP3a+0FTKpW8UQ1nSJzsqBO6AJL5/2Enhj89KquN1MCRLGz+ xWA2erEVCCtxgb8BaKjPQkQCcxJZ/VUtEbCqQRZ3397yNEUFLafFgwx6LLcUVjvIk3ud QlSsDJGcbOz89CNa9lX6nR8dI44dNIKPFOUo+VIJ7dfUr4rOyITm7lrlgfWCy0OvRfGW YF3jtH9AF1GWKuh+H6XxaR0CaL7NCYkf8outU2EBLmtMgb9hsHnl+SvW+nO5HMcbEPao Vi8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715200088; x=1715804888; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VxBCT1ZV/EGWLKjxVs7FXcKu7sqjJfkKsVJ1w+mU1+0=; b=YHmdojUv799IUbyBEQyLrPfC/TE6+RN90XVFp8klaIVOWGAlEgNZGI5gYjvdJ31ROw 9rJdtSeCm+WFY8P/uTCrm4a3bowIylXwpe1zJPuFsKMy3oGfUxAYuHIaMxPKqEt7iToc LtagRykFfma7dJMJOrVmKHcrDt7XRlkwevbTHBWJcSs287lGId6Euk6UpzjoiAEO3ZNA 9toxMq/lXCphwCkUsmruO14xIOSrhW/ddsszI8y8A/CO5Uo9gmnD8y1Xc3EkJZXHJRZt JdrFK1qSZSgSLS9oMizSz351V0HSnj4p8nmE7QuZimXywPzWHb1HqcU2wQGiIIV+ARua ITxQ== X-Forwarded-Encrypted: i=1; AJvYcCXJzNIpnOFL9DcKn45VH6lU282y7QcP203+RToaYC/EQqAs4ybETcJmAKR3oaCL812W2+0pqwpZSh3rSt7gbH69Nig= X-Gm-Message-State: AOJu0YwOSWnnl6n5Ues2Er7R9ZWImhdXyBfx68RfGyai45k9uAAlKr8t TxBJZhl8ntbh47J+NzwHJITxj4t250bYTYBsOM9QzGt7gfvgAaPbkl9sSNLWhtpc/CUM7l9Ic++ Hxt7BIQQYJGWa2T+9V6AE1qdgNwtLJ+SFnAOE X-Google-Smtp-Source: AGHT+IG0Nkg3RjjAAyj+n+Ew0xyy8RnKsH20og6+OrFEWYycNhxXEo9VK176FECewK/2EQxZ5XFepnMJQqWDZY6gYdE= X-Received: by 2002:a05:6402:228b:b0:572:a33d:437f with SMTP id 4fb4d7f45d1cf-573341614e1mr44879a12.2.1715200087751; Wed, 08 May 2024 13:28:07 -0700 (PDT) MIME-Version: 1.0 References: <20240507214254.2787305-1-edliaw@google.com> <20240507214254.2787305-5-edliaw@google.com> In-Reply-To: From: Edward Liaw Date: Wed, 8 May 2024 13:27:39 -0700 Message-ID: Subject: Re: [PATCH v2 4/5] selftests: Drop define _GNU_SOURCE To: Sean Christopherson Cc: shuah@kernel.org, Mark Brown , Jaroslav Kysela , Takashi Iwai , Catalin Marinas , Will Deacon , Nhat Pham , Johannes Weiner , Christian Brauner , Eric Biederman , Kees Cook , OGAWA Hirofumi , Thomas Gleixner , Ingo Molnar , Peter Zijlstra , Darren Hart , Davidlohr Bueso , =?UTF-8?Q?Andr=C3=A9_Almeida?= , Jiri Kosina , Benjamin Tissoires , Jason Gunthorpe , Kevin Tian , Andy Lutomirski , Will Drewry , Marc Zyngier , Oliver Upton , James Morse , Suzuki K Poulose , Zenghui Yu , Paolo Bonzini , Anup Patel , Atish Patra , Paul Walmsley , Palmer Dabbelt , Albert Ou , Christian Borntraeger , Janosch Frank , Claudio Imbrenda , David Hildenbrand , =?UTF-8?B?TWlja2HDq2wgU2FsYcO8bg==?= , Paul Moore , James Morris , "Serge E. Hallyn" , Andrew Morton , Seth Forshee , Bongsu Jeon , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Steffen Klassert , Herbert Xu , =?UTF-8?Q?Andreas_F=C3=A4rber?= , Manivannan Sadhasivam , Matthieu Baerts , Mat Martineau , Geliang Tang , Willem de Bruijn , Fenghua Yu , Reinette Chatre , Mathieu Desnoyers , "Paul E. McKenney" , Boqun Feng , Alexandre Belloni , Jarkko Sakkinen , Dave Hansen , Muhammad Usama Anjum , linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, kernel-team@android.com, linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org, linux-input@vger.kernel.org, iommu@lists.linux.dev, kvmarm@lists.linux.dev, kvm@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-security-module@vger.kernel.org, linux-fsdevel@vger.kernel.org, netdev@vger.kernel.org, linux-actions@lists.infradead.org, mptcp@lists.linux.dev, linux-rtc@vger.kernel.org, linux-sgx@vger.kernel.org, bpf@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: 3puorr6zpj5aa5xucgt4qj7fbhjj3kho X-Rspamd-Queue-Id: D50464000B X-Rspam-User: X-Rspamd-Server: rspam12 X-HE-Tag: 1715200089-260429 X-HE-Meta: U2FsdGVkX1+RotokN9+SujtkKG14EyD3wwsz3LHJ0OnXOLnku6pI0ZtR5y3yqB63eAohabmxyNYP8Iy7Ru2azaGigP6G7dFtXvd63Q62G2G5BURicKn5Uiy6QDqbPSGGreUpR6qFHgcDJKqayGCr85Dz08NMlL/rhTejYsEnjdJnpDHg5duwapXwHyyQu1DkARmzkjKvIl6YWsjibvUPGJzBl6cLrVLvsGcyTH4Z1xILMhjA07pLV4eCrqElFPL3AA0FGAbfQMgjOzj5kV1WG9F4wrypu3y3Cf5pEooiZgUNbBR5sLruEOHmPb2jO4XUiR02QCzZYLr7LmGMsDlQcNjZy8Uv7BWGoybMu9Rzh5aLDQW+67JA2PFnIDmubs7vt61uB4NRdBsNZnUSAOigBK1UmCbugUjDFSZ2otX4h/n5dmU96FBuNXoiaVRdWAq+56feSyKHmsjFLfYiflShSuqBoEe4YQa6IhEXQQHx8Q5poCH7YZ0K4pGTYBI8Y0yGdJTVKYKXiqNjo7vLTaJKeEHIUDWPTvwAQ/hGETc/0FFXR6d8hE05sVjc3YksmOx6iQmXoVhmMU4OOtnBbkSNKGqc+tRgOrhk/abAeC2D6ETY7hEdM0mPVmy0P0I2+6jqbOdcwDUi8ts0R2YfilMxKqaGHqA1Z+n0wEqqXq/T6pO6z8EUPL7f8J03FM0V+6IijGf5NHduMJvolL8CZn1BGcCNDTTMp0hpSD6hQlTIuxiOpRKOJ6IvnzgQKGzFyXL8zpgD6m52c/eh+JH9oPUIKI+NgkfIPIVo/IH6NHFIYdH5yAKxfOBG3Rw0xOqO1t6XFKYj+Gfk10f70xrM1en/QrQyBb4AsLOPKwhYm8lsoeSA/r+X6qLuyxjOl+2ZHvE4FeVYSmvA5wE3znFZGvTFfuJMhECi6KgmRctjm8iZIPDTbZKVkeXqofVe6cMZG0cx99xMRHT2WuGIOPepq9K cq/VjbB2 VAscMLAcgEkycniH2PClfUqqDStewmmJhbAmuWzndfUG7SsmEiwm4i6laD35os7+SubFRhkSzbq4Fm3Sz8dfjdH7iEXOy//jGwXIKWWknQDtqA1yJ6P0Red36iNBNJKn3Dfpkk4imc8R8Am62fPnIXX8b9A77n7DA4AYAZDvn8cfcFFh/kK7GdLctADSEbr2TSCd7vI0kzyo4xxHV7ErKGPfBSTw5lcAQG5slbrZOzG7MPni0EM8DbIC4PM/pg/qI34avCr6tmpMkVUCtjp9zm6WxRSRmpVQ/V2Qc2F+VE4cQE0rwEu4PaVC7XoITcT5/BXz01QsVJ/mydIPpTGlYlWsdnZnPOP2f0uo2jrUl5hvtPHg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, May 8, 2024 at 6:54=E2=80=AFAM Sean Christopherson wrote: > > On Tue, May 07, 2024, Edward Liaw wrote: > > _GNU_SOURCE is provided by KHDR_INCLUDES, so it should be dropped to > > prevent _GNU_SOURCE redefined warnings. > > ... > > > diff --git a/tools/testing/selftests/x86/test_syscall_vdso.c b/tools/te= sting/selftests/x86/test_syscall_vdso.c > > index 8965c311bd65..5cd13279bba5 100644 > > --- a/tools/testing/selftests/x86/test_syscall_vdso.c > > +++ b/tools/testing/selftests/x86/test_syscall_vdso.c > > @@ -8,10 +8,6 @@ > > * Can be built statically: > > * gcc -Os -Wall -static -m32 test_syscall_vdso.c thunks_32.S > > */ > > -#undef _GNU_SOURCE > > -#define _GNU_SOURCE 1 > > -#undef __USE_GNU > > -#define __USE_GNU 1 > > AFAICT, manually defining __USE_GNU is frowned upon, so I'm guessing the = __USE_GNU > stuff is just the result of misguided copy+paste. But it would be nice t= o get > confirmation that this test isn't doing something clever. Or at the very= least, > explain the removal of __USE_GNU in the changelog. It looks like test_syscall_vdso, test_FCMOV, test_FCOMI, and test_FISTTP don't actually use any GNU extensions. I'll add that to the commit message. > > > #include > > #include > > #include