From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B325C10F1A for ; Thu, 9 May 2024 17:46:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 80C2C6B0093; Thu, 9 May 2024 13:46:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7BC3E6B0096; Thu, 9 May 2024 13:46:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6842E6B0098; Thu, 9 May 2024 13:46:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 49E406B0093 for ; Thu, 9 May 2024 13:46:05 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id EAE04A1952 for ; Thu, 9 May 2024 17:46:04 +0000 (UTC) X-FDA: 82099585848.11.BB1084B Received: from mail-ed1-f49.google.com (mail-ed1-f49.google.com [209.85.208.49]) by imf28.hostedemail.com (Postfix) with ESMTP id 99811C0018 for ; Thu, 9 May 2024 17:46:01 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=WWySv5Cx; spf=pass (imf28.hostedemail.com: domain of edliaw@google.com designates 209.85.208.49 as permitted sender) smtp.mailfrom=edliaw@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715276761; a=rsa-sha256; cv=none; b=QMQhOBUhPMqdhclpPum5lXUwVGThq4syJGbOfNIVCp51rTLWGOIDPdCGeL8YZ05g2+8VCw kcZ1C2PashPcrYqGd3QSrTWNnqXJV2qhHH1A5Ja0cSYyt06gzUInx1XPurtmyiFtlpq1/s sBBrZOt8qacNx+wGBABeNrCRNwlGI8I= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=WWySv5Cx; spf=pass (imf28.hostedemail.com: domain of edliaw@google.com designates 209.85.208.49 as permitted sender) smtp.mailfrom=edliaw@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715276761; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=R9dUf6h0ZONDc1o4IvKX4JCSR1LfcFcW4NQit96LWug=; b=eU2gaYZ7rO+6xwSirDaQCTfZig6mHG5a8Luly0HiWSXpKF5hJFcrGhdMX8TXPxAaglKDvs mBljLHPTBOnezVCl/6xSr6XtgZw4BLtgPQztH90gJ7OAgiw4OseRuKE916vnTLDp8QXTT0 BFc8FmTkmftlqJYOHp+zboRuEL6Rra4= Received: by mail-ed1-f49.google.com with SMTP id 4fb4d7f45d1cf-572a1b3d6baso1197a12.1 for ; Thu, 09 May 2024 10:46:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1715276760; x=1715881560; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=R9dUf6h0ZONDc1o4IvKX4JCSR1LfcFcW4NQit96LWug=; b=WWySv5CxXoJ3zi4nAxdJ1fIZz9WC2wmaz6PIe5SiLTz8Nrq0u5JBSvoqP7+f0K2dsF t+0KJpQC8MzqH4XwdK1laHICo7nH3NOBkuM06iqvK/JFdGJ/Dc4Fx6EeXW1Bpdx/QTNZ pG401Z6rLCKeX7QW2LU4zxsn7oZCQUgqa3y5K9Di0GjwdAiJfav/WkK+Wo+qjdpcVHFX tqKbJlc/WkrK2pGjMc3EUZey9Xv1SDa/kCwj52rHn670idAcQ/uF+D9NRAdCRTx50rjA K4U9wEXjjlMuTOTpOg/dQ8zzO63NArE9+Hd7Kuj+9FnscovKpQq+TaQM+nsF2wxIQSxg iYag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715276760; x=1715881560; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=R9dUf6h0ZONDc1o4IvKX4JCSR1LfcFcW4NQit96LWug=; b=KPXijj/CtOeI4x3tz3PnUXRZKz8jtBrVZjQjHtU9RUHCQPz/0bv4Kdgs3uWWZvUbXy S1yDuQmdcxCbQzLN7EjBywBQAUrAwjUW28fRzgtN+BpjZ/i+uEZB6YKEAWfjmwl7FH7x wxIr++6bQAS+27N45uiq3wLcD9b4FFc7fXBJGvHyr9JSY/XLMJKUrvmnmWJw6NtC3/cd K4mSVQT9K8LtUPfRlxqyl+/Gz8Yt+n4rUnbuCH4FX+tU2Mn5Jb/wilO61I7tb4Uo1bh3 /2StpBJc99bn8hhZ5CAmVTSx91S3ch8n93yYCwCiE3OyMQ/8apE0FwkqJ2mUl0tO3MsE Z2mA== X-Forwarded-Encrypted: i=1; AJvYcCXERc/T2XOea8rVVJIUiHGtw8CNsPdfRwTEKx1INpwgah2IjssIq8QZqoLnw5umLkin+AdeH1nuIQevjoAMHsVBJxE= X-Gm-Message-State: AOJu0YxpbD25Fug19jaBggF1btVFoghyrSVBYb+1gXNL9PahLkB8ixkk wxxXuP0AcqXyiywKv99SlG/1cGOEFIub8lOOh7Y5w6cnYRtA/I5hmMMQR3+p5eNqAI7CXO37zrM WILKpO3EB7MuC2O3+q4HdFKlnDh7X3LfBSvsw X-Google-Smtp-Source: AGHT+IFG+qZVP+GdGsJ0bfuXNwufKAJIRBglqYr60vsLU06TQKxk62S9P+fDwyd1v4jS3rVgg+dEQp+BJ2xOYW96LJk= X-Received: by 2002:a50:cac7:0:b0:572:988f:2f38 with SMTP id 4fb4d7f45d1cf-5734f8fe9f6mr3018a12.6.1715276759326; Thu, 09 May 2024 10:45:59 -0700 (PDT) MIME-Version: 1.0 References: <20240507214254.2787305-1-edliaw@google.com> <946ae22f-a4af-448a-92e1-60afb6ed9261@linuxfoundation.org> In-Reply-To: <946ae22f-a4af-448a-92e1-60afb6ed9261@linuxfoundation.org> From: Edward Liaw Date: Thu, 9 May 2024 10:45:31 -0700 Message-ID: Subject: Re: [PATCH v2 0/5] Define _GNU_SOURCE for sources using To: Shuah Khan Cc: shuah@kernel.org, Mark Brown , Jaroslav Kysela , Takashi Iwai , Catalin Marinas , Will Deacon , Nhat Pham , Johannes Weiner , Christian Brauner , Eric Biederman , Kees Cook , OGAWA Hirofumi , Thomas Gleixner , Ingo Molnar , Peter Zijlstra , Darren Hart , Davidlohr Bueso , =?UTF-8?Q?Andr=C3=A9_Almeida?= , Jiri Kosina , Benjamin Tissoires , Jason Gunthorpe , Kevin Tian , Andy Lutomirski , Will Drewry , Marc Zyngier , Oliver Upton , James Morse , Suzuki K Poulose , Zenghui Yu , Paolo Bonzini , Sean Christopherson , Anup Patel , Atish Patra , Paul Walmsley , Palmer Dabbelt , Albert Ou , Christian Borntraeger , Janosch Frank , Claudio Imbrenda , David Hildenbrand , =?UTF-8?B?TWlja2HDq2wgU2FsYcO8bg==?= , Paul Moore , James Morris , "Serge E. Hallyn" , Andrew Morton , Seth Forshee , Bongsu Jeon , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Steffen Klassert , Herbert Xu , =?UTF-8?Q?Andreas_F=C3=A4rber?= , Manivannan Sadhasivam , Matthieu Baerts , Mat Martineau , Geliang Tang , Willem de Bruijn , Fenghua Yu , Reinette Chatre , Mathieu Desnoyers , "Paul E. McKenney" , Boqun Feng , Alexandre Belloni , Jarkko Sakkinen , Dave Hansen , Muhammad Usama Anjum , linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, kernel-team@android.com, linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org, linux-input@vger.kernel.org, iommu@lists.linux.dev, kvmarm@lists.linux.dev, kvm@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-security-module@vger.kernel.org, linux-fsdevel@vger.kernel.org, netdev@vger.kernel.org, linux-actions@lists.infradead.org, mptcp@lists.linux.dev, linux-rtc@vger.kernel.org, linux-sgx@vger.kernel.org, bpf@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: ja1ad3b7ay5j71ni9mzj5cpb93s1bmea X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 99811C0018 X-HE-Tag: 1715276761-557203 X-HE-Meta: U2FsdGVkX18egXyhZUTuDlRUJjAGXV8t8cU70MD39+/VJDT2hsdsIzEZlSv/YeheIBC+s88yPyeHgXckxEMA13RYZIwJc2UJ+luMFew7MqHU1+IIcARl+8P2kz8OwQLJB6M5h1tJSFwM34Atv1FWZYBexSP+TaeFvFQNnaCs9gHNeIZBBsp5yA7Q4Yw/2wHiWbCUuyL+zf069q0WR9o9GIviQmiAWUNrD5yWwn6Ri6dPYfrh4WKZXCgtShqsrA07ZyKKCTIJOezAfVzmaCqKQ2RNoKtALBSGyYPDhLNCG/q2N0wmbwDkoV57mGbRmB7jLyPKZ6cEGdFXcnC1wj+5jcS50g4q0QY6i8SHTZ8PqwDvX1NQbJcgZIEMNywXvUyzCgHjGY9P/+Hh55s2+sY2sJk82aFMi7+9us6gfChBT1m7C2+n4/B8rXXE2oDVC8XoApgvFaaEnvfNMgBGtPtvIln53Sxu4ePEyPduRXbZM9igQTDZSZHQQkXzT2BD20c4APckjEnGJAWl1FIjFMof9EkI5BLnCmC8PyHb+aAN2hUWc1MA7ncuUXXfwYgCmDOhlEa/UjrdfA1UWJmgOJzmC3W9GBWdUUPptFb0wnjAp7JQQE4TQCNM/ykTz354QoH9VACEmsl/xw9lDear/ZUT23bC4/dSozvzGw7MyKjs/naI9clwxLB93fJLaweht2/Z0lw2dg+oMhP5tJXESTghcO8535laXFuFJTwED3+7R3APlxMlIExHN/AfYqE+8CnAW9+pe5i8tiLkGRtWkndOfLFrQpWTSJjGepT+OhIt6xGHdxjsSWKxUbLi8UUNDkMCUeXV/6il+McClVLRMqOKE11KBS6XMpxhgePmFR7RnEnXc/iaLDp90IO2zolKxk5p5L9tO7ti4ZWAk/fq8liSt1q/uJd6ixTXyR6tXiBYEL0gra17Jc1LGzlH3VGw7oev0TGbphinxLtj7+rRPcR FFFgEDmK DeVFB4lSgZVQepDWimYkO2ZXnAtSPgQm/6v0zYx5TUvfQi9VuIGK2/XLU0DIw11ZPsaB5IHGC4gIkcx0wbRHoxDO/jMzKVkbiun2kVdADEiYV7EwbsY66fhzy4Mah7m6wZfKsCusODSCpFlVWwe1EEIIyLsv2I9BMFvxTkstcJD+kTyMpKW9t7nhS4JV6PPo9IW+EkbgzRpT9JbYXDtg2cJizXVZCyjdvUXw8pW16qawZvkHLUe2zKZdahhJqqzQhaG/cLrc6vhcjDo9XvbNuWonrNbEqfje+HLErZYIdVEF0czjNijdhp0cMzuPQsGhgYLoA08v7FXRbYSx8qGSxM3G0WGO6kRbZFlui7qjO5opVdtX/Vo/A7vCv86aWPAcep0D+nxv2YtvhP5EhDWrgX1M+wwcNDjHJcZr3hTefhZVzOD7c3Q5/LwPHGY/LP6maGPv5/TKwo52oBkX3aAdcb53bX73gulERGzuTYBSg4jfZOms= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, May 9, 2024 at 7:37=E2=80=AFAM Shuah Khan wrote: > > On 5/9/24 00:13, Edward Liaw wrote: > > On Wed, May 8, 2024 at 4:10=E2=80=AFPM Shuah Khan wrote: > >> > >> On 5/7/24 15:38, Edward Liaw wrote: > >>> 809216233555 ("selftests/harness: remove use of LINE_MAX") introduced > >>> asprintf into kselftest_harness.h, which is a GNU extension and needs > >>> _GNU_SOURCE to either be defined prior to including headers or with t= he > >>> -D_GNU_SOURCE flag passed to the compiler. > >>> > >>> v1: https://lore.kernel.org/linux-kselftest/20240430235057.1351993-1-= edliaw@google.com/ > >>> v2: add -D_GNU_SOURCE to KHDR_INCLUDES so that it is in a single > >>> location. Remove #define _GNU_SOURCE from source code to resolve > >>> redefinition warnings. > >>> > >>> Edward Liaw (5): > >>> selftests: Compile kselftest headers with -D_GNU_SOURCE > >>> selftests/sgx: Include KHDR_INCLUDES in Makefile > >> > >> I appled patches 1/5 and 2.5 - The rest need to be split up. > >> > >>> selftests: Include KHDR_INCLUDES in Makefile > >>> selftests: Drop define _GNU_SOURCE > >>> selftests: Drop duplicate -D_GNU_SOURCE > >>> > >> > >> Please split these patches pwe test directory. Otherwise it will > >> cause merge conflicts which can be hard to resolve. > > > > Hi Shuah, > > Sean asked that I rebase the patches on linux-next, and I will need to > > remove additional _GNU_SOURCE defines. Should I send an unsplit v3 to > > be reviewed, then split it afterwards? I'm concerned that it will be > > difficult to review with ~70 patches once split. > > Please send them split - it will be easier to review and apply. You > might as well wait until the merge window is done. I don't think > anybody would have time to review now since merge window starts > next week. Sorry, I have them split already; is it ok if I send them now? I will be on leave soon and may not be able to get back to it in a while. Thanks, Edward > > > thanks, > -- Shuah