From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C499C04FFE for ; Wed, 8 May 2024 18:03:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C46BA6B0098; Wed, 8 May 2024 14:03:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BF7076B009C; Wed, 8 May 2024 14:03:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A97CC6B009D; Wed, 8 May 2024 14:03:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 8A14B6B009C for ; Wed, 8 May 2024 14:03:40 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 3AE83A0F04 for ; Wed, 8 May 2024 18:03:40 +0000 (UTC) X-FDA: 82096001400.28.11D1C30 Received: from mail-ed1-f43.google.com (mail-ed1-f43.google.com [209.85.208.43]) by imf18.hostedemail.com (Postfix) with ESMTP id 496C51C000A for ; Wed, 8 May 2024 18:03:38 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b="Hd/Qp8HJ"; spf=pass (imf18.hostedemail.com: domain of edliaw@google.com designates 209.85.208.43 as permitted sender) smtp.mailfrom=edliaw@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715191418; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=NKy0w8SAVZYo27FpU6ZBovVv7b8KWTwyUtyfvoxHua4=; b=XEx0WdJ/9+a5s9E8wK9iRSRTNH/ThIdpogQjr3tELhCCLzdh+Uz5jQhBL2knP760Kav3u9 TmPoODe3vsxoOqI+FRPEuADADHRvOet+hnqtoZiHg1bwRyAfLrqO21kHblPrBqSL1AicqF hTcTY7VeFY+nqq02bpEcZPojCRCCWug= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b="Hd/Qp8HJ"; spf=pass (imf18.hostedemail.com: domain of edliaw@google.com designates 209.85.208.43 as permitted sender) smtp.mailfrom=edliaw@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715191418; a=rsa-sha256; cv=none; b=U6wHe01LHonuuFr7et4PsAE0NP7UMTnr0vvS2LaUHqvOOtgE9g7+XRySu/aztqRa9z6/pq jsnYHsDoGW/ltJJBfgV8FGbffQLfG8CrphnwHXOzTQmMBEvr59Wubd29uC5diAaPlCWTZW G62GFgVeHzhdkpZuTHa+pLnTHO9MT6w= Received: by mail-ed1-f43.google.com with SMTP id 4fb4d7f45d1cf-572a1b3d6baso1725a12.1 for ; Wed, 08 May 2024 11:03:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1715191416; x=1715796216; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=NKy0w8SAVZYo27FpU6ZBovVv7b8KWTwyUtyfvoxHua4=; b=Hd/Qp8HJxo1PIoFuTmMkFumeoTdDeNG28mzvuB5u5PfEcPkvLnXQZFSY011PJ8GI/y nUI8GQ+RbyD9fbvuWZdHcZWJJrNbFY+03jIdMJ8hlIQmQ+Ax3Rf8C/xrGEp/EUUuOjUz t1aIraUUgT6fvZnXw6r7n0Lx9eJ7ntePoxqE3Bo2kLVzWJvn52+pZJoCaVFmLqE55Tj1 5OBr9NeeQeQYNvTuzkpfQj5edQ6kkt7qbd7tUll7dgoehiVe7kZPn4cQ8EGCrgbdXBNI i2F2q2tcSOlG/chVdkbM56fBv5cGYdCzdPJsqE0jUPIlV9sQW66lGWspLgJwz7RGMLsS lkWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715191416; x=1715796216; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NKy0w8SAVZYo27FpU6ZBovVv7b8KWTwyUtyfvoxHua4=; b=Hwn7Y8xiKCy9MUMFzZqZ+Kmbju8mN1FQCwWFMO5RyJWRSblj+ZNEXuPfZcxUrY+fso Xb8/OaUlWi5epcLJjc+oT+Ya5asiKpkPdrWw3YKgImiAr0E9p0upIan9TPcq72bLYdUt UMSOWwO9uy0vSxfKliKCpyFCBSJrSyVZW8Ubtfgj3PQl6Afck4xBj2/mcLXbllpfwpxs cvn1LaRhyax1AwVhGIv+o6sJ9XFYkWW9pRcXoZMU27eAnfJA3+7p6aPwEe8ByPORYKVI kRlwyl2D8E8yaOYGeln8nbEHaVgSmc2RBnOcC29nT9P1F2RbaN8lN/8t7zWDI+QPJ16y KSHQ== X-Forwarded-Encrypted: i=1; AJvYcCVA2pxc7P3cvj4DQ3/8ZlCTNlSRe8KMGIH8//BqSPeibD2fGVgCsz6UFvpp9qoJ5bSUwIcMY2pIzvOycUy4f0CpbGU= X-Gm-Message-State: AOJu0Yz71Y8Q5PCfg7lyZbx42c1303xgVoqzMeKEWr9lIqDyhuJOQvmP 50JH1NNqp+MHS7Mrw/RcdpNuLjYpqdnUG6mQgzYDexuY6C3OURphgDR9zro5s1het/5BWi/jx4i twvSX71kNB5hB7MFHNV5NuCN7peRlJc2xlwcd X-Google-Smtp-Source: AGHT+IFdyxKHKBA5RxjNJeg0nvw+PuOv0TpVA43qYYBbq4FC0UUJLuiCzYnH7rV9IAgiFwYJSHM5Q/yPLhYa7GrUbHY= X-Received: by 2002:a05:6402:1763:b0:572:554b:ec66 with SMTP id 4fb4d7f45d1cf-57334b922acmr1088a12.3.1715191416289; Wed, 08 May 2024 11:03:36 -0700 (PDT) MIME-Version: 1.0 References: <20240507214254.2787305-1-edliaw@google.com> In-Reply-To: From: Edward Liaw Date: Wed, 8 May 2024 11:03:07 -0700 Message-ID: Subject: Re: [PATCH v2 0/5] Define _GNU_SOURCE for sources using To: Sean Christopherson Cc: shuah@kernel.org, Mark Brown , Jaroslav Kysela , Takashi Iwai , Catalin Marinas , Will Deacon , Nhat Pham , Johannes Weiner , Christian Brauner , Eric Biederman , Kees Cook , OGAWA Hirofumi , Thomas Gleixner , Ingo Molnar , Peter Zijlstra , Darren Hart , Davidlohr Bueso , =?UTF-8?Q?Andr=C3=A9_Almeida?= , Jiri Kosina , Benjamin Tissoires , Jason Gunthorpe , Kevin Tian , Andy Lutomirski , Will Drewry , Marc Zyngier , Oliver Upton , James Morse , Suzuki K Poulose , Zenghui Yu , Paolo Bonzini , Anup Patel , Atish Patra , Paul Walmsley , Palmer Dabbelt , Albert Ou , Christian Borntraeger , Janosch Frank , Claudio Imbrenda , David Hildenbrand , =?UTF-8?B?TWlja2HDq2wgU2FsYcO8bg==?= , Paul Moore , James Morris , "Serge E. Hallyn" , Andrew Morton , Seth Forshee , Bongsu Jeon , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Steffen Klassert , Herbert Xu , =?UTF-8?Q?Andreas_F=C3=A4rber?= , Manivannan Sadhasivam , Matthieu Baerts , Mat Martineau , Geliang Tang , Willem de Bruijn , Fenghua Yu , Reinette Chatre , Mathieu Desnoyers , "Paul E. McKenney" , Boqun Feng , Alexandre Belloni , Jarkko Sakkinen , Dave Hansen , Muhammad Usama Anjum , linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, kernel-team@android.com, linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org, linux-input@vger.kernel.org, iommu@lists.linux.dev, kvmarm@lists.linux.dev, kvm@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-security-module@vger.kernel.org, linux-fsdevel@vger.kernel.org, netdev@vger.kernel.org, linux-actions@lists.infradead.org, mptcp@lists.linux.dev, linux-rtc@vger.kernel.org, linux-sgx@vger.kernel.org, bpf@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Queue-Id: 496C51C000A X-Rspamd-Server: rspam06 X-Stat-Signature: krrhcrcminaru5ctutzjeabua96p8kou X-HE-Tag: 1715191418-708006 X-HE-Meta: U2FsdGVkX19SGxA86Vkio8k938WHZGt3w5jThJS5TYVmefBAgN41w/3kpak5Cffl/R/bep3gbe/CHJ/PyPa864f9G9CP7nA1PZZ1IidK84VfRAy5kS3n50br0QrJAXk+RvHp6/hlewMT3ccXER65JMEHw2HZfvXW/wIoMbbz2VFHOF4XH2ye6VbuCbbFfQQNdoq6jWe2IxrIffgu8++ydNq86Llyl7evg3AwX7LLXPsTiefETp1tSisQXu6K4Q7PP9Pr6COfUP2W2kUYLrNWCOrXoTmYDagzmMffa3yRtdGU35leBob/uDSVYKxxZ122flQoinuxGrnQ8Ge7UKJ3RCLtp97n5kMYb6pqkCPD6P9f3i7DycB87iL83gTON9iSXKevdNt3GRmxXWlanDdRQ4nz3WS/RrhA1ked1YBniIqH6jzdFRbPs3MCh0sD4w5bWfHKFj/3XL9aG8B6el/KzFF0xoLBswdAsxiWZkhJFeW6w//5jcrCPTkNU1yllHqqLmTDR9DCK7wYahGCrQNwe5oWPPSE5IBTrqYhkuM5if4w6ilRzEZWByHKWzd+0CGx34hqELdwbFZFbms25ByZT9Qsk7zifoSuCtRuyRLeax1ROuer3mBzwTP62C06ctUwqUDCHChCjAYy7waFp+5IwGASkX/oC3NG6wMgg5qcaxUR0hwY0EU0xxlVgMBX1N3Ts2NiGfSKBztmoiKyFy/K/h0oGTOazzXnaJTA1h+IWSg0sUJQQuMdMMpOwQKezfh9AT+9aVIzlD/30/CYI6vgtIS9MvwwavGnaIk5zGs/jZVNz3bJzu4/XttubXo3IrWYt4ZoS/aOiAQGfzzEj3uHUgA8fE69y+U1m3lLozGCPiZplVP2efO4VGvWMbjZs/nsvPXy9c6xgKZQdh78s9rqJAeAlwdm1RK1EjIlmhGHxzn1HJSNFTWGJJcaAo/PfNYjVEPZVzO09y4hDiq3IkE tq2Ccior Fpt6Cr9apil7w4cS0dC1kkGGZaSD1lX35QsiQODEMn+KW9TktTnZoI+DLdYWHkb0000a2ghY3fOEz045HRrO2PGI0dv9DzROKoIhJ/4zCewzKVuSXvwK+RltJUT7vci8b6n2VPZy3RzKda0om6toi13h/pFVKAv07DHSKKrsXkoQnY8jHU3Tju6liZ7ACrb2d4feqCegvZvVxpfh3o8Ibvhhq6vtOlQ0QAMtjGkQ3MOTORukyTJhYczobVyR2WIrA8KSTWqvUWDi0bXAh2Vu/s7PVy7XitdLGJFgYKWIsvSkYaWSgsqIajHZgYc50v8KdwCCJK8DUPiYUP1gubJ++DV2q6kBTJ4XJWhskvnHj5d86xNLKiFj1CZUSC1b6/PuNgiTyMCmo+ZdrZxriLkvTDfW/5X3XrTZogkZ9aNqcRLLJ9bfIki+lASOMkf3dMU3CtoBQ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, May 8, 2024 at 6:47=E2=80=AFAM Sean Christopherson wrote: > > On Tue, May 07, 2024, Edward Liaw wrote: > > 809216233555 ("selftests/harness: remove use of LINE_MAX") introduced > > asprintf into kselftest_harness.h, which is a GNU extension and needs > > _GNU_SOURCE to either be defined prior to including headers or with the > > -D_GNU_SOURCE flag passed to the compiler. > > > > v1: https://lore.kernel.org/linux-kselftest/20240430235057.1351993-1-ed= liaw@google.com/ > > v2: add -D_GNU_SOURCE to KHDR_INCLUDES so that it is in a single > > location. Remove #define _GNU_SOURCE from source code to resolve > > redefinition warnings. > > > > Edward Liaw (5): > > selftests: Compile kselftest headers with -D_GNU_SOURCE > > selftests/sgx: Include KHDR_INCLUDES in Makefile > > selftests: Include KHDR_INCLUDES in Makefile > > selftests: Drop define _GNU_SOURCE > > selftests: Drop duplicate -D_GNU_SOURCE > > Can you rebase this on top of linux-next? I have a conflicting fix[*] fo= r the > KVM selftests queued for 6.10, and I would prefer not to drop that commit= at > this stage as it would require a rebase of a pile of other commits. Ok, I'll do that. > > And I doubt KVM is the only subsystem that has a targeted fix for the _GN= U_SOURCE > mess. > > If we want/need to get a fix into 6.9, then IMO we should just revert 809= 216233555 > ("selftests/harness: remove use of LINE_MAX"), as that came in quite late= in the > 6.9 cycle, and I don't think it's feasible to be 100% confident that glob= ally > defining _GNU_SOURCE works for all selftests, i.e. we really should have = a full > cycle for folks to test. That sounds reasonable to me. In this thread Tao suggested reverting back to 809216233555 and using a fixed value in place of LINE_MAX to fix 38c957f07038 https://lore.kernel.org/linux-kselftest/20240508070003.2acdf9b4@kernel.org/ > > [*] https://github.com/kvm-x86/linux/commit/730cfa45b5f4