From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6FC8FC6FD1F for ; Fri, 29 Mar 2024 20:33:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A21746B008C; Fri, 29 Mar 2024 16:33:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9D1446B0093; Fri, 29 Mar 2024 16:33:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8988D6B0095; Fri, 29 Mar 2024 16:33:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 707D56B008C for ; Fri, 29 Mar 2024 16:33:43 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 276AE8031F for ; Fri, 29 Mar 2024 20:33:43 +0000 (UTC) X-FDA: 81951227526.11.FE6AAAF Received: from mail-ed1-f51.google.com (mail-ed1-f51.google.com [209.85.208.51]) by imf19.hostedemail.com (Postfix) with ESMTP id 47B511A000D for ; Fri, 29 Mar 2024 20:33:41 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=UuEuxM2I; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf19.hostedemail.com: domain of edliaw@google.com designates 209.85.208.51 as permitted sender) smtp.mailfrom=edliaw@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711744421; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7fJ4rSAI0GoYiQAMJdDfQgj6t00Kp7TpJETA/wU9wok=; b=0y3X17abdhZ2TI+1fUwcFZbTPlPO6VH77SqgaV1wcvDCu0DWV9rHbvJY/2AX+vIjgLsR6W E97njPIvBn4zwVkPNX5q1SOFRngu8HjhJ9ws1qSyKoGq0zPg/fn7cygsyYS6q6BOkhhuCK euuJIDCm+WzSUyr4mOIuZ480mhqTFAg= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=UuEuxM2I; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf19.hostedemail.com: domain of edliaw@google.com designates 209.85.208.51 as permitted sender) smtp.mailfrom=edliaw@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711744421; a=rsa-sha256; cv=none; b=8e6Y4qSXnE5NpNzV1hVaWC9gnGStl3qatSz3m5G9NeBA0KFXWcrbTvZibzu/XkTKrwpZ7T fNyH+tcFQTxHpMNAzWS+B260xUUsC+84K3ucNrDrIZf7HblN3n8tbR/BQnkyCls+fB7DUY ihk6IO49KRnfYqzu7GWJlmuofRimVi4= Received: by mail-ed1-f51.google.com with SMTP id 4fb4d7f45d1cf-56c2cfdd728so13717a12.1 for ; Fri, 29 Mar 2024 13:33:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1711744420; x=1712349220; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=7fJ4rSAI0GoYiQAMJdDfQgj6t00Kp7TpJETA/wU9wok=; b=UuEuxM2IIwKTULJsTxd1WxIInSBuhRE8fwtexisJy009kzKbgAa27qCfMsd0h/RGza l96+fo4W8JOq2DiMwuPq7QUeeY8VlWunbibeKtCJg1dOtpwhSEtVSyIHfGw2+bSGjkOk T37cDwezUhn1ye2MY8NIXSvMbRYM9oky0KMlKT37hFuQ9hk46Z3XnO0qBOxB+RxvpBmk eOF+d9ZpXbRb/Paoz30rOBDqBqF1AOTfhrma1n++R6PjmfLu0aO1JgViHOaWrI9O8dWo AyW98weDqcvO46gmYiz+dAgoXTXCqeA5HLrJ1pYgpMTxLWnVxI6RgRfGuYY9C5AS7Pao HwqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711744420; x=1712349220; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7fJ4rSAI0GoYiQAMJdDfQgj6t00Kp7TpJETA/wU9wok=; b=ZhBT16Ymjeor/NKVR7D1xbU6N7MDuoxAIp6gHxr2hxpU6s4P3vwzAoYIrLK5XoJLXO 1olXOj4EWqXUtAcOgGC6cbJTb+TrUAMwidROvmCwD0rdHeJFzOxvZf9uJBJXA1LJMqbk UFuTo1xPlsp7+QL/YdJerDOMf3z0S9/F2ORExWvkg7sWdbqBekPkjfGr+l3UPV0fja7l cZATPwMXsXDaWasjX9XD1g9YBsZiZ7YLvzyn/k38a0UmBAOwht2G9u8lFqFmcIAQ2Sm1 u/rFC/vzjWMAwacmugbHhPoyRjLPfxG0q1jxZ1cZ7V0M9prrMGmzap/jiVtXZpCRic4A GDLQ== X-Forwarded-Encrypted: i=1; AJvYcCUZeK+9htnNvqdUmXXRj1rkwUWUnq8HN7iE9Nl0QTrIpIJeP+6tIkD8Rh4MOL2nvjPJAOuaE6+uYVzGK/EG1ixlJG8= X-Gm-Message-State: AOJu0YwcvSQf+Z+iygpywEN5H7cYYCIbgc9GA7eYen2meQN4Zk3qbevw o3Tf5DKOiAVK0CHB/iiyhVIxE9E3dDvahTqCV7aOE/AlwZb+r0rNi94LYDMDxAqVHYfr17FwtqS Cmpy1NFNhWdMOBleCxzyY1jB6Z4dJLt2Dlfxh X-Google-Smtp-Source: AGHT+IFMizgS0G5ukFYvjYIGxUljt4fuYwgJVd/7xudG/ccYnF78sLbJwmbgsF7dKolFZvWx8Fq/tlthiyGNWzulF3Q= X-Received: by 2002:a05:6402:c94:b0:56c:2d40:7430 with SMTP id cm20-20020a0564020c9400b0056c2d407430mr138817edb.3.1711744419595; Fri, 29 Mar 2024 13:33:39 -0700 (PDT) MIME-Version: 1.0 References: <20240329174236.2278217-1-edliaw@google.com> <909806c1-a9c4-4f51-a807-46075efb8ab9@collabora.com> In-Reply-To: <909806c1-a9c4-4f51-a807-46075efb8ab9@collabora.com> From: Edward Liaw Date: Fri, 29 Mar 2024 13:33:12 -0700 Message-ID: Subject: Re: [PATCH] selftests/mm: import strings.h for ffsl To: Muhammad Usama Anjum Cc: linux-kernel@vger.kernel.org, Andrew Morton , Shuah Khan , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , Peter Xu , David Hildenbrand , "Mike Rapoport (IBM)" , Axel Rasmussen , linux-kselftest@vger.kernel.org, kernel-team@android.com, linux-mm@kvack.org, llvm@lists.linux.dev Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 47B511A000D X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: dygs17uaeeyyrtruieimdgjxsi599js3 X-HE-Tag: 1711744421-15042 X-HE-Meta: U2FsdGVkX19UUrCkEoOg7QW86LAc+iIO/i7Hiq01tKVhaT6BWF9b7oMs7TG62mIkXRbokkurzpkrZQQyYKXRhCGOV0ahpoCnSvIM8Zj94WeUtOkKnfIoS0kmb5cNKSxLVpHj4m015TafNSkHc3SEVN51/nuyT+DDfMErVDdvI4BOWAAK6TLUhNizVWWBBPCD9mkwE30FDNsIZdnw6HsKd2vS7GJooqtSX/LSjObhcBjtMOOBMHyHGIoGMnboP7+F9US4JfoWH99Jd69Ep+CGagQADTv1zaYi1NWxJNSe2rydyySTTG3xW52vwiXxDisEm6NIn1S5/jYul+KVlPiOy5f1aCrcp6T3/YtZWh4++UXLj2lPPMOnGDoz8X9nrZZmDzIHKlZVwg6aSdCX81tze/FgpxmU5ydyqF74F9lXUfZdgsBKzuy/Hw/gsv5bXJ6/Hw8TCZsP+gfD8VUZD+rFQT9IYld0wbKKy5wzP3lUY5GFnL+e/4t2Xr4AXb/F6k6Zist8A1J+mJWfl5/Vdw67M4XK9jX2g+E7mHhaj1Jc0RILJb4n+GJminFZaJRGvtvr2zYHam/1Q62TL13+WIi0J8wVlBtf0VFoziqvGpeo30yik3f1T4E2ZFcwlYECObMqt1237gzzBZ6kprUcAxRmaPH/Ss3wPLmcGrHmernUdbjA6fCLr0/BDld3HxOduKEtynpNkKiDRRbJlomSDM5FuGa62xtLjknZLoqRlfcBZ63GW3PPx4+DnI/h6lM0ZvDjZHf6pQWSzex0ta4rQRTrJiCTptGIEdHCMYeyGDyNnIbrtph08vEFDNVqt3b4Sc5DxwoAIbW8Nz5QfqtPuRE/tGCaVf92GuBgSzYn88norFPmKcPOGXVeMNHAhZaYEBNUoho/ueSz8qvuIal331CVFfrvkiUTRQUVLcPqLOD5oBgmRjzAxhmUspWUwAXA3RSF86OLTleMSBe/0JhyRjr bADI3xSm BZkk7wqVcz6uEZ2Zmtq52bdi5V96HWMLj3lu09uh+V1bTbKXsBgMRajOdWPy7tKpiEZu30HsA01Dp8VdPrqhBRrd0OtVQ0p9RNFbPVGNsgabj+BB5OcQgPix7L0eLUaPW6qFkIvk6SruyTdFF0YqyhSKiKppbeUH8/P1HNFPfF3N1kYtMkT27l0p+tvWhq9ZcZ5cxDuSWKJGqVgr9rh57V39IphEMLjXsYTT4smkxs959VN53BIvAxqZtsz2oyVzpC51VOU24o+gjj2AkGELhdZ+G7UHf8E4XlwY+ X-Bogosity: Ham, tests=bogofilter, spamicity=0.009854, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Mar 29, 2024 at 12:32=E2=80=AFPM Muhammad Usama Anjum wrote: > > On 3/29/24 10:42 PM, Edward Liaw wrote: > > Got a compilation error for ffsl after 91b80cc5b39f ("selftests: mm: fi= x > > map_hugetlb failure on 64K page size systems") imported vm_util.h. > > > > Fixes: af605d26a8f2 ("selftests/mm: merge util.h into vm_util.h") > Why do you think this Fixes tag is needed? This refers to a patch which i= s > just moving code. It doesn't seem to have any thing related to strings.h. Oops, I guess it should be: Fixes: 6f6a841fb77d ("selftest/vm: add helpers to detect PAGE_SIZE and PAGE_SHIFT")