From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF099C00528 for ; Mon, 24 Jul 2023 15:47:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 84E638E0001; Mon, 24 Jul 2023 11:47:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7FEAD6B0074; Mon, 24 Jul 2023 11:47:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6C67D8E0001; Mon, 24 Jul 2023 11:47:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 5789D6B0071 for ; Mon, 24 Jul 2023 11:47:38 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id EC36240BC2 for ; Mon, 24 Jul 2023 15:47:37 +0000 (UTC) X-FDA: 81046935354.27.A7CD196 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) by imf24.hostedemail.com (Postfix) with ESMTP id AA752180011 for ; Mon, 24 Jul 2023 15:47:35 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=4ayl5F9Q; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf24.hostedemail.com: domain of jannh@google.com designates 209.85.128.42 as permitted sender) smtp.mailfrom=jannh@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690213655; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=cGJt0fnvQ0L+LGrNb0ri+iKmwD6soVF+xq2UtktACoI=; b=FWiFguKtl6/V1XMvR7vH7v/m2o7bnILEEGOXjo59afgzlVRRp5cSw8BbIaQttXRDfuJl5K QC+8i3HpssyGsK75G8VUgCeIRJpDmHT+5nQbHgVXS/nSujS4WaC822t5mwFTaOfSpZJWaM dIrbOAPp4gI7lM27TGpjOr5gqpjVb+k= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=4ayl5F9Q; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf24.hostedemail.com: domain of jannh@google.com designates 209.85.128.42 as permitted sender) smtp.mailfrom=jannh@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690213655; a=rsa-sha256; cv=none; b=YAK4FXUusBd7B4AaR9rb5vIXJz2GkqxWt9MQxb8TqO2ODS+0e0f8HYMpwzoQ2QA+vZZQWj ZKBr2jueKdQIKNlbqRUj3Fa2bL0kJIFFpr3uXnW/6u7xhuV6ZWQOjUOwAzt8FOiAKk1m+1 OsNMul5f1tnKfA61JHxEuQHJrBokhic= Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-3fc075d9994so119605e9.0 for ; Mon, 24 Jul 2023 08:47:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1690213654; x=1690818454; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=cGJt0fnvQ0L+LGrNb0ri+iKmwD6soVF+xq2UtktACoI=; b=4ayl5F9QYoKtbj9ejSCAe6UhsDQtWDumTjIRa6JyteLTrQixDSyJcu8+QwHIpx7/WD FjsAOnsOXV6PeS3sTMvHBINTyiQlqiPaD4D9wgBhtRctPaqngoOCydp6pgASzhgpFxYC bTMNh942B2dLAD14NNBiuDoVGvHvDMOy5I9Bxftp+y7JsZvZzCm2s941mkqXvdG7jR/5 vbVnSRm6URy4D7RiPPoG6SYNv133htxpDLAO5+Xay9XRAB/lKEgsrbzGD4a+g5a8gIke 9Fow6CIjIzNnevK8Se1P0j0Qkr8RsVgzi8xF+qL+IPzpgtOJW4/hh4TsnVB2hrsfAJSS Ky7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690213654; x=1690818454; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=cGJt0fnvQ0L+LGrNb0ri+iKmwD6soVF+xq2UtktACoI=; b=NsEvu8flAj8njdjdQA8OEU9FcY1SHr+cNHTq6LtiBvE6U6GNBtawiH1WHfsgZ6E22D nasFPNJfwlkaB6Ek/Z0YxUN4Fl0T1bBOCMQHgDBdY0uq9Gld1yngNGmA0C+TdCQgyOuE /dLub+lHLCXIM/IdV0ZHlo3HR+SRFxF4esc56QTY2nMiQEsKQtYd0lUw2gPwELjZ5nkO 86in3Y0hpZqVJnZZnSXldHUxr0/xabuMngogpI9lRx6GnCtmSjfpXbuVElNKLgebksdq Go7DtQfQKs42ti2f3F3eE/cLkBrCuzlpEISvbimr2F06sv2Qt0tYYd+3/afTfdh9xC7O v6qQ== X-Gm-Message-State: ABy/qLYBNc86mPiSXHGSB91p1jJ6MPg6bjbSou7pQXUqNGEYCGvLzBen hsvbOMU1Z2Xq7Ecouj6nkTWkDAEUx8DwLBuB9kw89w== X-Google-Smtp-Source: APBJJlEVWgR3a5RNlqNjjZ80QA18DEOUK5VNWJl+Dhumc3ez4S2CtLVOLJKeWZ+0ZmYprXuCkEjt4uP9e6ofjAUA4VQ= X-Received: by 2002:a05:600c:3546:b0:3f4:2736:b5eb with SMTP id i6-20020a05600c354600b003f42736b5ebmr164745wmq.1.1690213653880; Mon, 24 Jul 2023 08:47:33 -0700 (PDT) MIME-Version: 1.0 References: <20230711202047.3818697-1-willy@infradead.org> <20230711202047.3818697-5-willy@infradead.org> In-Reply-To: <20230711202047.3818697-5-willy@infradead.org> From: Jann Horn Date: Mon, 24 Jul 2023 17:46:57 +0200 Message-ID: Subject: Re: [PATCH v2 4/9] mm: Move FAULT_FLAG_VMA_LOCK check into handle_pte_fault() To: "Matthew Wilcox (Oracle)" Cc: linux-mm@kvack.org, Arjun Roy , Eric Dumazet , Suren Baghdasaryan , linux-fsdevel@vger.kernel.org, Punit Agrawal Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: AA752180011 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: pzzyhh65ukkagog4uppfjk7zowu7eqy4 X-HE-Tag: 1690213655-399553 X-HE-Meta: U2FsdGVkX1+4zA1pUqo5MNnVoQ7c/OrAr2pcHmRhgCjOxQpG+PuCzJmsjtA9oIut9drl7Z93ottolAQpSzHkBdCWqDDt+wsNHlmsPQhQvZy+A1JZXEk7nutJu9hSNrDLYXIoa1v2Jr/uV/e32udYq0xBBCUdVIp9BXrj7bqxMjDaxF+aPkPe0dsftrsXP4P9ZjNO+JPLrgtngW8FobCbxyYcxYCSiTKk1VFmLDhdqAI5w3qslzvJUfdqh5QDJIa3d14TU4ruC12cBa4p/TW5dm0zN2rjHje414dK1gKY7gcloXNMXaXvnWS+/ln/qFoRybyNC3SxFT/QlWhsR2NBAHCx5zMD3liVNMklvvdGbrhem1hHoNHw6o4RFoRQYDruJ2m6CR8o37srnraWH1uX2HGMwQ9AY1+eJiJ/kB6r27OoEcbQOUD1oPqFCATKmd/ZhWJnPAzrJOzE2R/QsdIlFTm93+SbUq2cvSPARJIk+FExBXceeVpYfvEEBLcJdJhaYI+29BCFke51lq0gkGDT0pjCbgwD1G7d4POS4A2aKxSYnfn6wyORjQNoayFv2UyhBWLYZtCbJnd/TKIMCvRhGjA+Q0mJ8vHQV0WLj84imqmFgwRt1sYHxwCLmO7KRduPLhdXJCfLGf3dGYZEZj24xZAOvGb0Pareh96hcNGfNCDgaiLYADnjCgSGSBjVF9naGQY6zPnGlcERVyMi8a/ao7mxfhgRScEmNWGmIMGZIkezVazsNQWoZ/U13DWOvTANefbji6CM5D1NYQZHBfdNVnRNlE1LlC9CEq/jVCtCXHE++Jtj8U+uBMiKXEUvYLdHgBoHRyBs1Df42O5QyKT1kBfW+QkOtadsLXmLmx4BgACgoUpE5hQ5tCKY9gYHQ6nzW8gYOWYMgfIEMHif62ojV8eMPcW9/Ot7WgHrfGnKN4ZIjZ9faYiGozXfuZPy5eJ50sBCmAc1UweJyO1hQRt 7QPy6Jpr wkpBxnNrHqUgdr8XJt7VNmNu55qGQml2cEogfzxaK9nqm2GYJOOZOROOuFzCryGDqeUD2/iz0ZvwaMa8ItRxYXO2yK3W2GXPyvHxhYM+XYgenMjv2a1MltJQCNhZYHPMIOttnI4xkC3AqyoxqTc40GII66KMlGd+yShYvIDoJHmUNDeyQYWmL1Axf5b2nnRfwIodhnFkbfCi50PsM0MbjEceaQZmaiIdUUoifpmkxc/ecldYGdArzsJi76VPQK46/mTbr7LYq7ZqSrLjaJnjwLe0mdUMK6ULViAdOPJe44fuNnyLx8gdTAZ+wyXAw+afIWqi6J1774fg7gl3aeopXzF6hqUMbIh24uVs/ X-Bogosity: Ham, tests=bogofilter, spamicity=0.002326, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jul 11, 2023 at 10:20=E2=80=AFPM Matthew Wilcox (Oracle) wrote: > Push the check down from __handle_mm_fault(). There's a mild upside to > this patch in that we'll allocate the page tables while under the VMA > lock rather than the mmap lock, reducing the hold time on the mmap lock, > since the retry will find the page tables already populated. This commit, by moving the check from __handle_mm_fault() to handle_pte_fault(), also makes the non-anonymous THP paths (including the DAX huge fault handling) reachable for VMA-locked faults, right? Is that intentional?