From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57AA9C0015E for ; Mon, 24 Jul 2023 14:49:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E40E88E0005; Mon, 24 Jul 2023 10:49:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DEE988E0001; Mon, 24 Jul 2023 10:49:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C8F558E0005; Mon, 24 Jul 2023 10:49:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id AF1E08E0001 for ; Mon, 24 Jul 2023 10:49:56 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 5F8E880365 for ; Mon, 24 Jul 2023 14:49:56 +0000 (UTC) X-FDA: 81046789992.02.4374483 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) by imf20.hostedemail.com (Postfix) with ESMTP id 7E56E1C0021 for ; Mon, 24 Jul 2023 14:49:54 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b="CeE/SNaU"; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf20.hostedemail.com: domain of jannh@google.com designates 209.85.128.41 as permitted sender) smtp.mailfrom=jannh@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690210194; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ki+X2Ujoc38+QWppbACpmptGeQ/z2af0rECZEbVAVFI=; b=g5e2yL46O4RNnvdlMKDplLIUxj9etDMmsyK4LEHoSG1lGYOHQdBdQjMeRSkma7HCUtc6+0 nwm7srYS0HnsR9TOMZ0jQqHlg+CltnsVCtvndfcd5QmT92JJMOHLQNEIon2NEcia7+7l5w p3uIHFB0m6EFkxfLXv5QQbwGrbfPGF8= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b="CeE/SNaU"; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf20.hostedemail.com: domain of jannh@google.com designates 209.85.128.41 as permitted sender) smtp.mailfrom=jannh@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690210194; a=rsa-sha256; cv=none; b=yVEmhQgN3Ae8PmPyPBTz0pnyMAav0pJ0Pb4bL0blnm0P/n4NRuTzrwjpN5vIfKC0Am6YNC SO27LfgaTMkOyzqvj2eWST6L/ghF+O4sMOQ/LE0vx4Ss7kel5e03jxfV9YbBkfbUe6fQ8Y hLFgn+W0Z1m/ogeTPlOj2hrSEL3nbDw= Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-3fc075d9994so112435e9.0 for ; Mon, 24 Jul 2023 07:49:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1690210193; x=1690814993; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=ki+X2Ujoc38+QWppbACpmptGeQ/z2af0rECZEbVAVFI=; b=CeE/SNaU1vmPj5FnneXPHb3jJH79djSajq+EiQCueGmehbzLPuqRKsrG8hiPBG6CxE G2ctKccmmtp7ajI2h6irptpIz3AmPV3ZFguG3NAHBWxF3/LEfOQW5X/IfAD69m6jqfJg JfwzuA6Ew1d2vToJEtoJqCdZ92mi3u8Y2q0B/sWnf0BmPBIyhK8A3gQ467OLfb/8I0Gq VUqB8BHwkz1iZ5ZIJq9IA0su5Y0AzBKgY6GU0fafP6X/OKdEj14uduMZnSOmSzWc34ed wfAMQX6RSc3TlLD61vSGtqZ4s/TrCqBhTn9zcNX8xgOOrgd1pZw24byr8us1nJJWltPF MkQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690210193; x=1690814993; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ki+X2Ujoc38+QWppbACpmptGeQ/z2af0rECZEbVAVFI=; b=SGwTY7naqCkXc720cFek0fknMe8coorEEHf5pMk2yHghCxGP/3fz97C0qOQogFGIHB 9sG3naVbwv7AzBzVIpdeg9Y8mzrSiyjKI7vdNR47pBnb/g6iZxEMMQsNQYia7FaHCjc/ 3NV6nQAwtWbka8Q9lFraK26oW0zuoK40++90qgqGDePbtpuR4rEMgC/LlCLHLQzuOY/M TLOciQ7y9jZ7ZQmGwZICA/j5sWF3LbUEaIR1NGuCLCAMuLOs9FdkxEbbFnlZx/O1w14K 5JmsHSLOK1O5AofNNuX+OMguwHw+bXl88HLLge4ISrdSmTlkxJMnPqYe9fwLdOJ0l5uo 2NCw== X-Gm-Message-State: ABy/qLY6gv77M6ctTK+M2exwrwz9j9s79Ig6URxV9fxWw02I/DsYqFX9 /s39BA22xCIXEcCWSZ6GxO8r7JjMtQX2HwIhkNXtWw== X-Google-Smtp-Source: APBJJlF9uk3eSs5x3t+6WtqH14pUEUPIKuiZ2qGbirueqO/SURxmmVHB9Rog6hFQVOJAJnpxVQMqTOvWAXbIpUrca/w= X-Received: by 2002:a05:600c:3ba7:b0:3f7:e4d8:2569 with SMTP id n39-20020a05600c3ba700b003f7e4d82569mr154278wms.5.1690210192726; Mon, 24 Jul 2023 07:49:52 -0700 (PDT) MIME-Version: 1.0 References: <20230711202047.3818697-1-willy@infradead.org> <20230711202047.3818697-2-willy@infradead.org> In-Reply-To: From: Jann Horn Date: Mon, 24 Jul 2023 16:49:16 +0200 Message-ID: Subject: Re: [PATCH v2 1/9] Revert "tcp: Use per-vma locking for receive zerocopy" To: Matthew Wilcox Cc: Suren Baghdasaryan , linux-mm@kvack.org, Arjun Roy , Eric Dumazet , linux-fsdevel@vger.kernel.org, Punit Agrawal Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 7E56E1C0021 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: we3dswo3ghge4bo643ega9yc3xdzj44d X-HE-Tag: 1690210194-547043 X-HE-Meta: U2FsdGVkX1+88nE/e8ZLgw+EYjdkbOdAfGsMjEk9oFKoxhF3qsR7YF3DnDXG/ziqCkWQmoCe4mn2lfmNSvXIjEk0qWxewEd6ZqxVnpRRAvevc4nuldgf6a32Db0HxzKfZsAQKy2FHrPVJnrHsEkGic4GZ8jm0j2nx7VEWmdmn8IfiH/7ArYK4IV92Xkz1pZ/+wwLj0/iADqmwBQFGXYZboZJY0PLr0WDOnh3I21LHRCILj1tyZzxuph02g7Cs+T7l5NlqmhssybgmyiUrEGSVwTvj4xIAboRrWJauyUsLQU4S9iHF5HwPq0VGihsV0B+fWZMToQ3zkvuX+9EG1VxpH62JB6alGGVeYFuaWn6fvfMtoIHNW+vJ4YwZc+SnrcKaJYVjNL+aw3AVOUmU4KCR3YYslv1KWYxrz/QJfNRpAYYaOB1KJeFlBVIGS7ZUQN9mZr9OH/hhgwtkN/TJ6Qnz4OTlvpsLpk0ySuC6N7n2pbauuVzHvscPEFhgTMVcyUX6+GTANlApYWJEkZCIDaVY+BH8veCER3eAwvRQ1nEpQ2MbNJP4nuB7PcCjh4QLLH9K0GfOsrivNHHfk0385oFLGl9U4vu3pMNz5WCu79Wu/EFDX7sgxZBvRRzpf7P2pG0T5rqxrHL8qqqEmgJqyKXdJIuORq0Spqu1xIZp590LFXNkSSWRPGE+G/16/bxYvN9TcuivtwdBr5po7a/AXaZNstyqkCGHAwh1A3SmDtSobm+zOrSgKo+Js9/23082Ey0HHo1Z3AYxu8vjENkny7XCG7cCZaDgzzGApxgqn65KV0hZd4Rj0/xqJ6D1giGCiX2xVD77qw/Gr5HR4kzEwP/aRtHjt730s4av9fkFuqQYj6KvqB6Vmm7RfD/wrY/0BogoORoEgA7UuYF3MQUXgTbDyH3JJS8b6qTkOs4gV+Tpbzijr76aqulWUgOh+JoMU+bon1m33IWDuVTYQ7VDkR 0NrG4Qz7 RDnLsRQuGgfY+AxvYRNKTRQ3OG3XS+ju+4IaF8gLQ1+0JBJd8pZUfZ9/Cz+Y3XpmKr3KDfmEjZad6zwror2AHJNCxn2KGAwkeggXwU+mbW1pmgqIRzhjN8VgmVc8aeUh6ocxqqMAg6L9U5b55gDk2DqyPEisrkhWP5KIJvgQRZbD9GuvQchKgJP5P30I031QFSecRjlB0WhfwYk50R7U82dGdz7LCz2OI+enj12djmvXnKe/FhJyz/6NU7HXCwrFnzl8NlDgJhPd+wLqnQO7r5rCk0AoDgDa4wya+ X-Bogosity: Ham, tests=bogofilter, spamicity=0.003653, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jul 14, 2023 at 5:34=E2=80=AFAM Matthew Wilcox wrote: > On Thu, Jul 13, 2023 at 08:02:12PM -0700, Suren Baghdasaryan wrote: > > On Tue, Jul 11, 2023 at 1:21=E2=80=AFPM Matthew Wilcox (Oracle) > > wrote: > > > > > > This reverts commit 7a7f094635349a7d0314364ad50bdeb770b6df4f. > > > > nit: some explanation and SOB would be nice. > > Well, it can't be actually applied. What needs to happen is that the > networking people need to drop the commit from their tree. Some review > from the networking people would be helpful to be sure that I didn't > break anything in my reworking of this patch to apply after my patches. Are you saying you want them to revert it before it reaches mainline? That commit landed in v6.5-rc1.