From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0675EED619 for ; Fri, 15 Sep 2023 17:04:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 33B758D0028; Fri, 15 Sep 2023 13:04:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2EB908D0005; Fri, 15 Sep 2023 13:04:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1DB308D0028; Fri, 15 Sep 2023 13:04:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 0F3148D0005 for ; Fri, 15 Sep 2023 13:04:43 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id D2E8E802B1 for ; Fri, 15 Sep 2023 17:04:42 +0000 (UTC) X-FDA: 81239456004.18.909D636 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) by imf09.hostedemail.com (Postfix) with ESMTP id EE61414002C for ; Fri, 15 Sep 2023 17:04:40 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=SFh0FkD1; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf09.hostedemail.com: domain of jannh@google.com designates 209.85.128.44 as permitted sender) smtp.mailfrom=jannh@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1694797481; a=rsa-sha256; cv=none; b=YIC+lhFDeOa0v0gHy2+f0fIt8ELOsHJ4ArcPcTKcVW6/Dq5W66vCcmOXtmGEvYD/q4ZmqE t4HcPm7K2z9lN70+IXlJFOwDkf80qRcBhJKiJLRNtQsGIvwK+KKjGcIOHJBCjx84hWJp4B QjeHMd5CYiYbLiKc1f8EJ+9WzTJRZ/Q= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=SFh0FkD1; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf09.hostedemail.com: domain of jannh@google.com designates 209.85.128.44 as permitted sender) smtp.mailfrom=jannh@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1694797481; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=LlAvjtLPcGmDg4A7voaF5Wo0HxRPXZyKmdzluEIsWow=; b=8oKemMHD3UypkcU7SpK5Yacx5390zXHURtxDodETSlwgw2CSChybvE3L407uS5PtJXAXuQ DrdVLErQ5EwCW87o2ENBPdp0oLfE8kn7MQ9IpuFNzmUn6EWQ9k4PyhCx7EnJK29ml3F5nG YemBBltbja84Gbkv+7LNhzeYloM+ER0= Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-4047c6ec21dso3085e9.0 for ; Fri, 15 Sep 2023 10:04:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1694797479; x=1695402279; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=LlAvjtLPcGmDg4A7voaF5Wo0HxRPXZyKmdzluEIsWow=; b=SFh0FkD1Z87pbdkK8orMJUPYwWBlPvJEDBxEZkr4fLA6R8tBu3Ij6rVvl3tqXa5jkZ OUva9jit9PZucjtkmHoADAO8a2Q6hAU1MDBiXtsYmcMB2k1q/VqcdjtY9j26MzsF5r3Q 0oX7n/HhUXfp1HQbgQinA5VvXbLqQmpAl2MX9Pi2iZKSNqHBWv/KQH3cLxl9z7hZNKMq mCBtsm1Pia4e1aXzUi7q/WSx7ZIDGoLDwRBEUGai0ITkJJTcFziOjP0b0oQjxn3BMZoO inmSroOG9+nKu2SdfnIS5ijheD2WxbWjFZA6ruNee8+xN43/6mKTjHERH+P20NiAkP8z n8Zw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694797479; x=1695402279; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LlAvjtLPcGmDg4A7voaF5Wo0HxRPXZyKmdzluEIsWow=; b=P5y7vs+Z7b9J0kLiVOX6OweygB2oYueXYdwFmLdYowlEaFs0iqiXrU76ewMy8WYQq6 UtS5crE9nOZp8CmZvBS5jyLNRa0qdtdHQNQGFLIOZBCpH+wlC78gIE/EawHSKelsnm3W bU3J966oBDwczkRz44ZOts2Ia3VqI3t/0bLpCwti54cK9vBTrsVtJfBgNRpODX1GOyMY Q18ijvAgexAGDs4QcMGi1gOT/262AaECJrhlZBKUrjLTVXyOiuhoWzE8qxo7v6df7Fao Gi3gKPIFVFP3Wm55T8zyDzak2LJ4Oz7EtOuVuR7wH+//MBwkzF4yDj0oa7k91GU/E9fR IEww== X-Gm-Message-State: AOJu0YwSAAHHajgouSSh4zKFKRSvuliDeOy9nHg2SRVacJPeuGlb83D1 ckzhggj586cR6gt1tYIv6aDR7LZAPKqPEMi11b0bSg== X-Google-Smtp-Source: AGHT+IEonzgZqc+V81TNYkvowwdDOWM/CYqm2sY+5KYoHV7zxqDLiUjikh2qIP4geMp2o3XvkFv+g/ec00ROIhSqgW8= X-Received: by 2002:a05:600c:1e07:b0:3f6:f4b:d4a6 with SMTP id ay7-20020a05600c1e0700b003f60f4bd4a6mr2391wmb.7.1694797479400; Fri, 15 Sep 2023 10:04:39 -0700 (PDT) MIME-Version: 1.0 References: <20230915024559.32806-1-haibo.li@mediatek.com> In-Reply-To: From: Jann Horn Date: Fri, 15 Sep 2023 19:04:00 +0200 Message-ID: Subject: Re: [PATCH] kasan:fix access invalid shadow address when input is illegal To: Andrey Konovalov Cc: Haibo Li , akpm@linux-foundation.org, angelogioacchino.delregno@collabora.com, dvyukov@google.com, glider@google.com, kasan-dev@googlegroups.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-mm@kvack.org, mark.rutland@arm.com, matthias.bgg@gmail.com, ryabinin.a.a@gmail.com, vincenzo.frascino@arm.com, xiaoming.yu@mediatek.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: EE61414002C X-Stat-Signature: jfza77h9oohuegbugpgu718c1h9soicy X-HE-Tag: 1694797480-51079 X-HE-Meta: U2FsdGVkX19k++Z87Lp/xclaFyC8NnSBH7Xhw6hIgzzNfnef3JkjTgAZADHFxI5ahLYsAzsZ3j5kmOhKVprAZY4L7l6w1SPE5u7BRCzWXMu4ZsZtYja+2V/euYqBOPu1vAa2TKHQlcxR5V59a19iAMgug4b1S0CuYBEjz+nwqaJOg6POGyhXVzw1y+gmTs3m1lVfaOPPb/uAsPc4vMg7vN7ZYf7IjWkEDadS9RPuAizEcMRY//VZnlkopb+fjhaiQcQR+sQwkV97U/Leu65RBXqvCvFMUoPu5GwqWHUvHwBAEw/kDOj/hhHRGvdVlsv5al5Bfuv2lrvfVo6AIfUdRj7zjbA3hOUUTY1Hjte2LfcmViRFBMNE14cf/NLAtF6nIQjDd2otvNlGfvy++8iP/s/tgJtINKasc7vgKF0shgxNppJMQtS8dql9znIexJxg4lXmSFJMmBEeO+BAL1C3ZI4B464nc7Fic4Mrljn+hhHGpel5N8MpveKDomA24dSdyjze0/6zAVr/vmmN0F98xTsZy3tzxfEjlvl6Z04uYLuyTWBoeSCwLb456rTtGiBR23RDwaYHqvamvLE1GfmnEzeOvnZDb714R8Nb9X5E+AjdmVr/Zx04jLey6FDp64lRiUmiD3XjAKBcAqUBdA1Nks2yc+98BBtJCa+u7OllOrmMJ8cUfc6RnJhRxz28TcWmhW/fOlTVS82F6BAdwazkws5SbsWZP+/j46hUnBvHflk2d2Py7DaFmJVup/k5ZBHBbrxtoeE4QecOZDkzizZ/3C3LHJZmd66ErUYdltwmU6VsOjv3f2fKvmGyknAuPjEbyNOa7c7hkuTCyIKZPsV2fB5y5I+lx04CV1xqXggDxP5XturxILN9387bbksbpHEmqM6rICvI0sCZnN4tKlqVy7ZZkypmTz5ukzJkQl4y4dl0/yRNCb6ZsXrxF08OlGAfgaBE86qQoR02UaN/s9W bxfriWcO +oWoPGsgfY0YIy1BhoA+ZW5hHw1R6b6nUeHWcBq50kGTV8SFzVxY8kcYOnqgpm5N2hck7QkUPeBPlINcwk1cb/E4CMIqZr0lWXV6umrR4MEf555brAb9u4YMIjsovCk7My8B5r5Q2QnY3EB6uUaZjydXevkVSbT5PbBvZcbbYo8p7jWyXyedVj/gMQVlLzZgh4B+Pn0c9KNjo/8ZXi9wmJBQruV7FHg4VZseHgcCVsqvodM94OXOsTZVBMqrOdODkLV3cyYG3aa92CIR9p3vF1Vo8zcHtT/+48KII3SRiyfqXBn4ZmTsKd8goYwAtrQq7wAf6Jus+oilcRKgBwatIw0q5kLxJbqm51YB15v5Uknn3QezOSJZx4ag9b0esUbDXGePC X-Bogosity: Ham, tests=bogofilter, spamicity=0.017118, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Sep 15, 2023 at 6:51=E2=80=AFPM Andrey Konovalov wrote: > On Fri, Sep 15, 2023 at 4:46=E2=80=AFAM 'Haibo Li' via kasan-dev > wrote: > > > > The patch checks each shadow address,so it introduces extra overhead. > > Ack. Could still be fine, depends on the overhead. > > But if the message printed by kasan_non_canonical_hook is good enough > for your use case, I would rather stick to that. > > > Now kasan_non_canonical_hook only works for CONFIG_KASAN_INLINE. > > > > And CONFIG_KASAN_OUTLINE is set in my case. > > > > Is it possible to make kasan_non_canonical_hook works for both > > INLINE and OUTLINE by simply remove the "#ifdef CONFIG_KASAN_INLINE"? > > Yes, it should just work if you remove the ifdefs in mm/kasan/report.c > and in include/linux/kasan.h. > > Jann, do you have any objections to enabling kasan_non_canonical_hook > for the outline mode too? No objections from me.