From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C0D3C47247 for ; Tue, 5 May 2020 11:42:42 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 1B3C320746 for ; Tue, 5 May 2020 11:42:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="PZPHz2sf" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1B3C320746 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 91CF68E00BD; Tue, 5 May 2020 07:42:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8F4668E0058; Tue, 5 May 2020 07:42:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8319B8E00BD; Tue, 5 May 2020 07:42:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0221.hostedemail.com [216.40.44.221]) by kanga.kvack.org (Postfix) with ESMTP id 688158E0058 for ; Tue, 5 May 2020 07:42:41 -0400 (EDT) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 30E0E181AEF30 for ; Tue, 5 May 2020 11:42:41 +0000 (UTC) X-FDA: 76782478122.19.card81_8bd341dcb2662 X-HE-Tag: card81_8bd341dcb2662 X-Filterd-Recvd-Size: 4052 Received: from mail-lj1-f194.google.com (mail-lj1-f194.google.com [209.85.208.194]) by imf21.hostedemail.com (Postfix) with ESMTP for ; Tue, 5 May 2020 11:42:40 +0000 (UTC) Received: by mail-lj1-f194.google.com with SMTP id f18so1232236lja.13 for ; Tue, 05 May 2020 04:42:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ikKwSi47RkdUncF8ZIue6G09Cc3O7H+FG1YBZJHLO1c=; b=PZPHz2sf+Y8/7voSUCVwWYQDTFp6jwT4eccln+h2V5t1fLtEiuMZ5ce3f8GLrLB5/+ Lv1kPL8izEzV+2IdG5SUTSb1GcCNzzZfyx/zyH1vNX1EgrQil8bLC2Jc+9mBLhAhHXe7 lOi78W5ciY1Ra0aIWnH4lpyflE7/EEEyKc94UjlHjcZQTnCuGIhy7/dnoqU7UVdaxjRC Rdy8T9f0YhG4rZRuZD9UxnGFLdby4z/l2sf/CrEw82JtjLZcoH91Y9xfMaRapGwaeY1W cCq9z7jHxn2gQYCZgaN9WotoV7g5/hfB1w9fLaw30A+XNiJTmnTXn2BktrD8y/mxhzoX nxVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ikKwSi47RkdUncF8ZIue6G09Cc3O7H+FG1YBZJHLO1c=; b=cgx8b94Hq12zIw8jtC10H/uxn6qSgHbpUx3KugTyOTVJfilw9j5PbzQyBUiZIopVYu DnHLiDfxt86H0OpxbSdyvNotxo2oUMZEHZjhKkTBuTl3DGRFaaPL1VzgZopdzfRMz+jJ 3EA/utQ6lYyRIfVqz+0WlgsEcSZLKXWgG7CflsD7DlH5g3m1C+9YGdLOdzM7KjRihjRl PYBpAgA5Ge0YdybettIbZAhyPwWJTY3yLANg8f9QH9evsSWOzpupS3mSjgAya8g7wF8r pUbmnAxzio8r7Oc3iXcpF/iaOWZWUgQUT1ArB49Dt+QZioL73/1MV0WmJIJDTuSUSsNH hkQA== X-Gm-Message-State: AGi0PuZwcZv+s6P33gg0exHgiEjwk2ffdUl+yCCa2leu5IjiMatZPWO8 XMGfrAMtOBewTeI1AiOfXcAZuzHCtvPcuYXmr9A17g== X-Google-Smtp-Source: APiQypLzrurPKOFHS71dRCXI6iqbXYejtciTu5aveMTkrB6ldhKIG7OBjVfkuUaytzaP4Y/gPJR2+9djLt+JtIxmsXQ= X-Received: by 2002:a2e:b249:: with SMTP id n9mr1613232ljm.221.1588678959039; Tue, 05 May 2020 04:42:39 -0700 (PDT) MIME-Version: 1.0 References: <20200429214954.44866-1-jannh@google.com> <20200429214954.44866-2-jannh@google.com> <20200505104805.GA17400@lst.de> In-Reply-To: <20200505104805.GA17400@lst.de> From: Jann Horn Date: Tue, 5 May 2020 13:42:12 +0200 Message-ID: Subject: Re: [PATCH v2 1/5] binfmt_elf_fdpic: Stop using dump_emit() on user pointers on !MMU To: Christoph Hellwig Cc: Andrew Morton , Linus Torvalds , kernel list , Linux-MM , linux-fsdevel , Alexander Viro , "Eric W . Biederman" , Oleg Nesterov , Russell King , Linux ARM , Mark Salter , Aurelien Jacquiot , linux-c6x-dev@linux-c6x.org, Yoshinori Sato , Rich Felker , Linux-sh list Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, May 5, 2020 at 12:48 PM Christoph Hellwig wrote: > On Wed, Apr 29, 2020 at 11:49:50PM +0200, Jann Horn wrote: > > dump_emit() is for kernel pointers, and VMAs describe userspace memory. > > Let's be tidy here and avoid accessing userspace pointers under KERNEL_DS, > > even if it probably doesn't matter much on !MMU systems - especially given > > that it looks like we can just use the same get_dump_page() as on MMU if > > we move it out of the CONFIG_MMU block. > > Looks sensible. Did you get a chance to test this with a nommu setup? Nope. Do you happen to have a recommendation for a convenient environment I can use with QEMU, or something like that? I'm guessing that just running a standard armel Debian userspace with a !mmu ARM kernel wouldn't work so well?