From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB04BC54E90 for ; Thu, 22 May 2025 18:01:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4496D6B0082; Thu, 22 May 2025 14:01:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 421366B0083; Thu, 22 May 2025 14:01:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 311266B0085; Thu, 22 May 2025 14:01:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 07F896B0082 for ; Thu, 22 May 2025 14:01:34 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 60F59E22E2 for ; Thu, 22 May 2025 18:01:34 +0000 (UTC) X-FDA: 83471311308.23.35F1DC9 Received: from mail-ed1-f46.google.com (mail-ed1-f46.google.com [209.85.208.46]) by imf08.hostedemail.com (Postfix) with ESMTP id 587E8160003 for ; Thu, 22 May 2025 18:01:32 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b="NUz8e/vt"; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf08.hostedemail.com: domain of jannh@google.com designates 209.85.208.46 as permitted sender) smtp.mailfrom=jannh@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747936892; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zSrbOWuHQ1Z5sVIesfrhCLH21IIccGRYbToiYGXm2ZY=; b=fR9/06VJVvbHxAt2cyhDSmhnmEwXF329u9DF5fnvraUhzlTbx1VgIFkH2wK0R5gFk83UEd TTvfwvsecJx0QuqEl1hXu1Yjg+81ylgygW8Y24kG9vrtmdbXftRt876wdnjNzqpMg/h2LG uOQ5ZiUyYgnyR1pYiAIKWqA6DOwXkzQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747936892; a=rsa-sha256; cv=none; b=3uQ1dwGkpmux/MtHb3UIm29rTmWXeXni9AJT233iGKSSf+CYhU+qDkcHNHGmNKErKEDhF4 yQNQVblfOdyKLeTRbK5Ac3z0QSYGdLEpV0vUFIFW/HmZ770Z4uEHDqUTvrufLSBJHsiTOu yLQxagU/D3FMy80nkXvK0aTTFVxw9iY= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b="NUz8e/vt"; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf08.hostedemail.com: domain of jannh@google.com designates 209.85.208.46 as permitted sender) smtp.mailfrom=jannh@google.com Received: by mail-ed1-f46.google.com with SMTP id 4fb4d7f45d1cf-601a67c6e61so1365a12.0 for ; Thu, 22 May 2025 11:01:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1747936891; x=1748541691; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=zSrbOWuHQ1Z5sVIesfrhCLH21IIccGRYbToiYGXm2ZY=; b=NUz8e/vtS9WPE7jf0l+JOT2Sh6a/7Gko7gkokQLg2/9O8EqcYV9nn+kl8hZ49Z/E55 FcJsxt5Jb2BmwEOFutEbp3y5WKgm4nLGM0HrgzWfpBbMl3xI/2E2vP1qtj89jwQONR0C WFGhQgbF9Q2sRLM+PD8kFLeNOTTSuxETbsIudtfTdKD2TwzVEWnslRLGmNj/QDBvAZ0L w7WTwh9TlBGGmUR8EHeQBWzKT0Ag6K6vEGnFIQ+Vd6DOYEqIMaIo7+DlwJOWwMYc4JUU f5XGMBEhr+zXAosxAhCT0kVcIxrAn5XH3zj6Sam3etLYJoeQDd03zsqMmk5pjTx6j3RV LYZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747936891; x=1748541691; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zSrbOWuHQ1Z5sVIesfrhCLH21IIccGRYbToiYGXm2ZY=; b=wkXl+1yyOQo9cLEcZWbNlH8rRQB5pHBCF7S2NTztMmJnkLCYkwqvtqyLs4rWhsc2cH aVrRcVybdKSlPsBwBnNUG3UYItyJ92evY3YejjKFMgy4ZZy41svLGvlZH++iCOcz6jDS VHQE4bF2TKzMkQXP7jdqHLXvXh2XThaDORpKCTKLYJco/X+xI6UEoSataKS4mv4Btqak tDV4ZTzBxmShtCe6WWSiettjvIpuARYoPKC3Cn+OZkrKwcfuCe9lJC3rw7NduEv1t1ec Y9T2kd/vCq3+ExLmNB8ru3XiCKA+wQ98gMHeVntPNnw2zykaysOxhkoRSYSXLRCvsIap i3FQ== X-Forwarded-Encrypted: i=1; AJvYcCUE9ef3gQMKlqsnryuf4RbvLu+fo3xv4bxe78QuwcNqWHX6gv49vbBYZCUrix4l+x944wn1QJ0onw==@kvack.org X-Gm-Message-State: AOJu0YxF8NtSVNEbXwxD1ZWjA15nqSZM0iSfYHLWTplCLsqXC7o4gqNx l8B47jhR0ZTCcDsd4sPXWzqK85KdjWI/lTtQyq/xcevMLarMhj5dWyIkaAd1JdtgbLbK/U3MCli kwE2QbMEOz/+z+9qcqF2Eyp24kyDO4vUq07Hu9We7 X-Gm-Gg: ASbGncsEwqP2FvHt8PLjeSUtIKWCAYlKOq+Y+r7nk8q8FCmHwI9X9E1JYIHpCOs7SRY W8BR5prefLFe3ixjXF4uSRi+eSmD9ydP9Uw/AAMsogBJvz3jgJLdgYQLyWQQKccn/NHoReVXsHc 6trqjbbXPoft/DHPWzbQRFazHq9eJUtWAOT72AqyVyad3zrUSCidvL+NgS5HqMZFXj7pKifao/U 8Vu/KPSoA== X-Google-Smtp-Source: AGHT+IFxJE445XHoSMx5+PG2/5xKb63gk3NMgNuLdGQr4KqW7SDg77Lnmqsxp9mSej5j68Z9BUaqOffGqtQwskjYt88= X-Received: by 2002:aa7:d905:0:b0:601:8e4f:2eb3 with SMTP id 4fb4d7f45d1cf-6028fbe2b59mr9108a12.0.1747936890338; Thu, 22 May 2025 11:01:30 -0700 (PDT) MIME-Version: 1.0 References: <20250522012838.163876-1-roman.gushchin@linux.dev> In-Reply-To: <20250522012838.163876-1-roman.gushchin@linux.dev> From: Jann Horn Date: Thu, 22 May 2025 20:00:54 +0200 X-Gm-Features: AX0GCFsRGhGmDXFm5yb_HSIAhFgPKv3Mqm8Lu7C30sJ_pCqFSfVgLnVDarBenOE Message-ID: Subject: Re: [PATCH v6] mmu_gather: move tlb flush for VM_PFNMAP/VM_MIXEDMAP vmas into free_pgtables() To: Roman Gushchin Cc: Andrew Morton , Peter Zijlstra , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, Will Deacon , "Aneesh Kumar K.V" , Nick Piggin , Hugh Dickins Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 587E8160003 X-Stat-Signature: buet13yqqsu1aax3i4mgcdj3j7nxr7n7 X-Rspam-User: X-HE-Tag: 1747936892-740601 X-HE-Meta: U2FsdGVkX1/nKuh/ts/6ouyZs8ajNIjLPi8jEvdue0AMM8MVDPwi8GbweObDdDQFe3ANFUqnf9sQ1tOTiHwnSjjnd+3iKtmeelm68OUVznBSyWyo2xQpN2QKN7zUAWcGqb+H0bqShwuJiDkbq5PDASSLDEftIScXjiCOrhYNmkGpnToADnsyASuIa325K+QHGfzBc474Jm/+24iL5/2nx+VNeeWgIHDeSViChQasrf+7GY7lt5RHo+lrltZafCat0QTngvjA72aL4Buy3nCub9IsZ40xrO+yIMtH0qgrk6MtBj/0PsVT8T7EDPVquM9We96H1TJlVFoQAleQeSIDzXubbvuktXIojuc9RJ14i4WbqQgsSfIu+Qno37bmuIO4U2Xr45dOFgUba/inzAyr4AWrIQLkf6WRAsX7H7aYulvmi1GNJcvVxCJ0ROSeaxrqciQ9EZfKKSJuiuuDTCwR3YTqywsPwi1vTobOs5hIh032PpmEOWd0JPtya9Upu91PgmnXV31KWxAsHCPQzhn6Lb0QYOo02AmJK2QqwYjirhVpLSQ980d4OjKVasWQmZ90T9fOnm/ceeujA2YQbIxFfTfBv+Fr1PyZJUEugYc6Da7K+qmQygxmx7x6YY6Ry2MKlLQRuKmO0JoKmZEuEP/qygDgiAcuYgyT7EJzKTcwtZRk6ujtYhWGOcWJ0yOOZjDAaUbZc776bQhAvPyFlJ2jkA4ggVNrGiup+xsYhkAF6rFuyi3lofmKqBSSPhgXrATrYFc1WLFAGcgcO7r6bT5XK7IxuESAyOhkpLcCsNnBPhPVS+SvdsKRiMVEzL9KOvjdz8mDquHj7CW+980+LhVKwcSuBFdUsgtrWDlSWlm/GhM9Ly6OQOE1sE3CXcB5or5NZyd44fypAR1/Ljo7+vsq5RRzyR30KpLiGOEXA2RLnUZO1PA+BMvThLqJHy2/Q3h/Sg+kxwl15/K5HshPsI9 4Twzz/TQ KsxsV0LzUO0oLAssrUQL12YR6LtZdIWhOn8YaHLhv4wgBhwXKogOpW9632sb2CC73bj6BzBPMQNb0aSczG7APfFttDvfnpvfbdxqZtAR9FSmoi72cOp+sYXH+RD1hS0luFdXUFAmVCJv4OA3Wbzzh5h+6BCtANZBAHWCN/e/B3Us10Re1ML7DaiLyz++hgsks5WT0GsRtAoAX4rSBy88Pi2G12NsBiel/1yGzj1G+fhc39kDzVbmJtuPuyB3PcboeY1qwMrbM0jn9k1GA7Ob1nLSFg5c7UvXRfFUSWVgOUVR+gwXMfmdpxCWgYYfoKOOQg3kvZuoFXQW6meLTrluu1Tie+QcX6BFrWKT4rncSv2d0/9ZACCyvqPTc32nePGzjXQIhe4B3PtbdM7GLpYjo/61rdHNmFa2nXdItEMPtAwc2GVZ8Zht4hS0neOcCdescm8TxLQBNTplczVsFvUJW8T5H9gj1jzYTutXUsFqJN99wt4M= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, May 22, 2025 at 3:28=E2=80=AFAM Roman Gushchin wrote: > Commit b67fbebd4cf9 ("mmu_gather: Force tlb-flush VM_PFNMAP vmas") > added a forced tlbflush to tlb_vma_end(), which is required to avoid a > race between munmap() and unmap_mapping_range(). However it added some > overhead to other paths where tlb_vma_end() is used, but vmas are not > removed, e.g. madvise(MADV_DONTNEED). > > Fix this by moving the tlb flush out of tlb_end_vma() into new > tlb_flush_vmas() called from free_pgtables(), somewhat similar to the > stable version of the original commit: > commit 895428ee124a ("mm: Force TLB flush for PFNMAP mappings before > unlink_file_vma()"). > > Note, that if tlb->fullmm is set, no flush is required, as the whole > mm is about to be destroyed. > > Signed-off-by: Roman Gushchin > Cc: Jann Horn > Cc: Peter Zijlstra > Cc: Will Deacon > Cc: "Aneesh Kumar K.V" > Cc: Andrew Morton > Cc: Nick Piggin > Cc: Hugh Dickins > Cc: linux-arch@vger.kernel.org > Cc: linux-mm@kvack.org Thanks, this looks better. Reviewed-by: Jann Horn