From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7177C3ABAD for ; Fri, 2 May 2025 15:11:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E544F6B008A; Fri, 2 May 2025 11:11:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E04136B008C; Fri, 2 May 2025 11:11:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CCC586B0093; Fri, 2 May 2025 11:11:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id A9A776B008A for ; Fri, 2 May 2025 11:11:43 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 6EAEE1D0EA5 for ; Fri, 2 May 2025 15:11:43 +0000 (UTC) X-FDA: 83398307286.24.52568E1 Received: from mail-ed1-f52.google.com (mail-ed1-f52.google.com [209.85.208.52]) by imf11.hostedemail.com (Postfix) with ESMTP id 6336F40008 for ; Fri, 2 May 2025 15:11:41 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=zBtse1mF; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf11.hostedemail.com: domain of jannh@google.com designates 209.85.208.52 as permitted sender) smtp.mailfrom=jannh@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746198701; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=FKlZk6KjghNkNzFfe2VS93WmUZ24CsLkd431OYU93qY=; b=IRNPyiJgfTfmzQ3hO+3w7L88Z5V0YoEVfG00VgMnjPUUbElVHMbyWBShWn86e/MDbCO017 fR6X4QyiXtVQg7c9kBQJ3s+oR73mYZR9d7cfngpL1niOJGHadfp/kXG3TOncQ0x/+RXNmX EUhZeCHT2zy+wyZzhutWbxyt8MpMP6c= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746198701; a=rsa-sha256; cv=none; b=AYNxBvzwmejRw/4wfz4kdIQsrECT8cgduzHqGVUQ2O9w7I5O+tG0nA4sIUj0DVqKU0hdDe KkBqhlADvIUMCNUtmxU7UUGnyHtnnkN+nmsc/000qmcuoee3Wfk8ODvrzwNsgtGd64pCE/ 6PZqz0Tdq/m6Ex952sHOUoAsRhvqpPc= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=zBtse1mF; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf11.hostedemail.com: domain of jannh@google.com designates 209.85.208.52 as permitted sender) smtp.mailfrom=jannh@google.com Received: by mail-ed1-f52.google.com with SMTP id 4fb4d7f45d1cf-5f632bada3bso9190a12.1 for ; Fri, 02 May 2025 08:11:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1746198700; x=1746803500; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=FKlZk6KjghNkNzFfe2VS93WmUZ24CsLkd431OYU93qY=; b=zBtse1mFFVOpsB9mZ7+sn8I6oq1Eobrg030BoqzuwrOJDYJGNV96WB2BfexzD9L9FU xiFW71CYYI7LOsxePyeFUMagJHrIMfuCy5xvuNIhjb0LMMYRDuGzEkeAMV4cH9UhZsHT ZSUWkPfhAzqh7bO0L/xjClenHUFwp+z+p0oy/luZtQlwSTdEQj+Fh1+VNk+RhTz5AXx5 ZyElzg5/RGBQOVG8RENhq9VjjvPt8ASEah8e4jaLeZi4l+ydXYkovaZTnXdqW3FMAiDG XwFCrU6nmBdVL4GlhCUH6iW3Hp3Ky5nKCHxBba80MVZ1StY5DLKI7nJWfpU9Jxpx/QU9 7rOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746198700; x=1746803500; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=FKlZk6KjghNkNzFfe2VS93WmUZ24CsLkd431OYU93qY=; b=HDlpOzKDY/xOiB5TKwU8MvEUzamjsL5c59XZmAF0mUnoWQ75YkahDHb6tlOES9/18G 45MHtChCMo4QQpDOSWmMKv4lg0CTG5DyshUGDaQ7SlaYdvsT+ktU4wetUQPwcUVfiHN/ x2kzP3ienPJDYaA5vHSSNjFbXy5Ud5mOCpeECQk4Ojeu+J9xIdMd6NWPWK4/tTL5RXRd XntHY8Al80lPIL0ea6W9IsoJvwlyaIAeRMPwouunyN2p7t8rhAsvZLIci+Ui10d0tX42 kaQ3th3FPdH9Y+QUzvX0XRUaH94vRZWFlkisRw3A48hq8tmHx/wcFyqbTyviyU3EJCbL gGuA== X-Forwarded-Encrypted: i=1; AJvYcCVKi/zLOqz3WFeoweYgMa90HHjCSIQYc+Uktcg4HE7WsCbd+NiHWJsoJt1pDZLkpGMg0xe7aCw1rQ==@kvack.org X-Gm-Message-State: AOJu0YwpPlcHiwC06uLT0ium72qm3yu2MOHGnROpLgkSHvR7VfiEQDd/ Chr7j7QVSPe4Fox49Wc0ODS81afeJtPu8FaGabClzyj8macRXjrhdjKmvwaRZsixOjaZalqGXiv 2pJd76pH7+kiq3mhgM/K9ljieWKa4JJaOX0kj X-Gm-Gg: ASbGncvmuXn5hoEkdZtwDDSGl3fjxcqdOadg2oXFr++bIQNHR8Ug4G2UXTdccQJ0Exh Fyv5hkWnGVn80LUbvIHPniCWHtLuUwNsa2Qje5vXMDSqoMpwrdfBGIM9ocR7iLIZ7r2IXPbOnC+ QxzkZ8hDVDVJC3VNQo+r6XQe/qitspMPx6PZt50berr/xVE6gK5w== X-Google-Smtp-Source: AGHT+IERkzDNyTmOeaZwge9izZvT+3a5JL1Pt5BG92diaSrHdsXlC4LhpWG/7aF50+We9CxCzaJagP6DJzyfICQLxvQ= X-Received: by 2002:a50:d556:0:b0:5e6:15d3:ffe7 with SMTP id 4fb4d7f45d1cf-5f918c2a177mr184575a12.7.1746198699387; Fri, 02 May 2025 08:11:39 -0700 (PDT) MIME-Version: 1.0 References: <20250418174959.1431962-1-surenb@google.com> <20250418174959.1431962-9-surenb@google.com> In-Reply-To: From: Jann Horn Date: Fri, 2 May 2025 17:11:03 +0200 X-Gm-Features: ATxdqUFG2iaTkmFhKeQVVpe2LikO_MhFJjHWYrIsMyz9yg82E2DdMFylx1L3_Nc Message-ID: Subject: Re: [PATCH v3 8/8] mm/maps: execute PROCMAP_QUERY ioctl under RCU To: Andrii Nakryiko Cc: Suren Baghdasaryan , akpm@linux-foundation.org, Liam.Howlett@oracle.com, lorenzo.stoakes@oracle.com, david@redhat.com, vbabka@suse.cz, peterx@redhat.com, hannes@cmpxchg.org, mhocko@kernel.org, paulmck@kernel.org, shuah@kernel.org, adobriyan@gmail.com, brauner@kernel.org, josef@toxicpanda.com, yebin10@huawei.com, linux@weissschuh.net, willy@infradead.org, osalvador@suse.de, andrii@kernel.org, ryan.roberts@arm.com, christophe.leroy@csgroup.eu, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 6336F40008 X-Rspam-User: X-Stat-Signature: gw7p738zdypj5r1jydqg1snm76zxkcnn X-HE-Tag: 1746198701-476598 X-HE-Meta: U2FsdGVkX1+2y+aqO0aoBixKQvRZ9G/GuCV48E1UpexOOwBoxRDeF5iAAzhZr8wWmZBPKQ+p4Co7a3Tdg0r6eFPLTHXNR+FMPlfvn7eM7VywHKf1pmMMsuiH+lfEw9bKs7fBaQHeYWtFE1E1mswBsyfWgb5Ajnv0OG7ui9UI/08W5skHFz/p0I/LY2OujDH5enCFIUn0VHda7ZquOdt09yG+TXKTqgcDJRaadHoXngBg4s64yLpwYPl9czyd9FPD8raZj6SO8gzl92c4SY4/N3bsQ3TW23U8Kn0cItILLUQFQveCuCX4aBOvv7P8t5/buSp2pJIgORt32m4fHedd9lFlt7X73ZifUatWTEIaZNpzxAGtILX8u+qyEum8pDMfSnfgMk54osJmNuhs0cZApv323ZMSh7L93PQK1axjusej4yPLTPr+2FILgI+ykIypoBn1xAhyJSfFB02gxkx2KvE7OYOIp1YDX5ezq9zpUm9JKuEGONzDvxLANrSCrA6RfQsawVb2aXGOmalChyFKc9k7hVkHfbOfSuKUXIiQ9oWYzq92eApLOwbaumT0dkhkj78f3ziqIb9XpT0C1r2/gdzKqhf0pEfoXErZrFxAxJiUZutoOVGjD+fw1JKkOOFgXv2CYlWy6oKToJuhb0EOD2heytXlJ0FQhED98sXJ9VVIUeNOTfpN7vKne/fhUOG0VzPTneCk56FkclHqX8FtbfdNhwWWXA7cTNrbEHZPOEWDgw5UNmUw82N0hy5vG/kiiaRQJu41svB5eO8BmejzbJH7P/t4sJGcjSIzkpcLSHsBFdoTswq0GBWcu4p5/ByLGXhYYIbel2ALcwJEKq9gOYhuxLwy+kwVkmn0as14f02AOA9Kf+g46a8enGsWYr6ky3MzYhFhJjsxKu3lEcJudfYQnyOyfw5siMU/ZbJhYPrcvHpxCFDx+1JeFVDunFqCwThHsUf3onU00fpBEmY GO75SjAZ 1B1GRHAfqJrCIvj4APLvCiDRzLaHSGMI4FGdqy9sX3I21fqnEtoddRSx78pFY4z9Fmzdkq13J8hfBFCX9uL9HIqBOQfrut86N4XgTo2oMphWzVz/SR2l+oT0TVw9uZukRnWdnHsFL9hfetO0OnLODM/um+LH5F2VjH+L0TK619qyXQFc+K+YjoyAaELrzGolZeegFeqOedn4JdO70Ewktc7cazzveGl70pBJrZ0pdh0Zbun/1lGhYb8q1KcY29y5nKpbT431pMsoZSAJGXCDYQBu5rzkXttucWQ/uJeE1ggaOTaI39tA8HIrA2sdhMOAeyxYIA9L4X1CLNu5PblM7xzxSIKsmeU3Q3OuQelpxbBmnCn0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, May 2, 2025 at 12:10=E2=80=AFAM Andrii Nakryiko wrote: > On Tue, Apr 29, 2025 at 10:25=E2=80=AFAM Jann Horn wro= te: > > On Tue, Apr 29, 2025 at 7:15=E2=80=AFPM Suren Baghdasaryan wrote: > > > On Tue, Apr 29, 2025 at 8:56=E2=80=AFAM Jann Horn = wrote: > > > > On Wed, Apr 23, 2025 at 12:54=E2=80=AFAM Andrii Nakryiko > > > > wrote: > > > > > On Fri, Apr 18, 2025 at 10:50=E2=80=AFAM Suren Baghdasaryan wrote: > > > > > > Utilize speculative vma lookup to find and snapshot a vma witho= ut > > > > > > taking mmap_lock during PROCMAP_QUERY ioctl execution. Concurre= nt > > > > > > address space modifications are detected and the lookup is retr= ied. > > > > > > While we take the mmap_lock for reading during such contention,= we > > > > > > do that momentarily only to record new mm_wr_seq counter. > > > > > > > > > > PROCMAP_QUERY is an even more obvious candidate for fully lockles= s > > > > > speculation, IMO (because it's more obvious that vma's use is > > > > > localized to do_procmap_query(), instead of being spread across > > > > > m_start/m_next and m_show as with seq_file approach). We do > > > > > rcu_read_lock(), mmap_lock_speculate_try_begin(), query for VMA (= no > > > > > mmap_read_lock), use that VMA to produce (speculative) output, an= d > > > > > then validate that VMA or mm_struct didn't change with > > > > > mmap_lock_speculate_retry(). If it did - retry, if not - we are d= one. > > > > > No need for vma_copy and any gets/puts, no? > > > > > > > > I really strongly dislike this "fully lockless" approach because it > > > > means we get data races all over the place, and it gets hard to rea= son > > > > about what happens especially if we do anything other than reading > > > > plain data from the VMA. When reading the implementation of > > > > do_procmap_query(), at basically every memory read you'd have to th= ink > > > > twice as hard to figure out which fields can be concurrently update= d > > > > elsewhere and whether the subsequent sequence count recheck can > > > > recover from the resulting badness. > > > > > > > > Just as one example, I think get_vma_name() could (depending on > > > > compiler optimizations) crash with a NULL deref if the VMA's ->vm_o= ps > > > > pointer is concurrently changed to &vma_dummy_vm_ops by vma_close() > > > > between "if (vma->vm_ops && vma->vm_ops->name)" and > > > > "vma->vm_ops->name(vma)". And I think this illustrates how the "ful= ly > > > > lockless" approach creates more implicit assumptions about the > > > > behavior of core MM code, which could be broken by future changes t= o > > > > MM code. > > > > > > Yeah, I'll need to re-evaluate such an approach after your review. I > > > like having get_stable_vma() to obtain a completely stable version of > > > the vma in a localized place and then stop worrying about possible > > > races. If implemented correctly, would that be enough to address your > > > concern, Jann? > > > > Yes, I think a stable local snapshot of the VMA (where tricky data > > races are limited to the VMA snapshotting code) is a good tradeoff. > > I'm not sure I agree with VMA snapshot being better either, tbh. It is > error-prone to have a byte-by-byte local copy of VMA (which isn't > really that VMA anymore), and passing it into ops callbacks (which > expect "real" VMA)... Who guarantees that this won't backfire, > depending on vm_ops implementations? And constantly copying 176+ bytes > just to access a few fields out of it is a bit unfortunate... Yeah, we shouldn't be passing VMA snapshots into ops callbacks, I agree that we need to fall back to using proper locking for that. > Also taking mmap_read_lock() sort of defeats the point of "RCU-only > access". It's still locking/unlocking and bouncing cache lines between > writer and reader frequently. How slow is per-VMA formatting? I think this mainly does two things? 1. It shifts the latency burden of concurrent access toward the reader a bit, essentially allowing writers to preempt this type of reader to some extent. 2. It avoids bouncing cache lines between this type of reader and other *readers*. > If we > take mmap_read_lock, format VMA information into a buffer under this > lock, and drop the mmap_read_lock, would it really be that much slower > compared to what Suren is doing in this patch set? And if no, that > would be so much simpler compared to this semi-locked/semi-RCU way > that is added in this patch set, no? > But I do agree that vma->vm_ops->name access is hard to do in a > completely lockless way reliably. But also how frequently VMAs have > custom names/anon_vma_name? I think there are typically two VMAs with vm_ops->name per MM, vvar and vdso. (Since you also asked about anon_vma_name: I think anon_vma_name is more frequent than that on Android, there seem to be 58 of those VMAs even in a simple "cat" process.) > What if we detect that VMA has some > "fancy" functionality (like this custom name thing), and just fallback > to mmap_read_lock-protected logic, which needs to be supported as a > fallback even for lockless approach? > > This way we can process most (typical) VMAs completely locklessly, > while not adding any extra assumptions for all the potentially > complicated data pieces. WDYT? And then we'd also use the fallback path if karg.build_id_size is set? And I guess we also need it if the VMA is hugetlb, because of vma_kernel_pagesize()? And use READ_ONCE() in places like vma_is_initial_heap()/vma_is_initial_stack()/arch_vma_name() for accessing both the VMA and the MM? And on top of that, we'd have to open-code/change anything that currently uses the ->vm_ops (such as vma_kernel_pagesize()), because between us checking the type of the VMA and later accessing ->vm_ops, the VMA object could have been reallocated with different ->vm_ops? I still don't like the idea of pushing the complexity of "the VMA contents are unstable, and every read from the VMA object may return data about a logically different VMA" down into these various helpers. In my mind, making the API contract "The VMA contents can be an internally consistent snapshot" to the API contract for these helpers constrains the weirdness a bit more - though I guess the helpers will still need READ_ONCE() for accessing properties of the MM either way...