From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B273E7717D for ; Mon, 9 Dec 2024 14:39:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B23F48D006F; Mon, 9 Dec 2024 09:39:09 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id AAB588D0058; Mon, 9 Dec 2024 09:39:09 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 94D318D006F; Mon, 9 Dec 2024 09:39:09 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 69D048D0058 for ; Mon, 9 Dec 2024 09:39:09 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id BE4A7A06B0 for ; Mon, 9 Dec 2024 14:39:08 +0000 (UTC) X-FDA: 82875677010.08.A65F3CC Received: from mail-ed1-f41.google.com (mail-ed1-f41.google.com [209.85.208.41]) by imf02.hostedemail.com (Postfix) with ESMTP id 5DAA98001E for ; Mon, 9 Dec 2024 14:38:27 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=r3C5l7SD; spf=pass (imf02.hostedemail.com: domain of jannh@google.com designates 209.85.208.41 as permitted sender) smtp.mailfrom=jannh@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733755127; a=rsa-sha256; cv=none; b=ZaBXCzUsNzwVE8cuY3fEfy0Wdjx5T064xn9XDoV+lL/xFgTeEq3AlPixtKUN55zgzOrd4u yM1qcGMO0lgDAIufPITRFSpISQuY6KQS49ixrFXbRcdyM+tpkvKhnRpQxuYrJZBmlq9Bb+ 9hJBrdlNXHz/M1m951K4flH1wCMFo5E= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=r3C5l7SD; spf=pass (imf02.hostedemail.com: domain of jannh@google.com designates 209.85.208.41 as permitted sender) smtp.mailfrom=jannh@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733755127; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=K0HUgDioPZP8r9lR0mhX1U3yWLjjLAk+xygWg9c9gYE=; b=ioyvONRhoCDyBNDj7JO719QP94JKeQLZBEYlguyv+kL2GspWA5kSYUrMw1AOUtY6p9rMZ0 netWN5cpTgAWXqJvrbzaCKsZgp3Wc+q0Q4fSI3twuZxWn5JgFigvWy3W4grZyk2iuV+5du 6nKz24IKbrrhjgD/+b0Wjg1RPO13fcE= Received: by mail-ed1-f41.google.com with SMTP id 4fb4d7f45d1cf-5d3e638e1b4so9258a12.1 for ; Mon, 09 Dec 2024 06:39:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1733755145; x=1734359945; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=K0HUgDioPZP8r9lR0mhX1U3yWLjjLAk+xygWg9c9gYE=; b=r3C5l7SDAs/41H3conGb/Fl1MMdLn2Zl4H82uMYSwqLpipxvqpi4EB7XBqHuMY1D21 OsyDWWxfCXvHvx/ROovS+9Ah5E3mYW3eUCysDajwZYuxNij0SMSy3z0OxJ6LY8A2mbh4 13GOjMs0fn20gtyDuqapMMmDjm4f9VQC9/vfiNBphlac+GAztyFyC7L6dg4VcZgcsZY5 G+u5mJM0ochKMmuniw+iXqcoX281eeQCbzaQciRghgUJqWfAMg/x3N7rE+YVm61khtPB trU7eANeqEsq88XPoEQk592Sl0VNGdCB4J2uw1+X5+X2AxNhZqi76IY9dkjLu6x9eOAg Kidg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733755145; x=1734359945; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=K0HUgDioPZP8r9lR0mhX1U3yWLjjLAk+xygWg9c9gYE=; b=piuSr+71WHn95DkLAqcnNQeq44lFPbSqKHj07HJSBBYwDlLyNUKEEzyU/jzzC/rlVZ HbnEDCwaMYZiEgDWZzalO/fO4dSYob5m6/70X41DQtjEblzekoxyxigwF/t1lHiVgJ50 vsA7s5c/2+0HjXv7im9LHF3iepzcs39gPx6LIcDz0wwAGW64E9mA326Ms8ptZ3IIMRZZ 3mR7L1bOm6+4Oa9RFU2gjR9gk0nxUNd6azIvYSnaxt3nBOOo5ZQ8m4zv1+Appw1Wala/ GOZR1puO0eNyMJHrXX03QQNR1e16MYPGYYEoeLdtTjnRcyzma59ENWYKtg0cTOlwobM9 By/Q== X-Forwarded-Encrypted: i=1; AJvYcCVPMnUBbYKyOHPEvBLHjMVUZD7CiwADTUJAEm0oV2o2JDAeyByugonRLAwIz3tNApboD1HsozOfqg==@kvack.org X-Gm-Message-State: AOJu0Yx6jE6+cXLNDbGWRCMXE4PIXOt7bnYK887Z6eDvckEasfoY3EqB 5q9uD50+7l/x7tNSPUzuCXH55q8BOCbCZTqmhlpxmG3WfuhuGsDGY692Y0mMXr1qzD1f1xxKIee 1t7WELdlJ9M8tM93Q7mAoPV8VeKCEh27te1BJ X-Gm-Gg: ASbGncuylcEh8PFxcgIK89I5VvLPO7GtQKRhNQOlAoMWT0bC5RwdWX6lhVC6LkbTfQb yQ3bcRYcAlcdqA4oblDpgJkX46UiATsvTwY0vFBnBmgdXAST7MfdaJ6MUVmw= X-Google-Smtp-Source: AGHT+IGttMIbSXRcwbOzyv+s/N1tg8+a5C9j4EQR50flx6las7dboUBXcq3fmF5gfAB4rcz9OaVcYN7/1a+LIhwykhA= X-Received: by 2002:a50:cd19:0:b0:5d0:b029:e2b4 with SMTP id 4fb4d7f45d1cf-5d3dd9c511dmr127165a12.3.1733755145049; Mon, 09 Dec 2024 06:39:05 -0800 (PST) MIME-Version: 1.0 References: <20241206191600.45119-1-lorenzo.stoakes@oracle.com> <23d3d7f6-d6d1-430e-8ea0-ccae76b253fd@redhat.com> <41a14051-75ee-4de3-863c-d0532aa7e3aa@suse.cz> <1e4c3e31-ea9a-4af4-83f9-15a882732e69@redhat.com> <71beb3d1-21ac-4037-8363-6484c0c333b8@lucifer.local> In-Reply-To: <71beb3d1-21ac-4037-8363-6484c0c333b8@lucifer.local> From: Jann Horn Date: Mon, 9 Dec 2024 15:38:28 +0100 Message-ID: Subject: Re: [PATCH] MAINTAINERS: group all VMA-related files into the VMA section To: Lorenzo Stoakes Cc: David Hildenbrand , Vlastimil Babka , Andrew Morton , "Liam R . Howlett" , linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 5DAA98001E X-Stat-Signature: uj5qaatt1dqz5b6p6pefsdw8n49z5oz8 X-Rspam-User: X-Rspamd-Server: rspam09 X-HE-Tag: 1733755107-307716 X-HE-Meta: U2FsdGVkX19xkHdErmfMEFIf3BF488S6vGldlpOABG2wynf+6yQefKOlegAN9ks8dWccCOUI7lEplW8BKs8EjBpGw+y+l4GS9OSZgrJV7sA/zQ93QHPCkrlSRodP6k+yIx3i8cGl1x9Rvp3QExp6naMZ1lQbTdvpYaknYt3YBEBnvAHE6ot++93x8xGNvvcLhWS2MzUMj3mQWbWhGpjMMcTiiCnqqo7AN9yklseFcBfiQQjThLye1ARnNOEk+SEVHrCMCiG6bCp1d28UiyUwoRN/5UdQ6M63/f/MSbvXC7wzoat1uNZt+wCU1Sn0zrhrlFed4l7bbPa+xM0rXdyBYDmxbwf7cN6krMZ2PFQ2u/zZWDTZu8GgcjS4AMurfBlWmP3+VnQk8LyIykCT2vwpGJuW+ED0EIICZYzc+jzSukDIdyivHQc57/Lo0WT78GLqiVIW/gJ78EHKfeNETWfFkgtxUURHrAhaXctGm+kUiGIdoNKb57zqZzVhi03K4D2N2hYFJhyC+rCjAURRU4gEch9HuZRACsHDNl3XLcruvw7mgImzoUoWpEvd3fmkhwMKJnOVc7xsiBbczf8RWOuhC6V0DL3IeDO2SuBEDw0W9V2i6YqK0/tiS1drYAcMLp0LdDhUshJVzHayt0Jtn2mMPbcs48jrQ2AVhZDNkcvmYAtLrpXxu5qZV0dHRrr3ORTm4dt9bCvT6Y3YlcWCDPSl7MTKEME3r5qdZ+doPO3o8l9VYvgPvmaKc1KHtoxn6OzG5QVg2N36JQQOtjrfAmiL7QDTe08vkH69h72H3VwZm3HeEPwA+R+syPGTvyRt5gu8v4L4uOzSmq+YZm3qZP+eaBP2LUqs81U05uoX41W5y6pvK2cnfQPdgHuX+jx/z5nNcDLgt5sk92rsGc6dzGozttTpZgQbd2Xu7pmeYdmoIrcl+VPOXfFfCilYstfq5fDXvdtWdK1D2PpxIG8w4ET 8IUy/Bya 1O5D6KYs0xYEP+5Ix5YSn17STeQ7c2G++kUhPX1GUHcgplshLCVhiK06/QTuYvhuR397IiOXm8VRoXvoRJEQHiX3RCw6+CIX3NQ4DEUSJM3JXv1HYy+sSAdE/Hrw+djhNv5O9mHNfPxk4o/0/OXJwGzBfPu52ufVW2MvCb0sslCUkgoXipkmkNmbPREVAgRfdkh2ASEeFDznjjyAhVQ7IH2giPSUIAB7RnROZVj3IMmVYgu690VCWDDX7HT7K4wtEgV7QMgtMoesG+M7GQH23lWQE8m4aB33uuqr/QheIf4G1g0/CCaR2pvXZrzc9fNvpstwydxa3pQCsstKFfwB+yLHXlJ7on9aXpu2I0mUvSDxP6NyfbgmVNJn9WKCf09oX+UHOcb8zfZSG88VrETZ2KULs4Wi5gitMgqy5bWOzeTwwe0b6woeFERzfbVVVnzquixfg/S28dm1nQKR3WeMFVYcrtNwb1Mn0NH3MOC63IuvZPGomceEU+a91V5j9y+a5tyu5yvSEppFD0os= X-Bogosity: Ham, tests=bogofilter, spamicity=0.143519, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Dec 9, 2024 at 3:11=E2=80=AFPM Lorenzo Stoakes wrote: > On Mon, Dec 09, 2024 at 03:00:08PM +0100, David Hildenbrand wrote: > > On 09.12.24 14:25, Vlastimil Babka wrote: > > > On 12/9/24 10:16, David Hildenbrand wrote: > > > > On 06.12.24 20:16, Lorenzo Stoakes wrote: > > > > > There are a number of means of interacting with VMA operations wi= thin mm, > > > > > and we have on occasion not been made aware of impactful changes = due to > > > > > these sitting in different files, most recently in [0]. > > > > > > > > > > Correct this by bringing all VMA operations under the same sectio= n in > > > > > MAINTAINERS. Additionally take the opportunity to combine MEMORY = MAPPING > > > > > with VMA as there needn't be two entries as they amount to the sa= me thing. > > > > > > > > > > [0]:https://lore.kernel.org/linux-mm/CAG48ez0siYGB8GP5+Szgj2ovBZA= kL6Zi4n6GUAjzzjFV9LTkRQ@mail.gmail.com/ > > > > > > > > > > Signed-off-by: Lorenzo Stoakes > > > > > --- > > > > > MAINTAINERS | 19 +++++++------------ > > > > > 1 file changed, 7 insertions(+), 12 deletions(-) > > > > > > > > > > diff --git a/MAINTAINERS b/MAINTAINERS > > > > > index 1e930c7a58b1..95db20c26f5f 100644 > > > > > --- a/MAINTAINERS > > > > > +++ b/MAINTAINERS > > > > > @@ -15060,18 +15060,6 @@ F: tools/mm/ > > > > > F: tools/testing/selftests/mm/ > > > > > N: include/linux/page[-_]* > > > > > > > > > > -MEMORY MAPPING > > > > > -M: Andrew Morton > > > > > -M: Liam R. Howlett > > > > > -M: Lorenzo Stoakes > > > > > -R: Vlastimil Babka > > > > > -R: Jann Horn > > > > > -L: linux-mm@kvack.org > > > > > -S: Maintained > > > > > -W: http://www.linux-mm.org > > > > > -T: git git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm > > > > > -F: mm/mmap.c > > > > > - > > > > > MEMORY TECHNOLOGY DEVICES (MTD) > > > > > M: Miquel Raynal > > > > > M: Richard Weinberger > > > > > @@ -25028,6 +25016,13 @@ L: linux-mm@kvack.org > > > > > S: Maintained > > > > > W: https://www.linux-mm.org > > > > > T: git git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm > > > > > +F: mm/madvise.c > > > > > +F: mm/mlock.c > > > > > +F: mm/mmap.c > > > > > +F: mm/mprotect.c > > > > > +F: mm/mremap.c > > > > > +F: mm/mseal.c > > > > > +F: mm/msync.c > > > > > > > > Not sure about mprotect.c, mlock.c and madvise.c, though. I'd claim= that > > > > the real "magic" they perform is in page table handling and not > > > > primarily VMA handling (yes, both do VMA changes, but they are the > > > > "easy" part ;) ). > > > > > > I'd think that moving vma files into MEMORY MAPPING (and not the othe= r way) > > > would result in a better overal name, that would be a better fit for = the > > > newly added files too? > > > > Maybe. I think vma.c should likely have a different set of maintainers = than > > madvise.c and mprotect.c. (again, the magic is in page table modificati= ons) > > The bulk of the logic in mremap.c is related to page tables so by this > logic then, that is out too, right? FWIW, I think technically you can have multiple entries in MAINTAINERS that cover the same file, maybe that would make sense for files that belong to multiple parts of the kernel? Or maybe I'm making things too complicated and it'd be simpler to have some kind of more generic "core MM for userspace mappings" entry or such.