From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5AD44C36008 for ; Tue, 25 Mar 2025 18:42:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 35C9B280042; Tue, 25 Mar 2025 14:42:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 309E2280022; Tue, 25 Mar 2025 14:42:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 18597280042; Tue, 25 Mar 2025 14:42:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id EEF3F280022 for ; Tue, 25 Mar 2025 14:42:29 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 10C59C0BD9 for ; Tue, 25 Mar 2025 18:42:31 +0000 (UTC) X-FDA: 83260944102.14.1396B69 Received: from mail-ed1-f53.google.com (mail-ed1-f53.google.com [209.85.208.53]) by imf09.hostedemail.com (Postfix) with ESMTP id 1AA94140007 for ; Tue, 25 Mar 2025 18:42:28 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=UQasY6ey; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf09.hostedemail.com: domain of jannh@google.com designates 209.85.208.53 as permitted sender) smtp.mailfrom=jannh@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1742928149; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ohWbm/UuIc3MDUKHoYt0YitrpdOZotQW09VJZwN6f+A=; b=xoZyiys7Z0uD5CrxdfTAjIFmxe+rfc5JVp2V+HVPne71sVZ5HeXMoAuqlo1s9PmJFbwy5f 1zsrJV30ILI/e+XvxNFCZVyC/pF9q9mLLbW3dkDd38KP+KEGcDAO+jK2R5IoYX2RZptyG3 4sxxReWVa7fxJHorjjn8Fx/FL5vdfDc= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=UQasY6ey; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf09.hostedemail.com: domain of jannh@google.com designates 209.85.208.53 as permitted sender) smtp.mailfrom=jannh@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1742928149; a=rsa-sha256; cv=none; b=xTZcCydBdlJRy7CsvgvwwvPTjIWq6dpdzcfE+tghf1qsRofnFz1ltM0DsP9rYfqICLcuyd yQ9s8P7pRJgkz10v/4SgCzhOMf4vnVdZNYh0jhEniGvAeKJzq304w99RcgsH+3FFZJuheg 8/Hg2hQI+VS2ZAz+b8ygu9tphHXKvAs= Received: by mail-ed1-f53.google.com with SMTP id 4fb4d7f45d1cf-5e5cbd8b19bso1980a12.1 for ; Tue, 25 Mar 2025 11:42:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1742928147; x=1743532947; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=ohWbm/UuIc3MDUKHoYt0YitrpdOZotQW09VJZwN6f+A=; b=UQasY6eyWptu1w/7mQK2koKYKamWyNIRVoctz9ZFyxsKp9CdMSbe8saa9z1tPZYjff Jk8xjeK6hgy0uaa+/G2vdNdzxT1cCVAGrUpv/0JO4Vs6NlpgDlpLTeWAFFp+NsmbL4hW jxNIPfncXUvnZUHrQWaFhOXRpvLU7XrqLN/ku4Sqmesm2lg5Q8nspSRQzNUDLfeLE6nM hXMvNElRzOmk+MzVfx5oiyHTdWg3wK1iq/aqmTocTS4zeHomsofQVnAcjPZTSts1J81m 3AV2kCTvlQQ5jFv0ifVkKbaVfJmvJAYqltpOP3GfWvkQZNh89mryLs2EH4YtnEhVi9LR ay/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742928147; x=1743532947; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ohWbm/UuIc3MDUKHoYt0YitrpdOZotQW09VJZwN6f+A=; b=WGBQ8PQrAb83O20ubZI2OtFS8rhr1ZMg+MAEZruDzHNq6KvhmyTkW9w1VOpgiVZsi2 GdGOjtT/iyQhgxmHxiTx4ef9d4NdOiRbvSgFZWCN0FkVWGUKv+vqh3LSDLSRKntlhv0h 7w4G7jYu/lSQzSY4QE3lUYvlxpig8QWv66c2gqvoa7hl0c936+JXTQeaYKj1hPxI7Ayf J9GzksaFOHMwdNgeDK8l9Yx6I+ybSriu521j9GvJoZ9ig8eQyGMJvqODEaEzZndgnq/M 6VpSf+E4wHVHf08IYaO/6//SgRNw0ycW27+WX6OedFwheRZ+GdFis47SZLVck5vuY2rV GYKg== X-Forwarded-Encrypted: i=1; AJvYcCXo+PyBF//PaDUoTDM6yor2tE9jwbNsyt3/KN1g6SGe0sDazmgTHLRAWzzROa8X44+4dABHjLOrgw==@kvack.org X-Gm-Message-State: AOJu0YzFRL4qfKoZHjA82kafyfRH6zz9NF08hB9Lj3ZwHZqhFNs4D7hK 1rOhHkToIkT3/KaLvAorRnHABpI1JU9mHi0XMXtFHkzmsqgepaazGYi6iXORGO2h+cUcrMvVZCq qxCt3WC9/Fbe5jAM/rSJcf4Ijn8VAJzAvUVGh X-Gm-Gg: ASbGncvl8GVtv+ZxY9kv944mugHY+NQMlSJ4MSU6rTkHvt1zYpYMXGgZn75YtYk2DCc 8zsLvcIa9tQnA1Yxj+QpWeYYJYDUETxIAAKTaYp0R6YE6njAIgGgaA3Dv43haJfCPH/b62++IoX pgPJgQcZerZ4rDceaL7uxNyWsDw0431GSw3vQodRMem7IDaYifbWTG13wyZcl57t64 X-Google-Smtp-Source: AGHT+IG/oxMHsUwCe/Pv38c6tGHW1E+mjtkA7yC/Fgzn+9xwryPNKquWqjWfGFAmY6c6RcrvuYp4RqLtrV1djsqY7q0= X-Received: by 2002:a50:ed83:0:b0:5dc:ccb4:cb11 with SMTP id 4fb4d7f45d1cf-5ed53ee96e9mr10451a12.4.1742928147101; Tue, 25 Mar 2025 11:42:27 -0700 (PDT) MIME-Version: 1.0 References: <20250114175143.81438-1-vschneid@redhat.com> <20250114175143.81438-30-vschneid@redhat.com> <352317e3-c7dc-43b4-b4cb-9644489318d0@intel.com> <408ebd8b-4bfb-4c4f-b118-7fe853c6e897@intel.com> In-Reply-To: From: Jann Horn Date: Tue, 25 Mar 2025 19:41:49 +0100 X-Gm-Features: AQ5f1Jo2l3CP6X5vd0V2T3oskBTdoXupZsoP0HqqqOWE1sDQ_J5UAMa3wCMvDAw Message-ID: Subject: Re: [PATCH v4 29/30] x86/mm, mm/vmalloc: Defer flush_tlb_kernel_range() targeting NOHZ_FULL CPUs To: Valentin Schneider , Rik van Riel Cc: Dave Hansen , linux-kernel@vger.kernel.org, x86@kernel.org, virtualization@lists.linux.dev, linux-arm-kernel@lists.infradead.org, loongarch@lists.linux.dev, linux-riscv@lists.infradead.org, linux-perf-users@vger.kernel.org, xen-devel@lists.xenproject.org, kvm@vger.kernel.org, linux-arch@vger.kernel.org, rcu@vger.kernel.org, linux-hardening@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, bpf@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, Juergen Gross , Ajay Kaher , Alexey Makhalov , Russell King , Catalin Marinas , Will Deacon , Huacai Chen , WANG Xuerui , Paul Walmsley , Palmer Dabbelt , Albert Ou , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Peter Zijlstra , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , "Liang, Kan" , Boris Ostrovsky , Josh Poimboeuf , Pawan Gupta , Sean Christopherson , Paolo Bonzini , Andy Lutomirski , Arnd Bergmann , Frederic Weisbecker , "Paul E. McKenney" , Jason Baron , Steven Rostedt , Ard Biesheuvel , Neeraj Upadhyay , Joel Fernandes , Josh Triplett , Boqun Feng , Uladzislau Rezki , Mathieu Desnoyers , Lai Jiangshan , Zqiang , Juri Lelli , Clark Williams , Yair Podemsky , Tomas Glozar , Vincent Guittot , Dietmar Eggemann , Ben Segall , Mel Gorman , Kees Cook , Andrew Morton , Christoph Hellwig , Shuah Khan , Sami Tolvanen , Miguel Ojeda , Alice Ryhl , "Mike Rapoport (Microsoft)" , Samuel Holland , Rong Xu , Nicolas Saenz Julienne , Geert Uytterhoeven , Yosry Ahmed , "Kirill A. Shutemov" , "Masami Hiramatsu (Google)" , Jinghao Jia , Luis Chamberlain , Randy Dunlap , Tiezhu Yang Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam01 X-Stat-Signature: 58sjy3pdk47ongseqtd6yhpudprg74z1 X-Rspam-User: X-Rspamd-Queue-Id: 1AA94140007 X-HE-Tag: 1742928148-259384 X-HE-Meta: U2FsdGVkX1+hEz7+Ze2is42F/3sDR2e0hgczcE/WmrBZ9mfQ1sB27atQID5BzDDt1oi5EMZXYFHOVOdkqq9AJa+hK/A4F8p2SxEj9dh89pIjrx9LXkz16BPkmrzDA5toFliZc+4hS9Zh3i42xnDDT61ysKwWRC2qVlbNTmY1FyhSJ7wUsM6om+pfg/DLYTmNLth9VK3CoN/rwX50AdgKJXPWvhbyJuRRkxil7Wma2qUyQ4/l/CFZ9bHl8oF5xgV0BybBMzSjtnj/CHH7Ki4i13mV4kiWZm/KhsOSfW8gQSlD4A6uegLKo8NjTiUpnM2cDszZRWwjr9HQVMXPqKcMwcrmGxzT4Vgi8UD8tQotWMefOWruSehysv8klRD2pUWE9acRw3sQ41muUgQZdEKUy+sAd/qGhA2Wifzus0NpaQTqdLIGIPqfO7yLvcBcCmZDDtWjoBSR1+iFoO/N0yl2WChdS+Ii5muArwxJCR0MagZ/Piake81QkrpZ9bxFdGxZ6idmy7yEtj7XmEpvkkcd1DeTxJadGdqPQcTKQ5dK/+lE5jXeW25KaKGboXY7rS67hUortdwOH9D1ir63HXrM8/09RlQcDDwmKcq6Xz1YhSZN5+OKICHlcH7+ilx2/vcAO55L47Uhttd1vpl9te0RHlG2K8eegFDfWspvR+C45z/wOUGCDPS+6NbFpMpxB3itUArlAP7jwFIUWGMt2s+Z2PrQRzK9bRcSdJRzPBOIYDACWUKbN7Zk9luwcdhuLzGVxPN4txeIDcN2oLp+dCVeOTbgwXKltJyprHhoTIgnZx2JQT68LfJM51lxNAW3KDT0Ubbl8vSjBOcH0kFAdGZUWGHKgZUVjITwgU42CWFH05CY4YW9qnrNVMWRp/iyilFJ1PsKvB5Q8v8bWvymHLmO6CEin/L7C8jfVVuzJv70N/1+dxGiUG7jhK+4qB91VUkww1zaclUwHYDreU5sQHL tu8gKp0d i/tCldNO3x/Yw4QSY1EnCIZKXv7Qibh60VpZPIZnHGqFDc9Vkizy3R48xtgYKqBvETXfXu50dN9Ue1uFPfaheLeVbF5BVPA81WyX2ntzPtKNyM3CtuOjAxvvKBS9CRA40Wg2Hw07xiWKk6f96yetJJEkh6xBhYRr73IHOTZVeqOc5hXFkoojeWbTnqQ/mZn9HykXDlb6CpUVowXjL0MvOIIm1NVkeiuZlD+fhBp8GJIZtAkkotzu4CznzlkqrmzJ2VlCX3d8kEPMRE2MPybcy1miffc67TYXqQxK2zoyBF5eDfkRsRdjRJVT2EuldnbChWEHS3PXKAlZftDG0HWIXeWzeFWmS5Tdh8ElvWoY/v6N0IwllLt0A4DOUiq3OZsPyTaISmlFTekRmPbdvbMTdPdljwqsF6R9K5pgv X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Mar 25, 2025 at 6:52=E2=80=AFPM Valentin Schneider wrote: > On 20/02/25 09:38, Dave Hansen wrote: > > But, honestly, I'm still not sure this is worth all the trouble. If > > folks want to avoid IPIs for TLB flushes, there are hardware features > > that *DO* that. Just get new hardware instead of adding this complicate= d > > pile of software that we have to maintain forever. In 10 years, we'll > > still have this software *and* 95% of our hardware has the hardware > > feature too. > > Sorry, you're going to have to deal with my ignorance a little bit longer= ... > > Were you thinking x86 hardware specifically, or something else? > AIUI things like arm64's TLBIVMALLE1IS can do what is required without an= y > IPI: > > C5.5.78 > """ > The invalidation applies to all PEs in the same Inner Shareable shareabil= ity domain as the PE that > executes this System instruction. > """ > > But for (at least) these architectures: > > alpha > x86 > loongarch > mips > (non-freescale 8xx) powerpc > riscv > xtensa > > flush_tlb_kernel_range() has a path with a hardcoded use of on_each_cpu()= , > so AFAICT for these the IPIs will be sent no matter the hardware. On X86, both AMD and Intel have some fairly recently introduced CPU features that can shoot down TLBs remotely. The patch series adds support for the AMD flavor; that series landed in the current merge window (it's present in the mainline git repository now and should be part of 6.15). I think support for the Intel flavor has not yet been implemented, but the linked patch series mentions a plan to look at the Intel flavor next.