From: Jann Horn <jannh@google.com>
To: David Hildenbrand <david@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Pavel Emelianov <xemul@virtuozzo.com>,
Andrea Arcangeli <aarcange@redhat.com>,
Hugh Dickins <hughd@google.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Qi Zheng <zhengqi.arch@bytedance.com>,
stable@vger.kernel.org
Subject: Re: [PATCH v2 1/2] userfaultfd: Fix checks for huge PMDs
Date: Tue, 13 Aug 2024 22:44:10 +0200 [thread overview]
Message-ID: <CAG48ez2P=k6Eezhu+E5OUzPLFpY5C4rCds1y842oyBC1ux3ocw@mail.gmail.com> (raw)
In-Reply-To: <2e14537b-cf91-479d-a665-c3e174cf2c66@redhat.com>
On Tue, Aug 13, 2024 at 10:37 PM David Hildenbrand <david@redhat.com> wrote:
> On 13.08.24 22:25, Jann Horn wrote:
> > + if (unlikely(!pmd_present(dst_pmdval) || pmd_trans_huge(dst_pmdval) ||
> > + pmd_devmap(dst_pmdval))) {
>
> Likely in the future we should turn the latter part into a "pmd_leaf()"
> check.
Yeah, it'd be a good idea to refactor that as a followup.
next prev parent reply other threads:[~2024-08-13 20:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-13 20:25 [PATCH v2 0/2] userfaultfd: fix races around pmd_trans_huge() check Jann Horn
2024-08-13 20:25 ` [PATCH v2 1/2] userfaultfd: Fix checks for huge PMDs Jann Horn
2024-08-13 20:37 ` David Hildenbrand
2024-08-13 20:44 ` Jann Horn [this message]
2024-08-14 2:25 ` Qi Zheng
2024-08-13 20:25 ` [PATCH v2 2/2] userfaultfd: Don't BUG_ON() if khugepaged yanks our page table Jann Horn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAG48ez2P=k6Eezhu+E5OUzPLFpY5C4rCds1y842oyBC1ux3ocw@mail.gmail.com' \
--to=jannh@google.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=stable@vger.kernel.org \
--cc=xemul@virtuozzo.com \
--cc=zhengqi.arch@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox