From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62439C433E2 for ; Fri, 3 Jul 2020 13:29:53 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 2726F20760 for ; Fri, 3 Jul 2020 13:29:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="Q+uRhAVO" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2726F20760 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 944D86B00AC; Fri, 3 Jul 2020 09:29:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8F5376B00AD; Fri, 3 Jul 2020 09:29:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7E4CC6B00AE; Fri, 3 Jul 2020 09:29:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0181.hostedemail.com [216.40.44.181]) by kanga.kvack.org (Postfix) with ESMTP id 698B76B00AC for ; Fri, 3 Jul 2020 09:29:52 -0400 (EDT) Received: from smtpin16.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 11B0452DA for ; Fri, 3 Jul 2020 13:29:52 +0000 (UTC) X-FDA: 76996847424.16.smell05_630be4426e92 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin16.hostedemail.com (Postfix) with ESMTP id 88983100E690B for ; Fri, 3 Jul 2020 13:29:51 +0000 (UTC) X-HE-Tag: smell05_630be4426e92 X-Filterd-Recvd-Size: 4435 Received: from mail-lj1-f193.google.com (mail-lj1-f193.google.com [209.85.208.193]) by imf18.hostedemail.com (Postfix) with ESMTP for ; Fri, 3 Jul 2020 13:29:50 +0000 (UTC) Received: by mail-lj1-f193.google.com with SMTP id n23so37016167ljh.7 for ; Fri, 03 Jul 2020 06:29:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=X6zEQxvzQothZO05B4Wll0a1I7lNr/ukJgbFHD247Sw=; b=Q+uRhAVOIHXP3l5DGk1/AYscHvETYA8Ymm5mRBlR/XZ2o2UW9mnCLU7VESU4lL2OEy eZ7C26WENmNIB+gotFApffDk/Lm7wJJqW5WXxjtTJj6ZiS4cgcRVF/lud+lYD1VwE1xf cpzjiyELopP+C254O+Z8QVDXT6TXntwWbSEvwdpuLJb4iJGFg0nif+DbsqwcsfIyngvR cwwjXDlL0psFU3T01tJoAkowFEsXFjdqFGfsuc6+LYN6r4gQLlzEBZ55aY5+vXoDAqAM Cowz37opXoR4SPkIBRF8f/Wk2fYINKRcK4N7PEfRIqRnbLoh53R1SadZbb95BsxIbR06 8FKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=X6zEQxvzQothZO05B4Wll0a1I7lNr/ukJgbFHD247Sw=; b=QClcMOJD/vM7RTuNLgDHLoq4yxKwxoHUpZ4ODp7/pgOp9B0d6mchoDetUEreb44Fxv mJpZdI60E4j81aq10frS7uK4O/sbrh8oHbFPJ/BXzj6MoyOSTFXskIHQxSKGwWELw8n1 g+evyuSf5vlj8m7g5WfffZkgVKYWcpHo0pwncdI49v6egcKZ53dUlLjfxp+ZIkr0ahEl C6iWSoqAmk5RH/bPESlkCvK4Qn7p7Bt7kR9ZMh3nHj/7xoGivOzkLHQegJuFruEkH4Ep NN6oaR0NYt70NDG5k8cSRr4UBAU7TkFFnWeITYkE7rPHlNHumAV1rySbGCvwd2VDJzzB J+lA== X-Gm-Message-State: AOAM532NiCjUYIaRGJDdO6yqHxCmtaSWMSZ6HnMpF0oECPnhGUCECpEU r26R2n7Tn3qGmO1+M4wYNIAOkjbakIvl/guvFkEJsw== X-Google-Smtp-Source: ABdhPJyEDqX5CTF1WB5GWdO0bVAwepG+Vq+Mz8st/b4+OZW1Wmil9vt0PgmzZxcYnwapEuHceWJOgE/vqRlZbxTSVp8= X-Received: by 2002:a2e:9dcc:: with SMTP id x12mr3182797ljj.415.1593782989137; Fri, 03 Jul 2020 06:29:49 -0700 (PDT) MIME-Version: 1.0 References: <20200703113026.GT18446@dhcp22.suse.cz> In-Reply-To: <20200703113026.GT18446@dhcp22.suse.cz> From: Jann Horn Date: Fri, 3 Jul 2020 15:29:22 +0200 Message-ID: Subject: Re: [RFC]: mm,power: introduce MADV_WIPEONSUSPEND To: Michal Hocko Cc: "Catangiu, Adrian Costin" , "linux-mm@kvack.org" , "linux-pm@vger.kernel.org" , "virtualization@lists.linux-foundation.org" , "linux-api@vger.kernel.org" , "akpm@linux-foundation.org" , "rjw@rjwysocki.net" , "len.brown@intel.com" , "pavel@ucw.cz" , "fweimer@redhat.com" , "keescook@chromium.org" , "luto@amacapital.net" , "wad@chromium.org" , "mingo@kernel.org" , "bonzini@gnu.org" , "Graf (AWS), Alexander" , "MacCarthaigh, Colm" , "Singh, Balbir" , "Sandu, Andrei" , "Brooker, Marc" , "Weiss, Radu" , "Manwaring, Derek" Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 88983100E690B X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam01 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000100, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jul 3, 2020 at 1:30 PM Michal Hocko wrote: > On Fri 03-07-20 10:34:09, Catangiu, Adrian Costin wrote: > > This patch adds logic to the kernel power code to zero out contents of > > all MADV_WIPEONSUSPEND VMAs present in the system during its transition > > to any suspend state equal or greater/deeper than Suspend-to-memory, > > known as S3. > > How does the application learn that its memory got wiped? S2disk is an > async operation and it can happen at any time during the task execution. > So how does the application work to prevent from corrupted state - e.g. > when suspended between two memory loads? You can do it seqlock-style, kind of - you reserve the first byte of the page or so as a "is this page initialized" marker, and after every read from the page, you do a compiler barrier and check whether that byte has been cleared.