From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC60EC47254 for ; Tue, 5 May 2020 11:45:03 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 9263C206B8 for ; Tue, 5 May 2020 11:45:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="N4hxmyzj" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9263C206B8 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 300D08E00BE; Tue, 5 May 2020 07:45:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 28A0E8E0058; Tue, 5 May 2020 07:45:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1525E8E00BE; Tue, 5 May 2020 07:45:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0120.hostedemail.com [216.40.44.120]) by kanga.kvack.org (Postfix) with ESMTP id EE3EA8E0058 for ; Tue, 5 May 2020 07:45:02 -0400 (EDT) Received: from smtpin20.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id B3A2F160B0 for ; Tue, 5 May 2020 11:45:02 +0000 (UTC) X-FDA: 76782484044.20.sheep74_ee0da47a1611 X-HE-Tag: sheep74_ee0da47a1611 X-Filterd-Recvd-Size: 3862 Received: from mail-lj1-f196.google.com (mail-lj1-f196.google.com [209.85.208.196]) by imf26.hostedemail.com (Postfix) with ESMTP for ; Tue, 5 May 2020 11:45:02 +0000 (UTC) Received: by mail-lj1-f196.google.com with SMTP id j3so1253323ljg.8 for ; Tue, 05 May 2020 04:45:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=oIfWdRq9yyjwaPNLBB1WhcLPviYtpHs1y/6Em0UoQzc=; b=N4hxmyzj9lyf6o8bph0ivG/R3yiX7+7av0Z3hbRgE3G1P9nJfWcbLP48L+DmBUPdRL iS7tdHnci9lYc5jibCU27M9cIyiBouV3TGfHBxmomzZlTAA+K4jvmlfO+0PUY5gOJwWk INzBNV9RdyU4hz+KA3qMcbJKjE4Nef1pYkIpykiFiNhgkJ8IjX1SCD4/KaX9gsrjw7UM PqB5v5UISICWvKpUwJeHeWlT+kuUlYh2Fy7unW4FPr071vxBMvN/2bqL0KNaC/NHAxF/ T4cTLz3YQkpT0ozMLHkIMjfiTRUu5z91/BjdSvFzNbqdymSh9Jx5aHZO1PEyCLvLAOi3 ZMTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=oIfWdRq9yyjwaPNLBB1WhcLPviYtpHs1y/6Em0UoQzc=; b=TWqxzYUqeP2uz4RL9hKuzwHqpY8+GUjADxuoHtnO9KjBtJbStORGdCr2Hi8VHDiy/i h8g6ObpBdpDxUJexNnx1cYp4k1bhfkcocjApQ1S6ZLc6+5cMW8cjRrPqksJY9wiWIQE/ 4M48xmqOVtLMM4C69Ohn4Kk8fQQzG+yEeoXdCaEMFSri70M7nlsHdOLSwXPkdWFKjncr bqL18qBIRGk/jLylbcjwBEBdpzR1CB/yutOfMzn2S/iPOSjMbF2auSPjcyvIM8QFdLe9 XGDRiCCcKKFwnSudz56B7To5IrN19UvkL/a8Fae5NFUdf9vuG7hdggOKjeFT3wS7v7Xw 9YQQ== X-Gm-Message-State: AGi0PuaH/5eso7y7SDAD//vNA1alG8hstcgKM2/qIcGLBRPs55O3z/GM kqCPTQc/H5gW/4VU4wmT0KVdICa0+3h8ozFDFx+iew== X-Google-Smtp-Source: APiQypJYtnxQWEbjes9DIO+nQO7CpHNG6KYJaneU9CBZe2/UNds1SHP++W+raV03+mh53wSUVZj+nsFewgw6YpANntc= X-Received: by 2002:a2e:b17a:: with SMTP id a26mr1481524ljm.215.1588679100508; Tue, 05 May 2020 04:45:00 -0700 (PDT) MIME-Version: 1.0 References: <20200429214954.44866-1-jannh@google.com> <20200429214954.44866-4-jannh@google.com> <20200505105023.GB17400@lst.de> In-Reply-To: <20200505105023.GB17400@lst.de> From: Jann Horn Date: Tue, 5 May 2020 13:44:34 +0200 Message-ID: Subject: Re: [PATCH v2 3/5] coredump: Refactor page range dumping into common helper To: Christoph Hellwig Cc: Andrew Morton , Linus Torvalds , kernel list , Linux-MM , linux-fsdevel , Alexander Viro , "Eric W . Biederman" , Oleg Nesterov , Russell King , Linux ARM , Mark Salter , Aurelien Jacquiot , linux-c6x-dev@linux-c6x.org, Yoshinori Sato , Rich Felker , Linux-sh list Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, May 5, 2020 at 12:50 PM Christoph Hellwig wrote: > On Wed, Apr 29, 2020 at 11:49:52PM +0200, Jann Horn wrote: > > Both fs/binfmt_elf.c and fs/binfmt_elf_fdpic.c need to dump ranges of pages > > into the coredump file. Extract that logic into a common helper. > > > > Any other binfmt that actually wants to create coredumps will probably need > > the same function; so stop making get_dump_page() depend on > > CONFIG_ELF_CORE. > > Why is the #ifdef CONFIG_ELF_CORE in gup.c removed when the only > remaining caller is under the same ifdef? Oh, whoops, good point - I should go put that back.