From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2471EC369D9 for ; Wed, 30 Apr 2025 21:30:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 602DE6B00D1; Wed, 30 Apr 2025 17:30:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 58B856B00D2; Wed, 30 Apr 2025 17:30:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 42A8C6B00D3; Wed, 30 Apr 2025 17:30:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 1F8656B00D1 for ; Wed, 30 Apr 2025 17:30:27 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 0C2255D697 for ; Wed, 30 Apr 2025 21:30:27 +0000 (UTC) X-FDA: 83392004094.29.66E4188 Received: from mail-ed1-f42.google.com (mail-ed1-f42.google.com [209.85.208.42]) by imf13.hostedemail.com (Postfix) with ESMTP id 121DD2000B for ; Wed, 30 Apr 2025 21:30:24 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=kBETLTSk; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf13.hostedemail.com: domain of jannh@google.com designates 209.85.208.42 as permitted sender) smtp.mailfrom=jannh@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746048625; a=rsa-sha256; cv=none; b=Gg2KoClIdZzKlUPrzKAr8DO4proUMCUZ1AFrcvjsOC0HYiJ7IDYAS99609zWhuJ/epwG2M BjtuJ9c9YMG9qCWrioqCqrikG6j6o8oMUxcTT8FrSsVruFMSfguwOdQkVYw2MSg0dwJOj/ zAkwWtEA76pzfzFVW8V9Zdl0FKhj5EE= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=kBETLTSk; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf13.hostedemail.com: domain of jannh@google.com designates 209.85.208.42 as permitted sender) smtp.mailfrom=jannh@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746048625; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5CjcEDdUNisdYTC682ZR/akMXUXBiC2pK72vAthCoDc=; b=3riwCMr7RKvOguGqao3LbMVOHKFKLKYKreHkUIHTt/g/7rw/m3Nif5UIli98WdmiL6B0jw pJVtJb4dHw9/kNRKVPpixYVeC6KW51ikMdX/4hw0OYaPDD0rVx8WO0koEd/l0Y2vCDHZBe arn8bvbDl2HauyVtitMw2dDKeLTTVDM= Received: by mail-ed1-f42.google.com with SMTP id 4fb4d7f45d1cf-5f632bada3bso912a12.1 for ; Wed, 30 Apr 2025 14:30:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1746048623; x=1746653423; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=5CjcEDdUNisdYTC682ZR/akMXUXBiC2pK72vAthCoDc=; b=kBETLTSkfbm0aDRS4cIMwqfnX5/Mp1xp5HcNglhiin3GyMVpQIUPTjAFn9BWMoj0KR 6BqgQ4DfwvcygttVE3SeTNXvl4mYazHr+v3tc30W/W/4X2ORWFqMdh98cokzK+q22stT ykYvIJXDRAvzmZQBZoF6qKRZGUPFrzkhIdgbM+Y3mIMOWGOgeZy6iHx7UzNiFwzYCUUk levGKAy+8IIyYOfpbNeOyix0ji9ydCYCo/FVeosj/FM3gI+pTU+74PBHiU9A7p6tqc4a MsFLa6HzqDaKM6zd2y1AZFZd+S/LjgcvlmGVW+TCHi0bPzz+01MnoDAAp02IpfUI1g2i 9Yig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746048623; x=1746653423; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5CjcEDdUNisdYTC682ZR/akMXUXBiC2pK72vAthCoDc=; b=hrUT54/94EpcxU1HET8L0lQ7qYgAFIdZ806Au5nNXQN6yNPFy73XdNGkSOm+YMcqp2 S6a9Rnuvji5LmEg4xIzpADeGEiSVbmdrvP9ImyUXh4OkHYqEUTmePrDbB4rzxEbFv29T CZPgwBjoww5u/epbjs+xGeNDBfeUn+VmroDX8w21qTR9T+Fhqk2GkIKyqntPAaT2ck0P +nawwOi7Z6eFJ4KUxBOHAamTjkJNXNhQtZmK7NR3uSpZBqxWdLdEJzmSeSOAa3t7aJfw Mxd4IimLkGlQ9rqI5iD7nJrOwllc1Rmh5QH/4exmM/cIakN2/y2ZEwf1tSv010MoOK1d uJ1Q== X-Forwarded-Encrypted: i=1; AJvYcCWf/opkZheTjmRe3BwbCIFOA4MDsYTdurm063Jq9JQXgZL4mfqV5N26oJ8DqQdT9kHAFwYnBYV7dQ==@kvack.org X-Gm-Message-State: AOJu0YynBoTDQq2jHHS4hohqB5Aq2z5bS+ei0qCXuCwQSACUC3WfhZ35 7iGZot9kPctqD8YpFs3pUPgZUr3UsbQJr75+hlWXgYGBPmwcMyKgMrAPYchrIitbgybDH5eY9dg GNIwgQ6Av75zEVJYcc8HZ9KigDJvHzg8JWpHH X-Gm-Gg: ASbGnctTiH+SA5lWGXksYA3hhbX+KvA6mvZQEyb7ZA8TfFpXhGcJF/5YLw1T+7oYdSX Qk2cO4HwLZqi6GIwbeU/Zfp8b4QOKZI4yhKHvL18PAWwO/tcC7ZMxVvM1/+BYh4XnWkxPBPIuaq 6b7y5RXZ1++L8JcsWMLRihFWR0jNdmr1Btlg46mwGi1bOA2ufRyWc= X-Google-Smtp-Source: AGHT+IGDMMmX4eA2v6ulzCpeHnUuea9wQ5svOGFjkGvBWCiP8rCQm1GlFwWDt1zkKtNVQSBWCW/5nQN3fWwXJdYqdrY= X-Received: by 2002:aa7:dd04:0:b0:5e5:7c1:43bd with SMTP id 4fb4d7f45d1cf-5f918c081b3mr6342a12.1.1746048623266; Wed, 30 Apr 2025 14:30:23 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Jann Horn Date: Wed, 30 Apr 2025 23:29:46 +0200 X-Gm-Features: ATxdqUHQ2RqenZm9cv6clle4zPp-U0u0sqdqaHqJJXCLMmXCWvll4M0PNqaIFOM Message-ID: Subject: Re: [RFC PATCH 0/3] eliminate mmap() retry merge, add .mmap_proto hook To: Lorenzo Stoakes Cc: Andrew Morton , David Hildenbrand , "Liam R . Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Pedro Falcato , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Alexander Viro , Christian Brauner , Jan Kara , Matthew Wilcox Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 121DD2000B X-Stat-Signature: dju9xbyto95a8nc8ywbwwsq5wi5fb5i5 X-Rspam-User: X-HE-Tag: 1746048624-244451 X-HE-Meta: U2FsdGVkX1+54cut5y/irbg28h24ReH748dsLgG4i2AnT0NtT8D1Wlz11UMMsDUfPTQ0UOCAuzo2aUQdp6yrL8Xq8p3af5mkX5CB5aJmUfZGD1TNiCyTCXeZRGIZk1C90Dnp8quh6d7Ow6dCvnoI6Y6FrrpTtXPoChCWBj9D9XTuBT3sxJ99LL3oI1THI8minpOElKj8b7oTgXh0z2hk8qvrZdnFOX049jDPa+VGqh+SGgenjNhgKBheqjcb2DAq+1g/ytyrwQo+AgqJH6yprhEVNXQfmql2JhDBiOpV1eWMCfUmXxMDq/9rNR7dhaou4Ko1i9ClHuekgdbjUONYAc+5bU8WLudxXUmRUzv6SgBnxDXy5mkA9HllQ5C0XZ4CwFct4WnP4jD17ogqk80S5trAGJM5QuNk8ZGTEquT+yY13RATPmCcZFSIyvl0um3IWI2Ug7jIj2XJtj7EslgVNTphojarEpRm0t8Rak++B69kxcGHg7ZjBKxOsEFMgQeOXav5fFyuaQEp/HTJnFkbRF1015QhR09gNVjmbgH40BRcqoAF5yQOIshgMriDbgAlAzgVz2FCkmi/adPAhPCzjLRgYiN2AJANQd1MHK9Hzsc+iLAtoipyLGo8sDI8wBsxBntsO9tOss4qyWHHzfKqVNDz6USPt3umSlnagFEVX5ZdVwKsHetcV/laML/9plPz9UTRa9KG2pLtptmYmUA+fdqcNKeQ1a/h+6G8NM+hwPoEh+e1ygg8j/sgasjBfqg98OoPdSknjRzkOzC7UJhX6cVC4ipNMgrgObSLsOSWaofHFZpT+sKYXD1dphwRnC9o6B2FTkSyp+MfzqEOQLJdcGze1PWgFHQIzjTvGjFAOyZIg7xQIRnOhgWR0uku0VXztS0nhjIszE3LWfEkl92LjUHsJqNcELoJ6LXj6EiifsJFQ+GK3uEqkUZPKsMrTCWWUIJM2MtKfbPzmbblzoX deLvTBkM dU3tQEMAKhrbPlqb88GlPFl4oScYZlcwKsQo8upOKdyL1MmbCSHEfNIyoAg98c6gbKPL+kPbS22yJpt+NnyKHSoD/J8ciVI1pC6Zx2olBSBhjHnM6Cnd4YcdCkdbWCn53Ai6xYyyd6X9ceS17JBwstG8Gm2bV7OM+BBpzWJr/TWg06tFT8GuWiOkfr8J6i0sVC4WhkJz5xU4fSL2hEuDL3hyI6eI+nVIGpcpcLQuPDvVa9cQ2Lso0IsHPMQBETIdLp50sk5M7xw0w6rI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Apr 30, 2025 at 9:59=E2=80=AFPM Lorenzo Stoakes wrote: > A driver can specify either .mmap_proto(), .mmap() or both. This provides > maximum flexibility. Just to check I understand the intent correctly: The idea here is that .mmap_proto() is, at least for now, only for drivers who want to trigger merging, right? If a driver doesn't need merging, the normal .mmap() handler can still do all the things it was able to do before (like changing the ->vm_file pointer through vma_set_file(), or changing VMA flags in allowed ways)?