From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id ADB1BC02180 for ; Mon, 13 Jan 2025 17:11:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 459A46B0085; Mon, 13 Jan 2025 12:11:57 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3E2D16B0088; Mon, 13 Jan 2025 12:11:57 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 25C5C6B008C; Mon, 13 Jan 2025 12:11:57 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 0705A6B0085 for ; Mon, 13 Jan 2025 12:11:57 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id B914941FC7 for ; Mon, 13 Jan 2025 17:11:56 +0000 (UTC) X-FDA: 83003071032.28.32AE689 Received: from mail-ed1-f46.google.com (mail-ed1-f46.google.com [209.85.208.46]) by imf13.hostedemail.com (Postfix) with ESMTP id D279C20007 for ; Mon, 13 Jan 2025 17:11:54 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=ZWk94q42; spf=pass (imf13.hostedemail.com: domain of jannh@google.com designates 209.85.208.46 as permitted sender) smtp.mailfrom=jannh@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736788314; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DsKG+YgO8BHWh+dEBw99TmpmY+rseLiFj0/+mYNeqUQ=; b=SY15mkRWkxAHOEUEN0zAW3fU57Z0ZugVD5z5UYz9NbzlBXJGDpx3oBrbZbBm7te76E+IZD 6Vh3ZCSEHaJC7zpkAew0AHmyuwRbJEYVJJtrC3MgCZwM2Sksk2i2wZqpZiQdpaOHy0NQSN r/mLialgG3pxh0Dy36pyS8+kjZum1Gk= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=ZWk94q42; spf=pass (imf13.hostedemail.com: domain of jannh@google.com designates 209.85.208.46 as permitted sender) smtp.mailfrom=jannh@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736788314; a=rsa-sha256; cv=none; b=aPwbDsjYhPRjnIvKlyp1cGyoTJ7BDlnK1wSY5gtZaZLG8T7inQ1nMIhWc2LS/8k9l6wllE jRzJXPK2USRmJ31f+BMaaD8cR+DIVku9xYnr6bAoyrPvkKlMExyc8ALgJYjH3/7jvCNf5b 8DUWQKqT006yfkgrqQ4UDt0UEYsH3xY= Received: by mail-ed1-f46.google.com with SMTP id 4fb4d7f45d1cf-5d3e638e1b4so9221a12.1 for ; Mon, 13 Jan 2025 09:11:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1736788313; x=1737393113; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=DsKG+YgO8BHWh+dEBw99TmpmY+rseLiFj0/+mYNeqUQ=; b=ZWk94q42Z92Sm2PIHbLl0SNE9h7cQaNEsWR7KlU9CXhbybhE8lk6waQPMQgrThbhnB cWg4/SwlxtCeip8zwF4zfio0I8Oqs5DOu32reQgS41nYb9XGx4mfvDYd6A3goCwIRVHO m/K4WXcr+dlAeSOg5va6AeoSI9HrgC/d7x9gmNXTW9L2b3XQpiP8ptuDK318wH07mRWd Kym5wKazXnjzEvjcPEEuGihP8Jmr6arm3owlUrFxE9+D4WoOTpw/NdVOl0/k2GmKvI56 GX3beTy30BDETZ8y9Z/MJ3uUehn0j4riNKjgUAN5KNpoUtnABPwEKxmm3fL8Q1cEccOj bchg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736788313; x=1737393113; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DsKG+YgO8BHWh+dEBw99TmpmY+rseLiFj0/+mYNeqUQ=; b=Afjzzfrsb2Ltk0duuwnXk+9vJ/W9/2GiwbN4WkFuKCZvX3wcPBBVN7mebCeVeYdICn 9DyVDwbCOSImLLYok30LK+14lMan9dYettLDn9meIWui4SIF6goHHxMkKAK+IiXiQzs+ Fceoh5Wz9qG71V+AW31wts9gyrPrvOOu/i7fJ0T/rRh7+muhieDTcyPF2YjL+QbU9f+g SSJYsnIqIKJuZbweCdT+0+imWMa9rJwr0yhAoVQ8BU2IrAry+0rmDCyOoAjqrfH1BR8Q tNdAWJGumG4c49a2JxXSLjaxEZbIo6q0NVerTIgnRpJrmEqgjYVy/VR1J5zn3P1qBehg o5Kg== X-Forwarded-Encrypted: i=1; AJvYcCXqzio8YJ0JWYNIyQ75cpP2nTi6KLyIO/G5fSXaNbBx8a6r/ZDcLChAO2OFRRUF7ZC1+4Caz0y+2g==@kvack.org X-Gm-Message-State: AOJu0YxUyGt/XlRqIh5XxKr+w0Y/3wtruhFE6JJyFIzOt6J1QbL1/Tot pLUMMuck8wptYun4a2Nz7FTYHXA86Kjssb7wKXjxhA/F/NkNAv2YirCzo2cdXLxJDPcaFN97XR6 PxLPg8BEe9P8JfdrcNdqi3/zTBGc0UlRgtdSV X-Gm-Gg: ASbGncvz8J9gZPmk909LqdnoN353EeiMaGYQWQ3hEgxA+y0RlNSMyv+CkRp8iqAakCH HnuhgRqIHxgt16eQtnacW35YKxqKWkRRNlkwavFLMvV2M3pJO7d1CT44fsX2CbrU7Gw== X-Google-Smtp-Source: AGHT+IGw5Yst/0SWdhvfF8ourhaeDQ/8OmYCxxjk5ky16XEWMRdAouBRttWRxXJhNoKiqE2HJQoaiyx8q8ZYjIKZAVU= X-Received: by 2002:aa7:c641:0:b0:5d0:b6ff:5277 with SMTP id 4fb4d7f45d1cf-5d99fb4400amr266841a12.2.1736788312699; Mon, 13 Jan 2025 09:11:52 -0800 (PST) MIME-Version: 1.0 References: <20250112155453.1104139-1-riel@surriel.com> <20250112155453.1104139-13-riel@surriel.com> In-Reply-To: <20250112155453.1104139-13-riel@surriel.com> From: Jann Horn Date: Mon, 13 Jan 2025 18:11:16 +0100 X-Gm-Features: AbW1kvblA-f_572DGjoQWpLPw9V65PChq6mHftZ3B08EcWvoh0lBnVB3k8NOctU Message-ID: Subject: Re: [PATCH v4 12/12] x86/mm: only invalidate final translations with INVLPGB To: Rik van Riel Cc: x86@kernel.org, linux-kernel@vger.kernel.org, bp@alien8.de, peterz@infradead.org, dave.hansen@linux.intel.com, zhengqi.arch@bytedance.com, nadav.amit@gmail.com, thomas.lendacky@amd.com, kernel-team@meta.com, linux-mm@kvack.org, akpm@linux-foundation.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam05 X-Stat-Signature: 3wek1cn5yuy9sqr83djrjyutsdnxhown X-Rspamd-Queue-Id: D279C20007 X-Rspam-User: X-HE-Tag: 1736788314-381862 X-HE-Meta: U2FsdGVkX1+DBT+p/h6Mwd82qHoy3gzHIz5SVwg5aatPVH8lc03cb3mWG0ifVjROCRq2xMlLzSvvNJFYHl4fd1YMn2gzUZMFyldU3TCEbNeZhzO4dayUXroAouAkmQSJrNUFtY9nDTO2zersOE+Jx1pvEwXxtTJnMbV37kjIvvQS7aFcilBau/YxJ1MreP36ul/ZgH89J5X0N4t+5roS2EVEYFj+9n7aRCA271vQHL/z40FU7Y1dMLicXMKrFqxWJIWs+DmrJqWzuQV0I3dKvedqObWtWcCADOEw7lhyiuQpYh1ST2bMVzGJ7b1EAD+iNHH8P7tA7hUWtgMHGSpAUrR40oxEPaucfcfnTa3bGZgK7F7am97AXwYpwGp/oicHUoXG7B47WgPeTvAy7NXLyR537HnCgkPwvcVRFzTD4ciVjzZizf3j+hPcGZp2+rmW0dN38cVrPgkt3BiqX3dDV2O+RjAtqLMM5uXEN3slUtPx6vUu3XU1EvFZgujWchOTqGBb1L9CQLlEVrppxBgLq5Ib13AgkwmGdpjmwWFLokGnZJHiHW3xMDRdWKX9W0F+AtaNPQajAKExo1z8T8Tyy+qCIGhf3F2EuRG0q4NuHcfiMKOt+nvJd2dsmfmpWAwT0WJQXqURm/ipZTG0m/5AQuS3SZmwDq+9JAK0mYZLLMQcJSxCm1rnU3wLSw/R8587C47b820tajMvrlA8HdTHnCRKNn+a0xPD0jTPPYxeCvYsFWRw1ir6BWdb5FE3ptNji2aLlzUK/xtcINzYatIHlYsHzwFTJ5LY66EKHH/tOsW+3bw9YfLWZD7NaINJB61uUR66YBHtvaoEU1RtS1PGd22chITAFZD1uWPiwfkHwJrFkYmM81GPqVaoLdVMAcRu9lsTIoNNRtqwPoQwVTMzDBkR644lhFQFrrBxkf+sVnJ3bbiSgxa/2/Okp6/nmYn/IeMmiNJ748sb62OtFM3 GozM5tfk L5WQjgPZaOo4c2/UJruv3N2PU2SNsjLEsRdlWsJTFCn/pT6XYmImKjvfnzYcDCcs/L0sdN96r3rJ6Kgkvsz9LrADPfTdTlzeQDH0Lt9lVBaO0QDMlG/eflr1WjbE36+TsgH6TAsgLhA3SxDSdjAgkJeP6vbgdntJCRWLYAFK4P9Kw0pWGIjcMp7YukcuPvfcJzQ+yzjLIWYYfNHhCDqbVQwEv6B6xug6oPCHKw7G0pbkgx40UxUAcDgQMv2Zg+RF0Qs+U3d3Y3uMzN5uq5tr36f/4gP3QkMD3GhGRRNVa9ETRAr3gcy1L/JBFyV/yu4dxBCw9dZJdT2WzMR8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.039123, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, Jan 12, 2025 at 4:55=E2=80=AFPM Rik van Riel wro= te: > Use the INVLPGB_FINAL_ONLY flag when invalidating mappings with INVPLGB. > This way only leaf mappings get removed from the TLB, leaving intermediat= e > translations cached. > > On the (rare) occasions where we free page tables we do a full flush, > ensuring intermediate translations get flushed from the TLB. > > Signed-off-by: Rik van Riel > --- > arch/x86/include/asm/invlpgb.h | 10 ++++++++-- > arch/x86/mm/tlb.c | 8 ++++---- > 2 files changed, 12 insertions(+), 6 deletions(-) > > diff --git a/arch/x86/include/asm/invlpgb.h b/arch/x86/include/asm/invlpg= b.h > index d62e3733a1ab..4fa48d063b76 100644 > --- a/arch/x86/include/asm/invlpgb.h > +++ b/arch/x86/include/asm/invlpgb.h > @@ -61,9 +61,15 @@ static inline void invlpgb_flush_user(unsigned long pc= id, > > static inline void invlpgb_flush_user_nr_nosync(unsigned long pcid, > unsigned long addr, > - int nr, bool pmd_stride) > + int nr, bool pmd_stride, > + bool freed_tables) > { > - __invlpgb(0, pcid, addr, nr - 1, pmd_stride, INVLPGB_PCID | INVLP= GB_VA); > + unsigned long flags =3D INVLPGB_PCID | INVLPGB_VA; > + > + if (!freed_tables) > + flags |=3D INVLPGB_FINAL_ONLY; > + > + __invlpgb(0, pcid, addr, nr - 1, pmd_stride, flags); > } Thanks, this looks much nicer to me.