From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CCB55E71096 for ; Thu, 21 Sep 2023 17:00:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 52BDF6B0204; Thu, 21 Sep 2023 13:00:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4DBC36B0206; Thu, 21 Sep 2023 13:00:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3A3BE6B0207; Thu, 21 Sep 2023 13:00:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 2AC1C6B0204 for ; Thu, 21 Sep 2023 13:00:20 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id DCA6040E3F for ; Thu, 21 Sep 2023 17:00:19 +0000 (UTC) X-FDA: 81261217758.05.1C5128E Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) by imf25.hostedemail.com (Postfix) with ESMTP id E64C6A0030 for ; Thu, 21 Sep 2023 17:00:17 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=wPkoRLau; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf25.hostedemail.com: domain of jannh@google.com designates 209.85.128.53 as permitted sender) smtp.mailfrom=jannh@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695315618; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=eu8S1LBasF2ZhEspa4c1U6bTj1yYPvFYUvyFdE5+sh0=; b=JOHcioJ9uZUOAYqSrfGQpvQjiB2YF/RzWjYF7GLHiPEpZ8X7kkqs6ankIfAZan6TpUwzFY wVV+WcGpIHqAN05GUfUZKKWabVaX2IUrgXuW38gsCd+kvodjGtqmzjTgeVmke1rTKMRQZf 6e3N15EMV8A38xF9caIqG4/13JGp0kE= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=wPkoRLau; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf25.hostedemail.com: domain of jannh@google.com designates 209.85.128.53 as permitted sender) smtp.mailfrom=jannh@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695315618; a=rsa-sha256; cv=none; b=E4O9XSRaftxZlubUTYceAv2rXYBdBPzngGVkeVjOtt8zfw6+o1sY3FxAwLCZqFTjRq4+7x +7ZbHRXbooUm9ZW0RWlEuLu8NA4ZeugTtEdKg8wnVpYfnge9MJMaA6W3PT+85jdnaLcMwz lrFCcW/wt2u1VxJd3micy5vsyFj+36k= Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-4009fdc224dso2295e9.1 for ; Thu, 21 Sep 2023 10:00:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1695315616; x=1695920416; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=eu8S1LBasF2ZhEspa4c1U6bTj1yYPvFYUvyFdE5+sh0=; b=wPkoRLauNgZub1ig8D00E4rY6ijxYY8rs/tBONSWw/zVJ/CJ0G/S/Jyv//54dQ/2yg l9B9vJYxtYvnNsX85iMByUNp/6HamhuCmiFKg30gdJoNCIUEPER8zv2nE9WQ6draUBFu x4ZXAy4i7RoN9I+O+uyyRa5DUNfCV6pWGWsyPTRSiw9QrZ/4goIBvMVLYxJvU6tS9bg2 hsXDIC1nWELHRuw6Ra8vCD9iDISRc7WPe1AoPE1TfmYXvoNQljIosMyxzu8a8J4ddBu2 GZ4V6K1Wgqk8yAdfllwjQcUtQaLva4rF1Js2Tx58tqgjo5RB6mPQa5jI5U11D9hYfr9S zP/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695315616; x=1695920416; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=eu8S1LBasF2ZhEspa4c1U6bTj1yYPvFYUvyFdE5+sh0=; b=d8xPiUjFq1iRVmLuV4rJ4pqw9B9vfMMcvJdGNKt9nxjHpNSuUndmaY1LsXz9sscT6R TwxFdQ3bktqkX7P3gGURWb0HhJAZsz0YiPT0vKRR5BCROGT4lMCNrVgaspCnCeCndOtD LBrc5XsoCHAVY0k+dddgdPpx5vzfukseEud2vY0x1QlPkJwTGdG1c4pCytY1RvFEd+W5 fR5UWhtA+F5g7i7a/vy66QxjjCBdNV1htIp74aOc5go2ZvdUKcAzRgO7q8VNcgjDe2dX G20zpUJ9JYZD+6tb3LqhyI5YpCnipmfSu1JyGWRpEKGTd1DfYnbD8ArQeSqkk6zmeUQd km1w== X-Gm-Message-State: AOJu0Yyn8ceyTuSUOO5abJ+/xcj++UqvE+kLXraAi1BmjvDuTcU0W80t bGrqIGeuMUFD9kYMULGQjp6LHxJtpJVYeJn95Orf4A== X-Google-Smtp-Source: AGHT+IEsCsrSbKfig0oNoRzoceXo3paYU9sVVaDSOMikZhbSNVKsbvQENPu2CUkyElIndXJBCQ7CbIY2CAmctRCJmqI= X-Received: by 2002:a05:600c:5006:b0:404:74f8:f47c with SMTP id n6-20020a05600c500600b0040474f8f47cmr91268wmr.5.1695315616287; Thu, 21 Sep 2023 10:00:16 -0700 (PDT) MIME-Version: 1.0 References: <20230914152620.2743033-1-surenb@google.com> <20230914152620.2743033-3-surenb@google.com> In-Reply-To: From: Jann Horn Date: Thu, 21 Sep 2023 18:59:39 +0200 Message-ID: Subject: Re: [PATCH 2/3] userfaultfd: UFFDIO_REMAP uABI To: Suren Baghdasaryan Cc: akpm@linux-foundation.org, viro@zeniv.linux.org.uk, brauner@kernel.org, shuah@kernel.org, aarcange@redhat.com, lokeshgidra@google.com, peterx@redhat.com, david@redhat.com, hughd@google.com, mhocko@suse.com, axelrasmussen@google.com, rppt@kernel.org, willy@infradead.org, Liam.Howlett@oracle.com, zhangpeng362@huawei.com, bgeffon@google.com, kaleshsingh@google.com, ngeoffray@google.com, jdduke@google.com, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, kernel-team@android.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: E64C6A0030 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: suebbqsj71fah9rcf475mj49hb35rjsy X-HE-Tag: 1695315617-257650 X-HE-Meta: U2FsdGVkX18I2pwyxL/X6gE3vRTLa/UlyrK4Rc2t6FAmxvzlhKQ/Pe5Ija5f+RJl/WY2X6BLavpyH9Dw3kL0vLAfcTNCokFDBRfgPaM7++CO03c3qLmV6h1QmuyoL+B0MLyLCIFSRBgThf/RXDdzDiIogRSWSpF3Nlu+bVsW8OWHIJqcF+JD2EdGyaqNYgF3mUqsTUZl/xBMe9PXjFiMa11woaCsCcZL5ZkYypHs2kJbXuyCTO1A4N8GI6uODZmmE9Vi4vihu27uUDUNUIjj5TKG7+p71t6Dp1AHAJ6yS+sYUBoSQVqYMz10UyOgWO8QbIRaElyzlEpiuSBWuCcp1iiOtZ7y9edRdW35fmnhB6aBijI1C3Sd/23baAF6f8shycmosVmAtIAA+WHpzxzQYMPVVJjBeibIg1lWBdiOFisqmZbOh0fbWqOa5tWSI1avbZh+J8UbMPpBpcH0Rgmvsk6Fw1ynHHg+AQHBEEVlnuIO2WkUtVdOGb/vqRyOX5WTu0oNIXkxAbiDwpVA8ZGKNEfzFVQnrX+xyYnwZny40XbJ9s1d2XV8dTsC6TaButALLqP8etWw+BVF8LaU0OiSWh1Fy9V1D5WatIMMdP2O+uR8RKHKapPq5fYEciXSbgE43iQaE/YhCvN/80SCidkaB0txhb6beTRYpnxexflyHgSyrj8LqHUVaGNeoZcEw0P3L294sf+RGZB/ZwFPac7bUoFmig65cgmuQzuvk4x1Xs5GJ/3RoKkSmFX9VrYq7Sd7x7FF6xRlo52u6qcYYthNb6zRL3zicVeGcqgHKJwUduLH5Lyh6p0ReRXchoC6EXSHv4qjHR03EML3PQbOA6Nyqpg3gWnL69YVNCn7HI/XuBB0z6Xo1HC+CV6mTKxj3uP0ScN70erx4bFAlByxLgRO/kaXNI/KJZ7WfP4PwDZlisbkOMKAxxjtFhzsl7pufhk2qA0pESSxhu+qamOOdrJ nO/yBh/n TVQeAIdZbLtQAZgmEFhnkIKhsuQK61mdhCWuIfVINKe08rnpqnZqCOUjJBh9S+AvBJ4wQMS2uve7YxtMiXRfxuN56BSnCcP5DTVYh31ckZlOfq3g44JAEYP7q2QLzzkXouom7crJbGxN/cjYYwXZNRLuceiCtyqz+FTaw1X/FWTRVTa5e69nMnug0rOCHnjSFed/Ro7vx8FNc/QHQtPcNOSnMGgWpXkjxXimWTmdmCgwby7B8aSc60VzLrD8T4dISrjG7T7TBcqwgLa/Goanb56Js455hwkAeK1Rk9/6mPuIxscA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.015866, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Sep 14, 2023 at 9:28=E2=80=AFPM Jann Horn wrote: > Though, uuuuuh, I guess if that's true, the existing > vma_is_anonymous() is broken, since that also just checks ->vm_ops? > I'm not sure what the consequences of that would be... Either way, > vma_is_anonymous() might be the better way to check for anonymous VMAs > here, and someone should figure out whether vma_is_anonymous() needs > to be fixed. (Not really relevant to the rest of the thread, but just as a sidenote: Turns out this is not an issue; since commit bfd40eaff5ab ("mm: fix vma_is_anonymous() false-positives"), VMAs where the ->mmap handler does not set an operations pointer end up with a dummy operations pointer.)