From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56C61C5478C for ; Mon, 4 Mar 2024 15:15:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C64B86B0080; Mon, 4 Mar 2024 10:15:48 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C132D6B0081; Mon, 4 Mar 2024 10:15:48 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ADB7F6B0082; Mon, 4 Mar 2024 10:15:48 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 9B0756B0080 for ; Mon, 4 Mar 2024 10:15:48 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 72940140ADA for ; Mon, 4 Mar 2024 15:15:48 +0000 (UTC) X-FDA: 81859706376.30.62744B3 Received: from mail-ed1-f42.google.com (mail-ed1-f42.google.com [209.85.208.42]) by imf28.hostedemail.com (Postfix) with ESMTP id 5259CC000A for ; Mon, 4 Mar 2024 15:15:46 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b="3J/XTnDc"; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf28.hostedemail.com: domain of jannh@google.com designates 209.85.208.42 as permitted sender) smtp.mailfrom=jannh@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1709565346; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=JaftqBjRUd5OiE9mP6ElGruCPofNrsQHVf3pU9lO0lo=; b=iFWvFJutPxUceNpDZCUxv3kNyUPoppkLP721EffS/Ky8deX9E6ymV/LPpfME3N1ftn+1J7 gWEb7KlCSuheg4D6GL3MGRIUDzxYbprhYYtGEIPrix7DXHy2KDY5npCoSWcNK2PRsdce5y mRo+UXOS7OugKxJ0sNX82l2OzaL+dso= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b="3J/XTnDc"; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf28.hostedemail.com: domain of jannh@google.com designates 209.85.208.42 as permitted sender) smtp.mailfrom=jannh@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1709565346; a=rsa-sha256; cv=none; b=sq0RvNyeBq75rhV5II0VisZ4l9V37CnOqDhjPJpj+wmnqw6LOFuAXwJ4jSweDwx5/CZllY gk10K1MpVvHVe8DS7+YjfDCDAVUtwhxCz6VBk0n1R7JEQltPBBmGKyCHN5kxoQfg5Nnafx szDJHSdHEkavN7kthkpnRtY+Rj+vy8E= Received: by mail-ed1-f42.google.com with SMTP id 4fb4d7f45d1cf-566b160f6eeso28072a12.1 for ; Mon, 04 Mar 2024 07:15:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1709565345; x=1710170145; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=JaftqBjRUd5OiE9mP6ElGruCPofNrsQHVf3pU9lO0lo=; b=3J/XTnDcDW+8WOU+qizoVEnPzAhMEJFh4gYfMOOqYVHLF/gX/zXywXGOCsnr5jkR9V 3rOK5LPeAf2glgJyQ8vW6OkC7CGEK4JTPGHDZDpBNrAacFdkhgGUlIYLezZp00jufJVV ZumaVEDcrj50wdA1gyEnSBB0evr/Hm9fYPXldRQ6bRK/VSxNbmNjlJFjNx8Sj1G1+JsY l2y0WXQPZpDzg6byr1Vycypd22sF53fOppAqGjnNMbwVvQ8OQ3GrhIll8A+4ls1R+soe Q7IV+uwZ3GZ9W5wedJFeY8fH+SiyZTD98PCmaojCvM0FbQzQ991+ofIWVWDqnB6F8q3q dsjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709565345; x=1710170145; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=JaftqBjRUd5OiE9mP6ElGruCPofNrsQHVf3pU9lO0lo=; b=Yazo9BHZ8L4NZFNG6ckBF0ACeZ5Tr+Dc4OxYW/6CKh/jQ5Cx4zNdsVQUxCkpOu6Aqh pgs6rYshRUo6aJFQxKfpBq1IXaUoem8Z1ADkpzk6BItvYT4NEkIaPtzv5sLJ1TsTwl2g UM/tCMFK0hK5YugKrtduX3wynxA65nVvvBjzX1/EXfQKkfmi7SgxqEhybKKdHrgNfRfE baql4TwjnUc1wIT7rSCK+uNTf54u8tWxKPj3zc+iLZEwXvqo1gsl3/Xa1VmCOddQXnl2 LlQUi8gmUhvjfpdMNk/8JaZOrEOnev/v3QkHGARA1taDX20PgDpDEjOmb2HAY5Bzu+4I 1lYA== X-Forwarded-Encrypted: i=1; AJvYcCX099n6e84qimTv6XuFVeKucINnyH0JsU6p3Zu4tz2x13VEyaHyAtA+ZtoTQvTokDxycqoit8OVlm6ec8u29OE8p7o= X-Gm-Message-State: AOJu0YzPLRinxbyCj/aswuQvPagXWLXL9NEe7gw/9piFcgdPQQbDYcfQ qwDUDyXsplhlvgwBY6akqXqEag6EUiOlmUJVVzbueW/ixgaHix4b6Q8GBSCNRwjZ/ds0nmKxSJX Q7nUWblNYo3/X7cbVPouf/R8nUmJ/U+tbeNB+ X-Google-Smtp-Source: AGHT+IEtc8iFkUDhfxTXSKFmqZJRm6+dqGzN80jS12Vcq179DqSiAJDtL89r2EpdoV8ru4yX3BzzCTnXQuN4tukZYxk= X-Received: by 2002:a50:bac2:0:b0:566:ecde:290d with SMTP id x60-20020a50bac2000000b00566ecde290dmr291227ede.4.1709565344548; Mon, 04 Mar 2024 07:15:44 -0800 (PST) MIME-Version: 1.0 References: <1709516385-7778-1-git-send-email-xiaojiangfeng@huawei.com> In-Reply-To: <1709516385-7778-1-git-send-email-xiaojiangfeng@huawei.com> From: Jann Horn Date: Mon, 4 Mar 2024 16:15:07 +0100 Message-ID: Subject: Re: [PATCH] usercopy: delete __noreturn from usercopy_abort To: Jiangfeng Xiao Cc: gustavoars@kernel.org, akpm@linux-foundation.org, jpoimboe@kernel.org, peterz@infradead.org, dave.hansen@linux.intel.com, kirill.shutemov@linux.intel.com, keescook@chromium.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org, linux-mm@kvack.org, nixiaoming@huawei.com, kepler.chenxin@huawei.com, wangbing6@huawei.com, wangfangpeng1@huawei.com, douzhaolei@huawei.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 5259CC000A X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: yhhbwgezdd9oy4ohnrdykdj4gaim574n X-HE-Tag: 1709565346-505051 X-HE-Meta: U2FsdGVkX1+XRzWMnU+ytaiX0mp17ZC0v8lS90I0WqFlZDyD7SMLUkCXAba+XHWyNz22WLQj4HNODGlma+C8oQXL3IKkoVek1t3Mv1IMPXDwD1o/9BOG+G47xjMNbGXgwulQbHmFjAACDQCF5JW+av/hLMOKRE6FbYmz7YA/kst8OA7giTzqVDyS9bFstBw+pdMjvpCo9dGVBd99V9wGAnQ6IMgrPJdRXFuwcVMWIdBYCZM03gPCLnFOVwkK1NSF3UAywoy4fyniDFt9q524pgx0cQjeLh0Jjk4Ig+BbMBmoNw6zGzPAahH5/tE+29pVmRR8ShpYB30NDXeX6FaY/JRFgyUXxrqrVEPGZTXkXXUxv3qZ7IODwVgoyLfoJ5W7jXFjcbwfMusltaJ0j0VbPbuiwd1hMSzjzixWjMUVQ50dNkO36cKEDDKv8pPgO9B7fdkMDvH9eWgc9rCHIgwW0NjQcbYQtEYBt9pwE4PkPHp4sf4rZ10gBA+GA6q9yUribxG/kviTKanDdwnAA5w56Rvg4F7JE0AdC8cUekLBDoEyNH+BTqItTZOL+xCUUHezrBrg47m8g6VYKWQ6IjmB1LKuRGWLhqxKy40xBrJvidm2g9xLnGIhGdI0um20VHuDyVbLjDcbJCykBW0wYhsuigtfC4776SAClymZppfgPRnCRlkTTMRG8whYh75t8/cy1dLPj7ZTJoSDnbVTEuGD7p65kAzvuWfh/q4DIiXkBuRyIVTEr0/CD0Vdioav0yKLrFBhbR93YVCCdTkilwOjDw61jNMNUTaMhKkLdV/HqJGexCN59CZTOati48DqMmKDg6fIuJnOlJXWBhQvXus91vdhQe+8qnxtyuyvD2I5yZYsZZHF1sj7HcAWOiDuQYpYhuIaBj5bhhEG+cBPxNOFzzWNFnRvxeE4AawWHLGCsonVbHcLRqWX/c1Dntm+qaG4kAv4a7iDiOsEKTdqWi9 YbCcKGIC 6eRAMOrSMJ7u3GtPRsCFUZ70ZEHiUmEZuj7eos/JKLEJEDFGh1x6YnJZy0qtqLeJ/WDk+u6CK1gZPn8/DgzOas1YZFmJSuLuiAjOLbAquON+8Gf1u57VhVrIGrsupw7vXycLzks4LWmFphza4TRkx7TwcLkwRSsSUnapURJc7xxruTap0F+VDdkZvuZePdqHc0ukaAL/9CwosnLM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000022, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Mar 4, 2024 at 3:02=E2=80=AFAM Jiangfeng Xiao wrote: > When the last instruction of a noreturn function is a call > to another function, the return address falls outside > of the function boundary. This seems to cause kernel > to interrupt the backtrace. [...] > Delete __noreturn from usercopy_abort, This sounds like the actual bug is in the backtracing logic? I don't think removing __noreturn annotations from an individual function is a good fix, since the same thing can happen with other __noreturn functions depending on what choices the compiler makes.