From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AAF92E6F086 for ; Fri, 1 Nov 2024 20:34:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0C1BC6B009B; Fri, 1 Nov 2024 16:34:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 070E76B009F; Fri, 1 Nov 2024 16:34:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E54676B009D; Fri, 1 Nov 2024 16:34:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id C32B26B009A for ; Fri, 1 Nov 2024 16:34:48 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 7F66E140FD2 for ; Fri, 1 Nov 2024 20:34:48 +0000 (UTC) X-FDA: 82738678974.26.9BA7C37 Received: from mail-lf1-f47.google.com (mail-lf1-f47.google.com [209.85.167.47]) by imf11.hostedemail.com (Postfix) with ESMTP id 6A50E40024 for ; Fri, 1 Nov 2024 20:34:11 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=LOnaVeTz; spf=pass (imf11.hostedemail.com: domain of jannh@google.com designates 209.85.167.47 as permitted sender) smtp.mailfrom=jannh@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730493240; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=JGIKGLosAwaInaFR/dbZOVxT/qUwBnIv05j7Oofz3dM=; b=rXkrYPIeX5zN915N/F3aD1lEFFGN6C+zsX3MBbP3uSh+1ImVWTHLb1VgDALwGejq5whIoi c9If/twoqiwM+vVeh1uFVFh+2EeDlWbTdbP6/TlLXPzJgTUHLdXtC5vJvTD6An5vPBc3+P c4n8yHM/b+OMOS5/fJwoSC0j/N21VqA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730493240; a=rsa-sha256; cv=none; b=dMpNY3D5Cr5TQ6J18YEdyATaF5od8s8Hq9FYlbwHXwg/ejM2Rezuo8gMKPoKhQMoqfZM+9 3IT4qVslUBAOpox9jB9UfkVDLqyKPIGs6HTn7lirBrQ/5IRc64W/pSVih3xBtNvd6+7nvJ nvARLOxb/Mbtt3S4ayhxi6yxaE9NTzI= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=LOnaVeTz; spf=pass (imf11.hostedemail.com: domain of jannh@google.com designates 209.85.167.47 as permitted sender) smtp.mailfrom=jannh@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-lf1-f47.google.com with SMTP id 2adb3069b0e04-539e19d8c41so7196e87.0 for ; Fri, 01 Nov 2024 13:34:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1730493285; x=1731098085; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=JGIKGLosAwaInaFR/dbZOVxT/qUwBnIv05j7Oofz3dM=; b=LOnaVeTzqMpwX60WonAhqcPnh9Tmpmfv26U8I7/fL1hsYJif8Co9mZqLbAcR4cKof/ s656+f4bcjG3WHYWWstsZClD/8WI5P4LpjO+WVIfdvowEEQUxJQ770zPEGCEVq4P7vI0 MmWzYwT68bOAzAe4GNea5qPirXWa5tr5p8lGhQxaNjy6loEo5ZeZQwLiVyOU5A5plZCp cCPyEBJuARycuCP81L9Sl5+Tc1oW2bwgVbVVEuRXfx09Cx9Ry1k5eFcu7i6Z7yz9NNGO N9yNiNzYDNQ4WSxYC7BkzciKn/D3rvn5aMyPPYeVRHkSQ/PQkmt5i3Q8Ek527j6MOcGQ kOCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730493285; x=1731098085; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=JGIKGLosAwaInaFR/dbZOVxT/qUwBnIv05j7Oofz3dM=; b=owAYyORmDc7x+3X3jJ+YiSog3+SCyUZcGbTjhXO04/OW5mZgeA7RnQ8q+1Eh/qR+Kt mn/t1WestoZDzJ+zdXLxfaos6sCvoJykIR2YdvgtFnZeu9shb+30dMcil7QNKtbFUEPO 2OzDLDuZ8Y1CUDPDgrk+UarKhcPse+/w3pZ1MFp8aKalqrplNe109qOsY6iRd59Zlscw fknOTMiwP2s/1JkdZWl71bt0fWgnWgzJflamNf+Zlq3eRHuftootZZQgbeinxpx1Ir1r XSl4TkKWO5mTdB3ei8US3VbfrKaO41pRbC2OxkTigvzD+zVCImd9CIzIk3W0gYq5THlG 4L2Q== X-Forwarded-Encrypted: i=1; AJvYcCX+ARzCiLMrC7uUba0J3t52l/8I4L8Fy4I3ONN2ksBbZTnmk/TU9/qKyWT9LHeyoVCDr/lsbmrVNQ==@kvack.org X-Gm-Message-State: AOJu0Yy6hJuBMWNRXxgGf/9XHNw0NAv1ZYvZKrq2wlwCc2NVYfb8mM7W 42RaBMvb2adbwfNBuUfeZMnv569mwun7RYzMz+DGNxYeRDFCxWMnYWbWDuqLcBLyS7Wp+5rgXhm SlFCKf8SoyQi+k6k2hvozuCPVI9DCwkS8qyFi X-Gm-Gg: ASbGncs7u/0hVJGaXMVBgH0Swp4QULriAA1PXiKQzoILleoRBnqMkjMt5X13wRun62c bft3ehp20/OOcTbwk6wXpPTTc4aPaGykxEnq36iXCAolno+RJQIVZQ9vRh1fk X-Google-Smtp-Source: AGHT+IHleSpzUKqJpIQL1LrNUhvfc142T9+XqdGHrdAhF6QcicNe3I5wzlOtm+Kk9zqaztwqVj/nx8LtNAJjTI6lcF8= X-Received: by 2002:a19:5508:0:b0:530:baaa:ee10 with SMTP id 2adb3069b0e04-53d6b1abe1cmr9794e87.3.1730493284385; Fri, 01 Nov 2024 13:34:44 -0700 (PDT) MIME-Version: 1.0 References: <20241101184627.131391-1-lorenzo.stoakes@oracle.com> In-Reply-To: <20241101184627.131391-1-lorenzo.stoakes@oracle.com> From: Jann Horn Date: Fri, 1 Nov 2024 21:34:06 +0100 Message-ID: Subject: Re: [PATCH] mm: remove unnecessary page_table_lock on stack expansion To: Lorenzo Stoakes Cc: Andrew Morton , "Liam R . Howlett" , Vlastimil Babka , Linus Torvalds , linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: cmrfzr4ikjezdzd37uegzt3qwx61fgeb X-Rspam-User: X-Rspamd-Queue-Id: 6A50E40024 X-Rspamd-Server: rspam02 X-HE-Tag: 1730493251-867488 X-HE-Meta: U2FsdGVkX1958FuxoleDSb7c7FPVRB2eioamtVK7ym3UWzC8+bg6zgEsjf+UNToFozgDypPnYTNI5M46q0M+4CUg+AjS+R/HwnLD/IBf59ROEg56B/x/VmrGJBmNy4KOdxxFe1yIOr1BbcTbH0MtAo7H8aVVcUKgg24dtvLamo4y8j/YVyFhkN38KAt1Yb33I780dBfzHpRbKRd/Pv5wyTJ9FxxE4+ZExQAAR3mYgO4JI1yahj1CaWRzIZnBXkpDYTZyEEv5pO7ydaR2PD5s8MIXWVuS/eag08LmiBGjgQ8rfTWGIdg9ZQr1q7mA9oDQ7TfL7JX8h9jWJGe0Tr4su6m37+t8le6fjjC4o7IxlO8YcuJKvy8PmWWBw8FYWZiBqJtboaeB/Fo9H/2kbMX+dMVlaQNcSNhsDG5hXPfaOrNeevGSmICcZ44BKViUtXYOGPjpKJu6qZj1SdnzwENfNnpCp1C+PlRQFc+XOmGn+4A/Ns/sMv4A05kf7QIwUlScPMw6b+N0GcWWol1Os645sGaBdTgN6pzQTKUz/39M4eDScFKx+VWm4baXhvw2s2N0icV1Q9Nv1V4MbBRxGktxy5Iw6pDAalpaRNy2J5w+wFB+NMfq407II59fY9Du5fQvEI2QOMajwmjgiu/4nOjwpYAgbdQUQ6GjioA9176RfuEMlVwp95Bncjq1nsyrlLkTIkyH8vScFxv2eBWak0hdPXTAnzetp/OXPfz/EOwAmxZ2rByLaMV6gAhTOjP1TOAJda++4hyfZIMu9R66jYRxVFC1HFqjkHZ6o8gQAxuxQzbk7k1UGm4mguKX8Hzy1oCaAzkaqJunxjWIM/YhMeI0a5h/XXN0UTeEi6ei3ROOiW2JMUhBrQKl7MrQtrlQaK0RNvrdk2w5fGAzbsA44jQ7Rs8s9falsudxCPzrb7isDy+D8EIXZPhwrF2k3HOrQnS/lR47MljEirkqMXwkAeM i2XEQOS/ 5cijScBXjun3kRAE9cgFVz2wgYkMpEm10czfsWyIOnkorhVBPbDPBFkTFk6iaTaT+G9P6w/uxxN3jnhBBIgX1jupJjSjuMP9sPVokPHJ9623bkF35btW22veALy/D2SzYVjgnAJOeE3Qp6oOyGqigg01zvS3svjzJsPqQkPO0lvebzkct5EhxqNhD6hWhLT4hN3q+4wF33fNIEGjHyPL5kSPhtO6pnjGLUBTs6V/UkEFKYESADPvOQU/C+B2189C7w+2/8F/6OARxs9Pf82xEiWJPeUs+K0jS8/CjENYXozJMOIgioU2MT3GtLw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000043, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Nov 1, 2024 at 7:46=E2=80=AFPM Lorenzo Stoakes wrote: > Ever since commit 8d7071af8907 ("mm: always expand the stack with the mma= p > write lock held") we have been expanding the stack with the mmap write lo= ck > held. Right, in the 6.1 LTS tree and newer, the old stack expansion under mmap read lock is gone. (A related cleanup that also removed remains of the old stack expansion mechanism was e4bd84c069f2 ("mm: Always downgrade mmap_lock if requested").) Reviewed-by: Jann Horn